hub_kernel 0.11.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 582093847b3b8cf75dbadd831d8a68df615bebccce57eeb89be12d3496fc89f0
-  data.tar.gz: 4544cb83a72d80f920abbf78f6eee6984b4ab8d28e330d568eb86bd21ef97dc8
+  metadata.gz: d68f714812e20170c2ee5c5317e29b64c8ebbae25431492f457ae4b53263d50e
+  data.tar.gz: bae431b97f2e98ff2a28ed9712ab415a3e3b2dfe18753e46d93be5acfa86a9f6
 SHA512:
-  metadata.gz: e5d72c62b32c671f49ae4babcc4755dd871fc4fcfaa35573c78689250ca6b27774bb9ce2db460405940774fc017d1abd742da4df1d646565f8df770d379deb00
-  data.tar.gz: 4d5dff84ef2be0d5ebc3a53ce43e22e42d5d73ad53b0601663139f3fc0a68876e8c874a1833c200d078b29684d0bcd4056f11dd84150c0181dc6462943e9262a
+  metadata.gz: 1035694fa2c676b368938c61ecc21d1403fe8b68f151dba1ef80e9fc7b9166460f09a0e9c6aa275dcd005b615fd66c08dce5ae5f6b6b4f02421241ff266f8ca1
+  data.tar.gz: cb84d351c30f19dd86c7351351ec29ffd01e930f21ba2aece3061724ed1c7cc2a0ca3d43ec8ea0335a0741ada0debf683d379f8fa48eb12c521a2ba057fa66d8

data/README.md

@@ -196,6 +196,12 @@ end
 - The test fails with "The crossing check found no files to read" when none of the files
   it read belongs to a hub or the host's layer, so a wrong `files:` pattern or an empty
   map does not pass unnoticed.
+- It also fails naming each class defined in the files it reads that no hub owns, such as
+  "No hub owns Shop::Refund", and each class the map gives to two hubs, such as "Two hubs
+  own Shop::Receipt".
+- It fails naming each class the map names that no longer exists in the app, such as "The
+  map names Shop::Ghost, which does not exist", so a renamed or removed class does not
+  stay in the map.
 
 ## Installation
 Add this line to your application's Gemfile:

data/lib/hub_kernel/conformance/crossings.rb

@@ -17,15 +17,31 @@ module HubKernel
 
       included do
         test "no file names a class another hub owns" do
-          paths = (Dir.glob(crossing_files, base: crossing_root) - crossing_exceptions).sort
-          flunk "The crossing check found no files to read" if paths.none? { |path| the_crossings.belongs?(path) }
+          flunk "The crossing check found no files to read" if crossing_paths.none? { |path| the_crossings.belongs?(path) }
 
-          found = paths.flat_map do |path|
+          found = crossing_paths.flat_map do |path|
             the_crossings.in(path, File.read(File.join(crossing_root, path))).map { |name| "#{path} names #{name}" }
           end
           assert found.empty?, found.join("\n")
         end
+
+        test "every class it reads belongs to a hub" do
+          unowned = the_crossings.unowned_classes(crossing_paths)
+          assert unowned.empty?, unowned.map { |name| "No hub owns #{name}" }.join("\n")
+        end
+
+        test "no class belongs to two hubs" do
+          twice = the_crossings.claimed_twice
+          assert twice.empty?, twice.map { |name| "Two hubs own #{name}" }.join("\n")
+        end
+
+        test "every class the map names exists" do
+          missing = the_crossings.missing_classes
+          assert missing.empty?, missing.map { |name| "The map names #{name}, which does not exist" }.join("\n")
+        end
       end
+
+      def crossing_paths = (Dir.glob(crossing_files, base: crossing_root) - crossing_exceptions).sort
     end
   end
 end

data/lib/hub_kernel/crossings.rb

@@ -16,8 +16,18 @@ module HubKernel
 
     def belongs?(path) = !owner_of_file(path).nil?
 
+    def unowned_classes(paths)
+      paths.select { |path| path.end_with?(".rb") && !path.start_with?("app/views/") }.map { |path| class_of(path) }.reject { |name| owner_of(name) }
+    end
+
+    def claimed_twice = @owners.values.flatten.tally.select { |_name, hubs| hubs > 1 }.keys
+
+    def missing_classes = @owners.values.flatten.uniq.reject(&:safe_constantize)
+
     private
 
+    def class_of(path) = path.sub(%r{\Aapp/[^/]+/}, "").delete_suffix(".rb").camelize
+
     def crossing?(name, hub)
       return false if @shared.include?(name) || owner_of(name) == hub
 
@@ -34,7 +44,7 @@ module HubKernel
     def owner_of_file(path)
       return owner_of_view_folder(File.dirname(path.delete_prefix("app/views/")).camelize) if path.start_with?("app/views/")
 
-      owner_of(path.sub(%r{\Aapp/[^/]+/}, "").delete_suffix(".rb").camelize)
+      owner_of(class_of(path))
     end
 
     def owner_of_view_folder(folder) = owner_of("#{folder}Controller") || owner_of(folder) || @host_layer

data/lib/hub_kernel/version.rb

@@ -1,3 +1,3 @@
 module HubKernel
-  VERSION = "0.11.0"
+  VERSION = "0.13.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hub_kernel
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.13.0
 platform: ruby
 authors:
 - tylercschneider