hub_kernel-mcp 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 921598b05d30bf9e211477dbc575f7e59a8cde2487bdaa935e13242c7a80b5e7
-  data.tar.gz: d3e4111ecee2b448bee1120f7f9653b06c31bfd50d6a5143d622626fe42e7cc5
+  metadata.gz: 90fe375e57411dd604b4bbcd46776ba7d3f64b829ab6d79c5ad9b0de4a14c1cd
+  data.tar.gz: eefdf79205bb8a4b8a5be1ec171dc4eac15316bede5f3ad3069efe3f1a2301d0
 SHA512:
-  metadata.gz: eeb8295b220d5cdc288ba99e991eeced8e0e5be262d7052a95715a4703e886ddb5db31f2369234a093fd2858ff08e89a2910a388c531121710058f09fbd83612
-  data.tar.gz: 73f9ce82ab316a2dbf92b912ba0676f871d311975b4f297c7cdb8a0e263c722c954c53705a23a779038494e7a1b2e48a1ffea254389c6ff2f64c0c8e1e624446
+  metadata.gz: 2d964c38b18504184297666e94174507baf671c754dfd131b428be747efb337574e32292c331c7f23908edbc9a11dd44e46414a0e141c1d41a9e9d04e043c24c
+  data.tar.gz: 6a98d684583139acc2ace28041202f55f59d19cc06ec894dbd5929101502fecdd91b8904aa356a56690e2a609d9637df0c0bf61232bcd7db194b42ff2e314044

data/README.md

@@ -21,9 +21,16 @@ serves:
 ```ruby
 Rails.application.config.to_prepare do
   HubKernel::Interface.hubs = [ Supplies, { "money" => Billing::Ledger } ]
+  HubKernel::Mcp.check!
 end
 ```
 
+`HubKernel::Mcp.check!` raises `HubKernel::Mcp::UnservableHubError` naming every problem
+in one error. It names each problem hub_kernel-interface's own check finds in the served
+list, a served name holding two underscores in a row, and a tool whose name holds a
+character other than a letter, a digit, an underscore or a hyphen or is longer than 64
+characters. Inside `to_prepare` it runs again after every code reload.
+
 Mount the engine:
 
 ```ruby
@@ -58,10 +65,13 @@ give, and returns the method's answer as JSON text:
 { "content": [ { "type": "text", "text": "\"soap costs 3\"" } ], "isError": false }
 ```
 
-A hub's refusal, or a value the method requires and the call left out, comes back as a tool
-error carrying the reason, with `isError` set. A tool the caller may not call, a tool that does
-not exist, and a tool naming a hub the host does not serve are all answered with the same
-JSON-RPC error, code -32602, `Unknown tool: <name>`.
+A hub's refusal, a value the method requires and the call left out, a value the method is not
+listed with, and a record the call names that does not exist each come back as a tool error
+carrying the reason, with `isError` set. The last two reasons come from hub_kernel-interface, so
+they read the same in every interface gem, such as `price_of does not take colour` and
+`No item has the id 9`. A tool the caller may not call, a tool that does not exist, and a tool
+naming a hub the host does not serve are all answered with the same JSON-RPC error, code
+-32602, `Unknown tool: <name>`, whatever values the call sends.
 
 A caller the host's sign-in refuses is refused before any hub is asked.
 

data/app/controllers/hub_kernel/mcp/messages_controller.rb

@@ -38,12 +38,18 @@ module HubKernel
       def called
         served_name, method_name = tool_name.split("__", 2)
         hub = HubKernel::Interface.find(served_name) || raise(UnknownTool)
+        raise UnknownTool unless hub.exposed(method_name)
+        HubKernel::Interface::CallReasons.refuse_unlisted_values(hub, method_name, values: arguments, person: caller_person, account: caller_account)
         answer = hub.call_exposed(method_name, values: arguments, person: caller_person, account: caller_account)
         { content: [ { type: "text", text: answer.to_json } ], isError: false }
       rescue HubKernel::Refused, HubKernel::MissingArgumentError => refusal
-        { content: [ { type: "text", text: refusal.message } ], isError: true }
+        tool_error(refusal.message)
+      rescue ActiveRecord::RecordNotFound => missing
+        tool_error(HubKernel::Interface::CallReasons.missing_record(missing))
       end
 
+      def tool_error(reason) = { content: [ { type: "text", text: reason } ], isError: true }
+
       def tool_name = params.dig(:params, :name).to_s
 
       def arguments = params.dig(:params, :arguments)&.to_unsafe_h.to_h.deep_symbolize_keys

data/lib/hub_kernel/mcp/version.rb

@@ -1,5 +1,5 @@
 module HubKernel
   module Mcp
-    VERSION = "0.3.0"
+    VERSION = "0.5.0"
   end
 end

data/lib/hub_kernel/mcp.rb

@@ -4,8 +4,46 @@ require "hub_kernel/mcp/engine"
 
 module HubKernel
   module Mcp
+    UnservableHubError = HubKernel::Interface::UnservableHubError
+
     mattr_accessor :base_controller, default: "ActionController::API"
     mattr_accessor :person_method
     mattr_accessor :account_method
+
+    def self.check!
+      problems = shared_problems + doubled_underscores + unlisted_characters + long_names
+      raise UnservableHubError, problems.join("\n") if problems.any?
+    end
+
+    def self.shared_problems
+      HubKernel::Interface.check!
+      []
+    rescue UnservableHubError => error
+      error.message.split("\n")
+    end
+
+    def self.doubled_underscores
+      HubKernel::Interface.served.select { |name, _hub| name.include?("__") }.map do |name, hub|
+        "#{hub.name} is served at #{name}, which holds two underscores in a row"
+      end
+    end
+
+    def self.unlisted_characters
+      tool_names.grep_v(/\A[A-Za-z0-9_-]*\z/).map do |name|
+        "The tool #{name} holds a character other than a letter, a digit, an underscore or a hyphen"
+      end
+    end
+
+    def self.long_names
+      tool_names.select { |name| name.length > 64 }.map { |name| "The tool #{name} is longer than 64 characters" }
+    end
+
+    def self.tool_names
+      HubKernel::Interface.served.select { |_name, hub| hub.respond_to?(:exposures) }.flat_map do |served_name, hub|
+        hub.exposures.map { |exposure| "#{served_name}__#{exposure.name}" }
+      end
+    end
+
+    private_class_method :shared_problems, :doubled_underscores, :unlisted_characters, :long_names, :tool_names
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hub_kernel-mcp
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - tylercschneider
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
 description: hub_kernel-mcp serves the methods every hub a host serves exposes as
   MCP tools at one address, with every call going through the host's sign-in, permission
   check and account scope.