hub_kernel-api 0.7.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 012cd9631dd8925bcd3d6982acc076ee8ade6a159dbca527d3618ba4ff80eec4
-  data.tar.gz: 98850fb2e56aca0a182d1f70adc2deedb440e9b54f0f188e321a2738034d8991
+  metadata.gz: db1ce3a434c4f5c216ee183a431c31b983481255e1b277d74b061e9c6fbd57bd
+  data.tar.gz: 2e70a8aa06c9602d9b30cc9b9946bd432b5f58fefb54368e05829f4f4b20f66d
 SHA512:
-  metadata.gz: b2e7fc3101f127f70f515be313c0532efd5a64bce8f568dc693fa2e7e3a962dad5703ea5a295e3020cc56b644fc283854a140ac24d7f588d891227b30934bf70
-  data.tar.gz: 67b21cabf1dd75ad74c7c97a3d908432a7c508c5fd39b13a3108a63ede102b8864fc4dde26c47f6da666dbdd3234351e764a3d1d0f6431d4275fc94f7dbb12e9
+  metadata.gz: d872502bd39dd53ccad7391f327c1184aad52334ee0779d6f1491d1fb336118d0f0ee34f93164f70c0dda48a480b890173a46c500ef0731971ecb41ee4b79793
+  data.tar.gz: 5c372f040e56f64de05b83f1752928083105cfae076c20dd1ad09850152a990d918698e51cdd20c55c6495bc8890f79ec4b59557e2561306dc0dcae28a3cc162

data/README.md

@@ -22,11 +22,20 @@ Rails.application.config.to_prepare do
 end
 ```
 
+When `HubKernel::Api.person_method` or `HubKernel::Api.account_method` is not set, the JSON
+API uses `HubKernel::Interface.person_method` or `HubKernel::Interface.account_method`, so a
+host that also serves hub_kernel-mcp can name the caller once in hub_kernel-interface. The
+JSON API's own setting is used when it is set.
+
 `HubKernel::Api.check!` raises `HubKernel::Api::UnservableHubError` when a served entry
 exposes no methods, when two served hubs answer at the same address, or when a served
 hub's exposed list has a problem, naming each. Inside `to_prepare` it runs again after
 every code reload.
 
+`HubKernel::Api.hubs` reads and writes hub_kernel-interface's one served list,
+`HubKernel::Interface.hubs`, so every interface gem in the host, such as hub_kernel-mcp,
+serves the same hubs at the same names. The list is set once, through either gem.
+
 The base controller's own sign-in runs before every call. The permission check and account
 scope must also be set, `HubKernel::Authz.check` and `HubKernel::Context.scope`, as
 hub_kernel-interface's readme describes. Mount the engine:

data/app/controllers/hub_kernel/api/hub_calls_controller.rb

@@ -8,8 +8,8 @@ module HubKernel
 
       def answer
         raise ActionController::RoutingError, "Not found" unless asked_with_the_right_verb?
-        return refuse_unlisted_values if unlisted_values.any?
 
+        HubKernel::Interface::CallReasons.refuse_unlisted_values(hub, params[:name], values: values, person: caller_person, account: caller_account)
         render json: { answer: hub.call_exposed(params[:name], values: values, person: caller_person, account: caller_account) }
       end
 
@@ -17,23 +17,11 @@ module HubKernel
 
       def asked_with_the_right_verb? = hub.exposed(params[:name])&.writes == request.post?
 
-      def refuse_unlisted_values
-        raise HubKernel::NotAllowed unless permitted?
-
-        refused(HubKernel::Refused.new("#{params[:name]} does not take #{unlisted_values.join(", ")}"))
-      end
-
-      def permitted? = hub.exposures_for(person: caller_person, account: caller_account).any? { |exposure| exposure.name.to_s == params[:name] }
-
-      def unlisted_values = values.keys - hub.exposed(params[:name]).takes
-
       def values = request.query_parameters.merge(request.request_parameters).deep_symbolize_keys
 
       def refused(refusal) = render(json: { error: refusal.message }, status: :unprocessable_content)
 
-      def missing_record(missing)
-        render json: { error: "No #{missing.model.demodulize.underscore.humanize(capitalize: false)} has the id #{missing.id}" }, status: :not_found
-      end
+      def missing_record(missing) = render(json: { error: HubKernel::Interface::CallReasons.missing_record(missing) }, status: :not_found)
     end
   end
 end

data/app/controllers/hub_kernel/api/hub_controller.rb

@@ -7,9 +7,9 @@ module HubKernel
 
       def hub = @hub ||= HubKernel::Api.find(params[:hub]) || raise(ActionController::RoutingError, "Not found")
 
-      def caller_person = send(HubKernel::Api.person_method)
+      def caller_person = send(HubKernel::Api.person_method || HubKernel::Interface.person_method)
 
-      def caller_account = send(HubKernel::Api.account_method)
+      def caller_account = send(HubKernel::Api.account_method || HubKernel::Interface.account_method)
 
       def not_found = render(json: { error: "Not found" }, status: :not_found)
     end

data/lib/hub_kernel/api/version.rb

@@ -1,5 +1,5 @@
 module HubKernel
   module Api
-    VERSION = "0.7.0"
+    VERSION = "0.9.0"
   end
 end

data/lib/hub_kernel/api.rb

@@ -4,33 +4,20 @@ require "hub_kernel/api/engine"
 
 module HubKernel
   module Api
-    class UnservableHubError < StandardError; end
+    UnservableHubError = HubKernel::Interface::UnservableHubError
 
-    mattr_accessor :hubs, default: []
     mattr_accessor :base_controller, default: "ActionController::API"
     mattr_accessor :person_method
     mattr_accessor :account_method
 
-    def self.find(name) = addresses[name]
+    def self.hubs = HubKernel::Interface.hubs
 
-    def self.check!
-      problems = unexposed_hubs + shared_addresses + exposure_problems
-      raise UnservableHubError, problems.join("\n") if problems.any?
+    def self.hubs=(hubs)
+      HubKernel::Interface.hubs = hubs
     end
 
-    def self.addresses = served.to_h
+    def self.find(name) = HubKernel::Interface.find(name)
 
-    def self.served = hubs.flat_map { |entry| entry.is_a?(Hash) ? entry.to_a : [ [ entry.name.demodulize.underscore, entry ] ] }
-
-    def self.unexposed_hubs = served.map(&:last).reject { |hub| hub.respond_to?(:exposures) }.map { |hub| "#{hub.name} exposes no methods to serve" }
-
-    def self.shared_addresses
-      served.group_by(&:first).select { |_address, entries| entries.size > 1 }.map do |address, entries|
-        "#{entries.map { |_address, hub| hub.name }.join(" and ")} both answer at #{address}"
-      end
-    end
-
-    def self.exposure_problems = served.map(&:last).select { |hub| hub.respond_to?(:exposure_problems) }.flat_map(&:exposure_problems)
-    private_class_method :served, :unexposed_hubs, :shared_addresses, :exposure_problems
+    def self.check! = HubKernel::Interface.check!
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hub_kernel-api
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.9.0
 platform: ruby
 authors:
 - tylercschneider
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.9'
 description: 'hub_kernel-api gives any hub built on hub_kernel a JSON API: the host
   lists the hubs it serves, and every call goes through the host''s sign-in, permission
   check and account scope.'