htty 1.4.1 → 1.5.0

data/spec/unit/htty/cli/commands/http_options_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_get")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_options")
 

data/spec/unit/htty/cli/commands/http_patch_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/follow")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_delete")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_get")

data/spec/unit/htty/cli/commands/http_post_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/follow")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_delete")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_get")

data/spec/unit/htty/cli/commands/http_put_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_delete")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_get")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_patch")

data/spec/unit/htty/cli/commands/http_trace_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_get")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_trace")
 

data/spec/unit/htty/cli/commands/patch_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/patch")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_patch")
 

data/spec/unit/htty/cli/commands/path_set_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/cd")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/path_set")

data/spec/unit/htty/cli/commands/port_set_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/port_set")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/scheme_set")

data/spec/unit/htty/cli/commands/post_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/post")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_post")
 

data/spec/unit/htty/cli/commands/put_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/put")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/http_put")
 

data/spec/unit/htty/cli/commands/query_add_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_add")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_remove")

data/spec/unit/htty/cli/commands/query_clear_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_clear")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_unset_all")
 

data/spec/unit/htty/cli/commands/query_remove_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_add")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_remove")

data/spec/unit/htty/cli/commands/query_set_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_add")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_remove")

data/spec/unit/htty/cli/commands/query_unset_all_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_clear")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_set")

data/spec/unit/htty/cli/commands/query_unset_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_add")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/query_remove")

data/spec/unit/htty/cli/commands/quit_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/exit")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/quit")
 

data/spec/unit/htty/cli/commands/reuse_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/history")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/history_verbose")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/reuse")

data/spec/unit/htty/cli/commands/scheme_set_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/port_set")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/scheme_set")

data/spec/unit/htty/cli/commands/shared_examples_for_commands.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+shared_examples_for 'a command' do
+  it 'should be an alias_for the expected command' do
+    described_class.alias_for.should == alias_for
+  end
+
+  it 'should have the expected aliases' do
+    described_class.aliases.should == aliases
+  end
+
+  it 'should belong to the expected category' do
+    described_class.category.should == category
+  end
+
+  it 'should have the expected command_line' do
+    described_class.command_line.should == command_line
+  end
+
+  it 'should have the expected command_line_arguments' do
+    described_class.command_line_arguments.should == arguments
+  end
+
+  it 'should have the expected help' do
+    described_class.help.should_not be_empty
+  end
+
+  it 'should have the expected help_extended' do
+    described_class.help_extended.should be_multiline
+  end
+
+  it 'should have the expected see_also_commands' do
+    described_class.see_also_commands.should =~ see_also_commands
+  end
+
+  describe 'build_for' do
+    it 'should correctly handle a valid, unabbreviated command line' do
+      command_used = command_line.tr('[]', '')
+      built = described_class.build_for(command_used, :session => :the_session)
+      built.should be_instance_of(described_class)
+      built.arguments.should == []
+      built.session.should == :the_session
+    end
+
+    it 'should correctly handle a valid, abbreviated command line' do
+      if command_line.match /^(.*)\[(.*?)\]$/
+        command_used = $1 + $2[0, rand($2.length)+1]
+        built = described_class.build_for(command_used, :session => :the_session)
+        built.should be_instance_of(described_class)
+        built.arguments.should == []
+        built.session.should == :the_session
+      end
+    end
+  end
+end

data/spec/unit/htty/cli/commands/ssl_verification_off_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_off")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_on")

data/spec/unit/htty/cli/commands/ssl_verification_on_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_off")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_on")

data/spec/unit/htty/cli/commands/ssl_verification_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_off")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/ssl_verification_on")

data/spec/unit/htty/cli/commands/status_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/body_response")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/headers_response")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/status")

data/spec/unit/htty/cli/commands/undo_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/undo")
 
 describe HTTY::CLI::Commands::Undo do

data/spec/unit/htty/cli/commands/userinfo_clear_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_clear")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_unset")
 

data/spec/unit/htty/cli/commands/userinfo_set_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_set")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_unset")
@@ -71,5 +71,27 @@ The console prompt shows the address for the current request. Userinfo appears i
         built.should == nil
       end
     end
+
+    describe '#sanitize_arguments' do
+      context 'when only one argument like username:password' do
+        let(:arguments) {['username:password']}
+
+        it 'should be splitted in two arguments' do
+          klass.sanitize_arguments(arguments).should == [
+            'username', 'password'
+          ]
+        end
+      end
+
+      context 'when arguments contains special characters' do
+        let(:arguments) {['user/name', 'password']}
+
+        it 'should escape them' do
+          klass.sanitize_arguments(arguments).should == [
+            'user%2Fname', 'password'
+          ]
+        end
+      end
+    end
   end
 end

data/spec/unit/htty/cli/commands/userinfo_unset_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/address")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_clear")
 require File.expand_path("#{File.dirname __FILE__}/../../../../../lib/htty/cli/commands/userinfo_set")

data/spec/unit/htty/cli/display_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+require File.expand_path("#{File.dirname __FILE__}/../../../../lib/htty/headers")
+require File.expand_path("#{File.dirname __FILE__}/../../../../lib/htty/cli/display")
+
+describe HTTY::CLI::Display do
+  let(:display) {Class.new.new.extend(HTTY::CLI::Display)}
+
+  describe '#show_headers' do
+    it 'displays headers keeping the text case' do
+      headers = HTTY::Headers.new('user-agent' => 'htty/1.4.1').to_a
+
+      expect {display.show_headers(headers)}.to print_on_stdout(
+        "user-agent:#{display.strong('')} htty/1.4.1\n"
+      )
+    end
+
+    context 'with one header' do
+      let(:headers) {HTTY::Headers.new('User-Agent' => 'htty/1.4.1').to_a}
+
+      it 'displays the header starting from the beginning of the line' do
+        expect {display.show_headers(headers)}.to print_on_stdout(
+          "User-Agent:#{display.strong('')} htty/1.4.1\n"
+        )
+      end
+    end
+
+    context 'with few headers' do
+      let(:headers) {
+        headers = HTTY::Headers.new
+        headers['User-Agent'] = 'htty/1.4.1'
+        headers['Content-Type'] = 'application/json'
+        headers.to_a
+      }
+
+      it 'aligns headers on colons' do
+        expect {display.show_headers(headers)}.to print_on_stdout(
+          "  User-Agent:#{display.strong('')} htty/1.4.1\n" +
+          "Content-Type:#{display.strong('')} application/json\n"
+        )
+      end
+    end
+
+    context 'with marked headers' do
+      context 'with one header' do
+        let(:headers) {HTTY::Headers.new('User-Agent' => 'htty/1.4.1').to_a}
+        let(:options) {{:show_mercantile_next_to => 'User-Agent'}}
+
+        it 'displays the header starting from the beginning of the line' do
+          expect {display.show_headers(headers, options)}.to print_on_stdout(
+            "User-Agent:#{display.strong('@')} htty/1.4.1\n"
+          )
+        end
+      end
+
+      context 'with few headers' do
+        let(:options) {{:show_mercantile_next_to => 'Content-Type'}}
+        let(:headers) {
+          headers = HTTY::Headers.new
+          headers['User-Agent'] = 'htty/1.4.1'
+          headers['Content-Type'] = 'application/json'
+          headers.to_a
+        }
+
+        it 'aligns colons and mercantiles' do
+          expect {display.show_headers(headers, options)}.to print_on_stdout(
+            "   User-Agent:#{display.strong('')} htty/1.4.1\n" +
+            "Content-Type:#{display.strong('@')} application/json\n"
+          )
+        end
+      end
+    end
+
+    context 'when asked to mark an header' do
+      let(:options) {{:show_mercantile_next_to => 'Content-Type'}}
+      let(:headers) {HTTY::Headers.new('content-type' => 'application/json').to_a}
+
+      it 'marks headers indipendently of the text case' do
+        expect {display.show_headers(headers, options)}.to print_on_stdout(
+          "content-type:#{display.strong('@')} application/json\n"
+        )
+      end
+    end
+  end
+end

data/spec/unit/htty/cli_spec.rb

@@ -1,4 +1,4 @@
-require 'rspec'
+require 'spec_helper'
 require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/cli")
 require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/request")
 

data/spec/unit/htty/command.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/request")
+require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/cli/command")
+
+describe HTTY::CLI::Command do
+  let(:last_request) {HTTY::Request.new('http://0.0.0.0')}
+  let(:requests) {[last_request]}
+  let(:session) do
+    session = double
+    session.stub(:requests) {requests}
+    session
+  end
+
+  subject{described_class.new(:session => session)}
+
+  describe '#add_request_if_new' do
+    context 'when command returns nil' do
+      it 'should not add the request' do
+        expect do
+          subject.send(:add_request_if_new) do
+            nil
+          end
+        end.to_not change{subject.session.requests.count}
+      end
+    end
+
+    context 'when command returns the same request' do
+      it 'should not add the request' do
+        expect do
+          subject.send(:add_request_if_new) do
+            last_request
+          end
+        end.to_not change{subject.session.requests.count}
+      end
+    end
+
+    context 'when command returns a different request' do
+      it 'should add the request' do
+        expect do
+          subject.send(:add_request_if_new) do
+            HTTY::Request.new('http://0.0.0.0/foo')
+          end
+        end.to change{subject.session.requests.count}.by(1)
+      end
+    end
+  end
+end

data/spec/unit/htty/{ordered_hash_spec.rb → headers_spec.rb}

@@ -1,7 +1,7 @@
-require 'rspec'
-require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/ordered_hash")
+require 'spec_helper'
+require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/headers")
 
-describe HTTY::OrderedHash do
+describe HTTY::Headers do
   describe 'that is empty' do
     it { should be_empty }
 
@@ -20,7 +20,7 @@ describe HTTY::OrderedHash do
   end
 
   describe 'that has values out of order' do
-    subject { HTTY::OrderedHash.new('foo' => 'bar', 'baz' => 'qux') }
+    subject { described_class.new('foo' => 'bar', 'baz' => 'qux') }
 
     it { should == {'foo' => 'bar', 'baz' => 'qux'} }
 

data/spec/unit/htty/payload_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+require File.expand_path("#{File.dirname __FILE__}/../../../lib/htty/payload")
+
+
+describe HTTY::Payload do
+  before(:all) do
+    @bare_payload = Class.new(HTTY::Payload)
+  end
+
+  let(:body) {nil}
+  let(:headers) {[['Accept', 'application/json']]}
+
+  subject {@bare_payload.new({:body => body, :headers => headers})}
+
+  it 'should heave headers' do
+    subject.should have(1).headers
+  end
+
+  describe '.headers(key)' do
+    it 'should be case insensitive' do
+      subject.headers_with_key('Accept').should == [['Accept', 'application/json']]
+      subject.headers_with_key('Accept').should == subject.headers_with_key('accept')
+    end
+  end
+
+  describe '.header(key)' do
+    it 'should return the header with a given key' do
+      subject.header('Accept').should == 'application/json'
+    end
+
+    it 'should return the header with a given key ignoring the case' do
+      ['Accept', 'ACCEPT', 'accept', 'AccEpT'].each do |key|
+        subject.header(key).should == 'application/json'
+      end
+    end
+
+    context 'when key is not found' do
+      it 'should raise an exception' do
+        expect do
+          subject.header('not-found-key')
+        end.to raise_error(HTTY::NoHeaderError)
+      end
+
+      context 'when given a value as second parameter' do
+        it 'should return the default value' do
+          subject.header('not-found-key', :default).should == :default
+        end
+      end
+
+      context 'when given an exception' do
+        it 'should raise that exception' do
+          exception_to_raise = Exception.new('key not found')
+          expect do
+            subject.header('not-found-key', exception_to_raise)
+          end.to raise_error(exception_to_raise.class)
+        end
+      end
+    end
+  end
+end