httpx 0.9.0 → 0.10.0

data/lib/httpx/response.rb

@@ -75,11 +75,11 @@ module HTTPX
         @status == 204 ||
         @status == 205 ||
         @status == 304 || begin
-        content_length = @headers["content-length"]
-        return false if content_length.nil?
+          content_length = @headers["content-length"]
+          return false if content_length.nil?
 
-        content_length == "0"
-      end
+          content_length == "0"
+        end
     end
 
     class Body
@@ -95,6 +95,8 @@ module HTTPX
       end
 
       def write(chunk)
+        return if @state == :closed
+
         @length += chunk.bytesize
         transition
         @buffer.write(chunk)
@@ -116,7 +118,7 @@ module HTTPX
         return enum_for(__method__) unless block_given?
 
         begin
-          unless @state == :idle
+          if @buffer
             rewind
             while (chunk = @buffer.read(@window_size))
               yield(chunk.force_encoding(@encoding))
@@ -155,20 +157,19 @@ module HTTPX
         if dest.respond_to?(:path) && @buffer.respond_to?(:path)
           FileUtils.mv(@buffer.path, dest.path)
         else
-          @buffer.rewind
           ::IO.copy_stream(@buffer, dest)
         end
       end
 
       # closes/cleans the buffer, resets everything
       def close
-        return if @state == :idle
-
-        @buffer.close
-        @buffer.unlink if @buffer.respond_to?(:unlink)
-        @buffer = nil
+        if @buffer
+          @buffer.close
+          @buffer.unlink if @buffer.respond_to?(:unlink)
+          @buffer = nil
+        end
         @length = 0
-        @state = :idle
+        @state = :closed
       end
 
       def ==(other)
@@ -186,7 +187,7 @@ module HTTPX
       private
 
       def rewind
-        return if @state == :idle
+        return unless @buffer
 
         @buffer.rewind
       end
@@ -267,15 +268,7 @@ module HTTPX
       @error.message
     end
 
-    def reason
-      @error.class.name
-    end
-
-    def headers
-      {}
-    end
-
-    def body
+    def to_s
       @error.backtrace.join("\n")
     end
 
@@ -285,7 +278,7 @@ module HTTPX
 
     # rubocop:disable Style/MissingRespondToMissing
     def method_missing(meth, *, &block)
-      raise NoMethodError, "undefined response method `#{meth}' for error response" if Response.public_method_defined?(meth)
+      raise NoMethodError, "undefined response method `#{meth}' for error response" if @options.response_class.public_method_defined?(meth)
 
       super
     end

data/lib/httpx/selector.rb

@@ -51,7 +51,7 @@ class HTTPX::Selector
   READ_INTERESTS = %i[r rw].freeze
   WRITE_INTERESTS = %i[w rw].freeze
 
-  def select_many(interval)
+  def select_many(interval, &block)
     selectables, r, w = nil
 
     # first, we group IOs based on interest type. On call to #interests however,
@@ -102,9 +102,7 @@ class HTTPX::Selector
       writers.delete(io)
     end if readers
 
-    writers.each do |io|
-      yield io
-    end if writers
+    writers.each(&block) if writers
   end
 
   def select_one(interval)

data/lib/httpx/session.rb

@@ -66,7 +66,8 @@ module HTTPX
     end
 
     def find_connection(request, connections, options)
-      uri = URI(request.uri)
+      uri = request.uri
+
       connection = pool.find_connection(uri, options) || build_connection(uri, options)
       unless connections.nil? || connections.include?(connection)
         connections << connection
@@ -135,10 +136,10 @@ module HTTPX
                    reqs.map do |verb, uri, opts = EMPTY_HASH|
                      build_request(verb, uri, request_options.merge(opts))
                    end
-                 when 2, 3
+                 when 2
                    verb, uris = args
                    if uris.respond_to?(:each)
-                     uris.map do |uri, **opts|
+                     uris.enum_for(:each).map do |uri, opts = EMPTY_HASH|
                        build_request(verb, uri, request_options.merge(opts))
                      end
                    else
@@ -189,15 +190,13 @@ module HTTPX
       begin
         # guarantee ordered responses
         loop do
-          begin
-            request = requests.first
-            pool.next_tick until (response = fetch_response(request, connections, request_options))
+          request = requests.first
+          pool.next_tick until (response = fetch_response(request, connections, request_options))
 
-            responses << response
-            requests.shift
+          responses << response
+          requests.shift
 
-            break if requests.empty? || pool.empty?
-          end
+          break if requests.empty? || pool.empty?
         end
         responses
       ensure
@@ -221,7 +220,7 @@ module HTTPX
       def plugin(pl, options = nil, &block)
         # raise Error, "Cannot add a plugin to a frozen config" if frozen?
         pl = Plugins.load_plugin(pl) if pl.is_a?(Symbol)
-        unless @plugins.include?(pl)
+        if !@plugins.include?(pl)
           @plugins << pl
           pl.load_dependencies(self, &block) if pl.respond_to?(:load_dependencies)
           @default_options = @default_options.dup
@@ -245,6 +244,13 @@ module HTTPX
           opts.connection_class.__send__(:include, pl::ConnectionMethods) if defined?(pl::ConnectionMethods)
           pl.configure(self, &block) if pl.respond_to?(:configure)
 
+          @default_options.freeze
+        elsif options
+          # this can happen when two plugins are loaded, an one of them calls the other under the hood,
+          # albeit changing some default.
+          @default_options = @default_options.dup
+          @default_options = @default_options.merge(options)
+
           @default_options.freeze
         end
         self

data/lib/httpx/transcoder/chunker.rb

@@ -10,8 +10,6 @@ module HTTPX::Transcoder
     class Encoder
       extend Forwardable
 
-      def_delegator :@raw, :readpartial
-
       def initialize(body)
         @raw = body
       end

data/lib/httpx/transcoder/form.rb

@@ -14,8 +14,6 @@ module HTTPX::Transcoder
 
       def_delegator :@raw, :bytesize
 
-      def_delegator :@raw, :force_encoding
-
       def initialize(form)
         @raw = URI.encode_www_form(form)
       end
@@ -23,10 +21,6 @@ module HTTPX::Transcoder
       def content_type
         "application/x-www-form-urlencoded"
       end
-
-      def to_str
-        @raw.to_s
-      end
     end
 
     def encode(form)

data/lib/httpx/transcoder/json.rb

@@ -10,14 +10,10 @@ module HTTPX::Transcoder
     class Encoder
       extend Forwardable
 
-      def_delegator :@raw, :to_str
-
       def_delegator :@raw, :to_s
 
       def_delegator :@raw, :bytesize
 
-      def_delegator :@raw, :force_encoding
-
       def initialize(json)
         @raw = ::JSON.dump(json)
         @charset = @raw.encoding.name.downcase

data/lib/httpx/utils.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module HTTPX
+  module Utils
+    using URIExtensions
+
+    module_function
+
+    # The value of this field can be either an HTTP-date or a number of
+    # seconds to delay after the response is received.
+    def parse_retry_after(retry_after)
+      # first: bet on it being an integer
+      Integer(retry_after)
+    rescue ArgumentError
+      # Then it's a datetime
+      time = Time.httpdate(retry_after)
+      time - Time.now
+    end
+
+    if RUBY_VERSION < "2.3"
+      def uri(*args)
+        URI(*args)
+      end
+    else
+
+      URIParser = URI::RFC2396_Parser.new
+
+      def uri(uri)
+        return Kernel.URI(uri) unless uri.is_a?(String) && !uri.ascii_only?
+
+        uri = Kernel.URI(URIParser.escape(uri))
+
+        non_ascii_hostname = URIParser.unescape(uri.host)
+
+        non_ascii_hostname.force_encoding(Encoding::UTF_8)
+
+        idna_hostname = DomainName.new(non_ascii_hostname).hostname
+
+        uri.host = idna_hostname
+        uri.non_ascii_hostname = non_ascii_hostname
+        uri
+      end
+    end
+  end
+end

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.9.0"
+  VERSION = "0.10.0"
 end

data/sig/buffer.rbs

@@ -0,0 +1,24 @@
+module HTTPX
+  class Buffer
+    include _ToS
+    include _ToStr
+
+    @buffer: String
+
+    attr_reader limit: Integer
+
+    def full?: () -> bool
+    def shift!: (Integer) -> void
+
+    # delegated
+    def <<: (string data) -> void
+    def empty?: () -> bool
+    def bytesize: () -> Integer
+    def clear: () -> void
+    def replace: (string) -> void
+
+    private
+
+    def initialize: (Integer limit) -> untyped
+  end
+end

data/sig/callbacks.rbs

@@ -0,0 +1,14 @@
+module HTTPX
+  interface _Callable
+    def call: (*untyped) -> void
+  end
+
+  module Callbacks
+    def on: (Symbol) { (*untyped) -> void } -> void
+    def once: (Symbol) { (*untyped) -> void } -> void
+    def emit: (Symbol, *untyped) -> void
+
+    def callbacks: () -> Hash[Symbol, Array[_Callable]]
+                  | (Symbol) -> Array[_Callable]
+  end
+end

data/sig/chainable.rbs

@@ -0,0 +1,37 @@
+module HTTPX
+  module Chainable
+    def request: (*untyped, **untyped) -> (response | Array[response])
+    def accept: (String) -> Session
+    def wrap: () { (Session) -> void } -> void
+            | () -> void
+
+    def with: (options) -> Session
+            | (options) { (Session) -> Session} -> Session
+
+
+
+
+    def plugin: (:authentication) -> Plugins::sessionAuthentication
+              | (:basic_authentication) -> Plugins::sessionBasicAuthentication
+              | (:digest_authentication) -> Plugins::sessionDigestAuthentication
+              | (:compression) -> Session
+              | (:cookies) -> Plugins::sessionCookies
+              | (:expect) -> Session
+              | (:follow_redirects) -> Plugins::sessionFollowRedirects
+              | (:h2c) -> Plugins::sessionH2C
+              | (:multipart) -> Session
+              | (:persistent) -> Plugins::sessionPersistent
+              | (:proxy) -> Plugins::sessionProxy
+              | (:push_promise) -> Plugins::sessionPushPromise
+              | (:retries) -> Plugins::sessionRetries
+              | (:stream) -> Plugins::sessionStream
+              | (Symbol | Module, ?options?) { (Class) -> void } -> Session
+              | (Symbol | Module, ?options?) -> Session
+
+    private
+
+    def default_options: () -> Options
+    def branch: (options) -> Session
+              | (options) { (Session) -> Session } -> Session
+  end
+end

data/sig/connection.rbs

@@ -0,0 +1,2 @@
+class HTTPX::Connection
+end

data/sig/connection/http2.rbs

@@ -0,0 +1,4 @@
+module HTTPX
+  class Connection::HTTP2
+  end
+end

data/sig/domain_name.rbs

@@ -0,0 +1,17 @@
+module HTTPX
+  class DomainName
+    type domain = string | DomainName
+
+    include Comparable
+
+    def normalize: (String) -> String
+
+    def cookie_domain?: (domain, ?bool?) -> bool
+
+    def self.new: (domain) -> untyped
+
+    private
+
+    def initialize: (string) -> untyped
+  end
+end

data/sig/errors.rbs

@@ -0,0 +1,3 @@
+module HTTPX
+  Error: singleton(StandardError)
+end

data/sig/headers.rbs

@@ -0,0 +1,42 @@
+module HTTPX
+  class Headers
+    include _ToS
+
+    @headers: headers_hash
+
+    def self.new: (?untyped headers) -> Headers
+
+    def ==: (untyped other) -> bool
+
+    def []: (headers_key field) -> _ToS?
+    def []=: (headers_key field, headers_value value) -> void
+
+    def add: (headers_key field, string value) -> void
+    def delete: (headers_key field) -> void
+
+    def each: () { (headers_key, String) -> void } -> void
+            | () -> Enumerable[[headers_key, String], void]
+
+    def get: (headers_key field) -> Array[String]
+    def key?: (headers_key downcased_key) -> bool
+
+    def merge: (_Each[headers_key, headers_value] other) -> Headers
+
+    def same_headers?: (untyped headers) -> bool
+
+    def to_a: () -> Array[[headers_key, String]]
+    def inspect: () -> String 
+
+    private
+
+    def initialize: (headers?) -> untyped
+    def array_value: (headers_value) -> Array[String]
+    def downcased: (headers_key) -> String
+  end
+
+  type headers_key = String | Symbol
+  type headers_value = _ToS | Array[_ToS]
+  type headers_hash = Hash[headers_key, headers_value]
+  type headers_input = headers_hash | Array[[headers_key, string]]
+  type headers = Headers | headers_input
+end

data/sig/httpx.rbs

@@ -0,0 +1,14 @@
+module HTTPX
+  extend Chainable
+
+  VERSION: String
+
+  type uri = URI::HTTP | URI::HTTPS | string
+
+  type verb = :options | :get | :head | :post | :put | :delete | :trace | :connect |
+              :propfind | :proppatch | :mkcol | :copy | :move | :lock | :unlock | :orderpatch |
+              :acl | :report | :patch | :search
+
+  module Plugins
+  end
+end