httpx 0.23.3 → 0.23.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a826e525e4ea1e2836566d70fa8af5231580bc0836482a86b4af8a159785895
-  data.tar.gz: 13d7e254551f8b730361f347b9570e4af4544c63d98ef1ca9a25eea51e10b340
+  metadata.gz: e3869ae05ccfa2903477391c3ed918d9022ebd628795a09ad9681511a2d46f77
+  data.tar.gz: c7d296cdbaed94327582b409463677ad549038d5785d8e296e837c243183bf43
 SHA512:
-  metadata.gz: e1db33022d9e917911a570cd4773078dfe5feb4198fc58e65da04cfcc278fb8569af4b8754b60b7545897546f8da05f62b56557c132f02dfcfc628923d605f47
-  data.tar.gz: bffcd04f84fd74c825d186215d919b943349c8cd7672bf030c81696956f5625216e4118e8a16f6cdea8321f62d8fc018fbd17ca8dbeb2ad667ca847aca46de44
+  metadata.gz: 80b74ee360f1db9632a0e1317e3a3ed5ae3ac863e5c6c637e4ba85719027e68bf1e3fcc2103b35b1fc11221bd832af911d985a7dd51eb9030cd9392bf310b591
+  data.tar.gz: b424d2a3e8c796cd04747bd446a06ee690f1fa5965f397b4e7ab98880ca2d34f97d8846ecccf6973b42351b15543d610dac6ca8217ba68fb53388610071e17e1

data/doc/release_notes/0_23_4.md

@@ -0,0 +1,5 @@
+# 0.23.4
+
+## Bugfixes
+
+* fix `Response::Body#read` which rewinds on every call.

data/lib/httpx/plugins/response_cache/file_store.rb

@@ -0,0 +1,34 @@
+# # frozen_string_literal: true
+
+# require "mutex_m"
+# require "forwardable"
+
+# module HTTPX::Plugins
+#   module ResponseCache
+#     class FileStore < Store
+#       def initialize(dir = Dir.tmpdir)
+#         @dir = Pathname.new(dir)
+#         @store = {}
+#         @hash_store.extend(Mutex_m)
+#       end
+
+#       def clear
+#         @store.synchronize { @store.clear }
+#       end
+
+#       def _get(request)
+#         return unless File.exist?(@dir.join(request.response_cache_key))
+
+#         @store.synchronize { @store[key] }
+#       end
+
+#       def set(key)
+#         @store.synchronize do
+#           resps = (@store[key] ||= [])
+
+#           yield resps
+#         end
+#       end
+#     end
+#   end
+# end

data/lib/httpx/response.rb

@@ -107,6 +107,8 @@ module HTTPX
 
       raise Error, "no decoder available for \"#{transcoder}\"" unless decoder
 
+      @body.rewind
+
       decoder.call(self, *args)
     end
 
@@ -152,9 +154,12 @@ module HTTPX
       def read(*args)
         return unless @buffer
 
-        rewind
+        unless @reader
+          rewind
+          @reader = @buffer
+        end
 
-        @buffer.read(*args)
+        @reader.read(*args)
       end
 
       def bytesize
@@ -249,14 +254,17 @@ module HTTPX
       end
       # :nocov:
 
-      private
-
       def rewind
         return unless @buffer
 
+        # in case there's some reading going on
+        @reader = nil
+
         @buffer.rewind
       end
 
+      private
+
       def transition
         case @state
         when :idle

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.23.3"
+  VERSION = "0.23.4"
 end

data/sig/response.rbs

@@ -58,6 +58,7 @@ module HTTPX
       @window_size: Integer
       @length: Integer
       @buffer: StringIO | Tempfile | nil
+      @reader: StringIO | Tempfile | nil
 
       def write:(String chunk) -> Integer?
 
@@ -72,10 +73,11 @@ module HTTPX
       def close: () -> void
       def closed?: () -> bool
 
+      def rewind: () -> void
+
       private
 
-      def initialize: (Response, Options) -> untyped
-      def rewind: () -> void
+      def initialize: (Response, Options) -> void
       def transition: () -> void
       def _with_same_buffer_pos: [A] () { () -> A } -> A
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpx
 version: !ruby/object:Gem::Version
-  version: 0.23.3
+  version: 0.23.4
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http-2-next
@@ -98,6 +98,7 @@ extra_rdoc_files:
 - doc/release_notes/0_23_1.md
 - doc/release_notes/0_23_2.md
 - doc/release_notes/0_23_3.md
+- doc/release_notes/0_23_4.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
 - doc/release_notes/0_3_0.md
@@ -188,6 +189,7 @@ files:
 - doc/release_notes/0_23_1.md
 - doc/release_notes/0_23_2.md
 - doc/release_notes/0_23_3.md
+- doc/release_notes/0_23_4.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
 - doc/release_notes/0_3_0.md
@@ -275,6 +277,7 @@ files:
 - lib/httpx/plugins/push_promise.rb
 - lib/httpx/plugins/rate_limiter.rb
 - lib/httpx/plugins/response_cache.rb
+- lib/httpx/plugins/response_cache/file_store.rb
 - lib/httpx/plugins/response_cache/store.rb
 - lib/httpx/plugins/retries.rb
 - lib/httpx/plugins/stream.rb