httpx 0.20.0 → 0.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a5a31aeffa012bd1eea19c1e892c8669624de0d21c9cd8911ae025375f0b93fb
-  data.tar.gz: 285707682eb2d1451106d28bc2d4a8ceb247d4237139c9e7d83bd5a0163b5a5c
+  metadata.gz: 2d7bcf0e6c97e369caf28c209d551d4f9667745b6a6a530ae2efd328c611e0e5
+  data.tar.gz: 822c0437afcefb35e7d4319f91e71c5b4c81720bd0d7a7763db1d1f8bfbc4b1a
 SHA512:
-  metadata.gz: 6f2c50aa8895c6f07ed0acbca1b1171343da2b55bc838ae7f2a0f7a44300c101ea0020938946bf630b80ad6b81bed3cb54910b0734576b6e7c000e058497128c
-  data.tar.gz: 83e19a86d841056821d9198c9a8e3e7b06ec354445289a1fd7d612d070b02b0a01aa9f45f5acdb0b35e4da413c2c3955646e5f55c5421db95879092a0a3aa377
+  metadata.gz: 747e7d2ca2a4aee92f1774473e9b38565fec3879ee6b6d0ab3c4eeb1313740c6bbd3648c8c6f21b40903f4bf9bc842647b531968debcda747652afb483577b11
+  data.tar.gz: 88d3bafe38437bebb42960d980dddc85e9e12a917c492203744ded3f93c79736feedf839604cd1a4b080a59c64c96c26c545808cc29d19bcdaa93fa55154bbef

data/doc/release_notes/0_19_8.md

@@ -1,4 +1,4 @@
-# 0.19.7
+# 0.19.8
 
 ## Bugfixes
 

data/doc/release_notes/0_20_0.md

@@ -1,4 +1,4 @@
-# 0.19.0
+# 0.20.0
 
 ## Features
 

data/doc/release_notes/0_20_1.md

@@ -0,0 +1,5 @@
+# 0.20.1
+
+## Bugfixes
+
+* bugfix for unregistering connections when timing out on DNS resolving; this wasn't happening, leaving a few cases where requests to the same domain timing out on resolution would hang on the second request.

data/lib/httpx/pool.rb

@@ -80,6 +80,9 @@ module HTTPX
       connection.on(:activate) do
         select_connection(connection)
       end
+      connection.on(:close) do
+        unregister_connection(connection)
+      end
     end
 
     def deactivate(connections)
@@ -143,8 +146,6 @@ module HTTPX
 
     def on_resolver_error(connection, error)
       connection.emit(:error, error)
-      # must remove connection by hand, hasn't been started yet
-      unregister_connection(connection)
     end
 
     def on_resolver_close(resolver)
@@ -171,8 +172,7 @@ module HTTPX
 
     def unregister_connection(connection)
       @connections.delete(connection)
-      deselect_connection(connection)
-      @connected_connections -= 1
+      @connected_connections -= 1 if deselect_connection(connection)
     end
 
     def select_connection(connection)

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.20.0"
+  VERSION = "0.20.1"
 end

data/sig/pool.rbs

@@ -36,9 +36,9 @@ module HTTPX
 
     def unregister_connection: (Connection) -> void
 
-    def select_connection: (Resolver::Resolver | Connection connection) -> void
+    def select_connection: (Selector::selectable) -> void
 
-    def deselect_connection: (Resolver::Resolver | Connection connection) -> void
+    def deselect_connection: (Selector::selectable) -> Selector::selectable?
 
     def coalesce_connections: (Connection coalescable, Connection coalescing) -> void
 

data/sig/selector.rbs

@@ -7,7 +7,7 @@ module HTTPX
     @selectables: Array[selectable]
 
     def register: (selectable io) -> void
-    def deregister: (selectable io) -> void
+    def deregister: (selectable io) -> selectable?
 
     def select: (Numeric? interval) { (selectable) -> void } -> void
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpx
 version: !ruby/object:Gem::Version
-  version: 0.20.0
+  version: 0.20.1
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-31 00:00:00.000000000 Z
+date: 2022-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http-2-next
@@ -81,6 +81,7 @@ extra_rdoc_files:
 - doc/release_notes/0_19_8.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_20_0.md
+- doc/release_notes/0_20_1.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
 - doc/release_notes/0_3_0.md
@@ -154,6 +155,7 @@ files:
 - doc/release_notes/0_19_8.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_20_0.md
+- doc/release_notes/0_20_1.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
 - doc/release_notes/0_3_0.md