httpx 0.14.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abbeaccc55115244f08e7b39aaad174a34dd2e7aeb10b32cdc0563fbefe1b953
-  data.tar.gz: a39fc4e5644b21c1265840011e969c36904756573584cba0f805d568a549ec94
+  metadata.gz: fbedc26fba4c0d9a8e0543b437ada103b42bbd89d537a50546590adb2f004d04
+  data.tar.gz: 6645eeb893ed1f07a8e7c7c86db73c0ff2d49f01c63e52888d7da868b925bcdc
 SHA512:
-  metadata.gz: 82fa475dcd9ef05ebe90f0b3c742c17c33185410a70eb5af730fce393681b7f9f346decf78349614f77b76257550c0e3056e61f3b5d6cd5efdba0149eff235f6
-  data.tar.gz: 64ceb596415b440c99c9df31569fa0ee2f7c94e51787d5e0d84141f1ade0be92e23e2d7011a361c1366b43c4f159525599367009bd4021c358537f11c4605cac
+  metadata.gz: 1ea37e203901dbae07960c12023cbeb2b3ee62ea461a265ab3dff8687b8874e33cf3bf0bbf62df30243030ce9420317bf635e5df1102cfa9a8503ec09949ca3c
+  data.tar.gz: 3515498ac93ca1ef5f165754e8caa95dbddf8aebe079b0efbf8d5a7a78a778d76a4812e4beeddc723dd6fb81dafa4a47c7ae9cb2463834ebd5cf7812ef30a45c

data/doc/release_notes/0_14_1.md

@@ -0,0 +1,7 @@
+# 0.14.0
+
+
+## Bugfixes
+
+* fixed: HTTP/2-specific headers were being reused on insecure redirects, thereby creating an invalid request (#128);
+* fixed: multipart request parts weren't using explicity set `:content_type`, instead using file mime type or "text/plain";

data/lib/httpx/connection/http1.rb

@@ -254,12 +254,15 @@ module HTTPX
     end
 
     def set_protocol_headers(request)
-      request.headers["host"] ||= request.authority
-      request.headers["connection"] ||= request.options.persistent ? "keep-alive" : "close"
       if !request.headers.key?("content-length") &&
          request.body.bytesize == Float::INFINITY
         request.chunk!
       end
+
+      {
+        "host" => (request.headers["host"] || request.authority),
+        "connection" => (request.headers["connection"] || (request.options.persistent ? "keep-alive" : "close")),
+      }
     end
 
     def headline_uri(request)
@@ -282,8 +285,8 @@ module HTTPX
     def join_headers(request)
       @buffer << "#{request.verb.to_s.upcase} #{headline_uri(request)} HTTP/#{@version.join(".")}" << CRLF
       log(color: :yellow) { "<- HEADLINE: #{@buffer.to_s.chomp.inspect}" }
-      set_protocol_headers(request)
-      join_headers2(request.headers)
+      extra_headers = set_protocol_headers(request)
+      join_headers2(request.headers.each(extra_headers))
       log { "<- " }
       @buffer << CRLF
     end

data/lib/httpx/connection/http2.rb

@@ -192,18 +192,20 @@ module HTTPX
     end
 
     def set_protocol_headers(request)
-      request.headers[":scheme"]    = request.scheme
-      request.headers[":method"]    = request.verb.to_s.upcase
-      request.headers[":path"]      = headline_uri(request)
-      request.headers[":authority"] = request.authority
+      {
+        ":scheme" => request.scheme,
+        ":method" => request.verb.to_s.upcase,
+        ":path" => headline_uri(request),
+        ":authority" => request.authority,
+      }
     end
 
     def join_headers(stream, request)
-      set_protocol_headers(request)
+      extra_headers = set_protocol_headers(request)
       log(level: 1, color: :yellow) do
-        request.headers.each.map { |k, v| "#{stream.id}: -> HEADER: #{k}: #{v}" }.join("\n")
+        request.headers.merge(extra_headers).each.map { |k, v| "#{stream.id}: -> HEADER: #{k}: #{v}" }.join("\n")
       end
-      stream.headers(request.headers.each, end_stream: request.empty?)
+      stream.headers(request.headers.each(extra_headers), end_stream: request.empty?)
     end
 
     def join_trailers(stream, request)

data/lib/httpx/headers.rb

@@ -103,12 +103,16 @@ module HTTPX
     # returns the enumerable headers store in pairs of header field + the values in
     # the comma-separated string format
     #
-    def each
-      return enum_for(__method__) { @headers.size } unless block_given?
+    def each(extra_headers = nil)
+      return enum_for(__method__, extra_headers) { @headers.size } unless block_given?
 
       @headers.each do |field, value|
         yield(field, value.join(", ")) unless value.empty?
       end
+
+      extra_headers.each do |field, value|
+        yield(field, value) unless value.empty?
+      end if extra_headers
     end
 
     def ==(other)

data/lib/httpx/plugins/multipart/part.rb

@@ -26,7 +26,7 @@ module HTTPX
           content_type ||= MimeTypeDetector.call(value, filename) || "application/octet-stream"
           [value, content_type, filename]
         else
-          [StringIO.new(value.to_s), "text/plain"]
+          [StringIO.new(value.to_s), content_type || "text/plain"]
         end
       end
     end

data/lib/httpx/plugins/proxy/http.rb

@@ -82,11 +82,12 @@ module HTTPX
           end
 
           def set_protocol_headers(request)
-            super
+            extra_headers = super
+
             proxy_params = @options.proxy
-            request.headers["proxy-authorization"] = "Basic #{proxy_params.token_authentication}" if proxy_params.authenticated?
-            request.headers["proxy-connection"] = request.headers["connection"]
-            request.headers.delete("connection")
+            extra_headers["proxy-authorization"] = "Basic #{proxy_params.token_authentication}" if proxy_params.authenticated?
+            extra_headers["proxy-connection"] = extra_headers.delete("connection") if extra_headers.key?("connection")
+            extra_headers
           end
         end
 

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.14.0"
+  VERSION = "0.14.1"
 end

data/sig/connection/http1.rbs

@@ -52,7 +52,7 @@ module HTTPX
 
     def disable_pipelining: () -> void
 
-    def set_protocol_headers: (Request) -> void
+    def set_protocol_headers: (Request) -> _Each[headers_key, String]
 
     def headline_uri: (Request) -> String
 
@@ -62,7 +62,7 @@ module HTTPX
 
     def join_trailers: (Request request) -> void
 
-    def join_headers2: (Headers headers) -> void
+    def join_headers2: (_Each[headers_key, String] headers) -> void
 
     def join_body: (Request request) -> void
 

data/sig/connection/http2.rbs

@@ -43,7 +43,7 @@ module HTTPX
 
     def headline_uri: (Request) -> String
 
-    def set_protocol_headers: (Request) -> void
+    def set_protocol_headers: (Request) -> _Each[headers_key, String]
 
     def handle: (Request request, HTTP2Next::Stream stream) -> void
 

data/sig/headers.rbs

@@ -14,8 +14,8 @@ module HTTPX
     def add: (headers_key field, string value) -> void
     def delete: (headers_key field) -> void
 
-    def each: () { (headers_key, String) -> void } -> void
-            | () -> Enumerable[[headers_key, String], void]
+    def each: (?_Each[headers_key, String]? extra_headers) { (headers_key, String) -> void } -> void
+            | (?_Each[headers_key, String]? extra_headers) -> Enumerable[[headers_key, String], void]
 
     def get: (headers_key field) -> Array[String]
     def key?: (headers_key downcased_key) -> bool

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpx
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-22 00:00:00.000000000 Z
+date: 2021-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http-2-next
@@ -47,44 +47,45 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 - doc/release_notes/0_0_1.md
-- doc/release_notes/0_1_0.md
-- doc/release_notes/0_0_5.md
+- doc/release_notes/0_0_2.md
+- doc/release_notes/0_0_3.md
 - doc/release_notes/0_0_4.md
-- doc/release_notes/0_14_0.md
-- doc/release_notes/0_6_5.md
-- doc/release_notes/0_13_0.md
-- doc/release_notes/0_6_1.md
-- doc/release_notes/0_11_2.md
-- doc/release_notes/0_7_0.md
-- doc/release_notes/0_6_0.md
+- doc/release_notes/0_0_5.md
+- doc/release_notes/0_10_0.md
+- doc/release_notes/0_10_1.md
 - doc/release_notes/0_10_2.md
+- doc/release_notes/0_11_0.md
+- doc/release_notes/0_11_1.md
+- doc/release_notes/0_11_2.md
 - doc/release_notes/0_11_3.md
-- doc/release_notes/0_8_2.md
-- doc/release_notes/0_6_4.md
-- doc/release_notes/0_13_1.md
 - doc/release_notes/0_12_0.md
-- doc/release_notes/0_9_0.md
-- doc/release_notes/0_6_3.md
-- doc/release_notes/0_10_1.md
-- doc/release_notes/0_11_0.md
-- doc/release_notes/0_8_1.md
-- doc/release_notes/0_5_0.md
-- doc/release_notes/0_6_7.md
+- doc/release_notes/0_13_0.md
+- doc/release_notes/0_13_1.md
 - doc/release_notes/0_13_2.md
+- doc/release_notes/0_14_0.md
+- doc/release_notes/0_14_1.md
+- doc/release_notes/0_1_0.md
+- doc/release_notes/0_2_0.md
+- doc/release_notes/0_2_1.md
+- doc/release_notes/0_3_0.md
+- doc/release_notes/0_3_1.md
+- doc/release_notes/0_4_0.md
 - doc/release_notes/0_4_1.md
+- doc/release_notes/0_5_0.md
 - doc/release_notes/0_5_1.md
-- doc/release_notes/0_6_6.md
-- doc/release_notes/0_4_0.md
+- doc/release_notes/0_6_0.md
+- doc/release_notes/0_6_1.md
 - doc/release_notes/0_6_2.md
-- doc/release_notes/0_10_0.md
-- doc/release_notes/0_11_1.md
+- doc/release_notes/0_6_3.md
+- doc/release_notes/0_6_4.md
+- doc/release_notes/0_6_5.md
+- doc/release_notes/0_6_6.md
+- doc/release_notes/0_6_7.md
+- doc/release_notes/0_7_0.md
 - doc/release_notes/0_8_0.md
-- doc/release_notes/0_3_0.md
-- doc/release_notes/0_2_1.md
-- doc/release_notes/0_0_3.md
-- doc/release_notes/0_0_2.md
-- doc/release_notes/0_3_1.md
-- doc/release_notes/0_2_0.md
+- doc/release_notes/0_8_1.md
+- doc/release_notes/0_8_2.md
+- doc/release_notes/0_9_0.md
 files:
 - LICENSE.txt
 - README.md
@@ -105,6 +106,7 @@ files:
 - doc/release_notes/0_13_1.md
 - doc/release_notes/0_13_2.md
 - doc/release_notes/0_14_0.md
+- doc/release_notes/0_14_1.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
@@ -287,7 +289,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: HTTPX, to the future, and beyond