httpx 0.13.1 → 0.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3859c516c1cdddc64f8105fafd5425da26074582b1590cc87f65401a909e0e2
-  data.tar.gz: 209b5c1fba921d69f9aa2167ccb0f4b6b45a1a28667364eefef8026104004f53
+  metadata.gz: 35006c293d6a61a011056400a7934619b869ad32d9287507df8140bc9afd83fb
+  data.tar.gz: 62152c1c7cc0f7f330396f8e5967b4430226ba50466d6c9c829a52d4eb4902f8
 SHA512:
-  metadata.gz: 3862b4879291aa944b92c50d232abc6413a170f2bcd501d6f33a1ca55a99a1411dd0d4f2b6a50b92a8b1465fa42b654ef658c15a91154205bfd60bcdc983c5a5
-  data.tar.gz: 6b2f721cc2bb8e0fe7267517dcd146fe50f448676bcec64e9744d5f358232d8d9c364acd6717e0df3a72bfcb1d154a7e4b74252324cf9a248f1fe062242eb4fe
+  metadata.gz: 3aef9a00cb4861ae3c4bcf32af947d5c66b9e5bdf545e2cdae30733454a3c140704e36f138857868b4c564c59bb95e16ee0fc4a33500e4035a4c872f4f78421e
+  data.tar.gz: a1d55b77708ada85b1ec14575ee441369cbe302d7a13e316d3f91efbf8b64a6b2c8cabaa06329759a07190858f271df88462622a2bcddd598823a7d55de61c28

data/doc/release_notes/0_13_2.md

@@ -0,0 +1,9 @@
+# 0.13.1
+
+## Improvements
+
+`UDPSocket#sendmsg_nonblock` is now used in the native resolver.
+
+## Bugfixes
+
+Usage in Windows was buggy, resulting in `Errno::EINVAL` during DNS resolving, when using the native resolver. This was due to a discrepancy between `recvfrom` behaviour in WS Sockets and Linux Sockets. This was fixed by making we the UDP socket never tries to receive before a DNS query has been actually sent.

data/lib/httpx/io/udp.rb

@@ -39,16 +39,20 @@ module HTTPX
       end
     end
 
-    def write(buffer)
-      siz = @io.send(buffer.to_s, 0, @host, @port)
-      log { "WRITE: #{siz} bytes..." }
-      buffer.shift!(siz)
-      siz
-    end
-
     # :nocov:
     if (RUBY_ENGINE == "truffleruby" && RUBY_ENGINE_VERSION < "21.1.0") ||
        RUBY_VERSION < "2.3"
+      def write(buffer)
+        siz = @io.sendmsg_nonblock(buffer.to_s, 0, Socket.sockaddr_in(@port, @host.to_s))
+        log { "WRITE: #{siz} bytes..." }
+        buffer.shift!(siz)
+        siz
+      rescue ::IO::WaitWritable
+        0
+      rescue EOFError
+        nil
+      end
+
       def read(size, buffer)
         data, _ = @io.recvfrom_nonblock(size)
         buffer.replace(data)
@@ -59,6 +63,18 @@ module HTTPX
       rescue IOError
       end
     else
+
+      def write(buffer)
+        siz = @io.sendmsg_nonblock(buffer.to_s, 0, Socket.sockaddr_in(@port, @host.to_s), exception: false)
+        return 0 if siz == :wait_writable
+        return if siz.nil?
+
+        log { "WRITE: #{siz} bytes..." }
+
+        buffer.shift!(siz)
+        siz
+      end
+
       def read(size, buffer)
         ret = @io.recvfrom_nonblock(size, 0, buffer, exception: false)
         return 0 if ret == :wait_readable
@@ -68,6 +84,14 @@ module HTTPX
       rescue IOError
       end
     end
+
+    # In JRuby, sendmsg_nonblock is not implemented
+    def write(buffer)
+      siz = @io.send(buffer.to_s, 0, @host, @port)
+      log { "WRITE: #{siz} bytes..." }
+      buffer.shift!(siz)
+      siz
+    end if RUBY_ENGINE == "jruby"
     # :nocov:
   end
 end

data/lib/httpx/plugins/aws_sigv4.rb

@@ -150,6 +150,7 @@ module HTTPX
         end
 
         def load_dependencies(klass)
+          require "digest/sha2"
           require "openssl"
           klass.plugin(:expect)
           klass.plugin(:compression)

data/lib/httpx/plugins/upgrade.rb

@@ -33,7 +33,8 @@ module HTTPX
         def fetch_response(request, connections, options)
           response = super
 
-          if response && response.headers.key?("upgrade")
+          if response
+            return response unless response.respond_to?(:headers) && response.headers.key?("upgrade")
 
             upgrade_protocol = response.headers["upgrade"].split(/ *, */).first
 

data/lib/httpx/resolver/native.rb

@@ -101,7 +101,7 @@ module HTTPX
         transition(:open)
       end
 
-      !@write_buffer.empty? || @queries.empty? ? :w : :r
+      calculate_interests
     end
 
     def <<(connection)
@@ -127,10 +127,14 @@ module HTTPX
 
     private
 
+    def calculate_interests
+      !@write_buffer.empty? || @queries.empty? ? :w : :r
+    end
+
     def consume
-      dread
+      dread if calculate_interests == :r
       do_retry
-      dwrite
+      dwrite if calculate_interests == :w
     end
 
     def do_retry

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.13.1"
+  VERSION = "0.13.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpx
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.13.2
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-27 00:00:00.000000000 Z
+date: 2021-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http-2-next
@@ -61,6 +61,7 @@ extra_rdoc_files:
 - doc/release_notes/0_12_0.md
 - doc/release_notes/0_13_0.md
 - doc/release_notes/0_13_1.md
+- doc/release_notes/0_13_2.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
@@ -101,6 +102,7 @@ files:
 - doc/release_notes/0_12_0.md
 - doc/release_notes/0_13_0.md
 - doc/release_notes/0_13_1.md
+- doc/release_notes/0_13_2.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md