httpspell 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6245dacfbe0f2b1f7a95e95118a058e592f0fcbe88407b804e756bd41691054
-  data.tar.gz: 731ddea385cdca5f40c14c10289583b1544b9055bd82015ce2c5beb3b9495b52
+  metadata.gz: dc09324c003c7b14e08fa255b7a31c0a9aeb143df033da9aea300619a47268ba
+  data.tar.gz: 6890352a3cef38e243e2506398d58736c8179c2e0443a2b6ff341165e724dba0
 SHA512:
-  metadata.gz: 2295d29b287812f6f1330d4cc17a5eae9ab3a14e99bb9ab4d4215761d3146a3f27b8ddcb66331999156c68a1ac58e2ac33b47d7043b7a2771e56faca03eb7b62
-  data.tar.gz: 6cbab0f82ae37c684a6bf4ad60e30a7b5a9921e5d90956bd4baa088e4190c9e8b2b8359e41c457dc6d594c962e43b13e3483046b0208f5bb5273d0928e74950f
+  metadata.gz: 826bb8e875b2f1584dd5c052ab9777e616e1da0d6844263589b027c3eabfb07955155e0c43b8b1b8dc253d720eba952e80330c38035fff53fc1943420dea7454
+  data.tar.gz: 7a4e3c9aaa586d4fbdc41971424cd5f064793ff18cba8d8606a452b3cee36070af44aa2f78ab307c71a613404cc1e490af1f56eca11068675183625f5360790e

data/.rubocop.yml

@@ -1,7 +1,11 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
 AllCops:
   NewCops: enable
   TargetRubyVersion: 3.3
   Include:
+    - '**/*.rb'
     - '**/Gemfile'
     - '**/Rakefile'
     - '**/config.ru'
@@ -23,3 +27,19 @@ Layout/LineLength:
   Max: 160
 Style/Documentation:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+RSpec/ExampleWording:
+  Enabled: false
+RSpec/InstanceVariable:
+  AssignmentOnly: true
+RSpec/ExampleLength:
+  Max: 10
+Metrics/PerceivedComplexity:
+  Max: 16

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    httpspell (1.4.0)
+    httpspell (1.4.1)
       addressable
       nokogiri
 

data/TODO.markdown

@@ -2,4 +2,3 @@
 * exe/httpspell:    # TODO: --recursive, defaults to false
 * exe/httpspell:    # TODO wget has some additional options for recursive behavior that should be reviewed
 * lib/httpspell/spider.rb:          # TODO Print _which_ entry of the blacklist matches
-* lib/httpspell/spider.rb:        # TODO Ignore same page links (some anchor)

data/exe/httpspell

@@ -2,9 +2,9 @@
 # frozen_string_literal: true
 
 require 'optparse'
-require 'httpspell/spider'
-require 'httpspell/spellchecker'
-require 'httpspell/version'
+require 'http_spell/spider'
+require 'http_spell/spellchecker'
+require 'http_spell/version'
 
 personal_dictionary_path = nil
 force_language = nil

data/httpspell.gemspec

@@ -2,7 +2,7 @@
 
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'httpspell/version'
+require 'http_spell/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'httpspell'

data/lib/{httpspell → http_spell}/spellchecker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HttpSpell
   class SpellChecker
     def initialize(personal_dictionary_path = nil, verbose: false)
@@ -12,7 +14,7 @@ module HttpSpell
       ]
 
       if @verbose
-        warn "Piping the HTML document into the following chain of commands:"
+        warn 'Piping the HTML document into the following chain of commands:'
         warn commands
       end
 

data/lib/{httpspell → http_spell}/spider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 require 'open-uri'
 require 'open3'
@@ -27,13 +29,13 @@ module HttpSpell
         begin
           extracted = links(url) do |u, d|
             yield u, d if block_given?
-          rescue
+          rescue StandardError
             warn "Callback error for #{url}: #{$ERROR_INFO}"
             warn $ERROR_INFO.backtrace if @tracing
           end
 
           done.append(url)
-          todo.concat(extracted - done - todo)
+          todo.concat(extracted - done - todo).uniq!
         rescue StandardError
           warn "Skipping #{url} because of #{$ERROR_INFO.message}"
           warn $ERROR_INFO.backtrace if @tracing
@@ -41,7 +43,7 @@ module HttpSpell
         end
       end
 
-      return success
+      success
     end
 
     private
@@ -66,12 +68,14 @@ module HttpSpell
         end
 
         if @blacklist.any? { |re| re.match?(link.to_s) }
-          # TODO Print _which_ entry of the blacklist matches
+          # TODO: Print _which_ entry of the blacklist matches
           warn "Skipping #{link} because it is on the blacklist #{@blacklist}" if @verbose
           next
         end
 
-        # TODO Ignore same page links (some anchor)
+        # Ignore fragment; we always check the whole page
+        link.fragment = nil
+
         link
       rescue StandardError
         warn $ERROR_INFO.message
@@ -89,10 +93,10 @@ module HttpSpell
       tries = 10
 
       begin
-        URI.open(uri, redirect: false)
-      rescue OpenURI::HTTPRedirect => redirect
-        uri = redirect.uri
-        retry if (tries -= 1) > 0
+        URI.parse(uri).open(redirect: false)
+      rescue OpenURI::HTTPRedirect => e
+        uri = e.uri
+        retry if (tries -= 1).positive?
         raise
       end
     end

data/lib/{httpspell → http_spell}/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HttpSpell
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpspell
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Steffen Uhlig
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-05-29 00:00:00.000000000 Z
+date: 2024-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -63,9 +63,9 @@ files:
 - TODO.markdown
 - exe/httpspell
 - httpspell.gemspec
-- lib/httpspell/spellchecker.rb
-- lib/httpspell/spider.rb
-- lib/httpspell/version.rb
+- lib/http_spell/spellchecker.rb
+- lib/http_spell/spider.rb
+- lib/http_spell/version.rb
 homepage:
 licenses:
 - MIT