httpi 3.0.2 → 4.0.4

data/spec/integration/net_http_persistent_spec.rb

@@ -1,171 +0,0 @@
-require "spec_helper"
-require "integration/support/server"
-require "net/http/persistent"
-
-describe HTTPI::Adapter::NetHTTPPersistent do
-
-  subject(:adapter) { :net_http_persistent }
-
-  context "http requests" do
-    before :all do
-      @server = IntegrationServer.run
-    end
-
-    after :all do
-      @server.stop
-    end
-
-    it "sends and receives HTTP headers" do
-      request = HTTPI::Request.new(@server.url + "x-header")
-      request.headers["X-Header"] = "HTTPI"
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to include("HTTPI")
-    end
-
-    it "it supports headers with multiple values" do
-      request = HTTPI::Request.new(@server.url + "cookies")
-
-      response = HTTPI.get(request, adapter)
-      cookies = ["cookie1=chip1; path=/", "cookie2=chip2; path=/"]
-      expect(response.headers["Set-Cookie"]).to eq(cookies)
-    end
-
-    it "it supports read timeout" do
-      require "net/http/persistent"
-
-      request = HTTPI::Request.new(@server.url + "timeout")
-      request.read_timeout = 0.5 # seconds
-
-      expect do
-        HTTPI.get(request, adapter)
-      end.to raise_exception(Net::ReadTimeout)
-    end
-
-    it "executes GET requests" do
-      response = HTTPI.get(@server.url, adapter)
-      expect(response.body).to eq("get")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes POST requests" do
-      request = HTTPI::Request.new(url: @server.url, body: "<some>xml</some>")
-
-      response = HTTPI.post(request, adapter)
-      expect(response.body).to eq("post")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes HEAD requests" do
-      response = HTTPI.head(@server.url, adapter)
-      expect(response.code).to eq(200)
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes PUT requests" do
-      response = HTTPI.put(@server.url, "<some>xml</some>", adapter)
-      expect(response.body).to eq("put")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes DELETE requests" do
-      response = HTTPI.delete(@server.url, adapter)
-      expect(response.body).to eq("delete")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "supports basic authentication" do
-      request = HTTPI::Request.new(@server.url + "basic-auth")
-      request.auth.basic("admin", "secret")
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to eq("basic-auth")
-    end
-
-    it "does not support ntlm authentication" do
-      request = HTTPI::Request.new(@server.url + "ntlm-auth")
-      request.auth.ntlm("tester", "vReqSoafRe5O")
-
-      expect { HTTPI.get(request, adapter) }.
-        to raise_error(HTTPI::NotSupportedError, /does not support NTLM authentication/)
-    end
-
-    # it does not support digest authentication
-
-    it "supports chunked response" do
-      request = HTTPI::Request.new(@server.url)
-      res = ""
-      request.on_body do |body|
-        res += body
-      end
-      response = HTTPI.post(request, adapter)
-      expect(res).to eq("post")
-      expect(response.body.to_s).to eq("")
-    end
-  end
-
-  if RUBY_PLATFORM =~ /java/
-    pending "Puma Server complains: SSL not supported on JRuby"
-  else
-    context "https requests" do
-      before :all do
-        @server = IntegrationServer.run(:ssl => true)
-      end
-
-      after :all do
-        @server.stop
-      end
-
-      # does not raise when no certificate was set up
-      it "works when set up properly" do
-        request = HTTPI::Request.new(@server.url)
-        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-
-        response = HTTPI.get(request, adapter)
-        expect(response.body).to eq("get")
-      end
-
-      it "works with ciphers" do
-        request = HTTPI::Request.new(@server.url)
-        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-        request.auth.ssl.ciphers = OpenSSL::SSL::SSLContext.new.ciphers
-
-        response = HTTPI.get(request, adapter)
-        expect(response.body).to eq("get")
-      end
-    end
-  end
-
-  # The built-in Rack IntegrationServer and specs support a basic simulated NTLM exchange
-  # that does not require anything outside of the normal gem test infrastructure.
-  #   (see spec/httpi/adapter/net_http_spec.rb: it "supports ntlm authentication"
-  #    and spec/integration/support/application.rb: map "/ntlm-auth")
-  # But since that simulated exchange is based on recorded traffic, you may wish to
-  # run the following integration test against a real external NTLM server from time to time.
-  #
-  # This test must be specially enabled because it requires an external
-  # Windows 2012 Server configured according to the instructions found here:
-  #   https://github.com/savonrb/httpi/wiki/NTLM-Integration-Test-Plan
-  #
-  # Once you have that server running as instructed, you can include this test by setting
-  # NTLM=external via the command line, e.g.:
-  #   $ NTLM=external bundle exec rspec
-  #
-  if ENV["NTLM"]=="external"
-    context "http request via NTLM" do
-      it "works with NTLM connections" do
-        user = "tester"
-        pass = "vReqSoafRe5O"
-        request = HTTPI::Request.new("http://ntlmtest/")
-        request.auth.ntlm(user,pass)
-        response = HTTPI.get(request, adapter)
-        expect(response.code).to eq(200)
-        expect(response.body).to match(/iis-8\.png/)
-
-        puts "EXTERNAL NTLM INTEGRATION TEST, response body:"
-        puts response.body
-      end
-    end
-  end
-
-end

data/spec/integration/net_http_spec.rb

@@ -1,285 +0,0 @@
-require "spec_helper"
-require "integration/support/server"
-
-describe HTTPI::Adapter::NetHTTP do
-
-  subject(:adapter) { :net_http }
-
-  context "http requests" do
-    before :all do
-      @server = IntegrationServer.run
-    end
-
-    after :all do
-      @server.stop
-    end
-
-    context "when socks is specified" do
-      let(:socks_client) { mock("socks_client") }
-      let(:request) { HTTPI::Request.new(@server.url) }
-
-      it "uses Net::HTTP.SOCKSProxy as client" do
-        socks_client.expects(:new).with(URI(@server.url).host, URI(@server.url).port).returns(:socks_client_instance)
-        Net::HTTP.expects(:SOCKSProxy).with("localhost", 8080).returns socks_client
-
-        request.proxy = "socks://localhost:8080"
-        adapter = HTTPI::Adapter::NetHTTP.new(request)
-
-        expect(adapter.client).to eq(:socks_client_instance)
-      end
-    end
-
-    it "sends and receives HTTP headers" do
-      request = HTTPI::Request.new(@server.url + "x-header")
-      request.headers["X-Header"] = "HTTPI"
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to include("HTTPI")
-    end
-
-    it "it supports headers with multiple values" do
-      request = HTTPI::Request.new(@server.url + "cookies")
-
-      response = HTTPI.get(request, adapter)
-      cookies = ["cookie1=chip1; path=/", "cookie2=chip2; path=/"]
-      expect(response.headers["Set-Cookie"]).to eq(cookies)
-    end
-
-    it "it supports read timeout" do
-      require "net/http"
-
-      request = HTTPI::Request.new(@server.url + "timeout")
-      request.read_timeout = 0.5 # seconds
-
-      expect do
-        HTTPI.get(request, adapter)
-      end.to raise_exception(Net::ReadTimeout)
-    end
-
-    it "executes GET requests" do
-      response = HTTPI.get(@server.url, adapter)
-      expect(response.body).to eq("get")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes POST requests" do
-      response = HTTPI.post(@server.url, "<some>xml</some>", adapter)
-      expect(response.body).to eq("post")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes HEAD requests" do
-      response = HTTPI.head(@server.url, adapter)
-      expect(response.code).to eq(200)
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes PUT requests" do
-      response = HTTPI.put(@server.url, "<some>xml</some>", adapter)
-      expect(response.body).to eq("put")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    it "executes DELETE requests" do
-      response = HTTPI.delete(@server.url, adapter)
-      expect(response.body).to eq("delete")
-      expect(response.headers["Content-Type"]).to eq("text/plain")
-    end
-
-    context "custom methods" do
-      let(:request) {
-        HTTPI::Request.new(@server.url).tap do |r|
-          r.body = request_body if request_body
-        end
-      }
-      let(:request_body) { nil }
-
-      subject(:response) { HTTPI.request(http_method, request, adapter) }
-
-      shared_examples_for "any supported custom method" do
-        describe '#body' do
-          subject(:body) {response.body}
-          it { is_expected.to be == http_method.to_s }
-        end
-
-        describe '#headers' do
-          subject(:headers) {response.headers}
-          it { is_expected.to include('content-type' => "text/plain")}
-        end
-      end
-
-      context "PATCH method" do
-        let(:http_method) { :patch }
-        let(:request_body) { "<some>xml</some>" }
-
-        it_behaves_like "any supported custom method"
-      end
-
-      context "UNSUPPORTED method" do
-        let(:http_method) { :unsupported }
-
-        specify { expect { response }.to raise_error HTTPI::NotSupportedError }
-      end
-    end
-
-    it "supports basic authentication" do
-      request = HTTPI::Request.new(@server.url + "basic-auth")
-      request.auth.basic("admin", "secret")
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to eq("basic-auth")
-    end
-
-    it "does not support digest authentication" do
-      request = HTTPI::Request.new(@server.url + "digest-auth")
-      request.auth.digest("admin", "secret")
-
-      expect { HTTPI.get(request, adapter) }.
-        to raise_error(HTTPI::NotSupportedError, /does not support HTTP digest authentication/)
-    end
-
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "supports ntlm authentication" do
-      request = HTTPI::Request.new(@server.url + "ntlm-auth")
-      request.auth.ntlm("tester", "vReqSoafRe5O")
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to eq("ntlm-auth")
-    end
-
-    it "does not support ntlm authentication when Net::NTLM is not available" do
-      Net.expects(:const_defined?).with(:NTLM).returns false
-
-      request = HTTPI::Request.new(@server.url + "ntlm-auth")
-      request.auth.ntlm("testing", "failures")
-
-      expect { HTTPI.get(request, adapter) }.
-        to raise_error(HTTPI::NotSupportedError, /Net::NTLM is not available/)
-    end
-
-    it "does not require ntlm when ntlm authenication is not requested" do
-      HTTPI::Adapter::NetHTTP.any_instance.stubs(:check_net_ntlm_version!).raises(RuntimeError)
-        request = HTTPI::Request.new(@server.url)
-        expect(request.auth.ntlm?).to be false
-
-        # make sure a request doesn't call ntlm check if we don't ask for it.
-        expect { HTTPI.get(request, adapter) }.not_to raise_error
-      HTTPI::Adapter::NetHTTP.any_instance.unstub(:check_net_ntlm_version!)
-    end
-
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does check ntlm when ntlm authentication is requested" do
-      request = HTTPI::Request.new(@server.url + "ntlm-auth")
-      request.auth.ntlm("tester", "vReqSoafRe5O")
-
-      expect { HTTPI.get(request, adapter) }.not_to raise_error
-
-      # the check should also verify that the version of ntlm is supported and still fail if it isn't
-      HTTPI::Adapter::NetHTTP.any_instance.stubs(:ntlm_version).returns("0.1.1")
-
-        request = HTTPI::Request.new(@server.url + "ntlm-auth")
-        request.auth.ntlm("tester", "vReqSoafRe5O")
-
-        expect { HTTPI.get(request, adapter) }.to raise_error(ArgumentError, /Invalid version/)
-
-      HTTPI::Adapter::NetHTTP.any_instance.unstub(:ntlm_version)
-    end
-
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does not crash when authenticate header is missing (on second request)" do
-      request = HTTPI::Request.new(@server.url + "ntlm-auth")
-      request.auth.ntlm("tester", "vReqSoafRe5O")
-
-      expect { HTTPI.get(request, adapter) }.
-        to_not raise_error
-
-      expect { HTTPI.get(request, adapter) }.
-        to_not raise_error
-    end
-
-    it "supports chunked response" do
-      request = HTTPI::Request.new(@server.url)
-      res = ""
-      request.on_body do |body|
-        res += body
-      end
-      response = HTTPI.post(request, adapter)
-      expect(res).to eq("post")
-      expect(response.body.to_s).to eq("")
-    end
-  end
-
-  if RUBY_PLATFORM =~ /java/
-    pending "Puma Server complains: SSL not supported on JRuby"
-  else
-    context "https requests" do
-      before :all do
-        @server = IntegrationServer.run(:ssl => true)
-      end
-      after :all do
-        @server.stop
-      end
-
-      # does not raise when no certificate was set up
-      it "works when set up properly" do
-        request = HTTPI::Request.new(@server.url)
-        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-
-        response = HTTPI.get(request, adapter)
-        expect(response.body).to eq("get")
-      end
-
-      it "works with min_version/max_version" do
-        request = HTTPI::Request.new(@server.url)
-        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-        request.auth.ssl.min_version = :TLS1_2
-        request.auth.ssl.max_version = :TLS1_2
-
-        response = HTTPI.get(request, adapter)
-        expect(response.body).to eq("get")
-      end
-
-      it "works with ciphers" do
-        request = HTTPI::Request.new(@server.url)
-        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-        request.auth.ssl.ciphers = OpenSSL::SSL::SSLContext.new.ciphers
-
-        response = HTTPI.get(request, adapter)
-        expect(response.body).to eq("get")
-      end
-    end
-  end
-
-  # The built-in Rack IntegrationServer and specs support a basic simulated NTLM exchange
-  # that does not require anything outside of the normal gem test infrastructure.
-  #   (see spec/httpi/adapter/net_http_spec.rb: it "supports ntlm authentication"
-  #    and spec/integration/support/application.rb: map "/ntlm-auth")
-  # But since that simulated exchange is based on recorded traffic, you may wish to
-  # run the following integration test against a real external NTLM server from time to time.
-  #
-  # This test must be specially enabled because it requires an external
-  # Windows 2012 Server configured according to the instructions found here:
-  #   https://github.com/savonrb/httpi/wiki/NTLM-Integration-Test-Plan
-  #
-  # Once you have that server running as instructed, you can include this test by setting
-  # NTLM=external via the command line, e.g.:
-  #   $ NTLM=external bundle exec rspec
-  #
-  if ENV["NTLM"]=="external"
-    context "http request via NTLM" do
-      it "works with NTLM connections" do
-        user = "tester"
-        pass = "vReqSoafRe5O"
-        request = HTTPI::Request.new("http://ntlmtest/")
-        request.auth.ntlm(user,pass)
-        response = HTTPI.get(request, adapter)
-        expect(response.code).to eq(200)
-        expect(response.body).to match(/iis-8\.png/)
-
-        puts "EXTERNAL NTLM INTEGRATION TEST, response body:"
-        puts response.body
-      end
-    end
-  end
-
-end

data/spec/integration/support/application.rb

@@ -1,97 +0,0 @@
-require 'rack'
-require "rack/builder"
-
-class IntegrationServer
-
-  def self.respond_with(body)
-    [200, { "Content-Type" => "text/plain", "Content-Length" => body.size.to_s }, [body]]
-  end
-
-  Application = Rack::Builder.new do
-
-    map "/" do
-      run lambda { |env|
-        IntegrationServer.respond_with env["REQUEST_METHOD"].downcase
-      }
-    end
-
-    map "/timeout" do
-      run lambda { |env|
-        sleep 2
-        IntegrationServer.respond_with "done"
-      }
-    end
-
-    map "/x-header" do
-      run lambda { |env|
-        IntegrationServer.respond_with env["HTTP_X_HEADER"]
-      }
-    end
-
-    map "/cookies" do
-      run lambda { |env|
-        status, headers, body = IntegrationServer.respond_with("Many Cookies")
-        response = Rack::Response.new(body, status, headers)
-
-        response.set_cookie("cookie1", {:value => "chip1", :path => "/"})
-        response.set_cookie("cookie2", {:value => "chip2", :path => "/"})
-        response.finish
-      }
-    end
-
-    map "/basic-auth" do
-      use Rack::Auth::Basic, "basic-realm" do |username, password|
-        username == "admin" && password == "secret"
-      end
-
-      run lambda { |env|
-        IntegrationServer.respond_with "basic-auth"
-      }
-    end
-
-    map "/ntlm-auth" do
-      run lambda { |env|
-        resp = [401, {"WWW-Authenticate" => "NTLM\r\nNegotiate"}, []]
-        # head request 1: challenge & response (from actual server)
-        if env["HTTP_AUTHORIZATION"] =~ /(NTLM|Negotiate) TlRMTVNTUAABAAAAB4IIAA/
-          resp = [401, {
-            "Content-Type" => "text/html; charset=us-ascii",
-            "Server" => "Microsoft-HTTPAPI/2.0",
-            "WWW-Authenticate" => "#{$1} TlRMTVNTUAACAAAAEAAQADgAAAAFgooCj/AvDazHhQsAAAAAAAAAAGAAYABIAAAABgLwIwAAAA9OAFQATABNAFQARQBTAFQAAgAQAE4AVABMAE0AVABFAFMAVAABABAATgBUAEwATQBUAEUAUwBUAAQAEABuAHQAbABtAHQAZQBzAHQAAwAQAG4AdABsAG0AdABlAHMAdAAHAAgAfzQp037nzQEAAAAA",
-            "Date" => "Mon, 31 Dec 2012 17:46:55 GMT",
-            "Content-Length" => "341"
-            }, []]
-        elsif env["HTTP_AUTHORIZATION"] =~ /(NTLM|Negotiate) (.+)/
-          # request 2: serve content
-          resp = IntegrationServer.respond_with "ntlm-auth"
-        else 
-          resp = [401, {
-            "Content-Type" => "text/html; charset=us-ascii",
-            "WWW-Authenticate" => "NTLM\r\nNegotiate",
-            "Server" => "Microsoft-HTTPAPI/2.0",
-            "Date" => "Mon, 31 Dec 2012 17:46:55 GMT",
-            "Content-Length" => "341"
-            }, []]
-        end
-        resp
-      }
-    end
-
-    map "/digest-auth" do
-      unprotected_app = lambda { |env|
-        IntegrationServer.respond_with "digest-auth"
-      }
-
-      realm = 'digest-realm'
-      app = Rack::Auth::Digest::MD5.new(unprotected_app) do |username|
-        username == 'admin' ? Digest::MD5.hexdigest("admin:#{realm}:secret") : nil
-      end
-      app.realm = realm
-      app.opaque = 'this-should-be-secret'
-      app.passwords_hashed = true
-
-      run app
-    end
-
-  end
-end

data/spec/integration/support/server.rb

@@ -1,83 +0,0 @@
-require "puma"
-require "puma/minissl"
-
-require "integration/support/application"
-
-class IntegrationServer
-  def self.run(options = {})
-    server = new(options)
-    server.run
-    server
-  end
-
-  def self.ssl_ca_file;   integration_fixture("ca_all.pem")  end
-  def self.ssl_key_file;  integration_fixture("server.key")  end
-  def self.ssl_cert_file; integration_fixture("server.cert") end
-
-  def self.integration_fixture(file)
-    file = File.expand_path("../../fixtures/#{file}", __FILE__)
-    raise "No such file '#{file}'" unless File.exist? file
-    file
-  end
-
-  def initialize(options = {})
-    @app  = Application
-    @host = options.fetch(:host, "localhost")
-    @port = options.fetch(:port, 17172)
-    @ssl  = options.fetch(:ssl, false)
-
-    @server = Puma::Server.new(app, events)
-
-    if ssl?
-      add_ssl_listener
-    else
-      add_tcp_listener
-    end
-  end
-
-  attr_reader :app, :host, :port, :server
-
-  def url(path = nil)
-    protocol = ssl? ? "https" : "http"
-    File.join "#{protocol}://#{host}:#{port}/", path.to_s
-  end
-
-  def ssl?
-    @ssl
-  end
-
-  def run
-    server.run
-  end
-
-  def stop
-    server.stop(true)
-  end
-
-  private
-
-  def events
-    Puma::Events.new($stdout, $stderr)
-  end
-
-  def add_tcp_listener
-    server.add_tcp_listener(host, port)
-  rescue Errno::EADDRINUSE
-    raise "Panther is already running at #{url}"
-  end
-
-  def add_ssl_listener
-    server.add_ssl_listener(host, port, ssl_context)
-  end
-
-  def ssl_context
-    context = Puma::MiniSSL::Context.new
-
-    context.key         = IntegrationServer.ssl_key_file
-    context.cert        = IntegrationServer.ssl_cert_file
-    context.verify_mode = Puma::MiniSSL::VERIFY_NONE
-
-    context
-  end
-
-end

data/spec/spec_helper.rb

@@ -1,23 +0,0 @@
-require 'bundler'
-Bundler.setup(:default, :development)
-
-unless RUBY_PLATFORM =~ /java/
-  require 'simplecov'
-
-  SimpleCov.start do
-    add_filter 'spec'
-  end
-end
-
-require 'httpi'
-require 'rspec'
-
-RSpec.configure do |config|
-  config.mock_with :mocha
-  config.order = 'random'
-end
-
-HTTPI.log = false
-
-require 'support/fixture'
-require 'support/matchers'

data/spec/support/error_helper.rb

@@ -1,26 +0,0 @@
-module ErrorHelper
-
-  class Expectation
-
-    def initialize(error, spec)
-      @error = error
-      @spec = spec
-    end
-
-    def to(tag_error)
-      @spec.expect(@error).to @spec.be_a(tag_error)
-    end
-
-  end
-
-  def expect_error(error_to_raise, message)
-    fake_error(error_to_raise, message)
-  rescue => error
-    Expectation.new(error, self)
-  end
-
-  def be_tagged_with(tag_error)
-    tag_error
-  end
-
-end