httpi 3.0.2 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd06f829b3d33418dfe3ef465949f504f6acde0e9f5988edea9615e700bb8f23
-  data.tar.gz: '00197cf31c50d34768c76325d42cc8dc325774ffe5a2ecaf6feb33f7d22c382c'
+  metadata.gz: bb83de56d8f0e1b609e317db0a889b669290c6888b2ef4a41efe682bcd092ec3
+  data.tar.gz: a2ec713acb8c51714850de1490c2b247d10fdd0ada7227fbd89ec4cdfb3c7963
 SHA512:
-  metadata.gz: 81a2a86d8a7784711c0a72995a21262c7bcdfb17d9127a06a9573c50f7eaffde7e544c07b332e905da3fb1b177d867d34c2b59a75f0605182a6d278db9eda4a6
-  data.tar.gz: e59a0468efe743db6a4b4d7eff007714cb739e928396b7ff8797896a346e7808a2635185ccf1a9eb53db64d149626782a4f3dc530f3e9644c21923ce6a4a0f3d
+  metadata.gz: bd35a2d65bc74884715d763c2790aa0567355c84337f17459fc6d0956b2f019fc6c82dba220bd3fd707b1e1837dcf6b264395ef109251196211d700b76e9f66e
+  data.tar.gz: f965bcc58b97d692f295408058bbf2ee3cf70d7b19221cc892aa4bdd250aa177bedc1303efc172c1e953ec7c44327cb026ca044fbf32144b4bb1bf1c435ebb17

data/.github/workflows/development.yml

@@ -34,7 +34,7 @@ jobs:
             experimental: true
     
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     
     - name: Install dependencies
       run: sudo apt-get install libcurl4-openssl-dev

data/CHANGELOG.md

@@ -1,10 +1,27 @@
 ### Unreleased
 
-* Improvement: [#237](https://github.com/savonrb/httpi/pull/237) Implemented `adapter_client_setup`.
+* Add your changelog entry here
+
+### 4.0.2 (2024-06-13)
+
+* Don't change http header casing by @pcai in https://github.com/savonrb/httpi/pull/249
+
+### 4.0.1 (2024-02-16)
+
+HTTPI is officially in maintenance mode. Our emphasis will now be on bugs, security fixes, and compatibility with the wider ecosystem. See [this issue](https://github.com/savonrb/httpi/issues/238) for details.
+
+* Adds support for rack 3.0.
+* POTENTIAL BREAKING CHANGE: `HTTPI::Request#headers` and `HTTPI::Response#headers` now return `HTTPI::Utils::Headers` instead of `Rack::Utils::HeaderHash`. This change will prevent HTTPI from breaking or changing its public API whenever rack rearranges its classes. If you were relying on the `Rack::Utils::HeaderHash` implementation, you will need to update your code to use `HTTPI::Utils::Headers` instead.
+
+### 4.0.0 (yanked)
+
+Yanked due to a bug when used with rack 2.
 
 ### 3.0.2 (2024-02-10)
 
+* Improvement: [#237](https://github.com/savonrb/httpi/pull/237) Implemented `adapter_client_setup`.
 * Add support for ruby 3.1, 3.2, 3.3. Drop support for ruby 2.7 and below.
+* Pin to rack version < 3, HTTPI is not tested with rack 3 yet.
 
 ### 3.0.1 (2021-12-17)
 

data/Gemfile

@@ -15,7 +15,7 @@ gem 'net-http-persistent', '~> 4.0',    :require => false
 gem 'http',                             :require => false
 
 # adapter extensions
-gem 'rack', '< 3'
+gem 'rack'
 gem 'socksify'
 
 # coverage

data/README.md

@@ -1,6 +1,6 @@
 # HTTPI
 
-A common interface for Ruby's HTTP libraries.
+A common interface for Ruby's HTTP libraries. This project is now in maintenance mode. For new projects, we recommend [faraday](https://github.com/lostisland/faraday).
 
 [Documentation](https://www.rubydoc.info/gems/httpi)
 
@@ -14,7 +14,7 @@ HTTPI is available through [Rubygems](https://rubygems.org/gems/httpi) and can b
 
 or add it to your Gemfile like this:
 
-    gem 'httpi', '~> 3.0.0'
+    gem 'httpi', '~> 4.0.0'
 
 ## Usage example
 
@@ -36,6 +36,17 @@ HTTPI.adapter = :httpclient
 
 # and execute arbitary requests
 HTTPI.request(:custom, request)
+
+# add a client setup block that will be called before each request
+HTTPI.adapter = :httpclient
+HTTPI.adapter_client_setup = proc do |x|
+  x.ssl_config.set_default_paths
+  x.force_basic_auth = true
+end
+# ...
+HTTPI.get(request) do |x|
+  x.force_basic_auth = false
+end
 ```
 
 ### SOCKS Proxy Support

data/UPDATING.md

@@ -5,3 +5,7 @@
 BREAKING CHANGE: the [#255](https://github.com/savonrb/httpi/pull/225) made the gem socksify and rack gems optional dependencies.
 
 In order to restore the old behavior, see the README section "SOCKS Proxy Support" and "Rack Mock Adapter".
+
+## From 3.x to 4.x
+
+POTENTIAL BREAKING CHANGE: `HTTPI::Request#headers` and `HTTPI::Response#headers` now return `HTTPI::Utils::Headers` instead of `Rack::Utils::HeaderHash`. This change will prevent HTTPI from breaking or changing its public API whenever rack rearranges its classes. If you were relying on the `Rack::Utils::HeaderHash` implementation, you will need to update your code to use `HTTPI::Utils::Headers` instead.

data/httpi.gemspec

@@ -21,16 +21,16 @@ Gem::Specification.new do |s|
 
   s.license = 'MIT'
 
-  s.add_dependency 'rack', '< 3'
+  s.add_dependency 'rack', '>= 2.0', '< 3.1'
   s.add_dependency 'nkf'
   s.add_dependency 'base64'
   s.add_dependency 'mutex_m'
 
-  s.add_development_dependency 'rubyntlm', '~> 0.3.2'
+  s.add_development_dependency 'rubyntlm', '~> 0.6.4'
   s.add_development_dependency 'rake',     '~> 13.0'
   s.add_development_dependency 'rspec',    '~> 3.5'
   s.add_development_dependency 'mocha',    '~> 0.13'
-  s.add_development_dependency 'puma',     '~> 5.0'
+  s.add_development_dependency 'puma',     '~> 6.0'
   s.add_development_dependency 'webmock'
 
   s.metadata["rubygems_mfa_required"] = "true"

data/lib/httpi/request.rb

@@ -64,12 +64,12 @@ module HTTPI
 
     # Returns a Hash of HTTP headers. Defaults to return an empty Hash.
     def headers
-      @headers ||= Rack::Utils::HeaderHash.new
+      @headers ||= HTTPI::Utils::Headers.new
     end
 
     # Sets the Hash of HTTP headers.
     def headers=(headers)
-      @headers = Rack::Utils::HeaderHash.new(headers)
+      @headers = HTTPI::Utils::Headers.new.merge(headers)
     end
 
     # Adds a header information to accept gzipped content.

data/lib/httpi/response.rb

@@ -20,7 +20,7 @@ module HTTPI
     # Initializer expects an HTTP response +code+, +headers+ and +body+.
     def initialize(code, headers, body)
       self.code = code.to_i
-      self.headers = Rack::Utils::HeaderHash.new(headers)
+      self.headers = HTTPI::Utils::Headers.new.merge(headers)
       self.raw_body = body
     end
 

data/lib/httpi/utils.rb

@@ -0,0 +1,95 @@
+# mostly verbatim from: https://github.com/rack/rack/blob/main/lib/rack/headers.rb
+# Because this is part of httpi's public API, its better not to load an external 
+# library for it. 
+module HTTPI
+  module Utils
+    # A case-insensitive Hash that preserves the original case of a
+    # header when set.
+    #
+    class Headers < Hash
+      def self.[](headers)
+        if headers.is_a?(Headers) && !headers.frozen?
+          return headers
+        else
+          return self.new(headers)
+        end
+      end
+
+      def initialize(hash = {})
+        super()
+        @names = {}
+        hash.each { |k, v| self[k] = v }
+      end
+
+      # on dup/clone, we need to duplicate @names hash
+      def initialize_copy(other)
+        super
+        @names = other.names.dup
+      end
+
+      # on clear, we need to clear @names hash
+      def clear
+        super
+        @names.clear
+      end
+
+      def each
+        super do |k, v|
+          yield(k, v.respond_to?(:to_ary) ? v.to_ary.join("\n") : v)
+        end
+      end
+
+      def to_hash
+        hash = {}
+        each { |k, v| hash[k] = v }
+        hash
+      end
+
+      def [](k)
+        super(k) || super(@names[k.downcase])
+      end
+
+      def []=(k, v)
+        canonical = k.downcase.freeze
+        delete k if @names[canonical] && @names[canonical] != k # .delete is expensive, don't invoke it unless necessary
+        @names[canonical] = k
+        super k, v
+      end
+
+      def delete(k)
+        canonical = k.downcase
+        result = super @names.delete(canonical)
+        result
+      end
+
+      def include?(k)
+        super || @names.include?(k.downcase)
+      end
+
+      alias_method :has_key?, :include?
+      alias_method :member?, :include?
+      alias_method :key?, :include?
+
+      def merge!(other)
+        other.each { |k, v| self[k] = v }
+        self
+      end
+
+      def merge(other)
+        hash = dup
+        hash.merge! other
+      end
+
+      def replace(other)
+        clear
+        other.each { |k, v| self[k] = v }
+        self
+      end
+
+      protected
+        def names
+          @names
+        end
+    end
+  end
+end

data/lib/httpi/version.rb

@@ -1,3 +1,3 @@
 module HTTPI
-  VERSION = '3.0.2'
+  VERSION = '4.0.2'
 end

data/lib/httpi.rb

@@ -3,6 +3,7 @@ require "httpi/version"
 require "httpi/logger"
 require "httpi/request"
 require "httpi/query_builder"
+require "httpi/utils"
 
 require "httpi/adapter/httpclient"
 require "httpi/adapter/curb"

data/spec/httpi/adapter/httpclient_spec.rb

@@ -215,8 +215,7 @@ describe HTTPI::Adapter::HTTPClient do
     end
   end
 
-  # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-  xit "supports NTLM authentication" do
+  it "supports NTLM authentication" do
     request = HTTPI::Request.new(@server.url + "ntlm-auth")
 
     request.auth.ntlm("tester", "vReqSoafRe5O")

data/spec/httpi/request_spec.rb

@@ -92,11 +92,11 @@ describe HTTPI::Request do
         after { HTTPI.query_builder = :flat }
 
         it "lets you specify query parameter as Hash" do
-          expect(request.url.to_s).to eq("http://example.com?q[]=nested&q[]=query")
+          expect(request.url.to_s).to eq("http://example.com?q%5B%5D=nested&q%5B%5D=query")
         end
 
         it "getter return String for query parameter as Hash" do
-          expect(request.query).to eq("q[]=nested&q[]=query")
+          expect(request.query).to eq("q%5B%5D=nested&q%5B%5D=query")
         end
       end
     end
@@ -149,7 +149,7 @@ describe HTTPI::Request do
   describe "#headers" do
     it "lets you specify a Hash of HTTP request headers" do
       request.headers = { "Accept-Encoding" => "gzip" }
-      expect(request.headers).to eq({ "Accept-Encoding" => "gzip" })
+      expect(request.headers).to eq HTTPI::Utils::Headers.new.merge({ "Accept-Encoding" => "gzip" })
     end
 
     it "defaults to return an empty Hash" do
@@ -235,7 +235,7 @@ describe HTTPI::Request do
         end
         it "request body using a Hash with Array" do
           request.body = {:foo => :bar, :baz => [:foo, :tst]}
-          expect(request.body.split("&")).to match_array(["foo=bar", "baz[]=foo", "baz[]=tst"])
+          expect(request.body.split("&")).to match_array(["foo=bar", "baz%5B%5D=foo", "baz%5B%5D=tst"])
         end
       end
     end

data/spec/httpi/response_spec.rb

@@ -88,7 +88,7 @@ describe HTTPI::Response do
 
     describe "#headers" do
       it "returns the HTTP response headers" do
-        expect(response.headers).to eq({ "Content-Encoding" => "gzip" })
+        expect(response.headers).to eq HTTPI::Utils::Headers.new.merge({ "Content-Encoding" => "gzip" })
       end
     end
 
@@ -116,7 +116,11 @@ describe HTTPI::Response do
 
     describe "#headers" do
       it "returns the HTTP response headers" do
-        expect(response.headers).to eq({ "Content-Type" => "application/dime" })
+        expect(response.headers).to eq HTTPI::Utils::Headers.new.merge({ "Content-Type" => "application/dime" })
+      end
+
+      it "preserves casing" do
+        expect(response.headers.keys).to eq ["Content-Type"]
       end
     end
 

data/spec/integration/net_http_spec.rb

@@ -138,8 +138,7 @@ describe HTTPI::Adapter::NetHTTP do
         to raise_error(HTTPI::NotSupportedError, /does not support HTTP digest authentication/)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "supports ntlm authentication" do
+    it "supports ntlm authentication" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")
 
@@ -167,8 +166,7 @@ describe HTTPI::Adapter::NetHTTP do
       HTTPI::Adapter::NetHTTP.any_instance.unstub(:check_net_ntlm_version!)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does check ntlm when ntlm authentication is requested" do
+    it "does check ntlm when ntlm authentication is requested" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")
 
@@ -185,8 +183,7 @@ describe HTTPI::Adapter::NetHTTP do
       HTTPI::Adapter::NetHTTP.any_instance.unstub(:ntlm_version)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does not crash when authenticate header is missing (on second request)" do
+    it "does not crash when authenticate header is missing (on second request)" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")
 

data/spec/integration/support/server.rb

@@ -57,7 +57,7 @@ class IntegrationServer
   private
 
   def events
-    Puma::Events.new($stdout, $stderr)
+    Puma::Events.new
   end
 
   def add_tcp_listener

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: httpi
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 4.0.2
 platform: ruby
 authors:
 - Daniel Harrington
@@ -9,22 +9,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-11 00:00:00.000000000 Z
+date: 2024-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: nkf
   requirement: !ruby/object:Gem::Requirement
@@ -73,14 +79,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.2
+        version: 0.6.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.2
+        version: 0.6.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -129,14 +135,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -188,6 +194,7 @@ files:
 - lib/httpi/query_builder.rb
 - lib/httpi/request.rb
 - lib/httpi/response.rb
+- lib/httpi/utils.rb
 - lib/httpi/version.rb
 - spec/fixtures/attachment.gif
 - spec/fixtures/client_cert.pem
@@ -255,7 +262,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.19
 signing_key: 
 specification_version: 4
 summary: Common interface for Ruby's HTTP libraries