httpi 2.0.2 → 2.1.0

data/spec/httpi/auth/config_spec.rb

@@ -132,4 +132,32 @@ describe HTTPI::Auth::Config do
     end
   end
 
+  describe "#ntlm" do
+    it "lets you specify the ntlm auth credentials" do
+      auth.ntlm "username", "password"
+      auth.ntlm.should == ["username", "password"]
+    end
+
+    it "also accepts an Array of credentials" do
+      auth.ntlm ["username", "password"]
+      auth.ntlm.should == ["username", "password"]
+    end
+
+    it "sets the authentication type to :ntlm" do
+      auth.ntlm "username", "password"
+      auth.type.should == :ntlm
+    end
+  end
+
+  describe "#ntlm?" do
+    it "defaults to return false" do
+      auth.should_not be_ntlm
+    end
+
+    it "returns true for HTTP ntlm auth" do
+      auth.ntlm "username", "password"
+      auth.should be_ntlm
+    end
+  end
+
 end

data/spec/httpi/httpi_spec.rb

@@ -1,6 +1,10 @@
 require "spec_helper"
+require "integration/support/server"
 
 # find out why httpi doesn't load these automatically. [dh, 2012-12-15]
+require "excon"
+require "net/http/persistent"
+
 unless RUBY_VERSION < "1.9"
   require "em-synchrony"
   require "em-http-request"
@@ -13,6 +17,15 @@ describe HTTPI do
   let(:client) { HTTPI }
   let(:httpclient) { HTTPI::Adapter.load(:httpclient) }
   let(:net_http) { HTTPI::Adapter.load(:net_http) }
+  let(:net_http_persistent) { HTTPI::Adapter.load(:net_http_persistent) }
+
+  before(:all) do
+    HTTPI::Adapter::Rack.mount('example.com', IntegrationServer::Application)
+  end
+
+  after(:all) do
+    HTTPI::Adapter::Rack.unmount('example.com')
+  end
 
   describe ".adapter=" do
     it "sets the default adapter to use" do
@@ -204,7 +217,10 @@ describe HTTPI do
             :httpclient => lambda { HTTPClient },
             :curb       => lambda { Curl::Easy },
             :net_http   => lambda { Net::HTTP },
-            :em_http    => lambda { EventMachine::HttpConnection }
+            :net_http_persistent => lambda { Net::HTTP::Persistent },
+            :em_http    => lambda { EventMachine::HttpConnection },
+            :rack       => lambda { Rack::MockRequest },
+            :excon      => lambda { Excon::Connection }
           }
 
           context "using #{adapter}" do

data/spec/integration/curb_spec.rb

@@ -78,6 +78,18 @@ describe HTTPI::Adapter::Curb do
         response = HTTPI.get(request, adapter)
         response.body.should eq("digest-auth")
       end
+
+      it "supports chunked response" do
+        request = HTTPI::Request.new(@server.url)
+        res = ""
+        request.on_body do |body|
+          res += body
+        end
+        response = HTTPI.post(request, adapter)
+        res.should eq("post")
+        response.body.should eq("")
+      end
+
     end
 
     context "https requests" do

data/spec/integration/em_http_spec.rb

@@ -81,6 +81,8 @@ describe HTTPI::Adapter::EmHttpRequest do
       end
 
       # it does not support digest authentication
+
+      # it does not support chunked response
     end
 
     # it does not support ssl authentication

data/spec/integration/httpclient_spec.rb

@@ -75,27 +75,41 @@ describe HTTPI::Adapter::HTTPClient do
       response = HTTPI.get(request, adapter)
       response.body.should eq("digest-auth")
     end
-  end
-
-  context "https requests" do
-    before :all do
-      @server = IntegrationServer.run(:ssl => true)
-    end
 
-    after :all do
-      @server.stop
-    end
-
-    it "raises when no certificate was set up" do
-      expect { HTTPI.post(@server.url, "", adapter) }.to raise_error(HTTPI::SSLError)
-    end
-
-    it "works when set up properly" do
+    it "supports chunked response" do
       request = HTTPI::Request.new(@server.url)
-      request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
+      res = ""
+      request.on_body do |body|
+        res += body
+      end
+      response = HTTPI.post(request, adapter)
+      res.should eq("post")
+      response.body.should eq("")
+    end
+  end
 
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to eq("get")
+  if RUBY_PLATFORM =~ /java/
+    pending "Puma Server complains: SSL not supported on JRuby"
+  else
+    context "https requests" do
+      before :all do
+        @server = IntegrationServer.run(:ssl => true)
+      end
+      after :all do
+        @server.stop
+      end
+
+      it "raises when no certificate was set up" do
+        expect { HTTPI.post(@server.url, "", adapter) }.to raise_error(HTTPI::SSLError)
+      end
+
+      it "works when set up properly" do
+        request = HTTPI::Request.new(@server.url)
+        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
+
+        response = HTTPI.get(request, adapter)
+        expect(response.body).to eq("get")
+      end
     end
   end
 

data/spec/integration/net_http_persistent_spec.rb

@@ -0,0 +1,139 @@
+require "spec_helper"
+require "integration/support/server"
+
+describe HTTPI::Adapter::NetHTTP do
+
+  subject(:adapter) { :net_http_persistent }
+
+  context "http requests" do
+    before :all do
+      @server = IntegrationServer.run
+    end
+
+    after :all do
+      @server.stop
+    end
+
+    it "sends and receives HTTP headers" do
+      request = HTTPI::Request.new(@server.url + "x-header")
+      request.headers["X-Header"] = "HTTPI"
+
+      response = HTTPI.get(request, adapter)
+      response.body.should include("HTTPI")
+    end
+
+    it "it supports headers with multiple values" do
+      request = HTTPI::Request.new(@server.url + "cookies")
+
+      response = HTTPI.get(request, adapter)
+      cookies = ["cookie1=chip1; path=/", "cookie2=chip2; path=/"]
+      response.headers["Set-Cookie"].should eq(cookies)
+    end
+
+    it "executes GET requests" do
+      response = HTTPI.get(@server.url, adapter)
+      response.body.should eq("get")
+      response.headers["Content-Type"].should eq("text/plain")
+    end
+
+    it "executes POST requests" do
+      response = HTTPI.post(@server.url, "<some>xml</some>", adapter)
+      response.body.should eq("post")
+      response.headers["Content-Type"].should eq("text/plain")
+    end
+
+    it "executes HEAD requests" do
+      response = HTTPI.head(@server.url, adapter)
+      response.code.should == 200
+      response.headers["Content-Type"].should eq("text/plain")
+    end
+
+    it "executes PUT requests" do
+      response = HTTPI.put(@server.url, "<some>xml</some>", adapter)
+      response.body.should eq("put")
+      response.headers["Content-Type"].should eq("text/plain")
+    end
+
+    it "executes DELETE requests" do
+      response = HTTPI.delete(@server.url, adapter)
+      response.body.should eq("delete")
+      response.headers["Content-Type"].should eq("text/plain")
+    end
+
+    it "supports basic authentication" do
+      request = HTTPI::Request.new(@server.url + "basic-auth")
+      request.auth.basic("admin", "secret")
+
+      response = HTTPI.get(request, adapter)
+      response.body.should eq("basic-auth")
+    end
+
+    # it does not support digest authentication
+
+    it "supports chunked response" do
+      request = HTTPI::Request.new(@server.url)
+      res = ""
+      request.on_body do |body|
+        res += body
+      end
+      response = HTTPI.post(request, adapter)
+      res.should eq("post")
+      response.body.to_s.should eq("")
+    end
+  end
+
+  if RUBY_PLATFORM =~ /java/
+    pending "Puma Server complains: SSL not supported on JRuby"
+  else
+    context "https requests" do
+      before :all do
+        @server = IntegrationServer.run(:ssl => true)
+      end
+      after :all do
+        @server.stop
+      end
+
+      # does not raise when no certificate was set up
+      it "works when set up properly" do
+        request = HTTPI::Request.new(@server.url)
+        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
+
+        response = HTTPI.get(request, adapter)
+        expect(response.body).to eq("get")
+      end
+    end
+  end
+
+  # The built-in Rack IntegrationServer and specs support a basic simulated NTLM exchange
+  # that does not require anything outside of the normal gem test infrastructure.
+  #   (see spec/httpi/adapter/net_http_spec.rb: it "supports ntlm authentication"
+  #    and spec/integration/support/application.rb: map "/ntlm-auth")
+  # But since that simulated exchange is based on recorded traffic, you may wish to
+  # run the following integration test against a real external NTLM server from time to time.
+  #
+  # This test must be specially enabled because it requires an external
+  # Windows 2012 Server configured according to the instructions found here:
+  #   https://github.com/savonrb/httpi/wiki/NTLM-Integration-Test-Plan
+  #
+  # Once you have that server running as instructed, you can include this test by setting
+  # NTLM=external via the command line, e.g.:
+  #   $ NTLM=external bundle exec rspec
+  #
+  if ENV["NTLM"]=="external"
+    context "http request via NTLM" do
+      it "works with NTLM connections" do
+        user = "tester"
+        pass = "vReqSoafRe5O"
+        request = HTTPI::Request.new("http://ntlmtest/")
+        request.auth.ntlm(user,pass)
+        response = HTTPI.get(request, adapter)
+        expect(response.code).to eq(200)
+        response.body.should match(/iis-8\.png/)
+
+        puts "EXTERNAL NTLM INTEGRATION TEST, response body:"
+        puts response.body
+      end
+    end
+  end
+
+end

data/spec/integration/net_http_spec.rb

@@ -69,25 +69,70 @@ describe HTTPI::Adapter::NetHTTP do
     end
 
     # it does not support digest authentication
-  end
 
-  context "https requests" do
-    before :all do
-      @server = IntegrationServer.run(:ssl => true)
+    it "supports chunked response" do
+      request = HTTPI::Request.new(@server.url)
+      res = ""
+      request.on_body do |body|
+        res += body
+      end
+      response = HTTPI.post(request, adapter)
+      res.should eq("post")
+      response.body.to_s.should eq("")
     end
+  end
 
-    after :all do
-      @server.stop
+  if RUBY_PLATFORM =~ /java/
+    pending "Puma Server complains: SSL not supported on JRuby"
+  else
+    context "https requests" do
+      before :all do
+        @server = IntegrationServer.run(:ssl => true)
+      end
+      after :all do
+        @server.stop
+      end
+
+      # does not raise when no certificate was set up
+      it "works when set up properly" do
+        request = HTTPI::Request.new(@server.url)
+        request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
+
+        response = HTTPI.get(request, adapter)
+        expect(response.body).to eq("get")
+      end
     end
+  end
 
-    # does not raise when no certificate was set up
-
-    it "works when set up properly" do
-      request = HTTPI::Request.new(@server.url)
-      request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file
-
-      response = HTTPI.get(request, adapter)
-      expect(response.body).to eq("get")
+  # The built-in Rack IntegrationServer and specs support a basic simulated NTLM exchange
+  # that does not require anything outside of the normal gem test infrastructure.
+  #   (see spec/httpi/adapter/net_http_spec.rb: it "supports ntlm authentication"
+  #    and spec/integration/support/application.rb: map "/ntlm-auth")
+  # But since that simulated exchange is based on recorded traffic, you may wish to
+  # run the following integration test against a real external NTLM server from time to time.
+  #
+  # This test must be specially enabled because it requires an external
+  # Windows 2012 Server configured according to the instructions found here:
+  #   https://github.com/savonrb/httpi/wiki/NTLM-Integration-Test-Plan
+  #
+  # Once you have that server running as instructed, you can include this test by setting
+  # NTLM=external via the command line, e.g.:
+  #   $ NTLM=external bundle exec rspec
+  #
+  if ENV["NTLM"]=="external"
+    context "http request via NTLM" do
+      it "works with NTLM connections" do
+        user = "tester"
+        pass = "vReqSoafRe5O"
+        request = HTTPI::Request.new("http://ntlmtest/")
+        request.auth.ntlm(user,pass)
+        response = HTTPI.get(request, adapter)
+        expect(response.code).to eq(200)
+        response.body.should match(/iis-8\.png/)
+
+        puts "EXTERNAL NTLM INTEGRATION TEST, response body:"
+        puts response.body
+      end
     end
   end
 

data/spec/integration/support/application.rb

@@ -47,6 +47,34 @@ class IntegrationServer
       }
     end
 
+    map "/ntlm-auth" do
+      run lambda { |env|
+        resp = [401, {"WWW-Authenticate" => "NTLM\r\nNegotiate"}, []]
+        # head request 1: challenge & response (from actual server)
+        if env["HTTP_AUTHORIZATION"] =~ /(NTLM|Negotiate) TlRMTVNTUAABAAAAB4IIAA/
+          resp = [401, {
+            "Content-Type" => "text/html; charset=us-ascii",
+            "Server" => "Microsoft-HTTPAPI/2.0",
+            "WWW-Authenticate" => "#{$1} TlRMTVNTUAACAAAAEAAQADgAAAAFgooCj/AvDazHhQsAAAAAAAAAAGAAYABIAAAABgLwIwAAAA9OAFQATABNAFQARQBTAFQAAgAQAE4AVABMAE0AVABFAFMAVAABABAATgBUAEwATQBUAEUAUwBUAAQAEABuAHQAbABtAHQAZQBzAHQAAwAQAG4AdABsAG0AdABlAHMAdAAHAAgAfzQp037nzQEAAAAA",
+            "Date" => "Mon, 31 Dec 2012 17:46:55 GMT",
+            "Content-Length" => "341"
+            }, []]
+        elsif env["HTTP_AUTHORIZATION"] =~ /(NTLM|Negotiate) (.+)/
+          # request 2: serve content
+          resp = IntegrationServer.respond_with "ntlm-auth"
+        else 
+          resp = [401, {
+            "Content-Type" => "text/html; charset=us-ascii",
+            "WWW-Authenticate" => "NTLM\r\nNegotiate",
+            "Server" => "Microsoft-HTTPAPI/2.0",
+            "Date" => "Mon, 31 Dec 2012 17:46:55 GMT",
+            "Content-Length" => "341"
+            }, []]
+        end
+        resp
+      }
+    end
+
     map "/digest-auth" do
       unprotected_app = lambda { |env|
         IntegrationServer.respond_with "digest-auth"

data/spec/spec_helper.rb

@@ -1,16 +1,25 @@
-require "bundler"
+require 'bundler'
 Bundler.setup(:default, :development)
 
-require "httpi"
+unless RUBY_PLATFORM =~ /java/
+  require 'simplecov'
+  require 'coveralls'
 
-require "rspec"
-require "mocha/api"
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  SimpleCov.start do
+    add_filter 'spec'
+  end
+end
+
+require 'httpi'
+require 'rspec'
 
 RSpec.configure do |config|
   config.mock_with :mocha
+  config.order = 'random'
 end
 
 HTTPI.log = false
 
-require "support/fixture"
-require "support/matchers"
+require 'support/fixture'
+require 'support/matchers'