httpi 0.1.0 → 0.2.0

data/spec/httpi/request_spec.rb

@@ -0,0 +1,104 @@
+require "spec_helper"
+require "httpi/request"
+
+describe HTTPI::Request do
+  let(:request) { HTTPI::Request.new }
+
+  describe ".new" do
+    it "accepts a Hash of accessors to set" do
+      request = HTTPI::Request.new :url => "http://example.com", :open_timeout => 30
+      request.url.should == URI("http://example.com")
+      request.open_timeout.should == 30
+    end
+
+    it "accepts a Hash of authentication credentials to set" do
+      request = HTTPI::Request.new :basic_auth => ["username", "password"]
+      request.basic_auth.should == ["username", "password"]
+    end
+  end
+
+  describe "#url" do
+    it "lets you specify the URL to access as a String" do
+      request.url = "http://example.com"
+      request.url.should == URI("http://example.com")
+    end
+
+    it "also accepts a URI object" do
+      request.url = URI("http://example.com")
+      request.url.should == URI("http://example.com")
+    end
+
+    it "raises an ArgumentError in case the url does not seem to be valid" do
+      lambda { request.url = "invalid" }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe "#proxy" do
+    it "lets you specify the proxy URL to use as a String" do
+      request.proxy = "http://proxy.example.com"
+      request.proxy.should == URI("http://proxy.example.com")
+    end
+
+    it "also accepts a URI object" do
+      request.proxy = URI("http://proxy.example.com")
+      request.proxy.should == URI("http://proxy.example.com")
+    end
+
+    it "raises an ArgumentError in case the url does not seem to be valid" do
+      lambda { request.proxy = "invalid" }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe "#headers" do
+    it "lets you specify a Hash of HTTP request headers" do
+      request.headers = { "Accept-Encoding" => "gzip" }
+      request.headers.should == { "Accept-Encoding" => "gzip" }
+    end
+
+    it "defaults to return an empty Hash" do
+      request.headers.should == {}
+    end
+  end
+
+  describe "#body" do
+    it "lets you specify the HTTP request body" do
+      request.body = "<some>xml</some>"
+      request.body.should == "<some>xml</some>"
+    end
+  end
+
+  describe "#open_timeout" do
+    it "lets you specify the open timeout" do
+      request.open_timeout = 30
+      request.open_timeout.should == 30
+    end
+  end
+
+  describe "#read_timeout" do
+    it "lets you specify the read timeout" do
+      request.read_timeout = 45
+      request.read_timeout.should == 45
+    end
+  end
+
+  describe "#basic_auth" do
+    it "lets you specify the basic auth credentials" do
+      request.basic_auth "username", "password"
+      request.basic_auth.should == ["username", "password"]
+    end
+   
+    it "also accepts an Array of credentials" do
+      request.basic_auth ["username", "password"]
+      request.basic_auth.should == ["username", "password"]
+    end
+
+    it "lets you reset the credentials" do
+      request.basic_auth "username", "password"
+      request.basic_auth.should == ["username", "password"]
+
+      request.basic_auth nil
+      request.basic_auth.should be_nil
+    end
+ end
+
+end

data/spec/httpi/response_spec.rb

@@ -2,31 +2,29 @@ require "spec_helper"
 require "httpi/response"
 
 describe HTTPI::Response do
-  before do
-    @response = HTTPI::Response.new Some.response_code, Some.headers, Fixture.gzip
-  end
+  let(:response) { HTTPI::Response.new 200, { "Content-Encoding" => "gzip" }, Fixture.gzip }
 
   describe "#code" do
     it "should return the HTTP response code" do
-      @response.code.should == Some.response_code
+      response.code.should == 200
     end
   end
 
-  describe "#code" do
+  describe "#headers" do
     it "should return the HTTP response headers" do
-      @response.headers.should == Some.headers
+      response.headers.should == { "Content-Encoding" => "gzip" }
     end
   end
 
   describe "#body" do
     it "should return the (gzip decoded) HTTP response body" do
-      @response.body.should == "A short gzip encoded message\n"
+      response.body.should == Fixture.xml
     end
   end
 
   describe "#raw_body" do
     it "should return the raw HTML response body" do
-      @response.raw_body.should == Fixture.gzip
+      response.raw_body.should == Fixture.gzip
     end
   end
 

data/spec/spec_helper.rb

@@ -5,5 +5,5 @@ RSpec.configure do |config|
   config.mock_with :mocha
 end
 
-require "support/helper_methods"
+require "support/fixture"
 require "support/matchers"

data/spec/support/fixture.rb

@@ -0,0 +1,19 @@
+class Fixture
+  class << self
+
+    def xml
+      @xml ||= load :xml
+    end
+
+    def gzip
+      @gzip ||= load :xml, :gz
+    end
+
+  private
+
+    def load(fixture, type = :xml)
+      File.read File.expand_path("../../fixtures/#{fixture}.#{type}", __FILE__)
+    end
+
+  end
+end

data/spec/support/matchers.rb

@@ -1,8 +1,8 @@
 RSpec::Matchers.define :be_a_valid_httpi_response do
   match do |actual|
     actual.should be_an(HTTPI::Response)
-    actual.code.should == Some.response_code
-    actual.headers.should == Some.headers
+    actual.code.should == 200
+    actual.headers.should be_a(Hash)
     actual.body.should == Fixture.xml
   end
 end

metadata

@@ -1,21 +1,22 @@
 --- !ruby/object:Gem::Specification 
 name: httpi
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 23
   prerelease: false
   segments: 
   - 0
-  - 1
+  - 2
   - 0
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Daniel Harrington
+- Martin Tepper
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2010-09-12 00:00:00 +02:00
+date: 2010-09-23 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -58,14 +59,14 @@ dependencies:
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 62196421
+        hash: 62196431
         segments: 
         - 2
         - 0
         - 0
         - beta
-        - 19
-        version: 2.0.0.beta.19
+        - 22
+        version: 2.0.0.beta.22
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -94,28 +95,28 @@ extra_rdoc_files: []
 
 files: 
 - Gemfile
+- Gemfile.lock
 - Rakefile
 - README.rdoc
 - autotest/discover.rb
-- lib/httpi/adapter/base.rb
 - lib/httpi/adapter/curb.rb
 - lib/httpi/adapter/httpclient.rb
 - lib/httpi/adapter.rb
 - lib/httpi/client.rb
-- lib/httpi/interface.rb
+- lib/httpi/request.rb
 - lib/httpi/response.rb
 - lib/httpi/version.rb
 - lib/httpi.rb
-- spec/fixtures/gzip.gz
+- spec/fixtures/xml.gz
 - spec/fixtures/xml.xml
 - spec/httpi/adapter/curb_spec.rb
 - spec/httpi/adapter/httpclient_spec.rb
 - spec/httpi/adapter_spec.rb
 - spec/httpi/client_spec.rb
-- spec/httpi/interface_spec.rb
+- spec/httpi/request_spec.rb
 - spec/httpi/response_spec.rb
 - spec/spec_helper.rb
-- spec/support/helper_methods.rb
+- spec/support/fixture.rb
 - spec/support/matchers.rb
 - .rspec
 has_rdoc: true

data/lib/httpi/adapter/base.rb

@@ -1,16 +0,0 @@
-module HTTPI
-  module Adapter
-    module Base
-
-      # List of methods expected to be implemented by an adapter.
-      METHODS = %w(setup client headers headers= proxy proxy= get post auth)
-
-      METHODS.each do |method|
-        define_method method do |*args|
-          raise NotImplementedError, "#{Adapter.use} does not implement a #{method} method"
-        end
-      end
-
-    end
-  end
-end

data/lib/httpi/interface.rb

@@ -1,21 +0,0 @@
-require "httpi/adapter"
-
-module HTTPI
-  module Interface
-
-    # Loads a given +adapter+. Defaults to load <tt>HTTPI::Adapter::DEFAULT</tt>.
-    def load!(adapter = nil)
-      adapter ||= Adapter.use
-      include_adapter Adapter.find(adapter)
-      setup
-    end
-
-  private
-
-    # Includes a given +adapter+ into the current class.
-    def include_adapter(adapter)
-      self.class.send :include, adapter
-    end
-
-  end
-end

data/spec/httpi/interface_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-require "httpi/interface"
-
-describe HTTPI::Interface do
-
-  context "when included" do
-    before do
-      @httpi = Class.new { include HTTPI::Interface }.new
-    end
-
-    it "should offer a #load! method for loading an adapter" do
-      @httpi.load!
-      @httpi.client.should be_an(HTTPClient)
-    end
-
-    describe "#load!" do
-      it "should accept an adapter to use" do
-        @httpi.load! :curb
-        @httpi.client.should be_a(Curl::Easy)
-      end
-
-      it "should raise an ArgumentError in case of an invalid adapter" do
-        lambda { @httpi.load! :unknown }.should raise_error(ArgumentError)
-      end
-
-      it "should call the adapter's #setup method" do
-        @httpi.expects(:setup)
-        @httpi.load!
-      end
-    end
-  end
-
-end

data/spec/support/helper_methods.rb

@@ -1,41 +0,0 @@
-class Some
-  class << self
-
-    def url
-      @url ||= "http://example.com"
-    end
-
-    def proxy_url
-      @proxy_url ||= "http://proxy.example.com"
-    end
-
-    def headers
-      @headers ||= { "Content-Type" => "text/html; charset=utf-8" }
-    end
-
-    def response_code
-      @code ||= 200
-    end
-
-  end
-end
-
-class Fixture
-  class << self
-
-    def xml
-      @xml ||= load :xml
-    end
-
-    def gzip
-      @gzip ||= load :gzip, :gz
-    end
-
-  private
-
-    def load(fixture, type = :xml)
-      File.read File.expand_path("../../fixtures/#{fixture}.#{type}", __FILE__)
-    end
-
-  end
-end