httparty 0.14.0 → 0.15.0

data/spec/httparty/response_spec.rb

@@ -72,6 +72,18 @@ RSpec.describe HTTParty::Response do
     end
   end
 
+  it 'does raise an error about itself when using #method' do
+    expect {
+      HTTParty::Response.new(@request_object, @response_object, @parsed_response).method(:qux)
+    }.to raise_error(NameError, /HTTParty\:\:Response/)
+  end
+
+  it 'does raise an error about itself when invoking a method that does not exist' do 
+    expect {
+      HTTParty::Response.new(@request_object, @response_object, @parsed_response).qux
+    }.to raise_error(NoMethodError, /HTTParty\:\:Response/)
+  end 
+
   it "returns response headers" do
     response = HTTParty::Response.new(@request_object, @response_object, @parsed_response)
     expect(response.headers).to eq({'last-modified' => [@last_modified], 'content-length' => [@content_length]})
@@ -117,12 +129,32 @@ RSpec.describe HTTParty::Response do
     expect(response.respond_to?(:[])).to be_truthy
   end
 
-  it "should be able to iterate if it is array" do
-    response = HTTParty::Response.new(@request_object, @response_object, lambda { [{'foo' => 'bar'}, {'foo' => 'baz'}] })
-    expect(response.size).to eq(2)
-    expect {
-      response.each { |item| }
-    }.to_not raise_error
+  context 'response is array' do
+    let(:response_value) { [{'foo' => 'bar'}, {'foo' => 'baz'}] }
+    let(:response) { HTTParty::Response.new(@request_object, @response_object, lambda { response_value }) } 
+    it "should be able to iterate" do 
+      expect(response.size).to eq(2)
+      expect {
+        response.each { |item| }
+      }.to_not raise_error
+    end
+
+    it 'should respond to array methods' do       
+      expect(response).to respond_to(:bsearch, :compact, :cycle, :delete, :each, :flatten, :flatten!, :compact, :join)    
+    end
+
+    it 'should equal the string response object body' do
+      expect(response.to_s).to eq(@response_object.body.to_s)    
+    end    
+
+    it 'should display the same as an array' do
+      a = StringIO.new
+      b = StringIO.new
+      response_value.display(b)
+      response.display(a)
+
+      expect(a.string).to eq(b.string)    
+    end
   end
 
   it "allows headers to be accessed by mixed-case names in hash notation" do
@@ -151,8 +183,7 @@ RSpec.describe HTTParty::Response do
 
     it { is_expected.to respond_to(:is_a?).with(1).arguments }
     it { expect(subject.is_a?(HTTParty::Response)).to be_truthy }
-    it { expect(subject.is_a?(BasicObject)).to be_truthy }
-    it { expect(subject.is_a?(Object)).to be_falsey }
+    it { expect(subject.is_a?(Object)).to be_truthy }
   end
 
   describe "#kind_of?" do
@@ -160,8 +191,7 @@ RSpec.describe HTTParty::Response do
 
     it { is_expected.to respond_to(:kind_of?).with(1).arguments }
     it { expect(subject.kind_of?(HTTParty::Response)).to be_truthy }
-    it { expect(subject.kind_of?(BasicObject)).to be_truthy }
-    it { expect(subject.kind_of?(Object)).to be_falsey }
+    it { expect(subject.kind_of?(Object)).to be_truthy }
   end
 
   describe "semantic methods for response codes" do
@@ -263,9 +293,35 @@ RSpec.describe HTTParty::Response do
   end
 
   describe "headers" do
-    it "can initialize without headers" do
-      headers = HTTParty::Response::Headers.new
-      expect(headers).to eq({})
+    let (:empty_headers) { HTTParty::Response::Headers.new }
+    let (:some_headers_hash) do 
+      {'Cookie' => 'bob',
+      'Content-Encoding' => 'meow'}
+    end 
+    let (:some_headers) do 
+       HTTParty::Response::Headers.new.tap do |h|
+         some_headers_hash.each_pair do |k,v|
+           h[k] = v
+         end
+      end
+    end
+    it "can initialize without headers" do 
+      expect(empty_headers).to eq({})
+    end
+
+    it 'always equals itself' do
+      expect(empty_headers).to eq(empty_headers) 
+      expect(some_headers).to eq(some_headers)
+    end
+
+    it 'does not equal itself when not equivalent' do 
+      expect(empty_headers).to_not eq(some_headers)
+    end
+
+    it 'does equal a hash' do
+      expect(empty_headers).to eq({})
+
+      expect(some_headers).to eq(some_headers_hash)
     end
   end
 

data/spec/httparty_spec.rb

@@ -129,6 +129,11 @@ RSpec.describe HTTParty do
         .and_return(double("mock response", perform: nil))
     end
 
+    it "does not modify default_options when no arguments are passed" do
+      @klass.headers
+      expect(@klass.default_options[:headers]).to eq(nil)
+    end
+
     it "should default to empty hash" do
       expect(@klass.headers).to eq({})
     end
@@ -171,11 +176,11 @@ RSpec.describe HTTParty do
         @klass.get('', cookies: {type: 'snickerdoodle'})
       end
 
-      it 'doesnt modify default_options' do
+      it 'doesnt modify default headers' do
         expect(@klass.headers).to eq({})
         expect_headers('cookie' => 'type=snickerdoodle')
         @klass.get('', cookies: {type: 'snickerdoodle'})
-        expect(@klass.default_options[:headers]).to eq({})
+        expect(@klass.headers).to eq({})
       end
 
       it 'adds optional cookies to the optional headers' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: httparty
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - John Nunemaker
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2017-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_xml
@@ -41,7 +41,7 @@ files:
 - CONTRIBUTING.md
 - Gemfile
 - Guardfile
-- History
+- History.md
 - MIT-LICENSE
 - README.md
 - Rakefile
@@ -61,6 +61,7 @@ files:
 - examples/rescue_json.rb
 - examples/rubyurl.rb
 - examples/stackexchange.rb
+- examples/stream_download.rb
 - examples/tripit_sign_in.rb
 - examples/twitter.rb
 - examples/whoismyrep.rb
@@ -142,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -150,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Makes http fun! Also, makes consuming restful web services dead easy.

data/spec/fixtures/ssl/generated/1fe462c2.0

@@ -1,16 +0,0 @@
------BEGIN CERTIFICATE-----
-MIICbTCCAdagAwIBAgIJAIAeO9TXtJ45MA0GCSqGSIb3DQEBBQUAMC4xLDAqBgNV
-BAMTI0lOU0VDVVJFIFRlc3QgQ2VydGlmaWNhdGUgQXV0aG9yaXR5MCAXDTEwMTAy
-MDEzNDYyM1oYDzQ3NDgwOTE1MTM0NjIzWjAuMSwwKgYDVQQDEyNJTlNFQ1VSRSBU
-ZXN0IENlcnRpZmljYXRlIEF1dGhvcml0eTCBnzANBgkqhkiG9w0BAQEFAAOBjQAw
-gYkCgYEA3lkBcd352qiIIzqnyvvJj59cx1dnzMyjnuaK2cRH420rBfukLE2MbOVr
-9nYq/7CdjqXpE8uFAF+UTSIK6MWZ/bidkr2xd/et/Ce2pVIVxH+rt3pJz3wZhC3H
-Yz+HU4CD2iI9wAzsb6mMV7md1fjlYfir4SBGGPTkcqUJUp2/tQMCAwEAAaOBkDCB
-jTAdBgNVHQ4EFgQUy0Lz6RgmtpywlBOXdPABQArp358wXgYDVR0jBFcwVYAUy0Lz
-6RgmtpywlBOXdPABQArp35+hMqQwMC4xLDAqBgNVBAMTI0lOU0VDVVJFIFRlc3Qg
-Q2VydGlmaWNhdGUgQXV0aG9yaXR5ggkAgB471Ne0njkwDAYDVR0TBAUwAwEB/zAN
-BgkqhkiG9w0BAQUFAAOBgQCmi3JQm+EIWjkRlyz9sijkYS+Ps4opmd/weeaXwa4E
-gVBWJGyiduB+kBnfv61+/tDjlrbjBDH5dP8suczHQL8gox4zGgjw64KH4o1ujZYR
-cEPbhnUpwbXu7yItlajBZfpFefjF5P0Ao2iEzQldDy0D6nQ19h5QANvQxqweTPQp
-pw==
------END CERTIFICATE-----