httpadapter 0.2.1 → 1.0.0

data/spec/httpadapter_spec.rb

@@ -13,236 +13,115 @@
 #    limitations under the License.
 
 require 'spec_helper'
+require 'spec/httpadapter/adapter_type_checking_spec'
 
 require 'httpadapter'
 
 class StubAdapter
-  def to_ary
+  include HTTPAdapter
+
+  def convert_request_to_a(request_obj)
+    if request_obj == 42
+      raise TypeError, "This should never be fourty-two."
+    end
     return ['GET', '/', [], [""]]
   end
 
-  def self.from_ary(array)
-    return Object.new
+  def convert_request_from_a(request_ary)
+    if request_ary == 42
+      raise TypeError, "This should never be fourty-two."
+    end
+    return :stubbed_request
   end
 
-  def self.transmit(request, connection=nil)
+  def convert_response_to_a(response_obj)
+    if response_obj == 42
+      raise TypeError, "This should never be fourty-two."
+    end
     return [200, [], ['']]
   end
-end
-
-class BogusAdapter
-  def initialize(request)
-  end
-end
-
-describe HTTPAdapter, 'when attempting to specialize a request' do
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(42, StubAdapter)
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request([42], StubAdapter)
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        [42, 42, 42, 42], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', 42, [], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', 42, ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [42], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [[42, 'value']], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [['X', 42]], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [], 42], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [], ''], StubAdapter
-      )
-    end).should raise_error(TypeError)
+  def convert_response_from_a(response_ary)
+    if response_ary == 42
+      raise TypeError, "This should never be fourty-two."
+    end
+    return :stubbed_response
   end
 
-  it 'should raise an error for converting from an invalid adapter' do
-    (lambda do
-      HTTPAdapter.specialize_request(
-        ['GET', '/', [], ['']], Object
-      )
-    end).should raise_error(TypeError)
+  def fetch_resource(request_ary, connection=nil)
+    if request_ary == 42 || connection == 42
+      raise TypeError, "This should never be fourty-two."
+    end
+    return [200, [], ['']]
   end
 end
 
-describe HTTPAdapter, 'when attempting to adapt a request' do
-  it 'should raise an error for converting from an invalid adapter' do
-    (lambda do
-      HTTPAdapter.adapt_request(
-        Object.new, BogusAdapter
-      )
-    end).should raise_error(TypeError)
-  end
+class BogusAdapter
+  include HTTPAdapter
 end
 
-describe HTTPAdapter, 'when attempting to specialize a response' do
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(42, StubAdapter)
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response([42], StubAdapter)
-    end).should raise_error(TypeError)
-  end
-
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [42, 42, 42], StubAdapter
-      )
-    end).should raise_error(TypeError)
+describe StubAdapter, 'a stubbed adapter class that does nothing' do
+  before do
+    @adapter = StubAdapter.new
+    @request = ['GET', '/', [], ['']]
+    @response = [200, [], ['']]
   end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [Object.new, [], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
+  it_should_behave_like 'adapter type-checking example'
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        ['', 42, ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
+  it 'should convert to a stubbed request object' do
+    @adapter.specialize_request(@request).should == :stubbed_request
   end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [42], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
+  it 'should convert to a stubbed response object' do
+    @adapter.specialize_response(@response).should == :stubbed_response
   end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [[42, 'value']], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
+  it 'should convert to a stubbed request array' do
+    @adapter.adapt_request(Object.new).should == @request
   end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [['X', 42]], ['']], StubAdapter
-      )
-    end).should raise_error(TypeError)
+  it 'should convert to a stubbed response array' do
+    @adapter.adapt_response(Object.new).should == @response
   end
+end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [], 42], StubAdapter
-      )
-    end).should raise_error(TypeError)
+describe BogusAdapter, 'an empty class that does nothing' do
+  before do
+    @adapter = BogusAdapter.new
+    @request = ['GET', '/', [], ['']]
+    @response = [200, [], ['']]
   end
 
-  it 'should raise an error for converting from an invalid tuple' do
-    (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [], ''], StubAdapter
-      )
-    end).should raise_error(TypeError)
-  end
+  it_should_behave_like 'adapter type-checking example'
 
-  it 'should raise an error for converting from an invalid adapter' do
+  it 'should raise an error when attempting to adapt a request' do
     (lambda do
-      HTTPAdapter.specialize_response(
-        [200, [], ['']], Object
-      )
+      @adapter.adapt_request(Object.new)
     end).should raise_error(TypeError)
   end
-end
 
-describe HTTPAdapter, 'when attempting to adapt a response' do
-  it 'should raise an error for converting from an invalid adapter' do
+  it 'should raise an error when attempting to specialize a request' do
     (lambda do
-      HTTPAdapter.adapt_response(
-        Object.new, BogusAdapter
-      )
+      @adapter.specialize_request(@request)
     end).should raise_error(TypeError)
   end
-end
 
-describe HTTPAdapter, 'when attempting to transmit a request' do
-  it 'should raise an error for invalid request objects' do
+  it 'should raise an error when attempting to adapt a response' do
     (lambda do
-      HTTPAdapter.transmit(42, StubAdapter)
+      @adapter.adapt_response(Object.new)
     end).should raise_error(TypeError)
   end
 
-  it 'should raise an error for invalid adapter objects' do
+  it 'should raise an error when attempting to specialize a response' do
     (lambda do
-      HTTPAdapter.transmit(['GET', '/', [], ['']], BogusAdapter)
+      @adapter.specialize_response(@response)
     end).should raise_error(TypeError)
   end
 
-  it 'should raise an error for invalid connection objects' do
+  it 'should raise an error when attempting to transmit a request' do
     (lambda do
-      HTTPAdapter.transmit(['GET', '/', [], ['']], StubAdapter, 42)
+      @adapter.transmit(@request)
     end).should raise_error(TypeError)
   end
 end

data/tasks/gem.rake

@@ -19,8 +19,8 @@ namespace :gem do
     s.files = PKG_FILES.to_a
 
     s.has_rdoc = true
-    s.extra_rdoc_files = %w( README )
-    s.rdoc_options.concat ["--main",  "README"]
+    s.extra_rdoc_files = %w( README.md )
+    s.rdoc_options.concat ["--main",  "README.md"]
 
     s.add_runtime_dependency("addressable", "~> 2.2.0")
 

data/tasks/rdoc.rake

@@ -8,7 +8,7 @@ namespace :doc do
     rdoc.options << "--line-numbers" << "--inline-source" <<
       "--accessor" << "cattr_accessor=object" << "--charset" << "utf-8"
     rdoc.template = "#{ENV["template"]}.rb" if ENV["template"]
-    rdoc.rdoc_files.include("README", "CHANGELOG", "LICENSE")
+    rdoc.rdoc_files.include("README.md", "CHANGELOG", "LICENSE")
     rdoc.rdoc_files.include("lib/**/*.rb")
   end
 

data/tasks/spec.rake

@@ -15,10 +15,13 @@ namespace :spec do
       t.rcov = false
     end
     t.rcov_opts = [
+      '--exclude', 'lib\\/compat',
       '--exclude', 'spec',
+      '--exclude', '\\.rvm\\/gems',
       '--exclude', '1\\.8\\/gems',
       '--exclude', '1\\.9\\/gems',
-      '--exclude', 'addressable\\/idna\\.rb', # unicode tables too big
+      '--exclude', '\\.rvm',
+      '--exclude', '\\/Library\\/Ruby'
     ]
   end
 

data/tasks/yard.rake

@@ -10,7 +10,7 @@ begin
       yardoc.name = 'yard'
       yardoc.options = ['--verbose']
       yardoc.files = [
-        'lib/**/*.rb', 'ext/**/*.c', 'README', 'CHANGELOG', 'LICENSE'
+        'lib/**/*.rb', 'ext/**/*.c', 'README.md', 'CHANGELOG', 'LICENSE'
       ]
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: httpadapter
 version: !ruby/object:Gem::Version 
-  hash: 21
-  prerelease: false
+  hash: 23
+  prerelease: 
   segments: 
-  - 0
-  - 2
   - 1
-  version: 0.2.1
+  - 0
+  - 0
+  version: 1.0.0
 platform: ruby
 authors: 
 - Bob Aman
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-04 00:00:00 -08:00
+date: 2011-03-11 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -139,7 +139,7 @@ executables: []
 extensions: []
 
 extra_rdoc_files: 
-- README
+- README.md
 files: 
 - lib/httpadapter/adapters/mock.rb
 - lib/httpadapter/adapters/net_http.rb
@@ -148,14 +148,11 @@ files:
 - lib/httpadapter/connection.rb
 - lib/httpadapter/version.rb
 - lib/httpadapter.rb
-- spec/httpadapter/adapters/net_http_request_spec.rb
-- spec/httpadapter/adapters/net_http_response_spec.rb
-- spec/httpadapter/adapters/net_http_transmission_spec.rb
-- spec/httpadapter/adapters/rack_request_spec.rb
-- spec/httpadapter/adapters/rack_response_spec.rb
-- spec/httpadapter/adapters/typhoeus_request_spec.rb
-- spec/httpadapter/adapters/typhoeus_response_spec.rb
-- spec/httpadapter/adapters/typhoeus_transmission_spec.rb
+- spec/httpadapter/adapter_type_checking_spec.rb
+- spec/httpadapter/adapters/mock_adapter_spec.rb
+- spec/httpadapter/adapters/net_http_spec.rb
+- spec/httpadapter/adapters/rack_spec.rb
+- spec/httpadapter/adapters/typhoeus_spec.rb
 - spec/httpadapter/connection_spec.rb
 - spec/httpadapter_spec.rb
 - spec/spec.opts
@@ -172,7 +169,7 @@ files:
 - CHANGELOG
 - LICENSE
 - Rakefile
-- README
+- README.md
 has_rdoc: true
 homepage: http://httpadapter.rubyforge.org/
 licenses: []
@@ -180,7 +177,7 @@ licenses: []
 post_install_message: 
 rdoc_options: 
 - --main
-- README
+- README.md
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -204,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: httpadapter
-rubygems_version: 1.3.7
+rubygems_version: 1.4.1
 signing_key: 
 specification_version: 3
 summary: Package Summary

data/README

@@ -1,49 +0,0 @@
-== HTTPAdapter
-
-Homepage::  httpadapter.rubyforge.org[http://httpadapter.rubyforge.org/]
-Author::    Bob Aman  (mailto:bob@sporkmonger.com)
-Copyright:: Copyright © 2010 Google Inc.
-License::   Apache 2.0
-
-== Description
-
-A library for translating HTTP request and response objects for various clients into a common representation.
-
-== Reference
-
-- {HTTPAdapter}
-
-== Adapters
-
-- {HTTPAdapter::NetHTTPRequestAdapter}
-- {HTTPAdapter::NetHTTPResponseAdapter}
-- {HTTPAdapter::RackRequestAdapter}
-- {HTTPAdapter::RackResponseAdapter}
-- {HTTPAdapter::TyphoeusRequestAdapter}
-- {HTTPAdapter::TyphoeusResponseAdapter}
-
-== Example Usage
-
-  response = Net::HTTP.start('www.google.com', 80) { |http| http.get('/') }
-  # => #<Net::HTTPOK 200 OK readbody=true>
-  result = HTTPAdapter.adapt_response(
-    response, HTTPAdapter::NetHTTPResponseAdapter
-  )
-  # => [
-  #   200,
-  #   [
-  #     ["Expires", "-1"],
-  #     ["Content-Type", "text/html; charset=ISO-8859-1"],
-  #     ["X-Xss-Protection", "1; mode=block"],
-  #     ["Server", "gws"],
-  #     ["Date", "Thu, 26 Aug 2010 22:13:03 GMT"],
-  #     ["Set-Cookie", "<snip>"],
-  #     ["Cache-Control", "private, max-age=0"],
-  #     ["Transfer-Encoding", "chunked"]
-  #   ],
-  #   ["<snip>"]
-  # ]
-
-== Install
-
-* sudo gem install httpadapter