http_stub 0.23.1 → 0.24.0

data/spec/acceptance/stub_match_spec.rb

@@ -75,7 +75,6 @@ describe "Stub match acceptance" do
       end
 
       context "when the request contains parameters" do
-
         include_context "issues requests with parameters"
 
         it "returns a response body that contains the parameters" do

data/spec/lib/http_stub/configurer/dsl/stub_builder_spec.rb

@@ -217,7 +217,6 @@ describe HttpStub::Configurer::DSL::StubBuilder do
       end
 
       context "and a builder that is completely configured is provided" do
-
         include_context "a completely configured provided builder"
 
         it "replaces the uri" do
@@ -344,7 +343,6 @@ describe HttpStub::Configurer::DSL::StubBuilder do
     end
 
     context "when the builder has not been previously configured" do
-
       include_context "a completely configured provided builder"
 
       it "assumes the provided uri" do
@@ -443,7 +441,6 @@ describe HttpStub::Configurer::DSL::StubBuilder do
       describe "creates a stub payload with triggers that" do
 
         context "when a trigger is added" do
-
           include_context "triggers one stub"
 
           it "contain the provided trigger builder" do
@@ -455,7 +452,6 @@ describe HttpStub::Configurer::DSL::StubBuilder do
         end
 
         context "when many triggers are added" do
-
           include_context "triggers many stubs"
 
           it "contain the provided trigger builders" do

data/spec/lib/http_stub/configurer/request/stub_spec.rb

@@ -134,7 +134,6 @@ describe HttpStub::Configurer::Request::Stub do
     end
 
     context "when many triggers are provided" do
-
       include_context "triggers many stubs"
 
       it "builds the request object for each trigger" do
@@ -182,7 +181,6 @@ describe HttpStub::Configurer::Request::Stub do
       end
 
       context "when a trigger is added" do
-
         include_context "triggers one stub"
 
         it "has a triggers entry containing the stub trigger payload" do
@@ -192,7 +190,6 @@ describe HttpStub::Configurer::Request::Stub do
       end
 
       context "when many triggers are added" do
-
         include_context "triggers many stubs"
 
         it "has a triggers entry containing the stub trigger payloads" do
@@ -224,7 +221,6 @@ describe HttpStub::Configurer::Request::Stub do
       before(:example) { allow(stub_response).to receive(:file).and_return(response_file) }
 
       context "and the triggers contain files" do
-
         include_context "triggers many stubs"
 
         let(:triggers_files) do
@@ -238,7 +234,6 @@ describe HttpStub::Configurer::Request::Stub do
       end
 
       context "and the triggers contain no files" do
-
         include_context "triggers many stubs"
 
         let(:triggers_files) { trigger_payloads.map { (1..3).map { [] } } }
@@ -256,7 +251,6 @@ describe HttpStub::Configurer::Request::Stub do
       before(:example) { allow(stub_response).to receive(:file).and_return(nil) }
 
       context "and the triggers contain files" do
-
         include_context "triggers many stubs"
 
         let(:triggers_files) do
@@ -270,7 +264,6 @@ describe HttpStub::Configurer::Request::Stub do
       end
 
       context "and no triggers contain a file" do
-
         include_context "triggers many stubs"
 
         let(:triggers_files) { trigger_payloads.map { (1..3).map { [] } } }

data/spec/lib/http_stub/configurer/server/command_processor_integration_spec.rb

@@ -17,7 +17,6 @@ describe HttpStub::Configurer::Server::CommandProcessor do
     subject { command_processor.process(command) }
 
     context "when the server is running" do
-
       include_context "server integration"
 
       describe "and the server responds with a 200 response" do
@@ -52,6 +51,8 @@ describe HttpStub::Configurer::Server::CommandProcessor do
 
     context "when the server is unavailable" do
 
+      subject { command_processor.process(command, open_timeout: 1) }
+
       let(:request) { create_get_request("/does/not/exist") }
 
       it "raises an exception that includes the server base URI" do

data/spec/lib/http_stub/rake/server_tasks_smoke_spec.rb

@@ -29,12 +29,15 @@ describe HttpStub::Rake::ServerTasks do
 
         def wait_until_server_has_started
           ::Wait.until!(description: "http stub server #{task_args[:name]} started") do
-            Net::HTTP.get_response("localhost", "/", port)
+            HTTParty.get("http://localhost:#{port}")
           end
         end
 
         def wait_until_server_has_stopped
-          HttpStub::Server::Application.stop!
+          HttpStub::Server::Application::Application.stop!
+          ::Wait.until_true!(description: "http stub server #{task_args[:name]} stopped") do
+            HTTParty.get("http://localhost:#{port}", timeout: 1) && false rescue true
+          end
         end
 
       end
@@ -45,9 +48,9 @@ describe HttpStub::Rake::ServerTasks do
 
   context "when a configurer is provided" do
 
-    let(:port) { 8004 }
+    let(:port)       { 8004 }
     let(:configurer) do
-      configurer = Class.new.tap do |configurer|
+      Class.new.tap do |configurer|
         configurer.send(:include, HttpStub::Configurer)
         configurer.stub_server.host = "localhost"
         configurer.stub_server.port = port

data/spec/lib/http_stub/server/{application_integration_spec.rb → application/application_integration_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Application, "when the server is running" do
+describe HttpStub::Server::Application::Application, "when the server is running" do
   include_context "server integration"
 
   let(:response_document) { Nokogiri::HTML(response.body) }

data/spec/lib/http_stub/server/{application_spec.rb → application/application_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Application do
+describe HttpStub::Server::Application::Application do
   include Rack::Test::Methods
 
   let(:response)      { last_response }
@@ -11,9 +11,9 @@ describe HttpStub::Server::Application do
   let(:stub_controller)     { instance_double(HttpStub::Server::Stub::Controller) }
   let(:scenario_controller) { instance_double(HttpStub::Server::Scenario::Controller) }
 
-  let(:response_pipeline) { instance_double(HttpStub::Server::ResponsePipeline, process: nil) }
+  let(:response_pipeline) { instance_double(HttpStub::Server::Application::ResponsePipeline, process: nil) }
 
-  let(:app) { HttpStub::Server::Application.new! }
+  let(:app) { HttpStub::Server::Application::Application.new! }
 
   before(:example) do
     allow(HttpStub::Server::Registry).to receive(:new).with("match result").and_return(match_result_registry)
@@ -21,7 +21,7 @@ describe HttpStub::Server::Application do
     allow(HttpStub::Server::Stub::Registry).to receive(:new).and_return(stub_registry)
     allow(HttpStub::Server::Stub::Controller).to receive(:new).and_return(stub_controller)
     allow(HttpStub::Server::Scenario::Controller).to receive(:new).and_return(scenario_controller)
-    allow(HttpStub::Server::ResponsePipeline).to receive(:new).and_return(response_pipeline)
+    allow(HttpStub::Server::Application::ResponsePipeline).to receive(:new).and_return(response_pipeline)
   end
 
   context "when the diagnostics landing page is retrieved" do
@@ -302,4 +302,8 @@ describe HttpStub::Server::Application do
     expect(app.settings.protection).to eql(false)
   end
 
+  it "disables cross origin support by default" do
+    expect(app.settings.cross_origin_support).to eql(false)
+  end
+
 end

data/spec/lib/http_stub/server/application/cross_origin_support_spec.rb

@@ -0,0 +1,114 @@
+describe HttpStub::Server::Application::CrossOriginSupport do
+  include Rack::Test::Methods
+
+  let(:header_names)    { (1..3).map { |i| "HEADER_#{i}" } }
+  let(:request_headers) do
+    header_names.each_with_object({}) { |name, result| result["HTTP_#{name}"] = "#{name} value" }
+  end
+
+  let(:response) { last_response }
+
+  let(:app_class) { Class.new(Sinatra::Base) }
+
+  let(:app) { app_class.new! }
+
+  before(:example) do
+    app_class.before { @http_stub_request = HttpStub::Server::Request.create(request) }
+  end
+
+  describe "when registered in an application" do
+
+    before(:example) { app_class.register described_class }
+
+    shared_examples_for "a request whose response contains access control headers" do
+
+      it "responds with an access control origin header allowing requests from all origins" do
+        subject
+
+        expect(response.headers["Access-Control-Allow-Origin"]).to eql("*")
+      end
+
+      it "responds with an access control method header allowing the method of the current request" do
+        subject
+
+        expect(response.headers["Access-Control-Allow-Methods"]).to eql(request_method)
+      end
+
+      it "responds with an access control headers header allowing the headers of the current request" do
+        subject
+
+        header_names.each do |expected_header_name|
+          expect(response.headers["Access-Control-Allow-Headers"]).to include(expected_header_name)
+        end
+      end
+
+    end
+
+    context "and cross origin support is enabled" do
+
+      before(:example) { app_class.enable :cross_origin_support }
+
+      context "and a non-OPTIONS request is issued" do
+
+        let(:request_method) { "GET" }
+
+        subject { get "/some_resource", {}, request_headers }
+
+        it_behaves_like "a request whose response contains access control headers"
+
+      end
+
+
+      context "and an OPTIONS request is issued" do
+
+        let(:request_method) { "OPTIONS" }
+
+        subject { options "/some_resource", {}, request_headers }
+
+        it_behaves_like "a request whose response contains access control headers"
+
+        it "responds with a status of 200" do
+          subject
+
+          expect(response.status).to eql(200)
+        end
+
+      end
+
+    end
+
+    context "and cross origin support is disabled" do
+
+      before(:example) do
+        app_class.disable :cross_origin_support
+      end
+
+      context "and a non-OPTIONS request is issued" do
+
+        subject { get "/some_resource", {}, request_headers }
+
+        it "does not add access control headers" do
+          subject
+
+          header_names.each { |header_name| expect(header_name).to_not match(/^Access-Control/) }
+        end
+
+      end
+
+      context "and an OPTIONS request is issued" do
+
+        subject { options "/some_resource" }
+
+        it "returns a not found response" do
+          subject
+
+          expect(response.status).to eql(404)
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/spec/lib/http_stub/server/{response_pipeline_spec.rb → application/response_pipeline_spec.rb}

@@ -1,8 +1,8 @@
-describe HttpStub::Server::ResponsePipeline do
+describe HttpStub::Server::Application::ResponsePipeline do
 
-  let(:server)            { instance_double(HttpStub::Server) }
+  let(:application) { instance_double(Sinatra::Base) }
 
-  let(:response_pipeline) { HttpStub::Server::ResponsePipeline.new(server) }
+  let(:response_pipeline) { described_class.new(application) }
 
   describe "#process" do
 
@@ -18,8 +18,8 @@ describe HttpStub::Server::ResponsePipeline do
       subject
     end
 
-    it "serves the response via the server" do
-      expect(response).to receive(:serve_on).with(server)
+    it "serves the response via the application" do
+      expect(response).to receive(:serve_on).with(application)
 
       subject
     end

data/spec/lib/http_stub/server/{application_helpers_spec.rb → application/text_formatting_support_spec.rb}

@@ -1,12 +1,12 @@
-describe HttpStub::Server::ApplicationHelpers do
+describe HttpStub::Server::Application::TextFormattingSupport do
 
-  let(:helpers) { Class.new.extend(described_class) }
+  let(:text_formatting_support) { Class.new.extend(described_class) }
 
   describe "::h" do
 
     let(:text) { "<tag>Some text</tag>" }
 
-    subject { helpers.h(text) }
+    subject { text_formatting_support.h(text) }
 
     it "should escape the provided HTML" do
       expect(subject).to eq("&lt;tag&gt;Some text&lt;&#x2F;tag&gt;")
@@ -16,7 +16,7 @@ describe HttpStub::Server::ApplicationHelpers do
 
   describe "::pp" do
 
-    subject { helpers.pp(text) }
+    subject { text_formatting_support.pp(text) }
 
     context "when the text is JSON" do
 

data/spec/lib/http_stub/server/registry_spec.rb

@@ -69,7 +69,6 @@ describe HttpStub::Server::Registry do
     subject { registry.find(criteria, logger) }
 
     describe "when multiple models have been registered" do
-
       include_context "register multiple models"
 
       it "determines if the models satisfy the provided criteria" do
@@ -139,7 +138,6 @@ describe HttpStub::Server::Registry do
   describe "#last" do
 
     context "when multiple models have been registered" do
-
       include_context "register multiple models"
 
       it "returns the last added model" do
@@ -165,7 +163,6 @@ describe HttpStub::Server::Registry do
   describe "#all" do
 
     context "when multiple models have been registered" do
-
       include_context "register multiple models"
 
       it "returns the registered models in the order they were added" do
@@ -189,7 +186,6 @@ describe HttpStub::Server::Registry do
     subject { registry.rollback_to(model) }
 
     context "when models have been added" do
-
       include_context "register multiple models"
 
       context "and the rollback is to one of those models" do
@@ -243,7 +239,6 @@ describe HttpStub::Server::Registry do
     end
 
     context "when models have been added" do
-
       include_context "register multiple models"
 
       it "releases all knowledge of the models" do

data/spec/spec_helper.rb

@@ -17,20 +17,8 @@ require 'http_server_manager/test_support'
 
 require_relative '../lib/http_stub/rake/task_generators'
 require_relative '../lib/http_stub'
-require_relative '../examples/configurer_with_trivial_stub'
-require_relative '../examples/configurer_with_deprecated_activator'
-require_relative '../examples/configurer_with_trivial_scenarios'
-require_relative '../examples/configurer_with_exhaustive_scenarios'
-require_relative '../examples/configurer_with_initialize_callback'
-require_relative '../examples/configurer_with_complex_initializer'
-require_relative '../examples/configurer_with_server_defaults'
-require_relative '../examples/configurer_with_stub_triggers'
-require_relative '../examples/configurer_with_file_responses'
-require_relative '../examples/configurer_with_stub_request_body'
-require_relative '../examples/configurer_with_parts'
-require_relative '../examples/configurer_with_endpoint_template'
-require_relative '../examples/configurer_with_request_references'
-require_relative '../examples/authentication_service/configurer'
+
+Dir[File.expand_path('../../examples/**/*.rb', __FILE__)].each { |file| require file }
 
 HttpStub::Server::Daemon.log_dir = ::File.expand_path('../../tmp/log', __FILE__)
 HttpStub::Server::Daemon.pid_dir = ::File.expand_path('../../tmp/pids', __FILE__)
@@ -45,6 +33,8 @@ module HttpStub
 
 end
 
+require_relative 'support/cross_origin_server/integration'
+require_relative 'support/cross_origin_server/index_page'
 require_relative 'support/http_stub/server/request_fixture'
 require_relative 'support/http_stub/server/scenario/scenario_fixture'
 require_relative 'support/http_stub/server/stub/match/result_fixture'
@@ -52,5 +42,6 @@ require_relative 'support/http_stub/stub_fixture'
 require_relative 'support/http_stub/scenario_fixture'
 require_relative 'support/http_stub/empty_configurer'
 require_relative 'support/html_helpers'
+require_relative 'support/browser_integration'
 require_relative 'support/server_integration'
 require_relative 'support/configurer_integration'

data/spec/support/browser_integration.rb

@@ -0,0 +1,9 @@
+shared_context "browser integration" do
+
+  let(:browser) do
+    Selenium::WebDriver.for(:firefox).tap { @browser_launched = true }
+  end
+
+  after(:example) { browser.quit if @browser_launched }
+
+end

data/spec/support/cross_origin_server/application.rb

@@ -0,0 +1,5 @@
+require 'sinatra'
+
+set :port, 8005
+
+set :root, File.dirname(__FILE__)

data/spec/support/cross_origin_server/index_page.rb

@@ -0,0 +1,26 @@
+module CrossOriginServer
+
+  class IndexPage
+
+    def initialize(browser)
+      @browser = browser
+    end
+
+    def load_and_wait_until_available
+      @browser.navigate.to("http://localhost:8005/index.html")
+      ::Wait.until!(description: "cross origin test page has loaded") { @browser.find_element(id: "scenario_name") }
+    end
+
+    def activate_scenario(name)
+      @browser.find_element(id: "scenario_name").send_keys(name)
+      @browser.find_element(id: "activate_scenario").click
+    end
+
+    def wait_for_response_indicator(indicator)
+      ::Wait.until_true!(description: "cross origin request '#{indicator}'") do
+        @browser.find_element(id: "response_indicator").text == indicator
+      end
+    end
+
+  end
+end