http_stub 0.19.1 → 0.20.0

data/spec/lib/http_stub/server/stub/controller_spec.rb

@@ -1,24 +1,26 @@
 describe HttpStub::Server::Stub::Controller do
 
-  let(:request)  { instance_double(Rack::Request) }
+  let(:request)  { instance_double(HttpStub::Server::Request) }
+  let(:logger)   { instance_double(Logger) }
   let(:payload)  { HttpStub::StubFixture.new.server_payload }
   let(:response) { instance_double(HttpStub::Server::Stub::Response::Base) }
-  let(:the_stub) { instance_double(HttpStub::Server::Stub::Instance, response: response) }
+  let(:stub_uri) { "/some/stub/uri" }
+  let(:the_stub) { instance_double(HttpStub::Server::Stub::Stub, response: response, stub_uri: stub_uri) }
   let(:registry) { instance_double(HttpStub::Server::Stub::Registry).as_null_object }
 
   let(:controller) { HttpStub::Server::Stub::Controller.new(registry) }
 
   before(:example) do
-    allow(HttpStub::Server::Stub::RequestParser).to receive(:parse).and_return(payload)
+    allow(HttpStub::Server::Stub::Parser).to receive(:parse).and_return(payload)
     allow(HttpStub::Server::Stub).to receive(:create).and_return(the_stub)
   end
 
   describe "#register" do
 
-    subject { controller.register(request) }
+    subject { controller.register(request, logger) }
 
     it "parses the payload from the request" do
-      expect(HttpStub::Server::Stub::RequestParser).to receive(:parse).with(request).and_return(payload)
+      expect(HttpStub::Server::Stub::Parser).to receive(:parse).with(request).and_return(payload)
 
       subject
     end
@@ -30,37 +32,48 @@ describe HttpStub::Server::Stub::Controller do
     end
 
     it "adds the stub to the stub registry" do
-      expect(registry).to receive(:add).with(the_stub, request)
+      expect(registry).to receive(:add).with(the_stub, logger)
 
       subject
     end
 
-    it "returns a success response" do
-      expect(subject).to eql(HttpStub::Server::Response::SUCCESS)
+    it "creates a success response with a location header containing the stubs uri" do
+      expect(HttpStub::Server::Response).to receive(:success).with("location" => stub_uri)
+
+      subject
+    end
+
+    it "returns the success response" do
+      response = double("HttpStub::Server::Response")
+      allow(HttpStub::Server::Response).to receive(:success).and_return(response)
+
+      expect(subject).to eql(response)
     end
 
   end
 
   describe "#replay" do
 
+    subject { controller.replay(request, logger) }
+
     describe "when a stub has been registered that should be replayed for the request" do
 
-      before(:example) { allow(registry).to receive(:find_for).with(request).and_return(the_stub) }
+      before(:example) { allow(registry).to receive(:find).with(request, logger).and_return(the_stub) }
 
       it "returns the stubs response" do
         expect(the_stub).to receive(:response).and_return(response)
 
-        expect(controller.replay(request)).to eql(response)
+        expect(subject).to eql(response)
       end
 
     end
 
     describe "when no stub should be replayed for the request" do
 
-      before(:example) { allow(registry).to receive(:find_for).with(request).and_return(nil) }
+      before(:example) { allow(registry).to receive(:find).with(request, logger).and_return(nil) }
 
       it "returns an empty response" do
-        expect(controller.replay(request)).to eql(HttpStub::Server::Response::EMPTY)
+        expect(subject).to eql(HttpStub::Server::Response::EMPTY)
       end
 
     end
@@ -69,10 +82,12 @@ describe HttpStub::Server::Stub::Controller do
 
   describe "#clear" do
 
+    subject { controller.clear(logger) }
+
     it "clears the stub registry" do
-      expect(registry).to receive(:clear).with(request)
+      expect(registry).to receive(:clear).with(logger)
 
-      controller.clear(request)
+      subject
     end
 
   end

data/spec/lib/http_stub/server/stub/empty_spec.rb

@@ -0,0 +1,68 @@
+describe HttpStub::Server::Stub::Empty do
+
+  let(:empty_stub) { HttpStub::Server::Stub::Empty::INSTANCE }
+
+  %w{ uri method stub_uri body }.each do |empty_string_attribute|
+
+    describe "##{empty_string_attribute}" do
+
+      it "is an empty string" do
+        expect(empty_stub.send(empty_string_attribute.to_sym)).to eql("")
+      end
+
+    end
+
+  end
+
+  %w{ headers parameters }.each do |empty_hash_attribute|
+
+    describe "##{empty_hash_attribute}" do
+
+      it "is an empty hash" do
+        expect(empty_stub.send(empty_hash_attribute.to_sym)).to eql({})
+      end
+
+    end
+
+  end
+
+  describe "#triggers" do
+
+    it "is an empty array" do
+      expect(empty_stub.triggers).to eql([])
+    end
+
+  end
+
+  describe "#response" do
+
+    it "is empty" do
+      expect(empty_stub.response).to eql(HttpStub::Server::Response::EMPTY)
+    end
+
+  end
+
+  describe "#matches?" do
+
+    let(:criteria) { double("MatchCriteria") }
+    let(:logger)   { instance_double(Logger) }
+
+    it "returns false" do
+      expect(empty_stub.matches?(criteria, logger)).to eql(false)
+    end
+
+  end
+
+  describe "#to_s" do
+
+    it "returns an empty string" do
+      expect(empty_stub.to_s).to eql("")
+    end
+
+  end
+
+  it "defines all the methods on a convetional Stub" do
+    expect(HttpStub::Server::Stub::Empty.instance_methods).to include(*HttpStub::Server::Stub::Stub.instance_methods)
+  end
+
+end

data/spec/lib/http_stub/server/stub/{exact_value_matcher_spec.rb → match/exact_value_matcher_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Stub::ExactValueMatcher do
+describe HttpStub::Server::Stub::Match::ExactValueMatcher do
 
   describe "::match?" do
 
@@ -25,7 +25,7 @@ describe HttpStub::Server::Stub::ExactValueMatcher do
     end
 
     def perform_match
-      HttpStub::Server::Stub::ExactValueMatcher.match?(stub_value, actual_value)
+      HttpStub::Server::Stub::Match::ExactValueMatcher.match?(stub_value, actual_value)
     end
 
   end

data/spec/lib/http_stub/server/stub/{hash_with_string_value_matchers_spec.rb → match/hash_with_string_value_matchers_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Stub::HashWithStringValueMatchers do
+describe HttpStub::Server::Stub::Match::HashWithStringValueMatchers do
 
   let(:stubbed_hash) do
     (1..3).reduce({}) do |result, i|
@@ -8,14 +8,16 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
   end
 
   let(:value_matchers) do
-    stubbed_hash.values.map { |value| double(HttpStub::Server::Stub::StringValueMatcher, to_s: value).as_null_object }
+    stubbed_hash.values.map do |value|
+      double(HttpStub::Server::Stub::Match::StringValueMatcher, to_s: value).as_null_object
+    end
   end
 
-  let(:value_matcher_hash) { HttpStub::Server::Stub::HashWithStringValueMatchers.new(stubbed_hash) }
+  let(:value_matcher_hash) { HttpStub::Server::Stub::Match::HashWithStringValueMatchers.new(stubbed_hash) }
 
   before(:example) do
     value_matchers.each do |value|
-      allow(HttpStub::Server::Stub::StringValueMatcher).to receive(:new).with(value.to_s).and_return(value)
+      allow(HttpStub::Server::Stub::Match::StringValueMatcher).to receive(:new).with(value.to_s).and_return(value)
     end
   end
 
@@ -27,7 +29,7 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
 
     it "creates a value matcher representation of each value in the hash" do
       value_matchers.each do |value|
-        expect(HttpStub::Server::Stub::StringValueMatcher).to receive(:new).with(value.to_s).and_return(value)
+        expect(HttpStub::Server::Stub::Match::StringValueMatcher).to receive(:new).with(value.to_s).and_return(value)
       end
 
       expect(value_matcher_hash.values).to eql(value_matchers)
@@ -35,7 +37,9 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
     
   end
   
-  describe "#match?" do
+  describe "#matches?" do
+
+    subject { value_matcher_hash.matches?(provided_hash) }
     
     context "when the stubbed hash contains multiple entries" do
 
@@ -53,11 +57,13 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
           context "and the values match" do
 
             before(:example) do
-              value_matchers.each { |value| allow(value).to receive(:match?).with("another #{value}").and_return(true) }
+              value_matchers.each do |value|
+                allow(value).to receive(:matches?).with("another #{value}").and_return(true)
+              end
             end
             
             it "returns true" do
-              expect(value_matcher_hash.match?(provided_hash)).to be_truthy
+              expect(subject).to be(true)
             end
             
           end
@@ -65,14 +71,16 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
           context "and a value does not match" do
 
             before(:example) do
-              value_matchers.each { |value| allow(value).to receive(:match?).with("another #{value}").and_return(true) }
+              value_matchers.each do |value|
+                allow(value).to receive(:matches?).with("another #{value}").and_return(true)
+              end
 
               non_matching_value = value_matchers[1]
-              allow(non_matching_value).to receive(:match?).with("another #{non_matching_value}").and_return(false)
+              allow(non_matching_value).to receive(:matches?).with("another #{non_matching_value}").and_return(false)
             end
 
             it "returns false" do
-              expect(value_matcher_hash.match?(provided_hash)).to be_falsey
+              expect(subject).to be(false)
             end
 
           end
@@ -86,16 +94,16 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
           it "determines if the corresponding value matches nil" do
             expected_values = [ "value1", nil, "value3" ]
             value_matchers.zip(expected_values).each do |value_matcher, expected_value|
-              allow(value_matcher).to receive(:match?).with(expected_value)
+              allow(value_matcher).to receive(:matches?).with(expected_value)
             end
 
-            value_matcher_hash.match?(provided_hash)
+            subject
           end
 
           it "returns the result of evaluating the value matchers" do
-            value_matchers.each { |value| allow(value).to receive(:match?).and_return(true) }
+            value_matchers.each { |value| allow(value).to receive(:matches?).and_return(true) }
 
-            expect(value_matcher_hash.match?(provided_hash)).to be_truthy
+            expect(subject).to be(true)
           end
 
         end
@@ -114,11 +122,11 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
         context "and it has matching keys and values" do
 
           before(:example) do
-            value_matchers.each { |value| allow(value).to receive(:match?).with("another #{value}").and_return(true) }
+            value_matchers.each { |value| allow(value).to receive(:matches?).with("another #{value}").and_return(true) }
           end
 
           it "returns true" do
-            expect(value_matcher_hash.match?(provided_hash)).to be_truthy
+            expect(subject).to be(true)
           end
           
         end
@@ -136,7 +144,7 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
         let(:provided_hash) { { "key" => "value" } }
 
         it "returns true" do
-          expect(value_matcher_hash.match?(provided_hash)).to be_truthy
+          expect(subject).to be(true)
         end
 
       end
@@ -146,7 +154,7 @@ describe HttpStub::Server::Stub::HashWithStringValueMatchers do
         let(:provided_hash) { {} }
 
         it "returns true" do
-          expect(value_matcher_hash.match?(provided_hash)).to be_truthy
+          expect(subject).to be(true)
         end
 
       end

data/spec/lib/http_stub/server/stub/match/match_spec.rb

@@ -0,0 +1,40 @@
+describe HttpStub::Server::Stub::Match::Match do
+
+  let(:stub)    { instance_double(HttpStub::Server::Stub::Stub) }
+  let(:request) { instance_double(HttpStub::Server::Request) }
+
+  let(:stub_match) { HttpStub::Server::Stub::Match::Match.new(stub, request) }
+
+  describe "#stub" do
+
+    subject { stub_match.stub }
+
+    context "when a stub is provided" do
+
+      it "exposes the provided value" do
+        expect(subject).to eql(stub)
+      end
+
+    end
+
+    context "when a stub is not provided" do
+
+      let(:stub_match) { HttpStub::Server::Stub::Match::Match.new(nil, request) }
+
+      it "returns the empty stub" do
+        expect(subject).to eql(HttpStub::Server::Stub::Empty::INSTANCE)
+      end
+
+    end
+
+  end
+
+  describe "#request" do
+
+    it "exposes the provided value" do
+      expect(stub_match.request).to eql(request)
+    end
+
+  end
+
+end

data/spec/lib/http_stub/server/stub/{omitted_value_matcher_spec.rb → match/omitted_value_matcher_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Stub::OmittedValueMatcher do
+describe HttpStub::Server::Stub::Match::OmittedValueMatcher do
 
   describe "::match?" do
 
@@ -50,7 +50,7 @@ describe HttpStub::Server::Stub::OmittedValueMatcher do
     end
 
     def perform_match
-      HttpStub::Server::Stub::OmittedValueMatcher.match?(stub_value, actual_value)
+      HttpStub::Server::Stub::Match::OmittedValueMatcher.match?(stub_value, actual_value)
     end
 
   end

data/spec/lib/http_stub/server/stub/{regexp_value_matcher_spec.rb → match/regexp_value_matcher_spec.rb}

@@ -1,4 +1,4 @@
-describe HttpStub::Server::Stub::RegexpValueMatcher do
+describe HttpStub::Server::Stub::Match::RegexpValueMatcher do
 
   describe "::match?" do
 
@@ -40,7 +40,7 @@ describe HttpStub::Server::Stub::RegexpValueMatcher do
     end
     
     def perform_match
-      HttpStub::Server::Stub::RegexpValueMatcher.match?(stub_value, actual_value)
+      HttpStub::Server::Stub::Match::RegexpValueMatcher.match?(stub_value, actual_value)
     end
 
   end

data/spec/lib/http_stub/server/stub/{request_body_spec.rb → match/rule/body_spec.rb}

@@ -1,22 +1,22 @@
-describe HttpStub::Server::Stub::RequestBody do
+describe HttpStub::Server::Stub::Match::Rule::Body do
 
   describe "::create" do
 
-    subject { HttpStub::Server::Stub::RequestBody.create(stubbed_body) }
+    subject { described_class.create(stubbed_body) }
 
     shared_context "a raw request body that causes a simple request body to be created" do
 
       it "creates a simple request body with the body" do
-        expect(HttpStub::Server::Stub::SimpleRequestBody).to receive(:new).with(stubbed_body)
+        expect(HttpStub::Server::Stub::Match::Rule::SimpleBody).to receive(:new).with(stubbed_body)
 
         subject
       end
 
       it "returns the created request body" do
-        simple_request_body = instance_double(HttpStub::Server::Stub::SimpleRequestBody)
-        allow(HttpStub::Server::Stub::SimpleRequestBody).to receive(:new).and_return(simple_request_body)
+        simple_body = instance_double(HttpStub::Server::Stub::Match::Rule::SimpleBody)
+        allow(HttpStub::Server::Stub::Match::Rule::SimpleBody).to receive(:new).and_return(simple_body)
 
-        expect(subject).to eql(simple_request_body)
+        expect(subject).to eql(simple_body)
       end
 
     end
@@ -31,16 +31,16 @@ describe HttpStub::Server::Stub::RequestBody do
         let(:raw_schema)  { { "type" => "json", "definition" => json_schema } }
 
         it "creates a JSON request body with the schema" do
-          expect(HttpStub::Server::Stub::JsonRequestBody).to receive(:new).with(json_schema)
+          expect(HttpStub::Server::Stub::Match::Rule::JsonBody).to receive(:new).with(json_schema)
 
           subject
         end
 
         it "returns the created request body" do
-          json_request_body = instance_double(HttpStub::Server::Stub::JsonRequestBody)
-          allow(HttpStub::Server::Stub::JsonRequestBody).to receive(:new).and_return(json_request_body)
+          json_body = instance_double(HttpStub::Server::Stub::Match::Rule::JsonBody)
+          allow(HttpStub::Server::Stub::Match::Rule::JsonBody).to receive(:new).and_return(json_body)
 
-          expect(subject).to eql(json_request_body)
+          expect(subject).to eql(json_body)
         end
 
       end
@@ -100,7 +100,7 @@ describe HttpStub::Server::Stub::RequestBody do
       let(:stubbed_body) { "" }
 
       it "returns a truthy request matcher" do
-        expect(subject).to eql(HttpStub::Server::Stub::TruthyRequestMatcher)
+        expect(subject).to eql(HttpStub::Server::Stub::Match::TruthyMatcher)
       end
 
     end
@@ -110,7 +110,7 @@ describe HttpStub::Server::Stub::RequestBody do
       let(:stubbed_body) { nil }
 
       it "returns a truthy request matcher" do
-        expect(subject).to eql(HttpStub::Server::Stub::TruthyRequestMatcher)
+        expect(subject).to eql(HttpStub::Server::Stub::Match::TruthyMatcher)
       end
 
     end