http_stub 0.15.3 → 0.15.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ce903432525a6be7ca09e19d0ab38d4e9a4fdd8
-  data.tar.gz: 5851fd5ffc47448f50e02491b3bb9e32d1097b21
+  metadata.gz: fd0deffefb3609ce28def378afa514c15bf7a0f0
+  data.tar.gz: 2f6ea87666f76d3a454e6b7d422268a76c4169d5
 SHA512:
-  metadata.gz: 267d2f39bd292b6d6e34147bfcef6568adfe6878f27314c2ada04932a26bbd36bbbbd2ab13ed962fb6ef56516f6787b41ac4089f44008b2e9dd03474abbd45ba
-  data.tar.gz: f624649d74f4498a143f03c3475b3b3efea428c4ab0b9bf5f0d6d130e539a4e6880a45228b60f42a9d346881efa303b8f7023611caa2e366248c12ced600415d
+  metadata.gz: 24e93f05fe3cebf14a56239a96bf10cf31d79a94db3dcdbf4699c9eeabdf65e808ebc3361cc7e28cafafd5499da8c1f6e6173e77a6f35b64243b5e08d1503533
+  data.tar.gz: 51e0d3f4b7ceab10f084875e3eed84f8ec83a0035f685e4d29f43366ec649a97e23236fa2df10d5b24f7ad0bb0b9558b36c25311362f59d8bd934cd8f96a3d00

data/lib/http_stub.rb

@@ -11,7 +11,9 @@ require 'active_support/core_ext/module/aliasing'
 require 'active_support/core_ext/module/delegation'
 require 'active_support/core_ext/hash/slice'
 require 'active_support/core_ext/hash/deep_merge'
+require 'active_support/core_ext/hash/indifferent_access'
 
+require_relative 'http_stub/hash_with_indifferent_and_insensitive_access'
 require_relative 'http_stub/extensions/core/hash'
 require_relative 'http_stub/extensions/rack/handler'
 require_relative 'http_stub/server/headers'

data/lib/http_stub/configurer/request/stub_response.rb

@@ -5,32 +5,30 @@ module HttpStub
       class StubResponse
 
         def initialize(id, args)
-          @id   = id
-          @args = args
+          @id               = id
+          @status           = args[:status] || ""
+          @headers          = (args[:headers] || {}).with_indifferent_and_insensitive_access
+          @body             = args[:body]
+          @delay_in_seconds = args[:delay_in_seconds] || ""
         end
 
         def payload
-          {
-            status:           @args[:status] || "",
-            headers:          @args[:headers] || {},
-            body:             @args[:body],
-            delay_in_seconds: @args[:delay_in_seconds] || ""
-          }
+          { status: @status, headers: @headers, body: @body, delay_in_seconds: @delay_in_seconds }
         end
 
         def file
-          if contains_file?
-            args = { id: @id, type: @args[:headers]["content-type"] }.merge(@args[:body][:file])
-            HttpStub::Configurer::Request::StubResponseFile.new(args)
-          else
-            nil
-          end
+          contains_file? ? create_response_file : nil
         end
 
         private
 
         def contains_file?
-          @args[:body].is_a?(Hash) && @args[:body].key?(:file)
+          @body.is_a?(Hash) && @body.key?(:file)
+        end
+
+        def create_response_file
+          args = { id: @id, type: @headers["content-type"] }.merge(@body[:file])
+          HttpStub::Configurer::Request::StubResponseFile.new(args)
         end
 
       end

data/lib/http_stub/extensions/core/hash.rb

@@ -17,6 +17,10 @@ module HttpStub
           end
         end
 
+        def with_indifferent_and_insensitive_access
+          HttpStub::HashWithIndifferentAndInsensitiveAccess.new(self)
+        end
+
       end
 
     end

data/lib/http_stub/hash_with_indifferent_and_insensitive_access.rb

@@ -0,0 +1,18 @@
+module HttpStub
+
+  class HashWithIndifferentAndInsensitiveAccess < HashWithIndifferentAccess
+
+    def [](key)
+      self.key?(key) ? super : insensitive_find(key)
+    end
+
+    private
+
+    def insensitive_find(key)
+      entry = self.find { |entry_key, _entry_value| entry_key.to_s.downcase == key.to_s.downcase }
+      entry ? entry[1] : nil
+    end
+
+  end
+
+end

data/lib/http_stub/version.rb

@@ -1,3 +1,3 @@
 module HttpStub
-  VERSION = "0.15.3".freeze
+  VERSION = "0.15.4".freeze
 end

data/spec/lib/http_stub/configurer/request/stub_response_spec.rb

@@ -6,7 +6,7 @@ describe HttpStub::Configurer::Request::StubResponse do
   let(:stub_response) { HttpStub::Configurer::Request::StubResponse.new(stub_fixture.id, fixture.symbolized) }
 
   describe "#payload" do
-    
+
     subject { stub_response.payload }
 
     context "when a status response argument is provided" do
@@ -75,12 +75,13 @@ describe HttpStub::Configurer::Request::StubResponse do
 
     context "when the body contains a file hash" do
 
-      let(:content_type) { "some-content-type" }
-      let(:file_path)    { "some/file/path" }
-      let(:file_name)    { "some_file.name" }
+      let(:content_type_key)   { "content-type" }
+      let(:content_type_value) { "some-content-type" }
+      let(:file_path)          { "some/file/path" }
+      let(:file_name)          { "some_file.name" }
 
       before(:example) do
-        fixture.headers = { "content-type" => content_type }
+        fixture.headers = { content_type_key => content_type_value }
         fixture.body    = { file: { path: file_path, name: file_name } }
       end
 
@@ -102,10 +103,44 @@ describe HttpStub::Configurer::Request::StubResponse do
         subject
       end
 
-      it "creates a response file whose type is the content-type response header" do
-        expect_response_file_to_be_created_with(type: content_type)
+      context "when the content type header key is provided" do
+
+        context "in lower case" do
+
+          let(:content_type_key) { "content-type" }
+
+          it "creates a response file whose type is the content-type response header" do
+            expect_response_file_to_be_created_with(type: content_type_value)
+
+            subject
+          end
+
+        end
+
+        context "in upper case" do
+
+          let(:content_type_key) { "Content-Type" }
+
+          it "creates a response file whose type is the content-type response header" do
+            expect_response_file_to_be_created_with(type: content_type_value)
+
+            subject
+          end
+
+        end
+
+      end
+
+      context "when the content type header is not provided" do
+
+        let(:content_type_value) { nil }
+
+        it "creates a response file whose type is nil, which allows the server to default the value" do
+          expect_response_file_to_be_created_with(type: nil)
+
+          subject
+        end
 
-        subject
       end
 
       it "returns the created response file" do

data/spec/lib/http_stub/configurer_integration_spec.rb

@@ -665,20 +665,42 @@ describe HttpStub::Configurer, "when the server is running" do
 
     end
 
-    context "and the configurer stubs a response with a file body" do
+    context "and the configurer stubs responses with a file body" do
 
       let(:configurer) { HttpStub::Examples::ConfigurerWithFileResponse.new }
 
       context "and a request that matches is made" do
 
-        let(:response) { HTTParty.get("#{server_uri}/stub_response_with_file") }
+        context "that matches a stub with a custom content-type" do
+
+          let(:response) { HTTParty.get("#{server_uri}/stub_response_with_file") }
+
+          it "responds with the configured status code" do
+            expect(response.code).to eql(200)
+          end
+
+          it "responds with the configured content type" do
+            expect(response.content_type).to eql("application/pdf")
+          end
+
+          it "responds with the configured file" do
+            expect_response_to_contain_file(HttpStub::Examples::ConfigurerWithFileResponse::FILE_PATH)
+          end
 
-        it "responds with the configured status code" do
-          expect(response.code).to eql(200)
         end
 
-        it "responds with the file" do
-          expect_response_to_contain_file(HttpStub::Examples::ConfigurerWithFileResponse::FILE_PATH)
+        context "that matches a stub with no content-type" do
+
+          let(:response) { HTTParty.get("#{server_uri}/stub_response_with_file_and_no_content_type") }
+
+          it "responds with a default content type of 'application/octet-stream'" do
+            expect(response.content_type).to eql("application/octet-stream")
+          end
+
+          it "responds with the configured response" do
+            expect_response_to_contain_file(HttpStub::Examples::ConfigurerWithFileResponse::FILE_PATH)
+          end
+
         end
 
       end

data/spec/lib/http_stub/extensions/core/hash_spec.rb

@@ -154,4 +154,29 @@ describe HttpStub::Extensions::Core::Hash do
 
   end
 
+  describe "#with_indifferent_and_insensitive_access" do
+
+    let(:hash)                             { { key: "value" } }
+    let(:indifferent_and_insensitive_hash) { instance_double(HttpStub::HashWithIndifferentAndInsensitiveAccess) }
+
+    subject { hash.with_indifferent_and_insensitive_access }
+
+    before(:example) do
+      allow(HttpStub::HashWithIndifferentAndInsensitiveAccess).to(
+        receive(:new).and_return(indifferent_and_insensitive_hash)
+      )
+    end
+
+    it "creates a hash with indifferent and insensitive access containing the current hash" do
+      expect(HttpStub::HashWithIndifferentAndInsensitiveAccess).to receive(:new).with(hash)
+
+      subject
+    end
+
+    it "returns the created hash" do
+      expect(subject).to eql(indifferent_and_insensitive_hash)
+    end
+
+  end
+
 end

data/spec/lib/http_stub/hash_with_indifferent_and_insensitive_access_spec.rb

@@ -0,0 +1,179 @@
+describe HttpStub::HashWithIndifferentAndInsensitiveAccess do
+
+  let(:enhanced_hash) { HttpStub::HashWithIndifferentAndInsensitiveAccess.new(original_hash) }
+
+  describe "#[]" do
+
+    subject { enhanced_hash[key] }
+
+    context "when the original hash contains symbol keys" do
+
+      let(:original_hash) { { key: "value", another_key: "another value" } }
+
+      context "and the provided key is a symbol" do
+
+        context "that exactly matches an original hash key" do
+
+          let(:key) { :key }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+          context "and another key is also a case insensitive match" do
+
+            let(:original_hash) { { Key: "Case insensitive value", key: "value" } }
+
+            it "prefers the exact match" do
+              expect(subject).to eql("value")
+            end
+
+          end
+
+        end
+
+        context "that is a case insensitive match for an original hash key" do
+
+          let(:key) { :Key }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "that does not match an entry in the original hash" do
+
+          let(:key) { :does_not_match }
+
+          it "returns nil" do
+            expect(subject).to be(nil)
+          end
+
+        end
+
+      end
+
+      context "and the provided key is a string" do
+
+        context "whose symbol respresentation exactly matches an original hash key" do
+
+          let(:key) { "key" }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "whose symbol representation is a case insensitive match for an original hash key" do
+
+          let(:key) { "Key" }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "that does not match an entry in the original hash" do
+
+          let(:key) { "does not match" }
+
+          it "returns nil" do
+            expect(subject).to be(nil)
+          end
+
+        end
+
+      end
+
+    end
+
+    context "when the original hash string keys" do
+
+      let(:original_hash) { { "key" => "value", "another_key" => "another value" } }
+
+      context "and the provided key is a string" do
+
+        context "that exactly matches an original hash key" do
+
+          let(:key) { "key" }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+          context "and another key is also a case insensitive match" do
+
+            let(:original_hash) { { "Key" => "Case insensitive value", "key" => "value" } }
+
+            it "prefers the exact match" do
+              expect(subject).to eql("value")
+            end
+
+          end
+
+        end
+
+        context "that is a case insensitive match for an original hash key" do
+
+          let(:key) { "Key" }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "that does not match an entry in the original hash" do
+
+          let(:key) { "does not match" }
+
+          it "returns nil" do
+            expect(subject).to be(nil)
+          end
+
+        end
+
+      end
+
+      context "and the provided key is a symbol" do
+
+        context "whose string respresentation exactly matches an original hash key" do
+
+          let(:key) { :key }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "whose string representation is a case insensitive match for an original hash key" do
+
+          let(:key) { :Key }
+
+          it "returns the original value" do
+            expect(subject).to eql("value")
+          end
+
+        end
+
+        context "that does not match an entry in the original hash" do
+
+          let(:key) { :does_not_match }
+
+          it "returns nil" do
+            expect(subject).to be(nil)
+          end
+
+        end
+
+      end
+
+    end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http_stub
 version: !ruby/object:Gem::Version
-  version: 0.15.3
+  version: 0.15.4
 platform: ruby
 authors:
 - Matthew Ueckerman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-20 00:00:00.000000000 Z
+date: 2015-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -278,6 +278,7 @@ files:
 - "./lib/http_stub/configurer/server/request_processor.rb"
 - "./lib/http_stub/extensions/core/hash.rb"
 - "./lib/http_stub/extensions/rack/handler.rb"
+- "./lib/http_stub/hash_with_indifferent_and_insensitive_access.rb"
 - "./lib/http_stub/rake/server_daemon_tasks.rb"
 - "./lib/http_stub/rake/server_tasks.rb"
 - "./lib/http_stub/rake/task_generators.rb"
@@ -336,6 +337,7 @@ files:
 - "./spec/lib/http_stub/configurer_spec.rb"
 - "./spec/lib/http_stub/extensions/core/hash_spec.rb"
 - "./spec/lib/http_stub/extensions/rack/handler_spec.rb"
+- "./spec/lib/http_stub/hash_with_indifferent_and_insensitive_access_spec.rb"
 - "./spec/lib/http_stub/rake/server_daemon_tasks_smoke_spec.rb"
 - "./spec/lib/http_stub/rake/server_tasks_smoke_spec.rb"
 - "./spec/lib/http_stub/rake/server_tasks_spec.rb"
@@ -421,6 +423,7 @@ test_files:
 - "./spec/lib/http_stub/configurer_spec.rb"
 - "./spec/lib/http_stub/extensions/core/hash_spec.rb"
 - "./spec/lib/http_stub/extensions/rack/handler_spec.rb"
+- "./spec/lib/http_stub/hash_with_indifferent_and_insensitive_access_spec.rb"
 - "./spec/lib/http_stub/rake/server_daemon_tasks_smoke_spec.rb"
 - "./spec/lib/http_stub/rake/server_tasks_smoke_spec.rb"
 - "./spec/lib/http_stub/rake/server_tasks_spec.rb"