http_stub 0.13.5 → 0.14.0.rc1

data/spec/lib/http_stub/models/string_value_matcher_spec.rb

@@ -10,38 +10,38 @@ describe HttpStub::Models::StringValueMatcher do
 
     shared_examples_for "a StringValueMatcher that matches an expected stub value" do
 
-      it "should determine if actual value should be omitted" do
-        HttpStub::Models::OmittedValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if actual value should be omitted" do
+        expect(HttpStub::Models::OmittedValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
 
-      it "should determine if the actual value matches a regular expression" do
-        HttpStub::Models::RegexpValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if the actual value matches a regular expression" do
+        expect(HttpStub::Models::RegexpValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
 
-      it "should determine if the actual value exactly matches the stub value" do
-        HttpStub::Models::ExactValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if the actual value exactly matches the stub value" do
+        expect(HttpStub::Models::ExactValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
 
-      it "should determine if actual value should be omitted" do
-        HttpStub::Models::OmittedValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if actual value should be omitted" do
+        expect(HttpStub::Models::OmittedValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
 
-      it "should determine if the actual value matches a regular expression" do
-        HttpStub::Models::RegexpValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if the actual value matches a regular expression" do
+        expect(HttpStub::Models::RegexpValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
 
-      it "should determine if the actual value exactly matches the stub value" do
-        HttpStub::Models::ExactValueMatcher.should_receive(:match?).with(expected_stub_match_value, actual_value)
+      it "determines if the actual value exactly matches the stub value" do
+        expect(HttpStub::Models::ExactValueMatcher).to receive(:match?).with(expected_stub_match_value, actual_value)
 
         perform_match
       end
@@ -68,38 +68,38 @@ describe HttpStub::Models::StringValueMatcher do
 
     context "when an omitted match occurs" do
 
-      before(:each) { HttpStub::Models::OmittedValueMatcher.should_receive(:match?).and_return(true) }
+      before(:example) { expect(HttpStub::Models::OmittedValueMatcher).to receive(:match?).and_return(true) }
 
-      it "should return true" do
-        perform_match.should be_true
+      it "returns true" do
+        expect(perform_match).to be_truthy
       end
 
     end
 
     context "when a regular expression match occurs" do
 
-      before(:each) { HttpStub::Models::RegexpValueMatcher.should_receive(:match?).and_return(true) }
+      before(:example) { expect(HttpStub::Models::RegexpValueMatcher).to receive(:match?).and_return(true) }
 
-      it "should return true" do
-        perform_match.should be_true
+      it "returns true" do
+        expect(perform_match).to be_truthy
       end
 
     end
 
     context "when an exact match occurs" do
 
-      before(:each) { HttpStub::Models::ExactValueMatcher.should_receive(:match?).and_return(true) }
+      before(:example) { expect(HttpStub::Models::ExactValueMatcher).to receive(:match?).and_return(true) }
 
-      it "should return true" do
-        perform_match.should be_true
+      it "returns true" do
+        expect(perform_match).to be_truthy
       end
 
     end
 
     context "when no match occurs" do
 
-      it "should return false" do
-        perform_match.should be_false
+      it "returns false" do
+        expect(perform_match).to be_falsey
       end
 
     end
@@ -112,8 +112,8 @@ describe HttpStub::Models::StringValueMatcher do
 
   describe "#to_s" do
 
-    it "should return the stub value provided" do
-      string_value_matcher.to_s.should eql(stub_value)
+    it "returns the stub value provided" do
+      expect(string_value_matcher.to_s).to eql(stub_value)
     end
 
   end

data/spec/lib/http_stub/models/stub_activator_spec.rb

@@ -6,7 +6,7 @@ describe HttpStub::Models::StubActivator do
   end
   let(:stub_activator) { HttpStub::Models::StubActivator.new(args) }
 
-  before(:each) { HttpStub::Models::Stub.stub(:new).and_return(double(HttpStub::Models::Stub)) }
+  before(:example) { allow(HttpStub::Models::Stub).to receive(:new).and_return(double(HttpStub::Models::Stub)) }
 
   describe "#satisfies?" do
 
@@ -16,8 +16,8 @@ describe HttpStub::Models::StubActivator do
 
       let(:request_path_info) { activation_uri }
 
-      it "should return true" do
-        stub_activator.satisfies?(request).should be_true
+      it "returns true" do
+        expect(stub_activator.satisfies?(request)).to be_truthy
       end
 
     end
@@ -26,8 +26,8 @@ describe HttpStub::Models::StubActivator do
 
       let(:request_path_info) { "#{activation_uri}/with/additional/paths" }
 
-      it "should return false" do
-        stub_activator.satisfies?(request).should be_false
+      it "returns false" do
+        expect(stub_activator.satisfies?(request)).to be_falsey
       end
 
     end
@@ -36,8 +36,8 @@ describe HttpStub::Models::StubActivator do
 
       let(:request_path_info) { "/completely/different/path" }
 
-      it "should return false" do
-        stub_activator.satisfies?(request).should be_false
+      it "returns false" do
+        expect(stub_activator.satisfies?(request)).to be_falsey
       end
 
     end
@@ -46,29 +46,29 @@ describe HttpStub::Models::StubActivator do
 
   describe "#the_stub" do
 
-    it "should return a HttpStub::Models::Stub constructed from the activator's arguments" do
+    it "returns a HttpStub::Models::Stub constructed from the activator's arguments" do
       stub = double(HttpStub::Models::Stub)
-      HttpStub::Models::Stub.should_receive(:new).with(args).and_return(stub)
+      expect(HttpStub::Models::Stub).to receive(:new).with(args).and_return(stub)
 
-      stub_activator.the_stub.should eql(stub)
+      expect(stub_activator.the_stub).to eql(stub)
     end
 
   end
 
   describe "#activation_uri" do
 
-    it "should return the value provided in the request body" do
-      stub_activator.activation_uri.should eql(activation_uri)
+    it "returns the value provided in the request body" do
+      expect(stub_activator.activation_uri).to eql(activation_uri)
     end
 
   end
 
   describe "#to_s" do
 
-    it "should return the string representation of the activation arguments" do
-      args.should_receive(:to_s).and_return("activation args string")
+    it "returns the string representation of the activation arguments" do
+      expect(args).to receive(:to_s).and_return("activation args string")
 
-      stub_activator.to_s.should eql("activation args string")
+      expect(stub_activator.to_s).to eql("activation args string")
     end
 
   end

data/spec/lib/http_stub/models/stub_headers_spec.rb

@@ -5,16 +5,16 @@ describe HttpStub::Models::StubHeaders do
 
   let(:stub_headers) { HttpStub::Models::StubHeaders.new(stubbed_headers) }
 
-  it "should be Headers" do
-    stub_headers.should be_a(HttpStub::Models::Headers)
+  it "is Headers" do
+    expect(stub_headers).to be_a(HttpStub::Models::Headers)
   end
 
   describe "when stubbed headers are provided" do
 
-    it "should create a regexpable representation of the stubbed headers whose keys are downcased and underscored" do
+    it "creates a regexpable representation of the stubbed headers whose keys are downcased and underscored" do
       downcased_and_underscored_hash = { "another_stub_key" => "value" }
-      stubbed_headers.should_receive(:downcase_and_underscore_keys).and_return(downcased_and_underscored_hash)
-      HttpStub::Models::HashWithStringValueMatchers.should_receive(:new).with(downcased_and_underscored_hash)
+      expect(stubbed_headers).to receive(:downcase_and_underscore_keys).and_return(downcased_and_underscored_hash)
+      expect(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).with(downcased_and_underscored_hash)
 
       stub_headers
     end
@@ -25,8 +25,8 @@ describe HttpStub::Models::StubHeaders do
 
     let(:stubbed_headers) { nil }
 
-    it "should create a regexpable representation of an empty hash" do
-      HttpStub::Models::HashWithStringValueMatchers.should_receive(:new).with({})
+    it "creates a regexpable representation of an empty hash" do
+      expect(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).with({})
 
       stub_headers
     end
@@ -38,29 +38,29 @@ describe HttpStub::Models::StubHeaders do
     let(:request_headers) { { "request_key" => "value" } }
     let(:regexpable_stubbed_headers) { double(HttpStub::Models::HashWithStringValueMatchers).as_null_object }
 
-    before(:each) do
-      HttpStub::Models::HashWithStringValueMatchers.stub(:new).and_return(regexpable_stubbed_headers)
-      HttpStub::Models::RequestHeaderParser.stub(:parse).with(request).and_return(request_headers)
+    before(:example) do
+      allow(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).and_return(regexpable_stubbed_headers)
+      allow(HttpStub::Models::RequestHeaderParser).to receive(:parse).with(request).and_return(request_headers)
     end
 
-    it "should parse the requests headers into a hash" do
-      HttpStub::Models::RequestHeaderParser.should_receive(:parse).with(request).and_return(request_headers)
+    it "parses the requests headers into a hash" do
+      expect(HttpStub::Models::RequestHeaderParser).to receive(:parse).with(request).and_return(request_headers)
 
       stub_headers.match?(request)
     end
 
-    it "should downcase and underscore the keys in the request header hash" do
-      request_headers.should_receive(:downcase_and_underscore_keys)
+    it "downcases and underscore the keys in the request header hash" do
+      expect(request_headers).to receive(:downcase_and_underscore_keys)
 
       stub_headers.match?(request)
     end
 
-    it "should delegate to the regexpable representation of the stubbed headers to determine a match" do
+    it "delegates to the regexpable representation of the stubbed headers to determine a match" do
       downcased_and_underscored_hash = { "another_request_key" => "value" }
-      request_headers.stub(:downcase_and_underscore_keys).and_return(downcased_and_underscored_hash)
-      regexpable_stubbed_headers.should_receive(:match?).with(downcased_and_underscored_hash).and_return(true)
+      allow(request_headers).to receive(:downcase_and_underscore_keys).and_return(downcased_and_underscored_hash)
+      expect(regexpable_stubbed_headers).to receive(:match?).with(downcased_and_underscored_hash).and_return(true)
 
-      stub_headers.match?(request).should be_true
+      expect(stub_headers.match?(request)).to be_truthy
     end
 
   end

data/spec/lib/http_stub/models/stub_parameters_spec.rb

@@ -10,8 +10,8 @@ describe HttpStub::Models::StubParameters do
 
   describe "when stubbed parameters are provided" do
 
-    it "should create a regexpable representation of the stubbed parameters" do
-      HttpStub::Models::HashWithStringValueMatchers.should_receive(:new).with(stubbed_parameters)
+    it "creates a regexpable representation of the stubbed parameters" do
+      expect(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).with(stubbed_parameters)
 
       stub_parameters
     end
@@ -22,8 +22,8 @@ describe HttpStub::Models::StubParameters do
 
     let(:stubbed_parameters) { nil }
 
-    it "should create a regexpable representation of an empty hash" do
-      HttpStub::Models::HashWithStringValueMatchers.should_receive(:new).with({})
+    it "creates a regexpable representation of an empty hash" do
+      expect(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).with({})
 
       stub_parameters
     end
@@ -32,11 +32,11 @@ describe HttpStub::Models::StubParameters do
 
   describe "#match?" do
 
-    it "should delegate to the regexpable representation of the stubbed parameters to determine a match" do
-      HttpStub::Models::HashWithStringValueMatchers.stub(:new).and_return(regexpable_stubbed_paremeters)
-      regexpable_stubbed_paremeters.should_receive(:match?).with(request_parameters).and_return(true)
+    it "delegates to the regexpable representation of the stubbed parameters to determine a match" do
+      allow(HttpStub::Models::HashWithStringValueMatchers).to receive(:new).and_return(regexpable_stubbed_paremeters)
+      expect(regexpable_stubbed_paremeters).to receive(:match?).with(request_parameters).and_return(true)
 
-      stub_parameters.match?(request).should be(true)
+      expect(stub_parameters.match?(request)).to be(true)
     end
 
   end
@@ -47,14 +47,14 @@ describe HttpStub::Models::StubParameters do
 
       let(:stubbed_parameters) { { "key1" => "value1", "key2" => "value2", "key3" => "value3" } }
 
-      it "should return a string containing each parameter formatted as a conventional request parameter" do
+      it "returns a string containing each parameter formatted as a conventional request parameter" do
         result = stub_parameters.to_s
 
-        stubbed_parameters.each { |key, value| result.should match(/#{key}=#{value}/) }
+        stubbed_parameters.each { |key, value| expect(result).to match(/#{key}=#{value}/) }
       end
 
-      it "should separate each parameter with the conventional request parameter delimiter" do
-        stub_parameters.to_s.should match(/key\d.value\d\&key\d.value\d\&key\d.value\d/)
+      it "separates each parameter with the conventional request parameter delimiter" do
+        expect(stub_parameters.to_s).to match(/key\d.value\d\&key\d.value\d\&key\d.value\d/)
       end
 
     end
@@ -63,8 +63,8 @@ describe HttpStub::Models::StubParameters do
 
       let(:stubbed_parameters) { {} }
 
-      it "should return an empty string" do
-        stub_parameters.to_s.should eql("")
+      it "returns an empty string" do
+        expect(stub_parameters.to_s).to eql("")
       end
 
     end
@@ -73,8 +73,8 @@ describe HttpStub::Models::StubParameters do
 
       let(:stubbed_parameters) { nil }
 
-      it "should return an empty string" do
-        stub_parameters.to_s.should eql("")
+      it "returns an empty string" do
+        expect(stub_parameters.to_s).to eql("")
       end
 
     end

data/spec/lib/http_stub/models/stub_registry_integration_spec.rb

@@ -0,0 +1,62 @@
+describe HttpStub::Models::StubRegistry, "integrating with real stubs" do
+
+  let(:logger)  { double("Logger").as_null_object }
+  let(:request) { double("HttpRequest", logger: logger) }
+
+  let(:stub_registry) { HttpStub::Models::StubRegistry.new }
+
+  describe "#recall" do
+
+    subject { stub_registry.recall }
+
+    context "when stubs have been added" do
+
+      let(:stubs) do
+        (1..3).map { |i| create_stub(i) }
+      end
+
+      before(:example) do
+        stubs.each { |stub| stub_registry.add(stub, request) }
+      end
+
+      context "and remembered" do
+
+        before(:example) { stub_registry.remember }
+
+        context "and a stub subsequently added" do
+
+          let(:stub_to_add) { create_stub(4) }
+
+          before(:example) { stub_registry.add(stub_to_add, request) }
+
+          it "should restore all known stubs to the remembered state" do
+            subject
+
+            expect(stub_registry.all).not_to include(stub_to_add)
+          end
+
+        end
+
+      end
+
+    end
+
+  end
+
+  def create_stub(number)
+    HttpStub::Models::Stub.new(
+      {
+        "uri" => "/uri#{number}",
+        "method" => "get",
+        "headers" => {"header_key_#{number}" => "header_value_#{number}"},
+        "parameters" => {"parameter_key_#{number}" => "parameter_value_#{number}"},
+        "response" => {
+          "status" => 200 + number,
+          "body" => "Body #{number}"
+        },
+        "triggers" => []
+      }
+    )
+  end
+
+end

data/spec/lib/http_stub/models/stub_registry_spec.rb

@@ -0,0 +1,152 @@
+describe HttpStub::Models::StubRegistry do
+
+  let(:registry)      { instance_double(HttpStub::Models::Registry) }
+
+  let(:stub_registry) { HttpStub::Models::StubRegistry.new }
+
+  before(:example) { allow(HttpStub::Models::Registry).to receive(:new).and_return(registry) }
+
+  describe "#add" do
+
+    let(:stub)    { instance_double(HttpStub::Models::Stub) }
+    let(:request) { double("HttpRequest") }
+
+    it "delegates to an underlying simple registry" do
+      expect(registry).to receive(:add).with(stub, request)
+
+      stub_registry.add(stub, request)
+    end
+
+  end
+
+  describe "#find_for" do
+
+    let(:request) { double("HttpRequest") }
+
+    subject { stub_registry.find_for(request) }
+
+    it "delegates to an underlying simple registry" do
+      expect(registry).to receive(:find_for).with(request)
+
+      subject
+    end
+
+    context "when a stub is found" do
+
+      let(:triggers) { instance_double(HttpStub::Models::StubTriggers) }
+      let(:stub)     { instance_double(HttpStub::Models::Stub, triggers: triggers) }
+
+      before(:example) { allow(registry).to receive(:find_for).and_return(stub) }
+
+      it "should add the stubs triggers to the registry" do
+        expect(triggers).to receive(:add_to).with(stub_registry, request)
+
+        subject
+      end
+
+      it "returns the stub found in the underlying registry" do
+        allow(triggers).to receive(:add_to)
+
+        expect(subject).to eql(stub)
+      end
+
+    end
+
+    context "when a stub is not found" do
+
+      before(:example) { allow(registry).to receive(:find_for).and_return(nil) }
+
+      it "returns the result from the underlying registry" do
+        expect(subject).to eql(nil)
+      end
+
+    end
+
+  end
+
+  describe "#remember" do
+
+    it "copies the underlying registry" do
+      expect(registry).to receive(:copy)
+
+      stub_registry.remember
+    end
+
+  end
+
+  describe "#recall" do
+
+    subject { stub_registry.recall }
+
+    context "when the state of the registry has been remembered" do
+
+      let(:remembered_registry)         { instance_double(HttpStub::Models::Registry) }
+      let(:copy_of_remembered_registry) { instance_double(HttpStub::Models::Registry) }
+
+      before(:example) do
+        allow(registry).to receive(:copy).and_return(remembered_registry)
+        allow(remembered_registry).to receive(:copy).and_return(copy_of_remembered_registry)
+        stub_registry.remember
+      end
+
+      it "copies the remembered registry to ensure subsequent recalls recall the same stubs" do
+        expect(remembered_registry).to receive(:copy)
+
+        subject
+      end
+
+      it "causes subsequent method calls to delegate to the copy" do
+        subject
+
+        expect(copy_of_remembered_registry).to receive(:all)
+        stub_registry.all
+      end
+
+    end
+
+    context "when the state of the registry has not been remembered" do
+
+      it "does not effect subsequent method calls" do
+        subject
+
+        expect(registry).to receive(:all)
+        stub_registry.all
+      end
+
+    end
+
+  end
+
+  describe "#all" do
+
+    let(:stubs) { (1..3).map { instance_double(HttpStub::Models::Stub) } }
+
+    subject { stub_registry.all }
+
+    it "delegates to an underlying simple registry" do
+      expect(registry).to receive(:all)
+
+      subject
+    end
+
+    it "returns the result from the underlying registry" do
+      allow(registry).to receive(:all).and_return(stubs)
+
+      expect(subject).to eql(stubs)
+    end
+
+  end
+
+  describe "#clear" do
+
+    let(:request) { double("HttpRequest") }
+
+    it "delegates to an underlying simple registry" do
+      expect(registry).to receive(:clear).with(request)
+
+      stub_registry.clear(request)
+    end
+
+  end
+
+end