http_logger 0.3.2 → 0.3.3

data/VERSION

@@ -1 +1 @@
-0.3.2
+0.3.3

data/http_logger.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{http_logger}
-  s.version = "0.3.2"
+  s.version = "0.3.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bogdan Gusiev"]
-  s.date = %q{2013-02-13}
+  s.date = %q{2013-02-15}
   s.description = %q{This gem keep an eye on every Net::HTTP library usage and dump all request and response data to the log file}
   s.email = %q{agresso@gmail.com}
   s.extra_rdoc_files = [

data/lib/http_logger.rb

@@ -75,8 +75,9 @@ class HttpLogger
   end
 
   def log_post_put_params(request)
-    if request.is_a?(::Net::HTTP::Post) || request.is_a?(::Net::HTTP::Put)
-      log("#{request.class.to_s.upcase} params", request.body)
+    body = request.body
+    if body && !body.empty? && (request.is_a?(::Net::HTTP::Post) || request.is_a?(::Net::HTTP::Put))
+      log("Request body", truncate_body(body))
     end
   end
 
@@ -91,13 +92,12 @@ class HttpLogger
   end
 
   def log_response_body(body)
-    if body && !body.is_a?(Net::ReadAdapter)
-      if collapse_body_limit && collapse_body_limit > 0 && body.size >= collapse_body_limit
-        body = body[0..1000] + "\n\n<some data truncated>\n\n" + body[(body.size - 1000)..body.size]
-      end
-      log("Response body", body)
-    else
+    if body.is_a?(Net::ReadAdapter)
       log("Response body", "<impossible to log>")
+    else
+      if body && !body.empty?
+        log("Response body", truncate_body(body))
+      end
     end
   end
 
@@ -112,6 +112,17 @@ class HttpLogger
     self.logger && (http.started? || fakeweb)
   end
 
+  def truncate_body(body)
+    if collapse_body_limit && collapse_body_limit > 0 && body && body.size >= collapse_body_limit
+      body_piece_size = collapse_body_limit / 2
+      body[0..body_piece_size] + 
+        "\n\n<some data truncated>\n\n" + 
+        body[(body.size - body_piece_size)..body.size]
+    else
+      body
+    end
+  end
+
 
   def log(message, dump)
     self.logger.debug(format_log_entry(message, dump))

data/spec/http_logger_spec.rb

@@ -15,6 +15,11 @@ describe HttpLogger do
     Net::HTTP.get_response(uri)
   end
 
+  let(:long_body) do
+    "12,Dodo case,dodo@case.com,tech@dodcase.com,single elimination\n" * 50 +
+      "12,Bonobos,bono@bos.com,tech@bonobos.com,double elimination\n" * 50
+  end
+
   subject do
     _context if defined?(_context)
     request
@@ -47,12 +52,23 @@ describe HttpLogger do
   end
 
   describe "post request" do
+    let(:body) {{:a => 'hello', :b => 1}}
     let(:request) do
-      Net::HTTP.post_form(uri, {:a => 'hello', :b => 1})
+      Net::HTTP.post_form(uri, body)
     end
 
-    it {should include("POST params")}
+    it {should include("Request body")}
     it {should include("a=hello&b=1")}
+    context "with too long body" do
+      let(:url) do
+        FakeWeb.register_uri(:post, "http://github.com", :body => long_body)
+        "http://github.com/"
+      end
+      it { should include("12,Dodo case,dodo@case.com,tech@dodcase.com,single elimination\n")}
+      it { should include("<some data truncated>") }
+      it { should include("12,Bonobos,bono@bos.com,tech@bonobos.com,double elimination\n")}
+    end
+
   end
   describe "put request" do
     let(:request) do
@@ -62,19 +78,15 @@ describe HttpLogger do
       http.request(request)
     end
 
+    it {should include("Request body")}
     it {should include("a=hello&b=1")}
-    it {should include("PUT params")}
   end
 
   context "with long response body" do
 
-    let(:body) do
-      "12,Dodo case,dodo@case.com,tech@dodcase.com,single elimination\n" * 50 +
-        "12,Bonobos,bono@bos.com,tech@bonobos.com,double elimination\n" * 50
-    end
 
     let(:url) do
-      FakeWeb.register_uri(:get, "http://github.com", :body => body)
+      FakeWeb.register_uri(:get, "http://github.com", :body => long_body)
       "http://github.com"
     end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: http_logger
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 0
   - 3
-  - 2
-  version: 0.3.2
+  - 3
+  version: 0.3.3
 platform: ruby
 authors: 
 - Bogdan Gusiev
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-02-13 00:00:00 +02:00
+date: 2013-02-15 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency