http 5.3.1 → 6.0.0

data/test/http/features/raise_error_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class HTTPFeaturesRaiseErrorTest < Minitest::Test
+  cover "HTTP::Features::RaiseError*"
+
+  def connection
+    @connection ||= fake
+  end
+
+  def build_response(status:)
+    HTTP::Response.new(
+      version:    "1.1",
+      status:     status,
+      headers:    {},
+      connection: connection,
+      request:    HTTP::Request.new(verb: :get, uri: "https://example.com")
+    )
+  end
+
+  # -- #wrap_response --
+
+  def test_wrap_response_when_status_is_200_returns_original_response
+    feature = HTTP::Features::RaiseError.new(ignore: [])
+    response = build_response(status: 200)
+    result = feature.wrap_response(response)
+
+    assert_same response, result
+  end
+
+  def test_wrap_response_when_status_is_399_returns_original_response
+    feature = HTTP::Features::RaiseError.new(ignore: [])
+    response = build_response(status: 399)
+    result = feature.wrap_response(response)
+
+    assert_same response, result
+  end
+
+  def test_wrap_response_when_status_is_400_raises
+    feature = HTTP::Features::RaiseError.new(ignore: [])
+    response = build_response(status: 400)
+    err = assert_raises(HTTP::StatusError) { feature.wrap_response(response) }
+    assert_equal "Unexpected status code 400", err.message
+  end
+
+  def test_wrap_response_when_status_is_599_raises
+    feature = HTTP::Features::RaiseError.new(ignore: [])
+    response = build_response(status: 599)
+    err = assert_raises(HTTP::StatusError) { feature.wrap_response(response) }
+    assert_equal "Unexpected status code 599", err.message
+  end
+
+  def test_wrap_response_when_error_status_is_ignored_returns_original_response
+    feature = HTTP::Features::RaiseError.new(ignore: [500])
+    response = build_response(status: 500)
+    result = feature.wrap_response(response)
+
+    assert_same response, result
+  end
+
+  # -- #initialize --
+
+  def test_initialize_defaults_ignore_to_empty_array
+    feature = HTTP::Features::RaiseError.new
+    response = HTTP::Response.new(
+      version: "1.1", status: 500, headers: {},
+      connection: connection,
+      request: HTTP::Request.new(verb: :get, uri: "https://example.com")
+    )
+    assert_raises(HTTP::StatusError) { feature.wrap_response(response) }
+  end
+
+  def test_initialize_is_a_feature
+    assert_kind_of HTTP::Feature, HTTP::Features::RaiseError.new
+  end
+end

data/test/http/form_data/composite_io_test.rb

@@ -0,0 +1,215 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class FormDataCompositeIOTest < Minitest::Test
+  cover "HTTP::FormData::CompositeIO*"
+
+  def setup
+    @ios = ["Hello", " ", "", "world", "!"].map { |s| StringIO.new(s) }
+    @composite_io = HTTP::FormData::CompositeIO.new(@ios)
+  end
+
+  def test_accepts_ios_and_strings
+    io = HTTP::FormData::CompositeIO.new(["Hello ", StringIO.new("world!")])
+
+    assert_equal "Hello world!", io.read
+  end
+
+  def test_rejects_invalid_io_types
+    error = assert_raises(ArgumentError) { HTTP::FormData::CompositeIO.new(%i[hello world]) }
+
+    assert_includes error.message, ":hello"
+    assert_includes error.message, "is neither a String nor an IO object"
+  end
+
+  def test_error_message_contains_inspect
+    obj = Object.new
+    def obj.inspect = "INVALID_IO_INSPECT"
+    def obj.to_s = "INVALID_IO_TO_S"
+
+    error = assert_raises(ArgumentError) { HTTP::FormData::CompositeIO.new([obj]) }
+
+    assert_includes error.message, "INVALID_IO_INSPECT"
+  end
+
+  def test_reads_all_data
+    assert_equal "Hello world!", @composite_io.read
+  end
+
+  def test_reads_partial_data
+    assert_equal "Hel", @composite_io.read(3)
+    assert_equal "lo", @composite_io.read(2)
+    assert_equal " ", @composite_io.read(1)
+    assert_equal "world!", @composite_io.read(6)
+  end
+
+  def test_returns_empty_string_when_exhausted_without_length
+    @composite_io.read
+
+    assert_equal "", @composite_io.read
+  end
+
+  def test_returns_nil_when_exhausted_with_length
+    @composite_io.read
+
+    assert_nil @composite_io.read(3)
+  end
+
+  def test_reads_partial_data_with_buffer
+    outbuf = +""
+
+    assert_equal "Hel", @composite_io.read(3, outbuf)
+    assert_equal "lo", @composite_io.read(2, outbuf)
+    assert_equal " ", @composite_io.read(1, outbuf)
+    assert_equal "world!", @composite_io.read(6, outbuf)
+  end
+
+  def test_fills_buffer_with_retrieved_content
+    outbuf = +""
+    @composite_io.read(3, outbuf)
+
+    assert_equal "Hel", outbuf
+    @composite_io.read(2, outbuf)
+
+    assert_equal "lo", outbuf
+    @composite_io.read(1, outbuf)
+
+    assert_equal " ", outbuf
+    @composite_io.read(6, outbuf)
+
+    assert_equal "world!", outbuf
+  end
+
+  def test_clears_buffer_when_exhausted_with_length
+    outbuf = +"content"
+    @composite_io.read
+
+    assert_nil @composite_io.read(3, outbuf)
+    assert_equal "", outbuf
+  end
+
+  def test_returns_binary_encoding
+    io = HTTP::FormData::CompositeIO.new(%w[Janko Marohnić])
+
+    assert_equal Encoding::BINARY, io.read(5).encoding
+    assert_equal Encoding::BINARY, io.read(9).encoding
+
+    io.rewind
+
+    assert_equal Encoding::BINARY, io.read.encoding
+    assert_equal Encoding::BINARY, io.read.encoding
+  end
+
+  def test_reads_data_in_bytes
+    emoji = "😃"
+    io = HTTP::FormData::CompositeIO.new([emoji])
+
+    assert_equal emoji.b[0], io.read(1)
+    assert_equal emoji.b[1], io.read(1)
+    assert_equal emoji.b[2], io.read(1)
+    assert_equal emoji.b[3], io.read(1)
+  end
+
+  def test_rewinds_all_ios
+    @composite_io.read
+    @composite_io.rewind
+
+    assert_equal "Hello world!", @composite_io.read
+  end
+
+  def test_size_returns_sum_of_all_ios
+    assert_equal 12, @composite_io.size
+  end
+
+  def test_size_returns_zero_for_empty
+    assert_equal 0, HTTP::FormData::CompositeIO.new([]).size
+  end
+
+  def test_accepts_string_subclass
+    io = HTTP::FormData::CompositeIO.new([Class.new(String).new("hello")])
+
+    assert_equal "hello", io.read
+  end
+
+  def test_accepts_custom_io_object
+    custom_io = Class.new do
+      def initialize = @done = false
+
+      def read(length = nil, outbuf = nil)
+        if @done
+          length ? nil : ""
+        else
+          @done = true
+          result = +"custom"
+          outbuf ? outbuf.replace(result) : result
+        end
+      end
+
+      def size = 6
+      def rewind = @done = false
+    end.new
+
+    assert_equal "custom", HTTP::FormData::CompositeIO.new([custom_io]).read
+  end
+
+  def test_starts_reading_from_beginning
+    assert_equal "a", HTTP::FormData::CompositeIO.new(%w[abc def]).read(1)
+  end
+
+  def test_reads_across_io_boundaries
+    io = HTTP::FormData::CompositeIO.new(%w[abc def])
+
+    assert_equal "ab", io.read(2)
+    assert_equal "cd", io.read(2)
+    assert_equal "ef", io.read(2)
+  end
+
+  def test_skips_empty_io_in_middle
+    assert_equal "abcd", HTTP::FormData::CompositeIO.new(["ab", "", "cd"]).read
+  end
+
+  def test_respects_length_exactly
+    io = HTTP::FormData::CompositeIO.new(%w[abcdef ghijkl])
+
+    assert_equal "abc", io.read(3)
+    assert_equal "def", io.read(3)
+    assert_equal "ghi", io.read(3)
+    assert_equal "jkl", io.read(3)
+    assert_nil io.read(1)
+  end
+
+  def test_length_spanning_ios
+    io = HTTP::FormData::CompositeIO.new(%w[ab cd ef])
+
+    assert_equal "abcd", io.read(4)
+    assert_equal "ef", io.read(4)
+  end
+
+  def test_read_all_with_outbuf
+    outbuf = +""
+    io = HTTP::FormData::CompositeIO.new(["hello", " ", "world"])
+    result = io.read(nil, outbuf)
+
+    assert_equal "hello world", result
+    assert_equal "hello world", outbuf
+    assert_same result, outbuf
+  end
+
+  def test_read_with_outbuf_clears_previous_content
+    outbuf = +"previous content"
+    io = HTTP::FormData::CompositeIO.new(["new"])
+    io.read(nil, outbuf)
+
+    assert_equal "new", outbuf
+  end
+
+  def test_outbuf_encoding_forced_to_binary
+    outbuf = +"hello"
+    outbuf.force_encoding(Encoding::UTF_8)
+    io = HTTP::FormData::CompositeIO.new(%w[Marohnić])
+    io.read(5, outbuf)
+
+    assert_equal Encoding::BINARY, outbuf.encoding
+  end
+end

data/test/http/form_data/file_test.rb

@@ -0,0 +1,255 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class FormDataFileTest < Minitest::Test
+  cover "HTTP::FormData::File*"
+
+  private
+
+  def fixture_path
+    @fixture_path ||= Pathname.new(__dir__).join("fixtures/the-http-gem.info").realpath
+  end
+
+  def fixture_content
+    @fixture_content ||= fixture_path.read(mode: "rb")
+  end
+
+  # Yields [form_file, label, expected_content] for each IO source type.
+  # Handles closing File IOs in an ensure block.
+  def each_source
+    yield HTTP::FormData::File.new(fixture_path.to_s), "string_path", fixture_content
+    yield HTTP::FormData::File.new(fixture_path), "pathname", fixture_content
+
+    file = fixture_path.open("rb")
+    begin
+      yield HTTP::FormData::File.new(file), "file", fixture_content
+    ensure
+      file.close
+    end
+
+    yield HTTP::FormData::File.new(StringIO.new("привет мир!")), "string_io", "привет мир!"
+  end
+
+  public
+
+  # --- Core Readable behavior across IO sources ---
+
+  def test_size
+    each_source do |form_file, label, content|
+      assert_equal content.bytesize, form_file.size, "size failed for #{label}"
+    end
+  end
+
+  def test_to_s
+    each_source do |form_file, label, content|
+      assert_equal content, form_file.to_s, "to_s failed for #{label}"
+    end
+  end
+
+  def test_to_s_rewinds_content
+    each_source do |form_file, label, _content|
+      content = form_file.read
+
+      assert_equal content, form_file.to_s, "to_s rewind failed for #{label}"
+      assert_equal content, form_file.read, "read after to_s failed for #{label}"
+    end
+  end
+
+  def test_read
+    each_source do |form_file, label, content|
+      assert_equal content, form_file.read, "read failed for #{label}"
+    end
+  end
+
+  def test_rewind
+    each_source do |form_file, label, _content|
+      content = form_file.read
+      form_file.rewind
+
+      assert_equal content, form_file.read, "rewind failed for #{label}"
+    end
+  end
+
+  # --- Filename detection ---
+
+  def test_filename_with_string_path
+    assert_equal "the-http-gem.info", HTTP::FormData::File.new(fixture_path.to_s).filename
+  end
+
+  def test_filename_with_string_path_and_option
+    assert_equal "foobar.txt", HTTP::FormData::File.new(fixture_path.to_s, filename: "foobar.txt").filename
+  end
+
+  def test_filename_with_pathname
+    assert_equal "the-http-gem.info", HTTP::FormData::File.new(fixture_path).filename
+  end
+
+  def test_filename_with_pathname_and_option
+    assert_equal "foobar.txt", HTTP::FormData::File.new(fixture_path, filename: "foobar.txt").filename
+  end
+
+  def test_filename_with_file
+    file = fixture_path.open
+
+    assert_equal "the-http-gem.info", HTTP::FormData::File.new(file).filename
+  ensure
+    file.close
+  end
+
+  def test_filename_with_file_and_option
+    file = fixture_path.open
+
+    assert_equal "foobar.txt", HTTP::FormData::File.new(file, filename: "foobar.txt").filename
+  ensure
+    file.close
+  end
+
+  def test_filename_with_io
+    io = StringIO.new
+
+    assert_equal "stream-#{io.object_id}", HTTP::FormData::File.new(io).filename
+  end
+
+  def test_filename_with_io_and_option
+    assert_equal "foobar.txt", HTTP::FormData::File.new(StringIO.new, filename: "foobar.txt").filename
+  end
+
+  # Kill: ::File.basename(io.path) replaced with ::File.basename(io)
+  def test_filename_for_io_with_path_method
+    io = StringIO.new("data")
+    io.define_singleton_method(:path) { "/some/dir/custom.txt" }
+
+    assert_equal "custom.txt", HTTP::FormData::File.new(io).filename
+  end
+
+  def test_filename_for_io_without_path
+    io = StringIO.new("data")
+    form_file = HTTP::FormData::File.new(io)
+
+    assert_equal "stream-#{io.object_id}", form_file.filename
+    assert_match(/\Astream-\d+\z/, form_file.filename)
+  end
+
+  # --- Content type ---
+
+  def test_content_type_default
+    assert_equal HTTP::FormData::File::DEFAULT_MIME, HTTP::FormData::File.new(StringIO.new).content_type
+  end
+
+  def test_content_type_with_option
+    assert_equal "application/json",
+                 HTTP::FormData::File.new(StringIO.new, content_type: "application/json").content_type
+  end
+
+  def test_content_type_converts_to_string
+    form_file = HTTP::FormData::File.new(StringIO.new("data"), content_type: :json)
+
+    assert_equal "json", form_file.content_type
+    assert_instance_of String, form_file.content_type
+  end
+
+  # --- make_io ---
+
+  def test_make_io_with_string_subclass
+    assert_equal fixture_content, HTTP::FormData::File.new(Class.new(String).new(fixture_path.to_s)).to_s
+  end
+
+  def test_make_io_with_pathname_subclass
+    assert_equal fixture_content, HTTP::FormData::File.new(Class.new(Pathname).new(fixture_path.to_s)).to_s
+  end
+
+  def test_string_path_opens_in_binmode
+    assert_equal Encoding::ASCII_8BIT, HTTP::FormData::File.new(fixture_path.to_s).read.encoding
+  end
+
+  def test_pathname_opens_in_binmode
+    assert_equal Encoding::ASCII_8BIT, HTTP::FormData::File.new(fixture_path).read.encoding
+  end
+
+  # --- initialize edge cases ---
+
+  def test_initialize_with_nil_opts
+    assert_equal "application/octet-stream", HTTP::FormData::File.new(StringIO.new("data"), nil).content_type
+  end
+
+  # --- Readable#read with length/outbuf ---
+
+  def test_read_with_length
+    assert_equal "hello", HTTP::FormData::File.new(StringIO.new("hello world")).read(5)
+  end
+
+  def test_read_with_nil_length
+    assert_equal "hello world", HTTP::FormData::File.new(StringIO.new("hello world")).read(nil)
+  end
+
+  def test_read_with_length_and_outbuf
+    form_file = HTTP::FormData::File.new(StringIO.new("hello world"))
+    outbuf = +""
+    result = form_file.read(5, outbuf)
+
+    assert_equal "hello", result
+    assert_equal "hello", outbuf
+  end
+
+  def test_read_after_eof_returns_nil_with_length
+    form_file = HTTP::FormData::File.new(StringIO.new("hi"))
+    form_file.read
+
+    assert_nil form_file.read(1)
+  end
+
+  def test_read_after_eof_returns_empty_string_without_length
+    form_file = HTTP::FormData::File.new(StringIO.new("hi"))
+    form_file.read
+
+    assert_equal "", form_file.read
+  end
+
+  # --- File#close ---
+
+  def test_close_with_string_path_closes_io
+    form_file = HTTP::FormData::File.new(fixture_path.to_s)
+    form_file.read
+    form_file.close
+
+    assert_raises(IOError) { form_file.read }
+  end
+
+  def test_close_with_pathname_closes_io
+    form_file = HTTP::FormData::File.new(fixture_path)
+    form_file.read
+    form_file.close
+
+    assert_raises(IOError) { form_file.read }
+  end
+
+  def test_close_with_io_does_not_close
+    io = StringIO.new("hello")
+    HTTP::FormData::File.new(io).close
+
+    assert_equal "hello", io.read
+  end
+
+  def test_close_is_idempotent
+    form_file = HTTP::FormData::File.new(fixture_path.to_s)
+    form_file.close
+    form_file.close
+  end
+
+  def test_close_with_string_subclass_closes_io
+    form_file = HTTP::FormData::File.new(Class.new(String).new(fixture_path.to_s))
+    form_file.read
+    form_file.close
+
+    assert_raises(IOError) { form_file.read }
+  end
+
+  def test_close_with_pathname_subclass_closes_io
+    form_file = HTTP::FormData::File.new(Class.new(Pathname).new(fixture_path.to_s))
+    form_file.read
+    form_file.close
+
+    assert_raises(IOError) { form_file.read }
+  end
+end

data/test/http/form_data/fixtures/the-http-gem.info

@@ -0,0 +1 @@
+The HTTP Gem is an easy-to-use client library for making requests from Ruby.