RubyGems - http - Versions diffs - 4.4.1 → 5.0.1 - Mend

http 4.4.1 → 5.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (68) hide show

checksums.yaml +4 -4
data/.github/workflows/ci.yml +65 -0
data/.gitignore +6 -10
data/.rspec +0 -4
data/.rubocop.yml +8 -110
data/.rubocop/layout.yml +8 -0
data/.rubocop/style.yml +32 -0
data/.rubocop_todo.yml +192 -0
data/.yardopts +1 -1
data/CHANGES.md +112 -3
data/Gemfile +18 -10
data/LICENSE.txt +1 -1
data/README.md +17 -20
data/Rakefile +2 -10
data/http.gemspec +3 -3
data/lib/http/chainable.rb +23 -17
data/lib/http/client.rb +36 -30
data/lib/http/connection.rb +11 -7
data/lib/http/content_type.rb +12 -7
data/lib/http/feature.rb +3 -1
data/lib/http/features/auto_deflate.rb +6 -6
data/lib/http/features/auto_inflate.rb +6 -5
data/lib/http/features/instrumentation.rb +1 -1
data/lib/http/features/logging.rb +19 -21
data/lib/http/headers.rb +50 -13
data/lib/http/mime_type/adapter.rb +3 -1
data/lib/http/mime_type/json.rb +1 -0
data/lib/http/options.rb +5 -8
data/lib/http/redirector.rb +2 -1
data/lib/http/request.rb +28 -11
data/lib/http/request/body.rb +1 -0
data/lib/http/request/writer.rb +3 -2
data/lib/http/response.rb +17 -15
data/lib/http/response/body.rb +2 -2
data/lib/http/response/inflater.rb +1 -1
data/lib/http/response/parser.rb +74 -62
data/lib/http/response/status.rb +4 -3
data/lib/http/timeout/global.rb +17 -31
data/lib/http/timeout/null.rb +2 -1
data/lib/http/timeout/per_operation.rb +31 -54
data/lib/http/uri.rb +5 -5
data/lib/http/version.rb +1 -1
data/spec/lib/http/client_spec.rb +119 -30
data/spec/lib/http/connection_spec.rb +8 -5
data/spec/lib/http/features/auto_inflate_spec.rb +4 -2
data/spec/lib/http/features/instrumentation_spec.rb +28 -21
data/spec/lib/http/features/logging_spec.rb +8 -9
data/spec/lib/http/headers_spec.rb +53 -18
data/spec/lib/http/options/headers_spec.rb +1 -1
data/spec/lib/http/options/merge_spec.rb +16 -16
data/spec/lib/http/redirector_spec.rb +46 -1
data/spec/lib/http/request/writer_spec.rb +13 -1
data/spec/lib/http/request_spec.rb +5 -5
data/spec/lib/http/response/parser_spec.rb +33 -4
data/spec/lib/http/response/status_spec.rb +3 -3
data/spec/lib/http/response_spec.rb +5 -3
data/spec/lib/http_spec.rb +30 -3
data/spec/spec_helper.rb +21 -21
data/spec/support/black_hole.rb +1 -1
data/spec/support/dummy_server.rb +7 -7
data/spec/support/dummy_server/servlet.rb +17 -6
data/spec/support/fuubar.rb +21 -0
data/spec/support/http_handling_shared.rb +4 -4
data/spec/support/simplecov.rb +19 -0
data/spec/support/ssl_helper.rb +4 -4
metadata +18 -12
data/.coveralls.yml +0 -1
data/.travis.yml +0 -39

data/spec/lib/http/response/status_spec.rb CHANGED Viewed

@@ -26,7 +26,7 @@ RSpec.describe HTTP::Response::Status do
     end
     described_class::REASONS.each do |code, reason|
-      class_eval <<-RUBY
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
         context 'with well-known code: #{code}' do
           let(:code) { #{code} }
           it { is_expected.to eq #{reason.inspect} }
@@ -165,7 +165,7 @@ RSpec.describe HTTP::Response::Status do
     end
     described_class::SYMBOLS.each do |code, symbol|
-      class_eval <<-RUBY
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
         context 'with well-known code: #{code}' do
           let(:code) { #{code} }
           it { is_expected.to be #{symbol.inspect} }
@@ -193,7 +193,7 @@ RSpec.describe HTTP::Response::Status do
   end
   described_class::SYMBOLS.each do |code, symbol|
-    class_eval <<-RUBY
+    class_eval <<-RUBY, __FILE__, __LINE__ + 1
       describe '##{symbol}?' do
         subject { status.#{symbol}? }

data/spec/lib/http/response_spec.rb CHANGED Viewed

@@ -11,7 +11,8 @@ RSpec.describe HTTP::Response do
       :version => "1.1",
       :headers => headers,
       :body    => body,
-      :uri     => uri
+      :uri     => uri,
+      :request => HTTP::Request.new(:verb => :get, :uri => "http://example.com")
     )
   end
@@ -109,7 +110,7 @@ RSpec.describe HTTP::Response do
         expect(response.parse("application/json")).to eq "foo" => "bar"
       end
-      it "supports MIME type aliases" do
+      it "supports mime type aliases" do
         expect(response.parse(:json)).to eq "foo" => "bar"
       end
     end
@@ -165,7 +166,8 @@ RSpec.describe HTTP::Response do
       HTTP::Response.new(
         :version    => "1.1",
         :status     => 200,
-        :connection => connection
+        :connection => connection,
+        :request    => HTTP::Request.new(:verb => :get, :uri => "http://example.com")
       )
     end

data/spec/lib/http_spec.rb CHANGED Viewed

@@ -1,5 +1,5 @@
-# frozen_string_literal: true
 # encoding: utf-8
+# frozen_string_literal: true
 require "json"
@@ -95,7 +95,8 @@ RSpec.describe HTTP do
         expect(response.to_s).to match(/<!doctype html>/)
       end
-      context "ssl" do
+      # TODO: htt:s://github.com/httprb/http/issues/627
+      xcontext "ssl" do
         it "responds with the endpoint's body" do
           response = ssl_client.via(proxy.addr, proxy.port).get dummy_ssl.endpoint
           expect(response.to_s).to match(/<!doctype html>/)
@@ -131,7 +132,8 @@ RSpec.describe HTTP do
         expect(response.status).to eq(407)
       end
-      context "ssl" do
+      # TODO: htt:s://github.com/httprb/http/issues/627
+      xcontext "ssl" do
         it "responds with the endpoint's body" do
           response = ssl_client.via(proxy.addr, proxy.port, "username", "password").get dummy_ssl.endpoint
           expect(response.to_s).to match(/<!doctype html>/)
@@ -307,6 +309,15 @@ RSpec.describe HTTP do
       end
     end
+    context "specifying per operation timeouts as frozen hash" do
+      let(:frozen_options) { {:read => 123}.freeze }
+      subject(:client) { HTTP.timeout(frozen_options) }
+      it "does not raise an error" do
+        expect { client }.not_to raise_error
+      end
+    end
     context "specifying a global timeout" do
       subject(:client) { HTTP.timeout 123 }
@@ -429,6 +440,22 @@ RSpec.describe HTTP do
         expect(response.to_s).to eq("#{body}-deflated")
       end
+      it "returns empty body for no content response where Content-Encoding is gzip" do
+        client   = HTTP.use(:auto_inflate).headers("Accept-Encoding" => "gzip")
+        body     = "Hello!"
+        response = client.post("#{dummy.endpoint}/no-content-204", :body => body)
+        expect(response.to_s).to eq("")
+      end
+      it "returns empty body for no content response where Content-Encoding is deflate" do
+        client   = HTTP.use(:auto_inflate).headers("Accept-Encoding" => "deflate")
+        body     = "Hello!"
+        response = client.post("#{dummy.endpoint}/no-content-204", :body => body)
+        expect(response.to_s).to eq("")
+      end
     end
     context "with :normalize_uri" do

data/spec/spec_helper.rb CHANGED Viewed

@@ -1,19 +1,7 @@
 # frozen_string_literal: true
-require "simplecov"
-require "coveralls"
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
-  [
-    SimpleCov::Formatter::HTMLFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-)
-SimpleCov.start do
-  add_filter "/spec/"
-  minimum_coverage 80
-end
+require_relative "./support/simplecov"
+require_relative "./support/fuubar" unless ENV["CI"]
 require "http"
 require "rspec/its"
@@ -40,6 +28,13 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
   # These two settings work together to allow you to limit a spec run
   # to individual examples or groups you care about by tagging them with
   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
@@ -48,17 +43,22 @@ RSpec.configure do |config|
   config.filter_run_excluding :flaky if defined?(JRUBY_VERSION) && ENV["CI"]
   config.run_all_when_everything_filtered = true
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
   # This setting enables warnings. It's recommended, but in some cases may
   # be too noisy due to issues in dependencies.
   config.warnings = 0 == ENV["GUARD_RSPEC"].to_i
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
   # Many RSpec users commonly either run the entire suite or an individual
   # file, and it's useful to allow more verbose output when running an
   # individual spec file.

data/spec/support/black_hole.rb CHANGED Viewed

@@ -2,7 +2,7 @@
 module BlackHole
   class << self
-    def method_missing(*) # rubocop: disable Style/MethodMissing
+    def method_missing(*)
       self
     end

data/spec/support/dummy_server.rb CHANGED Viewed

@@ -13,18 +13,18 @@ class DummyServer < WEBrick::HTTPServer
   include ServerConfig
   CONFIG = {
-    :BindAddress  => "127.0.0.1",
-    :Port         => 0,
-    :AccessLog    => BlackHole,
-    :Logger       => BlackHole
+    :BindAddress => "127.0.0.1",
+    :Port        => 0,
+    :AccessLog   => BlackHole,
+    :Logger      => BlackHole
   }.freeze
   SSL_CONFIG = CONFIG.merge(
-    :SSLEnable            => true,
-    :SSLStartImmediately  => true
+    :SSLEnable           => true,
+    :SSLStartImmediately => true
   ).freeze
-  def initialize(options = {}) # rubocop:disable Style/OptionHash
+  def initialize(options = {})
     super(options[:ssl] ? SSL_CONFIG : CONFIG)
     mount("/", Servlet)
   end

data/spec/support/dummy_server/servlet.rb CHANGED Viewed

@@ -1,9 +1,8 @@
-# frozen_string_literal: true
 # encoding: UTF-8
+# frozen_string_literal: true
 class DummyServer < WEBrick::HTTPServer
-  # rubocop:disable Metrics/ClassLength
-  class Servlet < WEBrick::HTTPServlet::AbstractServlet
+  class Servlet < WEBrick::HTTPServlet::AbstractServlet # rubocop:disable Metrics/ClassLength
     def self.sockets
       @sockets ||= []
     end
@@ -18,7 +17,7 @@ class DummyServer < WEBrick::HTTPServer
     end
     %w[get post head].each do |method|
-      class_eval <<-RUBY, __FILE__, __LINE__
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
         def self.#{method}(path, &block)
           handlers["#{method}:\#{path}"] = block
         end
@@ -157,7 +156,7 @@ class DummyServer < WEBrick::HTTPServer
       res.status = 200
       res.body = case req["Accept-Encoding"]
-                 when "gzip" then
+                 when "gzip"
                    res["Content-Encoding"] = "gzip"
                    StringIO.open do |out|
                      Zlib::GzipWriter.wrap(out) do |gz|
@@ -166,12 +165,24 @@ class DummyServer < WEBrick::HTTPServer
                        out.tap(&:rewind).read
                      end
                    end
-                 when "deflate" then
+                 when "deflate"
                    res["Content-Encoding"] = "deflate"
                    Zlib::Deflate.deflate("#{req.body}-deflated")
                  else
                    "#{req.body}-raw"
                  end
     end
+    post "/no-content-204" do |req, res|
+      res.status = 204
+      res.body   = ""
+      case req["Accept-Encoding"]
+      when "gzip"
+        res["Content-Encoding"] = "gzip"
+      when "deflate"
+        res["Content-Encoding"] = "deflate"
+      end
+    end
   end
 end

data/spec/support/fuubar.rb ADDED Viewed

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+require "fuubar"
+RSpec.configure do |config|
+  # Use Fuubar instafail-alike formatter, unless a formatter has already been
+  # configured (e.g. via a command-line flag).
+  config.default_formatter = "Fuubar"
+  # Disable auto-refresh of the fuubar progress bar to avoid surprises during
+  # debugiing. And simply because there's next to absolutely no point in having
+  # this turned on.
+  #
+  # > By default fuubar will automatically refresh the bar (and therefore
+  # > the ETA) every second. Unfortunately this doesn't play well with things
+  # > like debuggers. When you're debugging, having a bar show up every second
+  # > is undesireable.
+  #
+  # See: https://github.com/thekompanee/fuubar#disabling-auto-refresh
+  config.fuubar_auto_refresh = false
+end

data/spec/support/http_handling_shared.rb CHANGED Viewed

@@ -14,11 +14,11 @@ RSpec.shared_context "HTTP handling" do
     let(:options) do
       {
-        :timeout_class => HTTP::Timeout::PerOperation,
+        :timeout_class   => HTTP::Timeout::PerOperation,
         :timeout_options => {
           :connect_timeout => conn_timeout,
-          :read_timeout => read_timeout,
-          :write_timeout => write_timeout
+          :read_timeout    => read_timeout,
+          :write_timeout   => write_timeout
         }
       }
     end
@@ -62,7 +62,7 @@ RSpec.shared_context "HTTP handling" do
   context "with a global timeout" do
     let(:options) do
       {
-        :timeout_class => HTTP::Timeout::Global,
+        :timeout_class   => HTTP::Timeout::Global,
         :timeout_options => {
           :global_timeout => global_timeout
         }

data/spec/support/simplecov.rb ADDED Viewed

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+require "simplecov"
+if ENV["CI"]
+  require "simplecov-lcov"
+  SimpleCov::Formatter::LcovFormatter.config do |config|
+    config.report_with_single_file = true
+    config.lcov_file_name          = "lcov.info"
+  end
+  SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter
+end
+SimpleCov.start do
+  add_filter "/spec/"
+  minimum_coverage 80
+end

data/spec/support/ssl_helper.rb CHANGED Viewed

@@ -5,7 +5,7 @@ require "pathname"
 require "certificate_authority"
 module SSLHelper
-  CERTS_PATH = Pathname.new File.expand_path("../../../tmp/certs", __FILE__)
+  CERTS_PATH = Pathname.new File.expand_path("../../tmp/certs", __dir__)
   class RootCertificate < ::CertificateAuthority::Certificate
     EXTENSIONS = {"keyUsage" => {"usage" => %w[critical keyCertSign]}}.freeze
@@ -83,14 +83,14 @@ module SSLHelper
     def client_params
       {
-        :key => client_cert.key,
-        :cert => client_cert.cert,
+        :key     => client_cert.key,
+        :cert    => client_cert.cert,
         :ca_file => ca.file
       }
     end
     %w[server client].each do |side|
-      class_eval <<-RUBY, __FILE__, __LINE__
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
         def #{side}_cert
           @#{side}_cert ||= ChildCertificate.new ca
         end

metadata CHANGED Viewed

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: http
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 5.0.1
 platform: ruby
 authors:
 - Tony Arcieri
 - Erik Michaels-Ober
 - Alexey V. Zapparov
 - Zachary Anker
-autorequire:
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-29 00:00:00.000000000 Z
+date: 2021-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -56,19 +56,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.2'
 - !ruby/object:Gem::Dependency
-  name: http-parser
+  name: llhttp-ffi
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -91,11 +91,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop/layout.yml"
+- ".rubocop/style.yml"
+- ".rubocop_todo.yml"
 - ".yardopts"
 - CHANGES.md
 - CONTRIBUTING.md
@@ -175,10 +177,12 @@ files:
 - spec/support/dummy_server.rb
 - spec/support/dummy_server/servlet.rb
 - spec/support/fakeio.rb
+- spec/support/fuubar.rb
 - spec/support/http_handling_shared.rb
 - spec/support/proxy_server.rb
 - spec/support/servers/config.rb
 - spec/support/servers/runner.rb
+- spec/support/simplecov.rb
 - spec/support/ssl_helper.rb
 homepage: https://github.com/httprb/http
 licenses:
@@ -187,8 +191,8 @@ metadata:
   source_code_uri: https://github.com/httprb/http
   wiki_uri: https://github.com/httprb/http/wiki
   bug_tracker_uri: https://github.com/httprb/http/issues
-  changelog_uri: https://github.com/httprb/http/blob/v4.4.1/CHANGES.md
-post_install_message:
+  changelog_uri: https://github.com/httprb/http/blob/v5.0.1/CHANGES.md
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -196,7 +200,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -204,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key:
+signing_key:
 specification_version: 4
 summary: HTTP should be easy
 test_files:
@@ -243,8 +247,10 @@ test_files:
 - spec/support/dummy_server.rb
 - spec/support/dummy_server/servlet.rb
 - spec/support/fakeio.rb
+- spec/support/fuubar.rb
 - spec/support/http_handling_shared.rb
 - spec/support/proxy_server.rb
 - spec/support/servers/config.rb
 - spec/support/servers/runner.rb
+- spec/support/simplecov.rb
 - spec/support/ssl_helper.rb