http 4.4.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cce9a8685f3b60f994e77174f79c2306f607d62016bf64b74fcebc4f86377ec0
-  data.tar.gz: 353702b62a1b9d3b2ea86ac5ac3ad88e9efa734c77e180128fa06c6c301895d3
+  metadata.gz: cc5c5ebaa25630442cf182d6cc9925d112dccbfeb4030f07951cfaad72f35bde
+  data.tar.gz: bdb8d0148f8fd0cdb3634ab743db153a998bfa8f8be28295bb8d95bae5833d68
 SHA512:
-  metadata.gz: 84ddc4cf98e603d175a9ecb8db03abd32187888070abd96a437c4121750ac2b86b6cada5d00d527b398ff4a403c2b6448d45bed61c45dbd3be8658f4ad38b121
-  data.tar.gz: 750edced9ae715483d750f0b18777f84a4ee24848ec761c67d2c5b89d00ebbc99fbc1e02932d3d30a33eaea43e1d081ba97bcacaf2231f6693e50d218ee24e87
+  metadata.gz: d74104f964a90c0d0689df9f5af8082fcd5d4902dfa46bf9bdc22ed1a2a86d48211c29fd42b20c037afee958f89ef1f5e7d442285083f169852ccf31bd522818
+  data.tar.gz: 6bac3882bc504513b6a05eb7facf5823b4f46ea55a737933b75305a336b23a97a21914f77378f8a67d7ab262a3b16ec46c592f224036491254f1bb0363e3d294

data/.github/workflows/ci.yml

@@ -0,0 +1,65 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+env:
+  BUNDLE_WITHOUT: "development"
+  JRUBY_OPTS: "--dev --debug"
+
+jobs:
+  test:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        ruby: [ ruby-2.5, ruby-2.6, ruby-2.7, ruby-3.0 ]
+        os: [ ubuntu-latest ]
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: bundle exec rspec
+        run: bundle exec rspec --format progress --force-colour
+
+      - name: Prepare Coveralls test coverage report
+        uses: coverallsapp/github-action@v1.1.2
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          flag-name: "${{ matrix.ruby }} @${{ matrix.os }}"
+          path-to-lcov: ./coverage/lcov/lcov.info
+          parallel: true
+
+  coveralls:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Finalize Coveralls test coverage report
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          parallel-finished: true
+
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.5
+          bundler-cache: true
+
+      - name: bundle exec rubocop
+        run: bundle exec rubocop --format progress --color
+
+      - run: bundle exec rake verify_measurements

data/.gitignore

@@ -1,19 +1,15 @@
 *.gem
-.bundle
 .config
 .rvmrc
-.ruby-version
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
-coverage
+
+.bundle
+.ruby-version
 doc
-lib/bundler/man
-measurement
+coverage
 pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
+spec/examples.txt
 tmp
+Gemfile.lock

data/.rspec

@@ -1,5 +1 @@
---backtrace
---color
---format=documentation
---order random
 --require spec_helper

data/.rubocop/layout.yml

@@ -0,0 +1,8 @@
+Layout/DotPosition:
+  Enabled: true
+  EnforcedStyle: leading
+
+Layout/HashAlignment:
+  Enabled: true
+  EnforcedColonStyle: table
+  EnforcedHashRocketStyle: table

data/.rubocop/style.yml

@@ -0,0 +1,32 @@
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*.rb'
+
+Style/FormatStringToken:
+  Enabled: true
+  EnforcedStyle: unannotated
+
+Style/HashSyntax:
+  Enabled: true
+  EnforcedStyle: hash_rockets
+
+Style/OptionHash:
+  Enabled: true
+
+Style/RescueStandardError:
+  Enabled: true
+  EnforcedStyle: implicit
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/WordArray:
+  Enabled: true
+
+Style/YodaCondition:
+  Enabled: false

data/.rubocop.yml

@@ -1,112 +1,10 @@
+inherit_from:
+  - .rubocop_todo.yml
+  - .rubocop/layout.yml
+  - .rubocop/style.yml
+
 AllCops:
-  TargetRubyVersion: 2.3
+  DefaultFormatter: fuubar
   DisplayCopNames: true
-
-## Layout ######################################################################
-
-Layout/DotPosition:
-  EnforcedStyle: trailing
-
-Layout/SpaceAroundOperators:
-  AllowForAlignment: true
-
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-## Metrics #####################################################################
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-    - "spec/**/*"
-    - "**/*.gemspec"
-
-Metrics/BlockNesting:
-  Max: 2
-
-Metrics/ClassLength:
-  CountComments: false
-  Max: 125
-
-# TODO: Lower to 6
-Metrics/CyclomaticComplexity:
-  Max: 8
-
-Metrics/PerceivedComplexity:
-  Max: 8
-
-# TODO: Lower to 80
-Metrics/LineLength:
-  AllowURI: true
-  Max: 143
-
-# TODO: Lower to 15
-Metrics/MethodLength:
-  CountComments: false
-  Max: 25
-
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 120
-
-Metrics/ParameterLists:
-  Max: 5
-  CountKeywordArgs: true
-
-## Performance #################################################################
-
-# XXX: requires ruby 2.4+
-Performance/RegexpMatch:
-  Enabled: false
-
-## Style #######################################################################
-
-Style/CollectionMethods:
-  PreferredMethods:
-    collect:  'map'
-    reduce:   'inject'
-    find:     'detect'
-    find_all: 'select'
-
-Style/Documentation:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/EachWithObject:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
-Style/EmptyCaseCondition:
-  Enabled: false
-
-# XXX: Lots of times it suggests making code terrible to read.
-Style/GuardClause:
-  Enabled: false
-
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-
-Style/Lambda:
-  Enabled: false
-
-Style/OptionHash:
-  Enabled: true
-
-# XXX: requires ruby 2.3+
-Style/SafeNavigation:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/YodaCondition:
-  Enabled: false
+  NewCops: enable
+  TargetRubyVersion: 2.5

data/.rubocop_todo.yml

@@ -0,0 +1,192 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 42`
+# on 2021-04-10 09:49:03 UTC using RuboCop version 1.12.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 53
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: leading, trailing
+Layout/DotPosition:
+  Exclude:
+    - 'lib/http/options.rb'
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/features/auto_deflate_spec.rb'
+    - 'spec/lib/http/headers_spec.rb'
+    - 'spec/lib/http/options/features_spec.rb'
+    - 'spec/lib/http/redirector_spec.rb'
+    - 'spec/lib/http/response/body_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/http_handling_shared.rb'
+
+# Offense count: 174
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/features/auto_inflate_spec.rb'
+    - 'spec/lib/http/features/instrumentation_spec.rb'
+    - 'spec/lib/http/features/logging_spec.rb'
+    - 'spec/lib/http/headers_spec.rb'
+    - 'spec/lib/http/options/features_spec.rb'
+    - 'spec/lib/http/options/merge_spec.rb'
+    - 'spec/lib/http/options/new_spec.rb'
+    - 'spec/lib/http/redirector_spec.rb'
+    - 'spec/lib/http/request_spec.rb'
+    - 'spec/lib/http/response_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/dummy_server/servlet.rb'
+    - 'spec/support/http_handling_shared.rb'
+    - 'spec/support/ssl_helper.rb'
+
+# Offense count: 4
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/features/instrumentation.rb'
+    - 'lib/http/features/logging.rb'
+    - 'lib/http/features/normalize_uri.rb'
+
+# Offense count: 8
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max.
+Metrics/AbcSize:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/request.rb'
+    - 'lib/http/response.rb'
+
+# Offense count: 66
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Exclude:
+    - '**/*.gemspec'
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/connection_spec.rb'
+    - 'spec/lib/http/content_type_spec.rb'
+    - 'spec/lib/http/features/auto_deflate_spec.rb'
+    - 'spec/lib/http/features/auto_inflate_spec.rb'
+    - 'spec/lib/http/features/instrumentation_spec.rb'
+    - 'spec/lib/http/features/logging_spec.rb'
+    - 'spec/lib/http/headers/mixin_spec.rb'
+    - 'spec/lib/http/headers_spec.rb'
+    - 'spec/lib/http/options/merge_spec.rb'
+    - 'spec/lib/http/redirector_spec.rb'
+    - 'spec/lib/http/request/body_spec.rb'
+    - 'spec/lib/http/request/writer_spec.rb'
+    - 'spec/lib/http/request_spec.rb'
+    - 'spec/lib/http/response/body_spec.rb'
+    - 'spec/lib/http/response/parser_spec.rb'
+    - 'spec/lib/http/response/status_spec.rb'
+    - 'spec/lib/http/response_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/http_handling_shared.rb'
+
+# Offense count: 4
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ClassLength:
+  Exclude:
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/request.rb'
+
+# Offense count: 2
+# Configuration parameters: IgnoredMethods, Max.
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+
+# Offense count: 19
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods.
+Metrics/MethodLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/features/auto_inflate.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/request.rb'
+    - 'lib/http/response.rb'
+    - 'lib/http/response/body.rb'
+    - 'lib/http/timeout/global.rb'
+
+# Offense count: 1
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ModuleLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/http/request.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/EmptyCaseCondition:
+  Exclude:
+    - 'lib/http/client.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/response/status.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/request/writer_spec.rb'
+    - 'spec/lib/http/request_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/dummy_server/servlet.rb'
+
+# Offense count: 17
+# Configuration parameters: SuspiciousParamNames.
+# SuspiciousParamNames: options, opts, args, params, parameters
+Style/OptionHash:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/feature.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/timeout/null.rb'
+    - 'spec/support/dummy_server.rb'
+
+# Offense count: 4
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/http/timeout/global.rb'
+    - 'lib/http/timeout/null.rb'
+    - 'lib/http/timeout/per_operation.rb'
+    - 'lib/http/uri.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'spec/lib/http/options/proxy_spec.rb'

data/.yardopts

@@ -1,2 +1,2 @@
---markup-provider=redcarpet
+--markup-provider=kramdown
 --markup=markdown

data/CHANGES.md

@@ -1,9 +1,85 @@
-## 4.4.1 (2020-03-29)
+## 5.0.0 (2021-05-12)
 
-* Backport [#590](https://github.com/httprb/http/pull/590)
-  Fix parser failing on some edge cases.
+* [#656](https://github.com/httprb/http/pull/656)
+  Handle connection timeouts in `Features`
+  ([@semenyukdmitry])
+
+* [#651](https://github.com/httprb/http/pull/651)
+  Replace `http-parser` with `llhttp`
+  ([@bryanp])
+
+* [#647](https://github.com/httprb/http/pull/647)
+  Add support for `MKCALENDAR` HTTP verb
+  ([@meanphil])
+
+* [#632](https://github.com/httprb/http/pull/632)
+  Respect the SSL context's `verify_hostname` value
+  ([@colemannugent])
+
+* [#625](https://github.com/httprb/http/pull/625)
+  Fix inflator with empty responses
+  ([@LukaszMaslej])
+
+* [#599](https://github.com/httprb/http/pull/599)
+  Allow passing `HTTP::FormData::{Multipart,UrlEncoded}` object directly.
+  ([@ixti])
+
+* [#593](https://github.com/httprb/http/pull/593)
+  [#592](https://github.com/httprb/http/issues/592)
+  Support informational (1XX) responses.
+  ([@ixti])
+
+* [#590](https://github.com/httprb/http/pull/590)
+  [#589](https://github.com/httprb/http/issues/589)
+  Fix response headers paring.
+  ([@Bonias])
+
+* [#587](https://github.com/httprb/http/pull/587)
+  [#585](https://github.com/httprb/http/issues/585)
+  Fix redirections when server responds with multiple Location headers.
+  ([@ixti])
+
+* [#581](https://github.com/httprb/http/pull/581)
+  [#582](https://github.com/httprb/http/issues/582)
+  Add Ruby 2.7.x support.
+  ([@janko])
+
+* [#577](https://github.com/httprb/http/pull/577)
+  Fix `Chainable#timeout` with frozen Hash.
+  ([@antonvolkoff])
+
+* [#576](https://github.com/httprb/http/pull/576)
+  [#524](https://github.com/httprb/http/issues/524)
+  Preserve header names casing.
+  ([@joshuaflanagan])
+
+* [#532](https://github.com/httprb/http/pull/532)
+  Fix pipes support in request bodies.
+  ([@ixti])
+
+* [#530](https://github.com/httprb/http/pull/530)
+  Improve header fields name/value validation.
+  ([@Bonias])
+
+* [#506](https://github.com/httprb/http/pull/506)
+  [#521](https://github.com/httprb/http/issues/521)
+  Skip auto-deflate when there is no body.
+  ([@Bonias])
+
+* [#489](https://github.com/httprb/http/pull/489)
+  Fix HTTP parser.
+  ([@ixti], [@fxposter])
+
+* [#546](https://github.com/httprb/http/pull/546)
+  **BREAKING CHANGE**
+  Provide initiating `HTTP::Request` object on `HTTP::Response`.
+  ([@joshuaflanagan])
+
+* [#571](https://github.com/httprb/http/pull/571)
+  Drop Ruby 2.3.x support.
   ([@ixti])
 
+
 ## 4.4.0 (2020-03-25)
 
 * Backport [#587](https://github.com/httprb/http/pull/587)
@@ -14,6 +90,7 @@
   Allow passing HTTP::FormData::{Multipart,UrlEncoded} object directly.
   ([@ixti])
 
+
 ## 4.3.0 (2020-01-09)
 
 * Backport [#581](https://github.com/httprb/http/pull/581)
@@ -803,3 +880,10 @@ end
 [@RickCSong]: https://github.com/RickCSong
 [@fxposter]: https://github.com/fxposter
 [@mamoonraja]: https://github.com/mamoonraja
+[@joshuaflanagan]: https://github.com/joshuaflanagan
+[@antonvolkoff]: https://github.com/antonvolkoff
+[@LukaszMaslej]: https://github.com/LukaszMaslej
+[@colemannugent]: https://github.com/colemannugent
+[@semenyukdmitry]: https://github.com/semenyukdmitry
+[@bryanp]: https://github.com/bryanp
+[@meanphil]: https://github.com/meanphil

data/Gemfile

@@ -5,30 +5,38 @@ ruby RUBY_VERSION
 
 gem "rake"
 
+# Ruby 3.0 does not ship it anymore.
+# TODO: We should probably refactor specs to avoid need for it.
+gem "webrick"
+
 group :development do
   gem "guard-rspec", :require => false
   gem "nokogiri",    :require => false
   gem "pry",         :require => false
 
-  platform :ruby_20 do
-    gem "pry-debugger",       :require => false
-    gem "pry-stack_explorer", :require => false
+  # RSpec formatter
+  gem "fuubar", :require => false
+
+  platform :mri do
+    gem "pry-byebug"
   end
 end
 
 group :test do
-  gem "activemodel", :require => false # Used by certificate_authority
-  gem "certificate_authority", :require => false
+  gem "certificate_authority", "~> 1.0", :require => false
 
   gem "backports"
 
-  gem "coveralls", :require => false
-  gem "simplecov", ">= 0.9"
+  gem "rubocop"
+  gem "rubocop-performance"
+  gem "rubocop-rake"
+  gem "rubocop-rspec"
 
-  gem "rspec", "~> 3.0"
-  gem "rspec-its"
+  gem "simplecov",      :require => false
+  gem "simplecov-lcov", :require => false
 
-  gem "rubocop", "= 0.49.1"
+  gem "rspec", "~> 3.10"
+  gem "rspec-its"
 
   gem "yardstick"
 end