http 4.4.1 → 5.0.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cce9a8685f3b60f994e77174f79c2306f607d62016bf64b74fcebc4f86377ec0
-  data.tar.gz: 353702b62a1b9d3b2ea86ac5ac3ad88e9efa734c77e180128fa06c6c301895d3
+  metadata.gz: 2825a470cfdf9fd2d231cfe42a5d9aa54286a5cd13e402a5988f9ebfccd5fea9
+  data.tar.gz: ae9fbde0feda802b51bdb9926179d5c449d8ef9694d2c131eaf3226899236a7e
 SHA512:
-  metadata.gz: 84ddc4cf98e603d175a9ecb8db03abd32187888070abd96a437c4121750ac2b86b6cada5d00d527b398ff4a403c2b6448d45bed61c45dbd3be8658f4ad38b121
-  data.tar.gz: 750edced9ae715483d750f0b18777f84a4ee24848ec761c67d2c5b89d00ebbc99fbc1e02932d3d30a33eaea43e1d081ba97bcacaf2231f6693e50d218ee24e87
+  metadata.gz: 7734a21527150dcf3e987d37c815930470e7a2620ceee1177b0885e6a23c10a571b040e16d1b2c6153c6a35c8e54aa89be1737a7e3d00c9e306caf33e4d199a2
+  data.tar.gz: 1ce3516a9928a62f852d3e995686a44c9ad1cd837e63c4862d7680a70b3d435b05f153f8a602f6f555dfadb431bd6567649512e596e56f54ba5c19fa040408ff

data/.rubocop.yml

@@ -20,8 +20,7 @@ Metrics/AbcSize:
 
 Metrics/BlockLength:
   Exclude:
-    - "spec/**/*"
-    - "**/*.gemspec"
+    - spec/**/*
 
 Metrics/BlockNesting:
   Max: 2

data/.travis.yml

@@ -6,7 +6,7 @@ cache: bundler
 before_install:
   - gem update --system
   - gem --version
-  - gem install bundler --no-document
+  - gem install bundler
   - bundle --version
 
 install: bundle install --without development doc
@@ -17,23 +17,20 @@ env: JRUBY_OPTS="$JRUBY_OPTS --debug"
 
 rvm:
   # Include JRuby first because it takes the longest
-  - jruby-9.2.5.0
+  - jruby-9.1.16.0
   - 2.3
   - 2.4
   - 2.5
-  - 2.6
-  - 2.7
 
 matrix:
   fast_finish: true
   include:
   # Only run RuboCop and Yardstick metrics on the latest Ruby
-  - rvm: 2.7
+  - rvm: 2.5
     env: SUITE="rubocop"
-  - rvm: 2.7
+  - rvm: 2.5
     env: SUITE="yardstick"
 
 branches:
   only:
     - master
-    - 4-x-stable

data/.yardopts

@@ -1,2 +1,2 @@
---markup-provider=redcarpet
+--markup-provider=kramdown
 --markup=markdown

data/CHANGES.md

@@ -1,60 +1,10 @@
-## 4.4.1 (2020-03-29)
+## future is unwritten (master)
 
-* Backport [#590](https://github.com/httprb/http/pull/590)
-  Fix parser failing on some edge cases.
-  ([@ixti])
-
-## 4.4.0 (2020-03-25)
-
-* Backport [#587](https://github.com/httprb/http/pull/587)
-  Fix redirections when server responds with multiple Location headers.
-  ([@ixti])
-
-* Backport [#599](https://github.com/httprb/http/pull/599)
-  Allow passing HTTP::FormData::{Multipart,UrlEncoded} object directly.
-  ([@ixti])
-
-## 4.3.0 (2020-01-09)
-
-* Backport [#581](https://github.com/httprb/http/pull/581)
-  Add Ruby-2.7 compatibility.
-  ([@ixti], [@janko])
-
-
-## 4.2.0 (2019-10-22)
-
-* Backport [#489](https://github.com/httprb/http/pull/489)
+* [#489](https://github.com/httprb/http/pull/489)
   Fix HTTP parser.
   ([@ixti], [@fxposter])
 
 
-## 4.1.1 (2019-03-12)
-
-* Add `HTTP::Headers::ACCEPT_ENCODING` constant.
-  ([@ixti])
-
-
-## 4.1.0 (2019-03-11)
-
-* [#533](https://github.com/httprb/http/pull/533)
-  Add URI normalizer feature that allows to swap default URI normalizer.
-  ([@mamoonraja])
-
-
-## 4.0.5 (2019-02-15)
-
-* Backport [#532](https://github.com/httprb/http/pull/532) from master.
-  Fix pipes support in request bodies.
-  ([@ixti])
-
-
-## 4.0.4 (2019-02-12)
-
-* Backport [#506](https://github.com/httprb/http/pull/506) from master.
-  Skip auto-deflate when there is no body.
-  ([@Bonias])
-
-
 ## 4.0.3 (2019-01-18)
 
 * Fix missing URL in response wrapped by auto inflate.
@@ -802,4 +752,3 @@ end
 [@paul]: https://github.com/paul
 [@RickCSong]: https://github.com/RickCSong
 [@fxposter]: https://github.com/fxposter
-[@mamoonraja]: https://github.com/mamoonraja

data/README.md

@@ -1,16 +1,16 @@
 # ![http.rb](https://raw.github.com/httprb/http.rb/master/logo.png)
 
 [![Gem Version](https://badge.fury.io/rb/http.svg)](https://rubygems.org/gems/http)
-[![Build Status](https://secure.travis-ci.org/httprb/http.svg?branch=4-x-stable)](https://travis-ci.org/httprb/http)
-[![Code Climate](https://codeclimate.com/github/httprb/http.svg?branch=4-x-stable)](https://codeclimate.com/github/httprb/http)
-[![Coverage Status](https://coveralls.io/repos/httprb/http/badge.svg?branch=4-x-stable)](https://coveralls.io/r/httprb/http)
-[![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/httprb/http/blob/4-x-stable/LICENSE.txt)
+[![Build Status](https://secure.travis-ci.org/httprb/http.svg?branch=master)](https://travis-ci.org/httprb/http)
+[![Code Climate](https://codeclimate.com/github/httprb/http.svg?branch=master)](https://codeclimate.com/github/httprb/http)
+[![Coverage Status](https://coveralls.io/repos/httprb/http/badge.svg?branch=master)](https://coveralls.io/r/httprb/http)
+[![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/httprb/http/blob/master/LICENSE.txt)
 
 [Documentation]
 
-_NOTE: This is the 4.x **stable** branch.  For the 3.x **stable** branch, please see:_
+_NOTE: This is the 5.x **development** branch.  For the 4.x **stable** branch, please see:_
 
-https://github.com/httprb/http/tree/3-x-stable
+https://github.com/httprb/http/tree/4-x-stable
 
 ## About
 
@@ -167,8 +167,7 @@ versions:
 * Ruby 2.3.x
 * Ruby 2.4.x
 * Ruby 2.5.x
-* Ruby 2.6.x
-* JRuby 9.2.x.x
+* JRuby 9.1.x.x
 
 If something doesn't work on one of these versions, it's a bug.
 
@@ -198,5 +197,5 @@ dropped.
 
 ## Copyright
 
-Copyright (c) 2011-2019 Tony Arcieri, Alexey V. Zapparov, Erik Michaels-Ober, Zachary Anker.
+Copyright (c) 2011-2018 Tony Arcieri, Alexey V. Zapparov, Erik Michaels-Ober, Zachary Anker.
 See LICENSE.txt for further details.

data/http.gemspec

@@ -27,17 +27,10 @@ Gem::Specification.new do |gem|
 
   gem.required_ruby_version = ">= 2.3"
 
-  gem.add_runtime_dependency "addressable",    "~> 2.3"
-  gem.add_runtime_dependency "http-cookie",    "~> 1.0"
-  gem.add_runtime_dependency "http-form_data", "~> 2.2"
   gem.add_runtime_dependency "http-parser",    "~> 1.2.0"
+  gem.add_runtime_dependency "http-form_data", "~> 2.0"
+  gem.add_runtime_dependency "http-cookie",    "~> 1.0"
+  gem.add_runtime_dependency "addressable",    "~> 2.3"
 
   gem.add_development_dependency "bundler", "~> 2.0"
-
-  gem.metadata = {
-    "source_code_uri" => "https://github.com/httprb/http",
-    "wiki_uri"        => "https://github.com/httprb/http/wiki",
-    "bug_tracker_uri" => "https://github.com/httprb/http/issues",
-    "changelog_uri"   => "https://github.com/httprb/http/blob/v#{HTTP::VERSION}/CHANGES.md"
-  }
 end

data/lib/http/client.rb

@@ -42,14 +42,14 @@ module HTTP
       uri     = make_request_uri(uri, opts)
       headers = make_request_headers(opts)
       body    = make_request_body(opts, headers)
+      proxy   = opts.proxy
 
       req = HTTP::Request.new(
-        :verb           => verb,
-        :uri            => uri,
-        :uri_normalizer => opts.feature(:normalize_uri)&.normalizer,
-        :proxy          => opts.proxy,
-        :headers        => headers,
-        :body           => body
+        :verb         => verb,
+        :uri          => uri,
+        :headers      => headers,
+        :proxy        => proxy,
+        :body         => body
       )
 
       opts.features.inject(req) do |request, (_name, feature)|
@@ -160,6 +160,14 @@ module HTTP
         headers[Headers::COOKIE] = cookies
       end
 
+      if (auto_deflate = opts.feature(:auto_deflate))
+        # We need to delete Content-Length header. It will be set automatically
+        # by HTTP::Request::Writer
+        headers.delete(Headers::CONTENT_LENGTH)
+
+        headers[Headers::CONTENT_ENCODING] = auto_deflate.method
+      end
+
       headers
     end
 
@@ -169,7 +177,7 @@ module HTTP
       when opts.body
         opts.body
       when opts.form
-        form = make_form_data(opts.form)
+        form = HTTP::FormData.create opts.form
         headers[Headers::CONTENT_TYPE] ||= form.content_type
         form
       when opts.json
@@ -178,12 +186,5 @@ module HTTP
         body
       end
     end
-
-    def make_form_data(form)
-      return form if form.is_a? HTTP::FormData::Multipart
-      return form if form.is_a? HTTP::FormData::Urlencoded
-
-      HTTP::FormData.create(form)
-    end
   end
 end

data/lib/http/connection.rb

@@ -93,7 +93,7 @@ module HTTP
       chunk    = @parser.read(size)
       finish_response if finished
 
-      chunk || "".b
+      chunk.to_s
     end
 
     # Reads data from socket up until headers are loaded

data/lib/http/feature.rb

@@ -20,4 +20,3 @@ require "http/features/auto_inflate"
 require "http/features/auto_deflate"
 require "http/features/logging"
 require "http/features/instrumentation"
-require "http/features/normalize_uri"

data/lib/http/features/auto_deflate.rb

@@ -10,7 +10,7 @@ module HTTP
     class AutoDeflate < Feature
       attr_reader :method
 
-      def initialize(**)
+      def initialize(*)
         super
 
         @method = @opts.key?(:method) ? @opts[:method].to_s : "gzip"
@@ -20,11 +20,6 @@ module HTTP
 
       def wrap_request(request)
         return request unless method
-        return request if request.body.size.zero?
-
-        # We need to delete Content-Length header. It will be set automatically by HTTP::Request::Writer
-        request.headers.delete(Headers::CONTENT_LENGTH)
-        request.headers[Headers::CONTENT_ENCODING] = method
 
         Request.new(
           :version => request.version,
@@ -32,8 +27,7 @@ module HTTP
           :uri => request.uri,
           :headers => request.headers,
           :proxy => request.proxy,
-          :body => deflated_body(request.body),
-          :uri_normalizer => request.uri_normalizer
+          :body => deflated_body(request.body)
         )
       end
 

data/lib/http/headers/known.rb

@@ -5,9 +5,6 @@ module HTTP
     # Content-Types that are acceptable for the response.
     ACCEPT = "Accept"
 
-    # Content-codings that are acceptable in the response.
-    ACCEPT_ENCODING = "Accept-Encoding"
-
     # The age the object has been in a proxy cache in seconds.
     AGE = "Age"
 

data/lib/http/options.rb

@@ -114,7 +114,7 @@ module HTTP
                     unless (feature = self.class.available_features[name])
                       argument_error! "Unsupported feature: #{name}"
                     end
-                    feature.new(**opts_or_feature)
+                    feature.new(opts_or_feature)
                   end
       end
     end

data/lib/http/redirector.rb

@@ -58,8 +58,7 @@ module HTTP
 
         @response.flush
 
-        # XXX(ixti): using `Array#inject` to return `nil` if no Location header.
-        @request  = redirect_to(@response.headers.get(Headers::LOCATION).inject(:+))
+        @request  = redirect_to @response.headers[Headers::LOCATION]
         @response = yield @request
       end
 

data/lib/http/request.rb

@@ -66,8 +66,6 @@ module HTTP
     # Scheme is normalized to be a lowercase symbol e.g. :http, :https
     attr_reader :scheme
 
-    attr_reader :uri_normalizer
-
     # "Request URI" as per RFC 2616
     # http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html
     attr_reader :uri
@@ -75,25 +73,25 @@ module HTTP
 
     # @option opts [String] :version
     # @option opts [#to_s] :verb HTTP request method
-    # @option opts [#call] :uri_normalizer (HTTP::URI::NORMALIZER)
     # @option opts [HTTP::URI, #to_s] :uri
     # @option opts [Hash] :headers
     # @option opts [Hash] :proxy
     # @option opts [String, Enumerable, IO, nil] :body
     def initialize(opts)
-      @verb           = opts.fetch(:verb).to_s.downcase.to_sym
-      @uri_normalizer = opts[:uri_normalizer] || HTTP::URI::NORMALIZER
-
-      @uri    = @uri_normalizer.call(opts.fetch(:uri))
+      @verb   = opts.fetch(:verb).to_s.downcase.to_sym
+      @uri    = normalize_uri(opts.fetch(:uri))
       @scheme = @uri.scheme.to_s.downcase.to_sym if @uri.scheme
 
       raise(UnsupportedMethodError, "unknown method: #{verb}") unless METHODS.include?(@verb)
       raise(UnsupportedSchemeError, "unknown scheme: #{scheme}") unless SCHEMES.include?(@scheme)
 
       @proxy   = opts[:proxy] || {}
+      @body    = (body = opts[:body]).is_a?(Request::Body) ? body : Request::Body.new(body)
       @version = opts[:version] || "1.1"
-      @headers = prepare_headers(opts[:headers])
-      @body    = prepare_body(opts[:body])
+      @headers = HTTP::Headers.coerce(opts[:headers] || {})
+
+      @headers[Headers::HOST]        ||= default_host_header_value
+      @headers[Headers::USER_AGENT]  ||= USER_AGENT
     end
 
     # Returns new Request with updated uri
@@ -102,13 +100,12 @@ module HTTP
       headers.delete(Headers::HOST)
 
       self.class.new(
-        :verb           => verb,
-        :uri            => @uri.join(uri),
-        :headers        => headers,
-        :proxy          => proxy,
-        :body           => body.source,
-        :version        => version,
-        :uri_normalizer => uri_normalizer
+        :verb         => verb,
+        :uri          => @uri.join(uri),
+        :headers      => headers,
+        :proxy        => proxy,
+        :body         => body.source,
+        :version      => version
       )
     end
 
@@ -216,17 +213,17 @@ module HTTP
       PORTS[@scheme] != port ? "#{host}:#{port}" : host
     end
 
-    def prepare_body(body)
-      body.is_a?(Request::Body) ? body : Request::Body.new(body)
-    end
+    # @return [HTTP::URI] URI with all componentes but query being normalized.
+    def normalize_uri(uri)
+      uri = HTTP::URI.parse uri
 
-    def prepare_headers(headers)
-      headers = HTTP::Headers.coerce(headers || {})
-
-      headers[Headers::HOST]        ||= default_host_header_value
-      headers[Headers::USER_AGENT]  ||= USER_AGENT
-
-      headers
+      HTTP::URI.new(
+        :scheme     => uri.normalized_scheme,
+        :authority  => uri.normalized_authority,
+        :path       => uri.normalized_path,
+        :query      => uri.query,
+        :fragment   => uri.normalized_fragment
+      )
     end
   end
 end

data/lib/http/request/body.rb

@@ -35,12 +35,10 @@ module HTTP
           yield @source
         elsif @source.respond_to?(:read)
           IO.copy_stream(@source, ProcIO.new(block))
-          rewind(@source)
+          @source.rewind if @source.respond_to?(:rewind)
         elsif @source.is_a?(Enumerable)
           @source.each(&block)
         end
-
-        self
       end
 
       # Request bodies are equivalent when they have the same source.
@@ -50,28 +48,6 @@ module HTTP
 
       private
 
-      def rewind(io)
-        io.rewind if io.respond_to? :rewind
-      rescue Errno::ESPIPE, Errno::EPIPE
-        # Pipe IOs respond to `:rewind` but fail when you call it.
-        #
-        # Calling `IO#rewind` on a pipe, fails with *ESPIPE* on MRI,
-        # but *EPIPE* on jRuby.
-        #
-        # - **ESPIPE** -- "Illegal seek."
-        #   Invalid seek operation (such as on a pipe).
-        #
-        # - **EPIPE** -- "Broken pipe."
-        #   There is no process reading from the other end of a pipe. Every
-        #   library function that returns this error code also generates
-        #   a SIGPIPE signal; this signal terminates the program if not handled
-        #   or blocked. Thus, your program will never actually see EPIPE unless
-        #   it has handled or blocked SIGPIPE.
-        #
-        # See: https://www.gnu.org/software/libc/manual/html_node/Error-Codes.html
-        nil
-      end
-
       def validate_source_type!
         return if @source.is_a?(String)
         return if @source.respond_to?(:read)

data/lib/http/response/parser.rb

@@ -49,17 +49,14 @@ module HTTP
       #
 
       def on_header_field(_response, field)
-        append_header if @reading_header_value
-        @field << field
+        @field = field
       end
 
       def on_header_value(_response, value)
-        @reading_header_value = true
-        @field_value << value
+        @headers.add(@field, value) if @field
       end
 
       def on_headers_complete(_reposse)
-        append_header if @reading_header_value
         @finished[:headers] = true
       end
 
@@ -92,26 +89,15 @@ module HTTP
       def reset
         @state.reset!
 
-        @finished             = Hash.new(false)
-        @headers              = HTTP::Headers.new
-        @reading_header_value = false
-        @field                = +""
-        @field_value          = +""
-        @chunk                = nil
+        @finished = Hash.new(false)
+        @headers  = HTTP::Headers.new
+        @field    = nil
+        @chunk    = nil
       end
 
       def finished?
         @finished[:message]
       end
-
-      private
-
-      def append_header
-        @headers.add(@field, @field_value)
-        @reading_header_value = false
-        @field_value          = +""
-        @field                = +""
-      end
     end
   end
 end

data/lib/http/uri.rb

@@ -26,19 +26,6 @@ module HTTP
     # @private
     HTTPS_SCHEME = "https"
 
-    # @private
-    NORMALIZER = lambda do |uri|
-      uri = HTTP::URI.parse uri
-
-      HTTP::URI.new(
-        :scheme     => uri.normalized_scheme,
-        :authority  => uri.normalized_authority,
-        :path       => uri.normalized_path,
-        :query      => uri.query,
-        :fragment   => uri.normalized_fragment
-      )
-    end
-
     # Parse the given URI string, returning an HTTP::URI object
     #
     # @param [HTTP::URI, String, #to_str] uri to parse

data/lib/http/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTP
-  VERSION = "4.4.1"
+  VERSION = "5.0.0.pre"
 end

data/spec/lib/http/client_spec.rb

@@ -98,8 +98,9 @@ RSpec.describe HTTP::Client do
       end
 
       it "works like a charm in real world" do
-        expect(HTTP.follow.get("https://bit.ly/2UaBT4R").parse(:json)).
-          to include("url" => "https://httpbin.org/anything/könig")
+        url    = "http://git.io/jNeY"
+        client = HTTP.follow
+        expect(client.get(url).to_s).to include "support for non-ascii URIs"
       end
     end
   end
@@ -189,22 +190,6 @@ RSpec.describe HTTP::Client do
 
       client.get("http://example.com/", :form => {:foo => HTTP::FormData::Part.new("content")})
     end
-
-    context "when passing an HTTP::FormData object directly" do
-      it "creates url encoded form data object" do
-        client    = HTTP::Client.new
-        form_data = HTTP::FormData::Multipart.new(:foo => "bar")
-
-        allow(client).to receive(:perform)
-
-        expect(HTTP::Request).to receive(:new) do |opts|
-          expect(opts[:body]).to be form_data
-          expect(opts[:body].to_s).to match(/^Content-Disposition: form-data; name="foo"\r\n\r\nbar\r\n/m)
-        end
-
-        client.get("http://example.com/", :form => form_data)
-      end
-    end
   end
 
   describe "passing json" do
@@ -228,9 +213,9 @@ RSpec.describe HTTP::Client do
       end
 
       it "works like a charm in real world" do
-        url = "https://httpbin.org/anything/ö無"
-
-        expect(HTTP.follow.get(url).parse(:json)).to include("url" => url)
+        url     = "https://github.com/httprb/http.rb/pull/197/ö無"
+        client  = HTTP.follow
+        expect(client.get(url).to_s).to include "support for non-ascii URIs"
       end
     end
 
@@ -249,7 +234,7 @@ RSpec.describe HTTP::Client do
 
     context "when :auto_deflate was specified" do
       let(:headers) { {"Content-Length" => "12"} }
-      let(:client)  { described_class.new :headers => headers, :features => {:auto_deflate => {}}, :body => "foo" }
+      let(:client)  { described_class.new :headers => headers, :features => {:auto_deflate => {}} }
 
       it "deletes Content-Length header" do
         expect(client).to receive(:perform) do |req, _|
@@ -266,18 +251,6 @@ RSpec.describe HTTP::Client do
 
         client.request(:get, "http://example.com/")
       end
-
-      context "and there is no body" do
-        let(:client) { described_class.new :headers => headers, :features => {:auto_deflate => {}} }
-
-        it "doesn't set Content-Encoding header" do
-          expect(client).to receive(:perform) do |req, _|
-            expect(req.headers).not_to include "Content-Encoding"
-          end
-
-          client.request(:get, "http://example.com/")
-        end
-      end
     end
   end
 

data/spec/lib/http/redirector_spec.rb

@@ -75,19 +75,6 @@ RSpec.describe HTTP::Redirector do
       expect(res.to_s).to eq "foo"
     end
 
-    it "concatenates multiple Location headers" do
-      req     = HTTP::Request.new :verb => :head, :uri => "http://example.com"
-      headers = HTTP::Headers.new
-
-      %w[http://example.com /123].each { |loc| headers.add("Location", loc) }
-
-      res = redirector.perform(req, simple_response(301, "", headers)) do |redirect|
-        simple_response(200, redirect.uri.to_s)
-      end
-
-      expect(res.to_s).to eq "http://example.com/123"
-    end
-
     context "following 300 redirect" do
       context "with strict mode" do
         let(:options) { {:strict => true} }

data/spec/lib/http/request/body_spec.rb

@@ -125,28 +125,6 @@ RSpec.describe HTTP::Request::Body do
       end
     end
 
-    context "when body is a pipe" do
-      let(:ios)  { IO.pipe }
-      let(:body) { ios[0] }
-
-      around do |example|
-        writer = Thread.new(ios[1]) do |io|
-          io << "abcdef"
-          io.close
-        end
-
-        begin
-          example.run
-        ensure
-          writer.join
-        end
-      end
-
-      it "yields chunks of content" do
-        expect(chunks.inject("", :+)).to eq("abcdef")
-      end
-    end
-
     context "when body is an Enumerable IO" do
       let(:data) { "a" * 16 * 1024 + "b" * 10 * 1024 }
       let(:body) { StringIO.new data }

data/spec/lib/http_spec.rb

@@ -430,26 +430,6 @@ RSpec.describe HTTP do
         expect(response.to_s).to eq("#{body}-deflated")
       end
     end
-
-    context "with :normalize_uri" do
-      it "normalizes URI" do
-        response = HTTP.get "#{dummy.endpoint}/hello world"
-        expect(response.to_s).to eq("hello world")
-      end
-
-      it "uses the custom URI Normalizer method" do
-        client = HTTP.use(:normalize_uri => {:normalizer => :itself.to_proc})
-        response = client.get("#{dummy.endpoint}/hello world")
-        expect(response.status).to eq(400)
-      end
-
-      it "uses the default URI normalizer" do
-        client = HTTP.use :normalize_uri
-        expect(HTTP::URI::NORMALIZER).to receive(:call).and_call_original
-        response = client.get("#{dummy.endpoint}/hello world")
-        expect(response.to_s).to eq("hello world")
-      end
-    end
   end
 
   it "unifies socket errors into HTTP::ConnectionError" do

data/spec/support/dummy_server/servlet.rb

@@ -148,11 +148,6 @@ class DummyServer < WEBrick::HTTPServer
       res.body   = req.body
     end
 
-    get "/hello world" do |_req, res|
-      res.status = 200
-      res.body   = "hello world"
-    end
-
     post "/encoded-body" do |req, res|
       res.status = 200
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 5.0.0.pre
 platform: ruby
 authors:
 - Tony Arcieri
@@ -11,64 +11,64 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-29 00:00:00.000000000 Z
+date: 2019-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: addressable
+  name: http-parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
-  name: http-cookie
+  name: http-form_data
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: http-form_data
+  name: http-cookie
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: http-parser
+  name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -116,7 +116,6 @@ files:
 - lib/http/features/auto_inflate.rb
 - lib/http/features/instrumentation.rb
 - lib/http/features/logging.rb
-- lib/http/features/normalize_uri.rb
 - lib/http/headers.rb
 - lib/http/headers/known.rb
 - lib/http/headers/mixin.rb
@@ -163,7 +162,6 @@ files:
 - spec/lib/http/request/writer_spec.rb
 - spec/lib/http/request_spec.rb
 - spec/lib/http/response/body_spec.rb
-- spec/lib/http/response/parser_spec.rb
 - spec/lib/http/response/status_spec.rb
 - spec/lib/http/response_spec.rb
 - spec/lib/http/uri_spec.rb
@@ -183,11 +181,7 @@ files:
 homepage: https://github.com/httprb/http
 licenses:
 - MIT
-metadata:
-  source_code_uri: https://github.com/httprb/http
-  wiki_uri: https://github.com/httprb/http/wiki
-  bug_tracker_uri: https://github.com/httprb/http/issues
-  changelog_uri: https://github.com/httprb/http/blob/v4.4.1/CHANGES.md
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -199,11 +193,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: HTTP should be easy
@@ -231,7 +225,6 @@ test_files:
 - spec/lib/http/request/writer_spec.rb
 - spec/lib/http/request_spec.rb
 - spec/lib/http/response/body_spec.rb
-- spec/lib/http/response/parser_spec.rb
 - spec/lib/http/response/status_spec.rb
 - spec/lib/http/response_spec.rb
 - spec/lib/http/uri_spec.rb

data/lib/http/features/normalize_uri.rb

@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-require "http/uri"
-
-module HTTP
-  module Features
-    class NormalizeUri < Feature
-      attr_reader :normalizer
-
-      def initialize(normalizer: HTTP::URI::NORMALIZER)
-        @normalizer = normalizer
-      end
-
-      HTTP::Options.register_feature(:normalize_uri, self)
-    end
-  end
-end

data/spec/lib/http/response/parser_spec.rb

@@ -1,45 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe HTTP::Response::Parser do
-  subject(:parser) { described_class.new }
-  let(:raw_response) do
-    "HTTP/1.1 200 OK\r\nContent-Length: 2\r\nContent-Type: application/json\r\nMy-Header: val\r\nEmpty-Header: \r\n\r\n{}"
-  end
-  let(:expected_headers) do
-    {
-      "Content-Length" => "2",
-      "Content-Type"   => "application/json",
-      "My-Header"      => "val",
-      "Empty-Header"   => ""
-    }
-  end
-  let(:expected_body) { "{}" }
-
-  before do
-    parts.each { |part| subject.add(part) }
-  end
-
-  context "whole response in one part" do
-    let(:parts) { [raw_response] }
-
-    it "parses headers" do
-      expect(subject.headers.to_h).to eq(expected_headers)
-    end
-
-    it "parses body" do
-      expect(subject.read(expected_body.size)).to eq(expected_body)
-    end
-  end
-
-  context "response in many parts" do
-    let(:parts) { raw_response.split(//) }
-
-    it "parses headers" do
-      expect(subject.headers.to_h).to eq(expected_headers)
-    end
-
-    it "parses body" do
-      expect(subject.read(expected_body.size)).to eq(expected_body)
-    end
-  end
-end