http 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18081275ee2fbb499b450316f301fc7cac4a35f3e5092fe453fd1fb089a2696b
-  data.tar.gz: 0a3c8b1dd2fa6bc5e68ed518552b4e4e3be8a517fe55fd6cb2b32650612d42ca
+  metadata.gz: 6b4b0a992f25d4d013ad17cc731ef43b9a77bce5326989ddfcce64e0dac136fc
+  data.tar.gz: 7db71f7b6038af882c3951c894d38eff1e54642fbd1025644cb2756e6ea3abe9
 SHA512:
-  metadata.gz: 35f037dc6661cc33147b40647c8faf78a1b881611672c806e529c75f28ab86fc4e9a37e592036a7f22bb5423203d0b6d62dfcc2335016424f8e4fdceccc7b65f
-  data.tar.gz: c7f299760ef14e5cf40f906520fabfaf2a845449686883f0a6512160f99fc0ff3ee73c8d3bab1b4d6337548e7bff158c23bc41bde843ba8f0dbc50649b131993
+  metadata.gz: 1566faa35cdf35dcef2c54cd88c7a9f3768c0e6ed1627e1fbc8af49d0a3b1aab84675bc065a28213f85d43d672779c6778f5dd661b51360116e8bedbc9dc48de
+  data.tar.gz: 61b6da199935be564e142a2a791374a652bda85ee142384a7d21fa62fbbf6b86167239332f10e67af39a0b719222f216eca3f7390ac72b7f624b95139eb8b852

data/.travis.yml

@@ -6,7 +6,7 @@ cache: bundler
 before_install:
   - gem update --system
   - gem --version
-  - gem install bundler --no-rdoc --no-ri
+  - gem install bundler
   - bundle --version
 
 install: bundle install --without development doc

data/CHANGES.md

@@ -1,5 +1,22 @@
+## 4.0.1 (2019-01-14)
+
+* [#515](https://github.com/httprb/http/pull/515)
+  Fix `#build_request` and `#request` to respect default options.
+  ([@RickCSong])
+
+
 ## 4.0.0 (2018-10-15)
 
+* [#482](https://github.com/httprb/http/pull/482)
+  [#499](https://github.com/httprb/http/pull/499)
+  Introduce new features injection API with 2 new feaures: instrumentation
+  (compatible with ActiveSupport::Notification) and logging.
+  ([@paul])
+
+* [#473](https://github.com/httprb/http/pull/473)
+  Handle early responses.
+  ([@janko-m])
+
 * [#468](https://github.com/httprb/http/pull/468)
   Rewind `HTTP::Request::Body#source` once `#each` is complete.
   ([@ixti])
@@ -709,3 +726,5 @@ end
 [@scarfacedeb]: https://github.com/scarfacedeb
 [@mikegee]: https://github.com/mikegee
 [@tycoon]: https://github.com/tycooon
+[@paul]: https://github.com/paul
+[@RickCSong]: https://github.com/RickCSong

data/README.md

@@ -1,14 +1,14 @@
 # ![http.rb](https://raw.github.com/httprb/http.rb/master/logo.png)
 
 [![Gem Version](https://badge.fury.io/rb/http.svg)](https://rubygems.org/gems/http)
-[![Build Status](https://secure.travis-ci.org/httprb/http.svg?branch=master)](https://travis-ci.org/httprb/http)
-[![Code Climate](https://codeclimate.com/github/httprb/http.svg?branch=master)](https://codeclimate.com/github/httprb/http)
-[![Coverage Status](https://coveralls.io/repos/httprb/http/badge.svg?branch=master)](https://coveralls.io/r/httprb/http)
+[![Build Status](https://secure.travis-ci.org/httprb/http.svg?branch=4-x-stable)](https://travis-ci.org/httprb/http)
+[![Code Climate](https://codeclimate.com/github/httprb/http.svg?branch=4-x-stable)](https://codeclimate.com/github/httprb/http)
+[![Coverage Status](https://coveralls.io/repos/httprb/http/badge.svg?branch=4-x-stable)](https://coveralls.io/r/httprb/http)
 [![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/httprb/http/blob/master/LICENSE.txt)
 
 [Documentation]
 
-_NOTE: This is the 4.x **development** branch.  For the 3.x **stable** branch, please see:_
+_NOTE: This is the 4.x **stable** branch.  For the 3.x **stable** branch, please see:_
 
 https://github.com/httprb/http/tree/3-x-stable
 

data/http.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = HTTP::VERSION
 
-  gem.required_ruby_version = ">= 2.2"
+  gem.required_ruby_version = ">= 2.3"
 
   gem.add_runtime_dependency "http_parser.rb", "~> 0.6.0"
   gem.add_runtime_dependency "http-form_data", "~> 2.0"

data/lib/http/chainable.rb

@@ -70,19 +70,15 @@ module HTTP
     end
 
     # Make an HTTP request with the given verb
-    # @param verb
-    # @param uri
-    # @option options [Hash]
-    def request(verb, uri, options = {}) # rubocop:disable Style/OptionHash
-      branch(options).request verb, uri
+    # @param (see Client#request)
+    def request(*args)
+      branch(default_options).request(*args)
     end
 
     # Prepare an HTTP request with the given verb
-    # @param verb
-    # @param uri
-    # @option options [Hash]
-    def build_request(verb, uri, options = {}) # rubocop:disable Style/OptionHash
-      branch(options).build_request verb, uri
+    # @param (see Client#build_request)
+    def build_request(*args)
+      branch(default_options).build_request(*args)
     end
 
     # @overload timeout(options = {})

data/lib/http/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTP
-  VERSION = "4.0.0"
+  VERSION = "4.0.1"
 end

data/spec/lib/http/features/logging_spec.rb

@@ -1,34 +1,42 @@
 # frozen_string_literal: true
 
+require "logger"
+
 RSpec.describe HTTP::Features::Logging do
-  subject(:feature) { HTTP::Features::Logging.new(:logger => logger) }
-  let(:logger) { TestLogger.new }
+  subject(:feature) do
+    logger = Logger.new(logdev)
+    logger.formatter = ->(severity, _, _, message) do
+      format("** %s **\n%s\n", severity, message)
+    end
+
+    described_class.new(:logger => logger)
+  end
+
+  let(:logdev) { StringIO.new }
 
   describe "logging the request" do
     let(:request) do
       HTTP::Request.new(
-        :verb => :post,
-        :uri => "https://example.com/",
-        :headers => {:accept => "application/json"},
-        :body => '{"hello": "world!"}'
+        :verb     => :post,
+        :uri      => "https://example.com/",
+        :headers  => {:accept => "application/json"},
+        :body     => '{"hello": "world!"}'
       )
     end
 
     it "should log the request" do
       feature.wrap_request(request)
 
-      expect(logger.output).to eq(
-        [
-          "> POST https://example.com/",
-          <<~REQ.strip
-            Accept: application/json
-            Host: example.com
-            User-Agent: http.rb/4.0.0.dev
+      expect(logdev.string).to eq <<~OUTPUT
+        ** INFO **
+        > POST https://example.com/
+        ** DEBUG **
+        Accept: application/json
+        Host: example.com
+        User-Agent: http.rb/#{HTTP::VERSION}
 
-            {"hello": "world!"}
-          REQ
-        ]
-      )
+        {"hello": "world!"}
+      OUTPUT
     end
   end
 
@@ -36,39 +44,24 @@ RSpec.describe HTTP::Features::Logging do
     let(:response) do
       HTTP::Response.new(
         :version => "1.1",
-        :uri => "https://example.com",
-        :status => 200,
+        :uri     => "https://example.com",
+        :status  => 200,
         :headers => {:content_type => "application/json"},
-        :body => '{"success": true}'
+        :body    => '{"success": true}'
       )
     end
 
     it "should log the response" do
       feature.wrap_response(response)
 
-      expect(logger.output).to eq(
-        [
-          "< 200 OK",
-          <<~REQ.strip
-            Content-Type: application/json
-
-            {"success": true}
-          REQ
-        ]
-      )
-    end
-  end
-
-  class TestLogger
-    attr_reader :output
-    def initialize
-      @output = []
-    end
+      expect(logdev.string).to eq <<~OUTPUT
+        ** INFO **
+        < 200 OK
+        ** DEBUG **
+        Content-Type: application/json
 
-    %w[fatal error warn info debug].each do |level|
-      define_method(level.to_sym) do |*args, &block|
-        @output << (block ? block.call : args)
-      end
+        {"success": true}
+      OUTPUT
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Tony Arcieri
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-14 00:00:00.000000000 Z
+date: 2019-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http_parser.rb
@@ -190,15 +190,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: HTTP should be easy