http 3.1.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 42fd5a5fec6c2e6448908c9578bf27175a291933
-  data.tar.gz: 03a31ca5372bf0e9e2c5dcae9a8e06d9a7e38c56
+SHA256:
+  metadata.gz: b6053cab7210860d3464e9441746186b46c7ac1dc5716ea59cc69dff0d4ef460
+  data.tar.gz: 49f6d6c66a674e792208f1c17fff2c5dd8fdda330c6bdbabbaddec1f69eebac8
 SHA512:
-  metadata.gz: abc5ea24f0d2eb18022994003ab416bfddaa8976fc58bb41169eac32431b70838255d9956d710581da1ec844e0c85243d7fa937c0603122a8d61211b47bc80ae
-  data.tar.gz: 4b25eb0dac0ad59a5688ec5298253975c8ff186dde6d181cb8276e8e2aeafe235305f3c1717bc8c4171a551bf965215c4e0f05cda30dc79cd1bd03f6a3aa204f
+  metadata.gz: 11585d59c45a6e762e6df8792e30107ec1011440ddc4597ad63f4ab5951f0e5c3fd801153bdb32bf74cae90c8ca716368003b3fb59cd98d8dc28c595899be177
+  data.tar.gz: 481d4f96d65e80226f505b93ff0da954ee4d0c3ee443d6dd4b72711cd0b44ae95c150eeb82d24442a34105dbb75013cb689f4b2ee0a2272d8320b473d91fc72d

data/.github/workflows/ci.yml

@@ -0,0 +1,67 @@
+name: CI
+
+on:
+  push:
+    branches: [ main, 5-x-stable ]
+  pull_request:
+    branches: [ main, 5-x-stable ]
+
+env:
+  BUNDLE_WITHOUT: "development"
+  JRUBY_OPTS: "--dev --debug"
+
+jobs:
+  test:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        ruby: [ ruby-2.6, ruby-2.7, ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3 ]
+        os: [ ubuntu-latest ]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: bundle exec rspec
+        run: bundle exec rspec --format progress --force-colour
+
+  test-flaky:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        ruby: [ jruby-9.3 ]
+        os: [ ubuntu-latest ]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: bundle exec rspec
+        continue-on-error: true
+        run: bundle exec rspec --format progress --force-colour
+
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+          bundler-cache: true
+
+      - name: bundle exec rubocop
+        run: bundle exec rubocop --format progress --color
+
+      - run: bundle exec rake verify_measurements

data/.gitignore

@@ -1,18 +1,15 @@
 *.gem
-.bundle
 .config
 .rvmrc
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
-coverage
+
+.bundle
+.ruby-version
 doc
-lib/bundler/man
-measurement
+coverage
 pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
+spec/examples.txt
 tmp
+Gemfile.lock

data/.rspec

@@ -1,5 +1 @@
---backtrace
---color
---format=documentation
---order random
 --require spec_helper

data/.rubocop/layout.yml

@@ -0,0 +1,8 @@
+Layout/DotPosition:
+  Enabled: true
+  EnforcedStyle: leading
+
+Layout/HashAlignment:
+  Enabled: true
+  EnforcedColonStyle: table
+  EnforcedHashRocketStyle: table

data/.rubocop/metrics.yml

@@ -0,0 +1,4 @@
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*.rb'
+    - '*.gemspec'

data/.rubocop/rspec.yml

@@ -0,0 +1,9 @@
+RSpec/ExampleLength:
+  CountAsOne:
+    - array
+    - hash
+    - heredoc
+    - method_call
+
+RSpec/MultipleExpectations:
+  Max: 5

data/.rubocop/style.yml

@@ -0,0 +1,32 @@
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*.rb'
+
+Style/FormatStringToken:
+  Enabled: true
+  EnforcedStyle: unannotated
+
+Style/HashSyntax:
+  Enabled: true
+  EnforcedStyle: hash_rockets
+
+Style/OptionHash:
+  Enabled: true
+
+Style/RescueStandardError:
+  Enabled: true
+  EnforcedStyle: implicit
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/WordArray:
+  Enabled: true
+
+Style/YodaCondition:
+  Enabled: false

data/.rubocop.yml

@@ -1,110 +1,11 @@
+inherit_from:
+  - .rubocop_todo.yml
+  - .rubocop/layout.yml
+  - .rubocop/metrics.yml
+  - .rubocop/style.yml
+
 AllCops:
+  DefaultFormatter: fuubar
   DisplayCopNames: true
-
-## Layout ######################################################################
-
-Layout/DotPosition:
-  EnforcedStyle: trailing
-
-Layout/SpaceAroundOperators:
-  AllowForAlignment: true
-
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-## Metrics #####################################################################
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*
-
-Metrics/BlockNesting:
-  Max: 2
-
-Metrics/ClassLength:
-  CountComments: false
-  Max: 125
-
-# TODO: Lower to 6
-Metrics/CyclomaticComplexity:
-  Max: 8
-
-Metrics/PerceivedComplexity:
-  Max: 8
-
-# TODO: Lower to 80
-Metrics/LineLength:
-  AllowURI: true
-  Max: 143
-
-# TODO: Lower to 15
-Metrics/MethodLength:
-  CountComments: false
-  Max: 25
-
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 120
-
-Metrics/ParameterLists:
-  Max: 5
-  CountKeywordArgs: true
-
-## Performance #################################################################
-
-# XXX: requires ruby 2.4+
-Performance/RegexpMatch:
-  Enabled: false
-
-## Style #######################################################################
-
-Style/CollectionMethods:
-  PreferredMethods:
-    collect:  'map'
-    reduce:   'inject'
-    find:     'detect'
-    find_all: 'select'
-
-Style/Documentation:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/EachWithObject:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
-Style/EmptyCaseCondition:
-  Enabled: false
-
-# XXX: Lots of times it suggests making code terrible to read.
-Style/GuardClause:
-  Enabled: false
-
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-
-Style/Lambda:
-  Enabled: false
-
-Style/OptionHash:
-  Enabled: true
-
-# XXX: requires ruby 2.3+
-Style/SafeNavigation:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/YodaCondition:
-  Enabled: false
+  NewCops: enable
+  TargetRubyVersion: 2.6

data/.rubocop_todo.yml

@@ -0,0 +1,219 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
+# on 2025-06-09 02:44:43 UTC using RuboCop version 1.30.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/DeprecatedAttributeAssignment:
+  Exclude:
+    - 'http.gemspec'
+
+# Offense count: 55
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: leading, trailing
+Layout/DotPosition:
+  Exclude:
+    - 'lib/http/options.rb'
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/features/auto_deflate_spec.rb'
+    - 'spec/lib/http/headers_spec.rb'
+    - 'spec/lib/http/options/features_spec.rb'
+    - 'spec/lib/http/redirector_spec.rb'
+    - 'spec/lib/http/response/body_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/http_handling_shared.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_braces
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+
+# Offense count: 206
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/features/auto_inflate_spec.rb'
+    - 'spec/lib/http/features/instrumentation_spec.rb'
+    - 'spec/lib/http/features/logging_spec.rb'
+    - 'spec/lib/http/headers_spec.rb'
+    - 'spec/lib/http/options/features_spec.rb'
+    - 'spec/lib/http/options/merge_spec.rb'
+    - 'spec/lib/http/options/new_spec.rb'
+    - 'spec/lib/http/redirector_spec.rb'
+    - 'spec/lib/http/request_spec.rb'
+    - 'spec/lib/http/response_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/dummy_server/servlet.rb'
+    - 'spec/support/http_handling_shared.rb'
+    - 'spec/support/ssl_helper.rb'
+
+# Offense count: 4
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/features/instrumentation.rb'
+    - 'lib/http/features/logging.rb'
+    - 'lib/http/features/normalize_uri.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'spec/lib/http/retriable/performer_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'spec/lib/http/retriable/performer_spec.rb'
+
+# Offense count: 8
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max.
+Metrics/AbcSize:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/request.rb'
+    - 'lib/http/response.rb'
+
+# Offense count: 4
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ClassLength:
+  Exclude:
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/request.rb'
+
+# Offense count: 2
+# Configuration parameters: IgnoredMethods, Max.
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+
+# Offense count: 19
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods.
+Metrics/MethodLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/connection.rb'
+    - 'lib/http/features/auto_deflate.rb'
+    - 'lib/http/features/auto_inflate.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/request.rb'
+    - 'lib/http/response.rb'
+    - 'lib/http/response/body.rb'
+    - 'lib/http/retriable/performer.rb'
+    - 'lib/http/timeout/global.rb'
+
+# Offense count: 1
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ModuleLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+
+# Offense count: 1
+Security/CompoundHash:
+  Exclude:
+    - 'lib/http/uri.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/http/request.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Style/EmptyCaseCondition:
+  Exclude:
+    - 'lib/http/client.rb'
+    - 'lib/http/headers.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/response/status.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+Style/Encoding:
+  Exclude:
+    - 'spec/lib/http/client_spec.rb'
+    - 'spec/lib/http/request/writer_spec.rb'
+    - 'spec/lib/http/request_spec.rb'
+    - 'spec/lib/http_spec.rb'
+    - 'spec/support/dummy_server/servlet.rb'
+
+# Offense count: 71
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+# SupportedShorthandSyntax: always, never, either
+Style/HashSyntax:
+  Exclude:
+    - 'spec/lib/http/features/raise_error_spec.rb'
+    - 'spec/lib/http/retriable/delay_calculator_spec.rb'
+    - 'spec/lib/http/retriable/performer_spec.rb'
+    - 'spec/lib/http_spec.rb'
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/http/headers/normalizer.rb'
+    - 'lib/http/retriable/delay_calculator.rb'
+
+# Offense count: 17
+# Configuration parameters: SuspiciousParamNames, Allowlist.
+# SuspiciousParamNames: options, opts, args, params, parameters
+Style/OptionHash:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'lib/http/client.rb'
+    - 'lib/http/feature.rb'
+    - 'lib/http/options.rb'
+    - 'lib/http/redirector.rb'
+    - 'lib/http/timeout/null.rb'
+    - 'spec/support/dummy_server.rb'
+
+# Offense count: 4
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/http/timeout/global.rb'
+    - 'lib/http/timeout/null.rb'
+    - 'lib/http/timeout/per_operation.rb'
+    - 'lib/http/uri.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'spec/lib/http/options/proxy_spec.rb'

data/.yardopts

@@ -1,2 +1,2 @@
---markup-provider=redcarpet
+--markup-provider=kramdown
 --markup=markdown

data/CHANGELOG.md

@@ -0,0 +1,67 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+
+## [5.3.1] - 2025-06-09
+
+### Changed
+
+- Revert switch to the native llhttp on MRI, as it's not compatible with
+  standalone bundles
+  ([#802](https://github.com/httprb/http/issues/802))
+
+
+## [5.3.0] - 2025-06-09
+
+### Added
+
+- (backported) Add .retriable feature to Http
+- (backported) Add more specific ConnectionError classes
+- (backported) New feature: RaiseError
+
+### Changed
+
+- (backported) Drop depenency on base64
+- (backported) Cache header normalization to reduce object allocation
+- (backported) Use native llhttp on MRI
+
+
+## [5.2.0] - 2024-02-05
+
+### Added
+
+- Add `Connection#finished_request?`
+  ([#743](https://github.com/httprb/http/pull/743))
+- Add `Instrumentation#on_error`
+  ([#746](https://github.com/httprb/http/pull/746))
+- Add `base64` dependency (suppresses warnings on Ruby 3.0)
+  ([#759](https://github.com/httprb/http/pull/759))
+- Add `PURGE` HTTP verb
+  ([#757](https://github.com/httprb/http/pull/757))
+- Add Ruby-3.3 support
+
+### Changed
+
+- **BREAKING** Process features in reverse order
+  ([#766](https://github.com/httprb/http/pull/766))
+- **BREAKING** Downcase Content-Type charset name
+  ([#753](https://github.com/httprb/http/pull/753))
+- **BREAKING** Make URI normalization more conservative
+  ([#758](https://github.com/httprb/http/pull/758))
+
+### Fixed
+
+- Close sockets on initialize failure
+  ([#762](https://github.com/httprb/http/pull/762))
+- Prevent CRLF injection due to broken URL normalizer
+  ([#765](https://github.com/httprb/http/pull/765))
+
+[unreleased]: https://github.com/httprb/http/compare/v5.3.0...5-x-stable
+[5.3.0]: https://github.com/httprb/http/compare/v5.2.0...v5.3.0
+[5.2.0]: https://github.com/httprb/http/compare/v5.1.1...v5.2.0