http.rb 0.23.0 → 0.25.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1e4577389b2272eb97f9912694fc3e2951c64cf83758c9a6f05b544dab99f3f
-  data.tar.gz: 13574567a8fabe8ac8693cda1cd183703eb8d7f57f94da20ffe249feb4b1a52b
+  metadata.gz: e13135b5b435a5698be8796e1b9875519747ec50ef9b67c28b81e2f635f43934
+  data.tar.gz: 05adbd72d459b796093914c3e47b1be023fd543a41305b4fa42b8d90e3fc3a6a
 SHA512:
-  metadata.gz: f15f20fb2292d31e28da282fd138463234a2cead1e153a963c32a298b3fee441fcd50958203be30a103eb2c176da18f4beccdd6b362624e1c2769c1ee5b351f8
-  data.tar.gz: c8062c4c3f8ea7ffba22ac31f5e53288b8b36941651df1d087b18ec6e9bff46178e45afd421fc6218a910d61dc32e6cf410182336d058f28136b302589e1869a
+  metadata.gz: db5b30d4185591e0a52fb740514f135b4bd21e06482f160d1ecf7c6c69068e57d8b27e2af9735d8beabd8e41a33ad4f25e400d9ed9999225b576b3ef79e4d545
+  data.tar.gz: a751c3f915491a27cbea213524c5c83271b3b61b1c7b04c9c279e8f26956b718d45467a970a0eb22eb5d5d7bc710cbb6074105dbb55cdd61c7f257424a621dd2

data/CHANGELOG

@@ -2,6 +2,30 @@
 
 ## 20260522
 
+0.25.0: Remove unused internal machinery; require Ruby >= 3.2.
+
+1. ~ HTTP/verbs.rb: /"Net::HTTP::#{verb.to_s.capitalize}".to_const/Net::HTTP.const_get(verb.to_s.capitalize)/. The recursive String#to_const was overkill for a single-level lookup inside Net::HTTP; const_get does it directly.
+2. - lib/String/to_const.rb
+3. - lib/Thoran/String/ToConst/to_const.rb
+4. - lib/Thoran/Array/AllButFirst/all_but_first.rb (was only used by to_const)
+5. - lib/Thoran/Array/FirstX/firstX.rb (was only used by all_but_first)
+6. ~ lib/HTTP.rb: Remove $LOAD_PATH.unshift; rubygems puts lib/ on the load path for installed gems and bundler does the same for local development.
+7. ~ http.rb.gemspec: /required_ruby_version = '>= 2.7'/required_ruby_version = '>= 3.2'/. Aligns with the minitest 6.0 floor used in development; the runtime would still load on 2.7, but claiming compatibility with a Ruby the test suite can't be run against is a fiction worth ending before 1.0.
+8. ~ HTTP::VERSION: /0.24.0/0.25.0/
+9. ~ CHANGELOG: + 0.25.0 entry
+
+## 20260522
+
+0.24.0: ok? predicate now means 200 specifically.
+
+1. ~ Net::HTTPResponse::StatusPredicates: ok? is now defined as @code == '200' rather than aliased to successful?. The alias semantics (any 2xx) misled — "OK" is the reason-phrase for 200 specifically, not the 2xx class. Migration: callers wanting any-2xx should use successful? (or its alias success?).
+2. + test/Net/HTTPResponse/StatusPredicates_test.rb: Specs for ok? against 200, other 2xx codes, and a 4xx code.
+3. ~ README.md: Status-predicate section rewritten — single coherent reference for the predicate set, with ok? listed as 200-specific.
+4. ~ HTTP::VERSION: /0.23.0/0.24.0/
+5. ~ CHANGELOG: + 0.24.0 entry
+
+## 20260522
+
 0.23.0: Fix cross-scheme redirect SSL leak; clamp negative Retry-After.
 
 1. ~ HTTP.request: Compute http-object SSL configuration via options.merge instead of mutating the caller's options hash with auto-derived use_ssl and verify_mode. The previous ||= writes meant an HTTPS→HTTP redirect carried use_ssl: true through to the recursive call against the HTTP host, attempting an SSL handshake on the plain-HTTP port. Cross-scheme redirects in both directions now re-derive use_ssl from each URI.

data/README.md

@@ -114,48 +114,35 @@ options = {
 
 ### Response status predicate methods
 
+Every response carries predicates for each status class:
+
 ```ruby
-# 1xx
-response = HTTP.get('http://example.com')
-response.informational?
-# => true
+response.informational?   # 1xx
+response.successful?      # 2xx (aliased as success?)
+response.redirection?     # 3xx
+response.client_error?    # 4xx
+response.server_error?    # 5xx
+response.error?           # 4xx or 5xx
+response.ok?              # 200 specifically
+```
 
-# 2xx
-response = HTTP.get('http://example.com')
-response.success?
-# => true
+Redirects are followed by default, so a 3xx is only surfaced when `no_redirect` is set:
 
-# 3xx
-response = HTTP.get('http://example.com', {}, {}, {no_redirect: true})
+```ruby
+response = HTTP.get('http://example.com/moved', {}, {}, {no_redirect: true})
 response.redirection?
 # => true
-response.success?
+response.successful?
 # => false
+```
 
-response = HTTP.get('http://example.com', {}, {}, {no_redirect: false})
-response.redirection?
-# => false
-response.success?
-# => true
+Without `no_redirect`, the redirect is followed and `response` is the final destination:
 
-response = HTTP.get('http://example.com')
+```ruby
+response = HTTP.get('http://example.com/moved')
 response.redirection?
 # => false
-response.success?
-# => true
-
-# 4xx
-response = HTTP.get('http://example.com')
-response.client_error?
-# => true
-response.error?
-# => true
-
-# 5xx
-response = HTTP.get('http://example.com')
-response.server_error?
-# => true
-response.error?
+response.successful?
 # => true
 ```
 

data/http.rb.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.homepage = "http://github.com/thoran/HTTP"
   spec.license = 'MIT'
 
-  spec.required_ruby_version = '>= 2.7'
+  spec.required_ruby_version = '>= 3.2'
   spec.require_paths = ['lib']
 
   spec.files = [

data/lib/HTTP/VERSION.rb

@@ -2,5 +2,5 @@
 # HTTP::VERSION
 
 module HTTP
-  VERSION = '0.23.0'
+  VERSION = '0.25.0'
 end

data/lib/HTTP/verbs.rb

@@ -6,7 +6,6 @@ require 'net/http'
 
 require_relative '../Hash/x_www_form_urlencode'
 require_relative './request'
-require_relative '../String/to_const'
 
 module HTTP
   module VERBS
@@ -21,7 +20,7 @@ module HTTP
       unless args.empty?
         request_uri += '?' + args.x_www_form_urlencode
       end
-      request_object = "Net::HTTP::#{verb.to_s.capitalize}".to_const.new(request_uri)
+      request_object = Net::HTTP.const_get(verb.to_s.capitalize).new(request_uri)
       request(uri, request_object, headers, options, &block)
     end
 
@@ -31,7 +30,7 @@ module HTTP
   VERBS::WITH_BODY.each do |verb|
     define_method(verb) do |uri, data = {}, headers = {}, options = {}, &block|
       uri = uri.is_a?(URI) ? uri : URI.parse(uri)
-      request_object = "Net::HTTP::#{verb.to_s.capitalize}".to_const.new(uri.request_uri)
+      request_object = Net::HTTP.const_get(verb.to_s.capitalize).new(uri.request_uri)
       content_type = headers.find{|k, v| k.downcase == 'content-type'}&.last.to_s
       if data.is_a?(String)
         request_object.body = data

data/lib/HTTP.rb

@@ -1,7 +1,4 @@
 # HTTP.rb
 # HTTP
 
-lib_dir = File.expand_path(File.join(__FILE__, '..'))
-$LOAD_PATH.unshift(lib_dir) unless $LOAD_PATH.include?(lib_dir)
-
 require 'HTTP/verbs'

data/lib/Net/HTTPResponse/StatusPredicates.rb

@@ -12,7 +12,10 @@ module Net
         @code =~ /^2/ ? true : false
       end
       alias_method :success?, :successful?
-      alias_method :ok?, :successful?
+
+      def ok?
+        @code == '200'
+      end
 
       def redirection?
         @code =~ /^3/ ? true : false

data/test/Net/HTTPResponse/StatusPredicates_test.rb

@@ -0,0 +1,28 @@
+# test/Net/HTTPResponse/StatusPredicates_test.rb
+
+require_relative '../../helper'
+
+describe Net::HTTPResponse::StatusPredicates do
+  let(:response_class) do
+    Class.new do
+      include Net::HTTPResponse::StatusPredicates
+      def initialize(code); @code = code; end
+    end
+  end
+
+  describe "#ok?" do
+    it "returns true for 200" do
+      _(response_class.new('200').ok?).must_equal(true)
+    end
+
+    it "returns false for other 2xx codes" do
+      ['201', '202', '204'].each do |code|
+        _(response_class.new(code).ok?).must_equal(false)
+      end
+    end
+
+    it "returns false for non-2xx codes" do
+      _(response_class.new('404').ok?).must_equal(false)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http.rb
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.25.0
 platform: ruby
 authors:
 - thoran
@@ -102,11 +102,7 @@ files:
 - lib/Net/HTTP/set_options.rb
 - lib/Net/HTTPRequest/set_headers.rb
 - lib/Net/HTTPResponse/StatusPredicates.rb
-- lib/String/to_const.rb
 - lib/String/url_encode.rb
-- lib/Thoran/Array/AllButFirst/all_but_first.rb
-- lib/Thoran/Array/FirstX/firstX.rb
-- lib/Thoran/String/ToConst/to_const.rb
 - lib/URI/Generic/use_sslQ.rb
 - test/HTTP/RETRY_test.rb
 - test/HTTP/delete_test.rb
@@ -117,6 +113,7 @@ files:
 - test/HTTP/post_test.rb
 - test/HTTP/put_test.rb
 - test/HTTP/trace_test.rb
+- test/Net/HTTPResponse/StatusPredicates_test.rb
 - test/helper.rb
 homepage: http://github.com/thoran/HTTP
 licenses:
@@ -129,7 +126,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/String/to_const.rb

@@ -1,7 +0,0 @@
-# String/to_const.rb
-# String#to_const
-
-# 20250819
-# 0.2.0
-
-require 'Thoran/String/ToConst/to_const'

data/lib/Thoran/Array/AllButFirst/all_but_first.rb

@@ -1,28 +0,0 @@
-# Thoran/Array/AllButFirst/all_but_first.rb
-# Thoran::Array::AllButFirst#all_but_first
-
-# 20141223
-# 0.1.0
-
-# Description: This returns a copy of the receiving array with the first element removed.  
-
-# Changes:
-# 1. + Thoran namespace.
-
-require 'Thoran/Array/FirstX/firstX'
-
-module Thoran
-  module Array
-    module AllButFirst
-
-      def all_but_first
-        d = self.dup
-        d.first!
-        d
-      end
-
-    end
-  end
-end
-
-Array.send(:include, Thoran::Array::AllButFirst)

data/lib/Thoran/Array/FirstX/firstX.rb

@@ -1,32 +0,0 @@
-# Thoran/Array/FirstX/firstX.rb
-# Thoran::Array::FirstX#first!
-
-# 20180804
-# 0.3.3
-
-# Description: Sometimes it makes more sense to treat arrays this way.
-
-# Changes since 0.2:
-# 1. Added the original version 0.1.0 of the implementation to the later 0.1.0!
-# 0/1
-# 2. Switched the tests to spec-style.
-# 1/2
-# 3. Added a test for the state of the array afterward, since this is meant to be an in place change.
-# 2/3
-# 4. Added tests for the extended functionality introduced in the first version 0.1.0.
-
-module Thoran
-  module Array
-    module FirstX
-
-      def first!(n = 1)
-        return_value = []
-        n.times{return_value << self.shift}
-        return_value.size == 1 ? return_value[0] : return_value
-      end
-
-    end
-  end
-end
-
-Array.send(:include, Thoran::Array::FirstX)

data/lib/Thoran/String/ToConst/to_const.rb

@@ -1,47 +0,0 @@
-# Thoran/String/ToConst/to_const.rb
-# Thoran::String::ToConst#to_const
-
-# 20141223
-# 0.2.0
-
-# Description: This takes a string and returns a constant, with unlimited namespacing.
-
-# History: Derived from Object#to_const 0.3.0, and superceding Object#to_const.
-
-# Changes:
-# 1. + Thoran namespace.
-
-# Todo:
-# 1. This only works for two levels of constants.  Three and you're stuffed.  So, this needs to be recursive...
-#   Done iteratively as of 0.1.0.
-# 2. Make this work for symbols.  However, this will only work if there's no namespacing.  ie. :A is OK, but :A::B is not.
-
-# Discussion:
-# 1. Should this go separately into classes for which ::const_get will work and be removed from Object?  Done as of 0.1.0.
-
-require 'Thoran/Array/AllButFirst/all_but_first'
-
-module Thoran
-  module String
-    module ToConst
-
-      def to_const
-        if self =~ /::/
-          constants = self.split('::')
-          constant = Object.const_get(constants.first)
-          constants = constants.all_but_first
-          until constants.empty? do
-            constant = constant.const_get(constants.shift)
-          end
-        else
-          constant = Object.const_get(self)
-        end
-        constant
-      end
-      alias_method :to_constant, :to_const
-
-    end
-  end
-end
-
-String.send(:include, Thoran::String::ToConst)