http.rb 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1e4577389b2272eb97f9912694fc3e2951c64cf83758c9a6f05b544dab99f3f
-  data.tar.gz: 13574567a8fabe8ac8693cda1cd183703eb8d7f57f94da20ffe249feb4b1a52b
+  metadata.gz: 192aecaee0d22accbabb0b03b00f987cf7902c4958d6d5dab823515f4e681408
+  data.tar.gz: 1adb47bbf1b800b6e3fa9f7767db4a5b63f0b23abe12547056e564bda0c76713
 SHA512:
-  metadata.gz: f15f20fb2292d31e28da282fd138463234a2cead1e153a963c32a298b3fee441fcd50958203be30a103eb2c176da18f4beccdd6b362624e1c2769c1ee5b351f8
-  data.tar.gz: c8062c4c3f8ea7ffba22ac31f5e53288b8b36941651df1d087b18ec6e9bff46178e45afd421fc6218a910d61dc32e6cf410182336d058f28136b302589e1869a
+  metadata.gz: 608a398a78d14c9ba1a40db7478510b5a25cc073898a9fa1759c783b3aec8b9f6846597662972f15552f561a6f9e8269485053aab2f707e874f0c753a98144df
+  data.tar.gz: 8d9e7449e938c01bad80526aa566cc9886c76df5020cbc556dd458e1acb6f0c2af1b23d3b53dc872df39ec6f27f1c828bbe5bcdc9cfea31c4b5cd3167e129c1d

data/CHANGELOG

@@ -2,6 +2,16 @@
 
 ## 20260522
 
+0.24.0: ok? predicate now means 200 specifically.
+
+1. ~ Net::HTTPResponse::StatusPredicates: ok? is now defined as @code == '200' rather than aliased to successful?. The alias semantics (any 2xx) misled — "OK" is the reason-phrase for 200 specifically, not the 2xx class. Migration: callers wanting any-2xx should use successful? (or its alias success?).
+2. + test/Net/HTTPResponse/StatusPredicates_test.rb: Specs for ok? against 200, other 2xx codes, and a 4xx code.
+3. ~ README.md: Status-predicate section rewritten — single coherent reference for the predicate set, with ok? listed as 200-specific.
+4. ~ HTTP::VERSION: /0.23.0/0.24.0/
+5. ~ CHANGELOG: + 0.24.0 entry
+
+## 20260522
+
 0.23.0: Fix cross-scheme redirect SSL leak; clamp negative Retry-After.
 
 1. ~ HTTP.request: Compute http-object SSL configuration via options.merge instead of mutating the caller's options hash with auto-derived use_ssl and verify_mode. The previous ||= writes meant an HTTPS→HTTP redirect carried use_ssl: true through to the recursive call against the HTTP host, attempting an SSL handshake on the plain-HTTP port. Cross-scheme redirects in both directions now re-derive use_ssl from each URI.

data/README.md

@@ -114,48 +114,35 @@ options = {
 
 ### Response status predicate methods
 
+Every response carries predicates for each status class:
+
 ```ruby
-# 1xx
-response = HTTP.get('http://example.com')
-response.informational?
-# => true
+response.informational?   # 1xx
+response.successful?      # 2xx (aliased as success?)
+response.redirection?     # 3xx
+response.client_error?    # 4xx
+response.server_error?    # 5xx
+response.error?           # 4xx or 5xx
+response.ok?              # 200 specifically
+```
 
-# 2xx
-response = HTTP.get('http://example.com')
-response.success?
-# => true
+Redirects are followed by default, so a 3xx is only surfaced when `no_redirect` is set:
 
-# 3xx
-response = HTTP.get('http://example.com', {}, {}, {no_redirect: true})
+```ruby
+response = HTTP.get('http://example.com/moved', {}, {}, {no_redirect: true})
 response.redirection?
 # => true
-response.success?
+response.successful?
 # => false
+```
 
-response = HTTP.get('http://example.com', {}, {}, {no_redirect: false})
-response.redirection?
-# => false
-response.success?
-# => true
+Without `no_redirect`, the redirect is followed and `response` is the final destination:
 
-response = HTTP.get('http://example.com')
+```ruby
+response = HTTP.get('http://example.com/moved')
 response.redirection?
 # => false
-response.success?
-# => true
-
-# 4xx
-response = HTTP.get('http://example.com')
-response.client_error?
-# => true
-response.error?
-# => true
-
-# 5xx
-response = HTTP.get('http://example.com')
-response.server_error?
-# => true
-response.error?
+response.successful?
 # => true
 ```
 

data/lib/HTTP/VERSION.rb

@@ -2,5 +2,5 @@
 # HTTP::VERSION
 
 module HTTP
-  VERSION = '0.23.0'
+  VERSION = '0.24.0'
 end

data/lib/Net/HTTPResponse/StatusPredicates.rb

@@ -12,7 +12,10 @@ module Net
         @code =~ /^2/ ? true : false
       end
       alias_method :success?, :successful?
-      alias_method :ok?, :successful?
+
+      def ok?
+        @code == '200'
+      end
 
       def redirection?
         @code =~ /^3/ ? true : false

data/test/Net/HTTPResponse/StatusPredicates_test.rb

@@ -0,0 +1,28 @@
+# test/Net/HTTPResponse/StatusPredicates_test.rb
+
+require_relative '../../helper'
+
+describe Net::HTTPResponse::StatusPredicates do
+  let(:response_class) do
+    Class.new do
+      include Net::HTTPResponse::StatusPredicates
+      def initialize(code); @code = code; end
+    end
+  end
+
+  describe "#ok?" do
+    it "returns true for 200" do
+      _(response_class.new('200').ok?).must_equal(true)
+    end
+
+    it "returns false for other 2xx codes" do
+      ['201', '202', '204'].each do |code|
+        _(response_class.new(code).ok?).must_equal(false)
+      end
+    end
+
+    it "returns false for non-2xx codes" do
+      _(response_class.new('404').ok?).must_equal(false)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http.rb
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - thoran
@@ -117,6 +117,7 @@ files:
 - test/HTTP/post_test.rb
 - test/HTTP/put_test.rb
 - test/HTTP/trace_test.rb
+- test/Net/HTTPResponse/StatusPredicates_test.rb
 - test/helper.rb
 homepage: http://github.com/thoran/HTTP
 licenses: