http.rb 0.21.0 → 0.22.0

data/test/HTTP/delete_test.rb

@@ -0,0 +1,265 @@
+# test/HTTP/delete_test.rb
+
+require_relative '../helper'
+
+describe ".delete" do
+  describe "with uri-only supplied" do
+    before do
+      stub_request(:delete, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "uri as a string" do
+      let(:uri){'http://example.com/path'}
+
+      it "creates an instance of URI" do
+        received_arg = nil
+        parsed_uri = URI.parse(uri)
+        URI.stub(:parse, ->(arg){received_arg = arg; parsed_uri}) do
+          response = HTTP.delete(uri)
+          _(received_arg).must_equal(uri)
+          _(response.success?).must_equal(true)
+        end
+      end
+
+      it "creates a new Net::HTTP object" do
+        received_args = nil
+        parsed_uri = URI.parse(uri)
+        net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+        Net::HTTP.stub(:new, ->(*args){received_args = args; net_http_object}) do
+          response = HTTP.delete(uri)
+          _(received_args).must_equal([parsed_uri.host, parsed_uri.port])
+          _(response.success?).must_equal(true)
+        end
+      end
+    end
+
+    describe "uri as a URI" do
+      let(:uri){URI.parse('http://example.com/path')}
+
+      it "creates a new Net::HTTP object" do
+        received_args = nil
+        net_http_object = Net::HTTP.new(uri.host, uri.port)
+        Net::HTTP.stub(:new, ->(*args){received_args = args; net_http_object}) do
+          response = HTTP.delete(uri)
+          _(received_args).must_equal([uri.host, uri.port])
+          _(response.success?).must_equal(true)
+        end
+      end
+    end
+  end
+
+  describe "with args supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:delete, 'http://example.com/path?a=1&b=2').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "x_www_form_urlencode's the args" do
+      args = {a: 1, b: 2}
+      called = false
+      args.stub(:x_www_form_urlencode, ->{called = true; 'a=1&b=2'}) do
+        response = HTTP.delete(uri, args)
+        _(called).must_equal(true)
+        _(response.success?).must_equal(true)
+      end
+    end
+
+    it "creates a new Net::HTTP::Delete object" do
+      received_arg = nil
+      delete_argument = parsed_uri.request_uri + '?a=1&b=2'
+      request_object = Net::HTTP::Delete.new(delete_argument)
+      Net::HTTP::Delete.stub(:new, ->(arg){received_arg = arg; request_object}) do
+        response = HTTP.delete(uri, {a: 1, b: 2})
+        _(received_arg).must_equal(delete_argument)
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with headers supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:delete, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Minitest'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "sets the headers on the request object" do
+      request_object = Net::HTTP::Delete.new(parsed_uri.request_uri)
+      Net::HTTP::Delete.stub(:new, request_object) do
+        response = HTTP.delete(uri, {}, {'User-Agent' => 'Minitest'})
+        _(request_object['User-Agent']).must_equal('Minitest')
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with options supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:delete, 'https://example.com:80/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "sets the use_ssl option on the Net::HTTP instance" do
+      net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+      Net::HTTP.stub(:new, net_http_object) do
+        response = HTTP.delete(uri, {}, {}, {use_ssl: true})
+        _(net_http_object.instance_variable_get(:@use_ssl)).must_equal(true)
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with block supplied" do
+    let(:uri){'http://example.com/path'}
+
+    before do
+      stub_request(:delete, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "yields an instance of Net::HTTPResponse" do
+      yielded = nil
+      HTTP.delete(uri){|response| yielded = response}
+      _(yielded).must_be_kind_of(Net::HTTPResponse)
+    end
+  end
+
+  describe "with redirection" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_uri){'http://redirected.com'}
+
+    before do
+      stub_request(:get, redirect_uri).
+        to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "via 301" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 301, headers: {'location' => redirect_uri})
+      end
+
+      it "follows the redirect" do
+        response = HTTP.delete(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:delete, request_uri)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 302, headers: {'location' => redirect_uri})
+      end
+
+      it "follows the redirect" do
+        response = HTTP.delete(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:delete, request_uri)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+  end
+
+  describe "with path only redirection" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_path){'/new_path'}
+    let(:redirect_uri){"http://example.com#{redirect_path}"}
+
+    before do
+      stub_request(:get, redirect_uri).
+        to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "via 301" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 301, headers: {'location' => redirect_path})
+      end
+
+      it "resolves the relative redirect against the original URI" do
+        response = HTTP.delete(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 302, headers: {'location' => redirect_path})
+      end
+
+      it "resolves the relative redirect against the original URI" do
+        response = HTTP.delete(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+  end
+
+  describe "with verb-preserving redirection via 307" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_uri){'http://redirected.com'}
+
+    before do
+      stub_request(:delete, request_uri).
+        to_return(status: 307, headers: {'location' => redirect_uri})
+      stub_request(:delete, redirect_uri).
+        to_return(status: 200, body: '', headers: {})
+    end
+
+    it "preserves the verb" do
+      response = HTTP.delete(request_uri)
+      _(response.success?).must_equal(true)
+      assert_requested(:delete, request_uri)
+      assert_requested(:delete, redirect_uri)
+    end
+  end
+
+  describe "no_redirect true" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_uri){'http://redirected.com'}
+
+    describe "via 301" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 301, headers: {'location' => redirect_uri})
+      end
+
+      it "returns the redirect response without following it" do
+        response = HTTP.delete(request_uri, {}, {}, {no_redirect: true})
+        _(response.redirection?).must_equal(true)
+        assert_not_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:delete, request_uri).
+          to_return(status: 302, headers: {'location' => redirect_uri})
+      end
+
+      it "returns the redirect response without following it" do
+        response = HTTP.delete(request_uri, {}, {}, {no_redirect: true})
+        _(response.redirection?).must_equal(true)
+        assert_not_requested(:get, redirect_uri)
+      end
+    end
+  end
+end

data/test/HTTP/get_test.rb

@@ -0,0 +1,304 @@
+# test/HTTP/get_test.rb
+
+require_relative '../helper'
+
+describe ".get" do
+  describe "with uri-only supplied" do
+    before do
+      stub_request(:get, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "uri as a string" do
+      let(:uri){'http://example.com/path'}
+
+      it "creates an instance of URI" do
+        received_arg = nil
+        parsed_uri = URI.parse(uri)
+        URI.stub(:parse, ->(arg){received_arg = arg; parsed_uri}) do
+          response = HTTP.get(uri)
+          _(received_arg).must_equal(uri)
+          _(response.success?).must_equal(true)
+        end
+      end
+
+      it "creates a new Net::HTTP object" do
+        received_args = nil
+        parsed_uri = URI.parse(uri)
+        net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+        Net::HTTP.stub(:new, ->(*args){received_args = args; net_http_object}) do
+          response = HTTP.get(uri)
+          _(received_args).must_equal([parsed_uri.host, parsed_uri.port])
+          _(response.success?).must_equal(true)
+        end
+      end
+    end
+
+    describe "uri as a URI" do
+      let(:uri){URI.parse('http://example.com/path')}
+
+      it "creates a new Net::HTTP object" do
+        received_args = nil
+        net_http_object = Net::HTTP.new(uri.host, uri.port)
+        Net::HTTP.stub(:new, ->(*args){received_args = args; net_http_object}) do
+          response = HTTP.get(uri)
+          _(received_args).must_equal([uri.host, uri.port])
+          _(response.success?).must_equal(true)
+        end
+      end
+    end
+  end
+
+  describe "with args supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:get, 'http://example.com/path?a=1&b=2').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "x_www_form_urlencode's the args" do
+      args = {a: 1, b: 2}
+      called = false
+      args.stub(:x_www_form_urlencode, ->{called = true; 'a=1&b=2'}) do
+        response = HTTP.get(uri, args)
+        _(called).must_equal(true)
+        _(response.success?).must_equal(true)
+      end
+    end
+
+    it "creates a new Net::HTTP::Get object" do
+      received_arg = nil
+      get_argument = parsed_uri.request_uri + '?a=1&b=2'
+      request_object = Net::HTTP::Get.new(get_argument)
+      Net::HTTP::Get.stub(:new, ->(arg){received_arg = arg; request_object}) do
+        response = HTTP.get(uri, {a: 1, b: 2})
+        _(received_arg).must_equal(get_argument)
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with headers supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:get, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Minitest'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "sets the headers on the request object" do
+      request_object = Net::HTTP::Get.new(parsed_uri.request_uri)
+      Net::HTTP::Get.stub(:new, request_object) do
+        response = HTTP.get(uri, {}, {'User-Agent' => 'Minitest'})
+        _(request_object['User-Agent']).must_equal('Minitest')
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with options supplied" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:get, 'https://example.com:80/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "sets the use_ssl option on the Net::HTTP instance" do
+      net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+      Net::HTTP.stub(:new, net_http_object) do
+        response = HTTP.get(uri, {}, {}, {use_ssl: true})
+        _(net_http_object.instance_variable_get(:@use_ssl)).must_equal(true)
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with default verify_mode" do
+    let(:uri){'http://example.com/path'}
+    let(:parsed_uri){URI.parse(uri)}
+
+    before do
+      stub_request(:get, uri).
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "defaults verify_mode to OpenSSL::SSL::VERIFY_PEER" do
+      net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+      Net::HTTP.stub(:new, net_http_object) do
+        response = HTTP.get(uri)
+        _(net_http_object.verify_mode).must_equal(OpenSSL::SSL::VERIFY_PEER)
+        _(response.success?).must_equal(true)
+      end
+    end
+
+    it "allows opting back into VERIFY_NONE via options" do
+      net_http_object = Net::HTTP.new(parsed_uri.host, parsed_uri.port)
+      Net::HTTP.stub(:new, net_http_object) do
+        response = HTTP.get(uri, {}, {}, {verify_mode: OpenSSL::SSL::VERIFY_NONE})
+        _(net_http_object.verify_mode).must_equal(OpenSSL::SSL::VERIFY_NONE)
+        _(response.success?).must_equal(true)
+      end
+    end
+  end
+
+  describe "with block supplied" do
+    let(:uri){'http://example.com/path'}
+
+    before do
+      stub_request(:get, 'http://example.com/path').
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    it "yields an instance of Net::HTTPResponse" do
+      yielded = nil
+      HTTP.get(uri){|response| yielded = response}
+      _(yielded).must_be_kind_of(Net::HTTPResponse)
+    end
+  end
+
+  describe "with redirection" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_uri){'http://redirected.com'}
+
+    before do
+      stub_request(:get, redirect_uri).
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "via 301" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 301, body: '', headers: {'location' => redirect_uri})
+      end
+
+      it "follows the redirect" do
+        response = HTTP.get(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, request_uri)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 302, body: '', headers: {'location' => redirect_uri})
+      end
+
+      it "follows the redirect" do
+        response = HTTP.get(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, request_uri)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+  end
+
+  describe "with path only redirection" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_path){'/new_path'}
+    let(:redirect_uri){"http://example.com#{redirect_path}"}
+
+    before do
+      stub_request(:get, redirect_uri).
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+    end
+
+    describe "via 301" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 301, body: '', headers: {'location' => redirect_path})
+      end
+
+      it "resolves the relative redirect against the original URI" do
+        response = HTTP.get(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 302, body: '', headers: {'location' => redirect_path})
+      end
+
+      it "resolves the relative redirect against the original URI" do
+        response = HTTP.get(request_uri)
+        _(response.success?).must_equal(true)
+        assert_requested(:get, redirect_uri)
+      end
+    end
+  end
+
+  describe "with path only redirection from HTTPS" do
+    let(:request_uri){'https://example.com/path'}
+    let(:redirect_path){'/new_path'}
+    let(:redirect_uri){"https://example.com#{redirect_path}"}
+
+    before do
+      stub_request(:get, redirect_uri).
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: '', headers: {})
+      stub_request(:get, request_uri).
+        with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(status: 301, body: '', headers: {'location' => redirect_path})
+    end
+
+    it "preserves the HTTPS scheme on a relative redirect" do
+      response = HTTP.get(request_uri)
+      _(response.success?).must_equal(true)
+      assert_requested(:get, redirect_uri)
+    end
+  end
+
+  describe "no_redirect true" do
+    let(:request_uri){'http://example.com/path'}
+    let(:redirect_uri){'http://redirected.com'}
+
+    describe "via 301" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 301, body: '', headers: {'location' => redirect_uri})
+      end
+
+      it "returns the redirect response without following it" do
+        response = HTTP.get(request_uri, {}, {}, {no_redirect: true})
+        _(response.redirection?).must_equal(true)
+        assert_not_requested(:get, redirect_uri)
+      end
+    end
+
+    describe "via 302" do
+      before do
+        stub_request(:get, request_uri).
+          with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+            to_return(status: 302, body: '', headers: {'location' => redirect_uri})
+      end
+
+      it "returns the redirect response without following it" do
+        response = HTTP.get(request_uri, {}, {}, {no_redirect: true})
+        _(response.redirection?).must_equal(true)
+        assert_not_requested(:get, redirect_uri)
+      end
+    end
+  end
+end