http-retry-after 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b63c0a78e43c4969c1d9e7b6ba97c9ce3cc812733099742bd9e83d5553c70ee7
-  data.tar.gz: 865afe31ede0b564fc8d39adff283341867aa3f944ab91ed860c21d9630b4eeb
+  metadata.gz: 5cba00245cea0af17f0af45b2fed6bf791ffc0fc0ece1d63174fdd0b4f9bd21b
+  data.tar.gz: 12520273c74bbf845c3b050e00aed56162bdb9ee76017fff94eff788686847a3
 SHA512:
-  metadata.gz: 720502473aac539815c50b2698da5670492dfea7a4743111c2011d1250f12795399300f09caa85b2c6d0f1f13f33e6178283f44fa80f8bd9dd254c4a4d247d75
-  data.tar.gz: 7025636d7ed303f7b629adab5967e69af2442d64d28ac065cd2a566e232537a71d3cf1697088a23ca5dd776390b7fd5ebfec7c8401a76ccd805f4307d7600b3a
+  metadata.gz: 9af7b8a8975f9d7fa2996d9f40f2870ef2e903ab5bec3d23940230196145800a3188b0d9d8bc6decd712be16ad26206682e3984e089e18f1fa1c759109f73d90
+  data.tar.gz: 866dc47b25b8609c834265434b75990ef4c401ce952a22af1dfcfafbe323dd523bb4f871e86d9b80ed490ada34d454259257e00ae25197813616fff5a95299e6

data/.github/workflows/ci.yml

@@ -14,8 +14,8 @@ jobs:
         ruby: ["3.1", "3.2", "3.3", "3.4"]
 
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: ruby/setup-ruby@0481980f17b760ef6bca5e8c55809102a0af1e5a # v1.263.0
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+      - uses: ruby/setup-ruby@4c24fa5ec04b2e79eb40571b1cee2a0d2b705771 # v1.278.0
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true

data/.github/workflows/release-please.yml

@@ -0,0 +1,35 @@
+name: release-please
+
+on:
+  push:
+    branches:
+      - main
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+    steps:
+      - id: release
+        uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0
+        with:
+          release-type: ruby
+  deploy:
+    runs-on: ubuntu-latest
+    needs:
+      - release-please
+    if: ${{ needs.release-please.outputs.release_created }}
+    steps:
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+      - uses: ruby/setup-ruby@4c24fa5ec04b2e79eb40571b1cee2a0d2b705771 # v1.278.0
+        with:
+          ruby-version: "3.3"
+      - run: gem build http-retry-after.gemspec
+      - run: gem push pkg/http-retry-after-*.gem
+        env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}

data/AGENTS.md

@@ -0,0 +1,38 @@
+# Repository Guidelines
+
+## Project Structure
+
+- Core implementation: `lib/http/retry_after.rb` contains parsing logic; `lib/http/retry_after/version.rb` holds the version. `http-retry-after.gemspec` defines gem metadata and Ruby requirement (>= 3.0).
+- Tests: Minitest specs in `test/**/*_test.rb`; default Rake task runs them. `test/test_helper.rb` sets load paths and requires the gem.
+- Build outputs: `pkg/` is used for built gems. `CHANGELOG.md` tracks releases; `LICENSE.txt` is MIT.
+
+## Setup and Development
+
+- Install dependencies: `bundle install`.
+- Run tests: `bundle exec rake test` (or `bundle exec rake`; default task is test).
+- REPL check: `bundle exec irb -Ilib -rhttp/retry_after` to try parsing helpers interactively.
+- Build gem: `gem build http-retry-after.gemspec`; keep `pkg/` clean between builds.
+- Release CI Ruby version: set `release-please.yml` `ruby-version` to the stable version used in CI matrix (prefer latest stable; update when CI matrix changes).
+
+## Coding Style and Naming
+
+- Ruby 2-space indentation; keep `# frozen_string_literal: true` at the top of Ruby files.
+- Public API: `HTTP::RetryAfter.parse`, `parse_seconds`, `parse_http_date`. Reuse `NegativeRetryAfterError` and `InvalidFormatError`; keep messages aligned with `"Invalid Retry-After value: ..."` style.
+- Keep rescue blocks minimal; rely on `Integer(...)` and `Time.httpdate` behavior for parsing. Avoid new external dependencies or monkey patches.
+
+## Testing Guidelines
+
+- Framework: Minitest. Add cases to `*_test.rb`, using existing assertions (`assert_raises`, `assert_in_delta`) as patterns.
+- Time-sensitive logic: wrap `Time.now` calculations with `assert_in_delta`; cover boundaries (negative values, nil, malformed strings).
+- Run `bundle exec rake test` before PRs; add regression tests when altering time math or error handling.
+
+## Commit and Pull Request
+
+- Commit style mirrors current history: Conventional Commits-like prefixes (`feat|fix|chore|docs: ...`) with issue numbers `(#123)` when relevant.
+- PRs: include summary, motivation, key changes, and test results as bullets. Update `CHANGELOG.md` for user-visible changes.
+- Keep one concern per PR, ensure Rake tests pass, and attach repro steps or screenshots only when helpful.
+
+## Security and Maintenance
+
+- Do not commit secrets. Treat header values as untrusted input; preserve validation and consistent exceptions.
+- Renovate (`renovate.json`) updates dependencies; confirm tests/CI before merging. If Ruby version requirements change, update the gemspec and README together.

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.1.1](https://github.com/kudoas/http-retry-after/compare/v0.1.0...v0.1.1) (2026-01-02)
+
+
+### Bug Fixes
+
+* improve error handling in parse_seconds and parse_http_date methods ([#4](https://github.com/kudoas/http-retry-after/issues/4)) ([558c11b](https://github.com/kudoas/http-retry-after/commit/558c11b81f04bb9184bd1678b4c20d819c05d6e7))
+
 ## [Unreleased]
 
 - No changes yet.

data/Gemfile.lock

@@ -6,8 +6,8 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    minitest (5.25.5)
-    rake (13.3.0)
+    minitest (5.27.0)
+    rake (13.3.1)
 
 PLATFORMS
   arm64-darwin-25

data/README.md

@@ -1,5 +1,7 @@
 # http-retry-after
 
+[![Gem Version](https://badge.fury.io/rb/http-retry-after.svg?icon=si%3Arubygems)](https://badge.fury.io/rb/http-retry-after)
+
 `http-retry-after` is a Ruby gem for parsing HTTP `Retry-After` header values and converting them into Ruby `Time` instances, so clients can respect server retry policies defined in RFC 9110 without reimplementing parsing logic.
 
 ## What is Retry-After?
@@ -11,7 +13,7 @@ The HTTP `Retry-After` response header, defined in [RFC 9110, Section 10.2.2](ht
 Require the gem and call `HTTP::RetryAfter.parse` with either a delta-seconds value or an HTTP-date string:
 
 ```ruby
-require "http-retry-after"
+require "http/retry-after"
 
 # Delta-seconds value (interpreted as seconds from now)
 HTTP::RetryAfter.parse("120")
@@ -53,7 +55,7 @@ Both helpers return a `Time` object. `parse_seconds` uses `Time.now + seconds`,
 Add this line to your application's Gemfile:
 
 ```ruby
-gem "http-retry-after", github: "kudoas/http-retry-after"
+gem "http-retry-after"
 ```
 
 And then execute:

data/http-retry-after.gemspec

@@ -6,9 +6,9 @@ Gem::Specification.new do |spec|
   spec.name          = "http-retry-after"
   spec.version       = HTTP::RetryAfter::VERSION
   spec.authors       = ["Daichi KUDO"]
-  spec.summary       = "A Ruby library for handling HTTP Retry-After headers."
+  spec.summary       = "A Ruby gem for handling HTTP Retry-After headers."
   spec.description   = <<~DESC
-    HTTP::RetryAfter is a Ruby library that provides functionality to parse and handle HTTP Retry-After headers, which indicate how long a client should wait before making a follow-up request.
+    HTTP::RetryAfter is a Ruby gem that provides functionality to parse and handle HTTP Retry-After headers, which indicate how long a client should wait before making a follow-up request.
   DESC
   spec.homepage      = "https://github.com/kudoas/http-retry-after"
   spec.license       = "MIT"

data/lib/http/retry_after/version.rb

@@ -2,6 +2,6 @@
 
 module HTTP
   module RetryAfter
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/lib/http/retry_after.rb

@@ -17,17 +17,20 @@ module HTTP
     def self.parse_seconds(retry_after)
       seconds = begin
         Integer(retry_after)
-      rescue
+      rescue TypeError, ArgumentError
         raise InvalidFormatError, "Invalid Retry-After value: #{retry_after.inspect}"
       end
 
       raise NegativeRetryAfterError, "Negative Retry-After value: #{seconds}" if seconds.negative?
+
       Time.now + seconds
     end
 
     def self.parse_http_date(retry_after)
+      raise InvalidFormatError, "Invalid Retry-After value: #{retry_after.inspect}" if retry_after.nil?
+
       Time.httpdate(retry_after)
-    rescue
+    rescue ArgumentError, NoMethodError, TypeError
       raise InvalidFormatError, "Invalid Retry-After value: #{retry_after.inspect}"
     end
   end

data/renovate.json

@@ -0,0 +1,6 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "config:recommended"
+  ]
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http-retry-after
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Daichi KUDO
@@ -9,7 +9,7 @@ bindir: bin
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies: []
-description: 'HTTP::RetryAfter is a Ruby library that provides functionality to parse
+description: 'HTTP::RetryAfter is a Ruby gem that provides functionality to parse
   and handle HTTP Retry-After headers, which indicate how long a client should wait
   before making a follow-up request.
 
@@ -19,7 +19,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/ci.yml"
+- ".github/workflows/release-please.yml"
 - ".gitignore"
+- AGENTS.md
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -30,6 +32,7 @@ files:
 - lib/http-retry-after.rb
 - lib/http/retry_after.rb
 - lib/http/retry_after/version.rb
+- renovate.json
 - test/http_retry_after_test.rb
 - test/test_helper.rb
 homepage: https://github.com/kudoas/http-retry-after
@@ -52,7 +55,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 4.0.3
 specification_version: 4
-summary: A Ruby library for handling HTTP Retry-After headers.
+summary: A Ruby gem for handling HTTP Retry-After headers.
 test_files: []