http-negotiate 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c40df3f0c699e99b0f45c3af71e19e5461878bddecf1a8a28a4125965cc05c9
-  data.tar.gz: 58dfdd11e0a9b119f5e84bdb24e8d2d28145e91d7a8fa3d5d3067572d1c2980e
+  metadata.gz: d699dd657fff5ae1a330a54f83b33b9d091a455e052566270e3ff697e4eedc97
+  data.tar.gz: baae101cbbe136cf67f698eb4fb6990fc43e6194f4dbebcd7acc786911ec5c2d
 SHA512:
-  metadata.gz: 0610a598b694dfa3a147257e160dfbfafcde951715ff7329f489b22e097490e2999f84a8401ef6019183f30fbbdbe01c31c4daf7dd9abcab34402add0a1f96bc
-  data.tar.gz: b3a19ba49afe90cd32aba42046ec57af147bb1a12f7087102fed03e5520c30cc33fecc41785a226cf7a5680298adcb59ea2b14a9bcd6950db3b2148109a070be
+  metadata.gz: ef0b67b2cb482168f9effe5900efb1f1be8c24a42fde4ddb3d51669b950d63e42f651c5b5cd6062172dff940ad4b27741b24648560a7d72343354969bdb7bafb
+  data.tar.gz: bd297a0bb246293fb405da83eafdf5226ffd38aedabf648c1d88234177c12a63a59e9cdb0ca7dc6e0462b0a1c4ac55707ffa0a8a4fd6cbe74fc53f0dd0ebec42

data/lib/http/negotiate/version.rb

@@ -1,5 +1,5 @@
 module HTTP
   module Negotiate
-    VERSION = '0.2.0'
+    VERSION = '0.2.2'
   end
 end

data/lib/http/negotiate.rb

@@ -55,18 +55,19 @@ module HTTP::Negotiate
         # theoretically you can have quoted-string parameter values
         # but we don't care (although interestingly according to rfc7231,
         # accept-language only affords q= and not arbitrary parameters)
-        hdr = hdr.dup.gsub(/\s+/, '')
+        hdr = hdr.respond_to?(:to_a) ? hdr.to_a.dup : hdr.to_s.split(/\s*,+\s*/)
+        hdr = hdr.map { |h| h.to_s.gsub(/\s+/, '') }.reject(&:empty?)
 
         # don't add the test group if it's an empty string, because
         # postel's law is a thing
         next if hdr.empty?
 
-        accept[k] = hdr.split(/,+/).map do |c|
+        accept[k] = hdr.map do |c|
           val, *params = c.split(/;+/)
           params = params.map do |p|
-            k, v = p.split(/=+/, 2)
+            k, v = p.split(/\s*=+\s*/, 2)
             k = k.downcase.to_sym
-            v = v.to_f if v and k == :q
+            v = v.to_f if v and k == :q # note garbage will return 0
             [k, v]
           end.to_h
           if params[:q]
@@ -228,12 +229,14 @@ module HTTP::Negotiate
              else
                0.1
              end
-
       end
 
       scores[var] = [qs * qe * qc * ql * qt, size]
     end
 
+    # DUH DON'T FORGET TO NUKE THE ZERO SCORES
+    scores.reject! { |_, s| s.first == 0 }
+
     # XXX do something smarter here for secondary comparison
     cmp ||= -> a, b { 0 }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: http-negotiate
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Dorian Taylor
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2024-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler