http-exceptions 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dd2e0213e9efb0ed35cb07bd193f9b86ce0f9d5
-  data.tar.gz: 243069506cecfd6c0ddfc1bd547147316a555f18
+  metadata.gz: 03bd2eec282320ea2757da660f823694333ec23d
+  data.tar.gz: aa793159eb0c1f53c1528a250f7272664e41f871
 SHA512:
-  metadata.gz: 7deb67a6d04d8eb57c9e23a57862630f241f1958b5e3fc7378abcd9510ec36fc5f909211a4c07d5ffcef4289877b7ad966c4e7d82d6f6ae6f516737c237ea810
-  data.tar.gz: e106195b15e6c5edb957d7a26549b19c3f8ccabb2af0ab9388d5bae449d9f20a9c0219be35d5a57eafa3ef5a3e6d30ef22d9c3dc092ada8d0d687ddca2dee872
+  metadata.gz: dd355b76607a59d58bb287af11e062e0912ddb08cd0adca784ca96cc373bb0194a9ccfdbe768c66473becd39c1253d4246c1f267f10e4910e597b6b1090fb0dc
+  data.tar.gz: bbc6ecf77d7ec8913adafe9e7b19ae008d76f3a42f4cf0ee102670882361c2ed83e81dbe5ebeb3454721303f0217ce72886ae89b8e2908aeeb7af5a0a78ab324

data/http-exceptions.gemspec

@@ -6,11 +6,11 @@ require 'http/exceptions/version'
 Gem::Specification.new do |spec|
   spec.name          = "http-exceptions"
   spec.version       = Http::Exceptions::VERSION
-  spec.authors       = ["Simon Mathieu"]
-  spec.email         = ["simon.math@gmail.com"]
-  spec.summary       = %q{An easy way to rescue exceptions that might be thrown by your Http library}
-  spec.description   = %q{An easy way to rescue exceptions that might be thrown by your Http library}
-  spec.homepage      = ""
+  spec.authors       = ["Simon Mathieu", "Russell Smith"]
+  spec.email         = ["simon.math@gmail.com", "russ@rainforestqa.com"]
+  spec.summary       = %q{An easy way to rescue exceptions that might be thrown by your HTTP library}
+  spec.description   = %q{An easy way to rescue exceptions that might be thrown by your HTTP library}
+  spec.homepage      = "https://github.com/rainforestapp/http-exceptions"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

data/lib/http/exceptions.rb

@@ -29,7 +29,7 @@ module Http
     end
 
     def self.check_response!(res)
-      raise HttpException.new(response: res) unless (200...300).include?(res.code)
+      raise HttpException.new(response: res) unless (200...300).include?(res.code.to_i)
       res
     end
 

data/lib/http/exceptions/version.rb

@@ -1,5 +1,5 @@
 module Http
   module Exceptions
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/spec/http_exception_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 
 describe Http::Exceptions do
-  let(:invalid_response) { double(code: 400, body: '') }
-  let(:valid_response) { double(code: 200) }
+  let(:code)     { 200 }
+  let(:response) { double(code: code, body: '') }
 
   class TestException < RuntimeError
   end
 
   describe ".wrap_exception" do
-    let(:supported_exception_class) { Http::Exceptions::Configuration::DEFAULT_EXCEPTIONS_TO_CONVERT.first }
+    let(:supported_exception_class)   { Http::Exceptions::Configuration::DEFAULT_EXCEPTIONS_TO_CONVERT.first }
     let(:unsupported_exception_class) { TestException }
 
     context "when exception class is supported" do
@@ -47,30 +47,54 @@ describe Http::Exceptions do
   end
 
   describe ".check_response!" do
-    it "raises exception on non-200 response" do
-      expect do
-        described_class.check_response!(invalid_response)
-      end.to raise_error(Http::Exceptions::HttpException)
+    shared_examples 'invalid response' do |error_status_code|
+      context "when the response code is not a 200" do
+        let(:code) { error_status_code }
+
+        it "raises exception" do
+          expect do
+            described_class.check_response!(response)
+          end.to raise_error(Http::Exceptions::HttpException)
+        end
+      end
+
+      it "the raised exception contains the response" do
+        begin
+          described_class.check_response!(response)
+        rescue Http::Exceptions::HttpException => e
+          expect(e.response).to eq(response)
+        end
+      end
     end
 
-    it "the raised exception contains the response" do
-      begin
-        described_class.check_response!(invalid_response)
-      rescue Http::Exceptions::HttpException => e
-        expect(e.response).to eq(invalid_response)
+    shared_examples 'valid response' do |successful_status_code|
+      context "when the response code is a 200" do
+        let(:code) { successful_status_code }
+
+        it "returns the response" do
+          expect(described_class.check_response!(response)).to eq(response)
+        end
       end
     end
 
-    it "returns the response on valid response" do
-      expect(described_class.check_response!(valid_response)).to eq(valid_response)
+    context "when the response code is an integer" do
+      it_behaves_like 'invalid response', 400
+      it_behaves_like 'valid response', 200
+    end
+
+    context "when the response code is a string" do
+      it_behaves_like 'invalid response', '400'
+      it_behaves_like 'valid response', '200'
     end
   end
 
   describe ".wrap_and_check" do
-    it "raises exception on bad response" do
+    let(:code) { 400 }
+
+    it "raises an exception on a response with an error code" do
       expect do
         described_class.wrap_and_check do
-          invalid_response
+          response
         end
       end.to raise_error(Http::Exceptions::HttpException)
     end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: http-exceptions
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Simon Mathieu
+- Russell Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-12 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,16 +39,16 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: An easy way to rescue exceptions that might be thrown by your Http library
+description: An easy way to rescue exceptions that might be thrown by your HTTP library
 email:
 - simon.math@gmail.com
+- russ@rainforestqa.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".rvmrc"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -61,7 +62,7 @@ files:
 - spec/http/exceptions/configuration_spec.rb
 - spec/http_exception_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/rainforestapp/http-exceptions
 licenses:
 - MIT
 metadata: {}
@@ -84,9 +85,8 @@ rubyforge_project:
 rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: An easy way to rescue exceptions that might be thrown by your Http library
+summary: An easy way to rescue exceptions that might be thrown by your HTTP library
 test_files:
 - spec/http/exceptions/configuration_spec.rb
 - spec/http_exception_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/.rvmrc

@@ -1 +0,0 @@
-rvm use 2.2.0@http-exceptions --create