http-exceptions 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ffca1fda1f057ce3a70dc47630a23fd567de208
-  data.tar.gz: 19c46b249e069e3e5c5ce90b39edf979e23a62f9
+  metadata.gz: b2b8379b87bb1870f177fcd13945a60429904e58
+  data.tar.gz: 3a6315754839e85a1284174c2bf8799225eede32
 SHA512:
-  metadata.gz: 2cfbced68908a3db07560fd8fe00104b3fe5e2167b52368d272b4f4d199911fcebf149ce6d8fa8fd1a32aac3897a64411f176d2f90ed23bc412e60aab551f0a9
-  data.tar.gz: 15a95d10cd078497d30925bddd477ae76bb96a420001815019a4921500ea9e931ccb917089caa66fe59df42c506e83045de8e928dd5e4697b29610569444cd46
+  metadata.gz: d485c0b6fe6f40b0c98f40437f8a878faa701251975460bf8b7607f60c3c1f89518dfe8b45a66f4e06a20b9761e6c75a6197ac576a45dad3120763a47499b2de
+  data.tar.gz: e091b9790f5ee5e2c99233c829d402749c6248a284099de9f22d6ca225dad0fab72f14901489b2eb8a8d3402c89ea9b836e6c688e1be5edeb40e79798dd33357

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 2.1.2
+  - 2.0.0
+  - 1.9.3
+script: bundle exec rspec spec

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in http-exceptions.gemspec
 gemspec
+
+gem 'rspec'

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/rainforestapp/http-exceptions.png?branch=master)](https://travis-ci.org/rainforestapp/http-exceptions)
+
 # Http::Exceptions
 
 Http::Exceptions provides an easy way to rescue exceptions that might be thrown by your Http library.
@@ -30,7 +32,7 @@ response = Http::Exceptions.wrap_exception do
 end
 ```
 
-Raise an exception is the return code of the API call is not `2XX`.
+Raise an exception if the return code of the API call is not `2XX`.
 
 ```ruby
 response = Http::Exceptions.wrap_and_check do

data/lib/http/exceptions.rb

@@ -6,8 +6,8 @@ module Http
     EXCEPTIONS = [
       SocketError,
       Errno::ETIMEDOUT,
-      Net::ReadTimeout,
-      Net::OpenTimeout,
+      (Net.const_defined?(:ReadTimeout) ? Net::ReadTimeout : EOFError),
+      (Net.const_defined?(:OpenTimeout) ? Net::ReadTimeout : EOFError),
       Net::ProtocolError,
       Errno::ECONNREFUSED,
       Errno::EHOSTDOWN,

data/lib/http/exceptions/http_exception.rb

@@ -3,9 +3,9 @@ module Http
     class HttpException < RuntimeError
       attr_reader :response, :original_exception
 
-      def initialize(original_exception: nil, response: nil)
-        @response = response
-        @original_exception = original_exception
+      def initialize(options = {})
+        @original_exception = options[:original_exception]
+        @response = options[:response]
         msg = "An error as occured while processing response."
         msg += " Status #{response.code}\n#{response.body}" if response
         msg += " Original Exception: #{original_exception}" if original_exception

data/lib/http/exceptions/version.rb

@@ -1,5 +1,5 @@
 module Http
   module Exceptions
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/http_exception_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe Http::Exceptions do
+  let(:invalid_response) { double(code: 400, body: '') }
+  let(:valid_response) { double(code: 200) }
+
+  class TestException < RuntimeError
+  end
+
+  describe ".wrap_exception" do
+    it "raises an HttpException on supported http exceptions" do
+      expect do
+        described_class.wrap_exception do
+          raise SocketError
+        end
+      end.to raise_error(Http::Exceptions::HttpException)
+    end
+
+    it "saves the original exception against the HttpException" do
+      begin
+        described_class.wrap_exception do
+          raise SocketError
+        end
+      rescue Http::Exceptions::HttpException => e
+        expect(e.original_exception).to be_a(SocketError)
+      end
+    end
+
+    it "ignores other exceptions" do
+      expect do
+        described_class.wrap_exception do
+          raise TestException
+        end
+      end.to raise_error(TestException)
+    end
+  end
+
+  describe ".check_response!" do
+    it "raises exception on non-200 response" do
+      expect do
+        described_class.check_response!(invalid_response)
+      end.to raise_error(Http::Exceptions::HttpException)
+    end
+
+    it "the raised exception contains the response" do
+      begin
+        described_class.check_response!(invalid_response)
+      rescue Http::Exceptions::HttpException => e
+        expect(e.response).to eq(invalid_response)
+      end
+    end
+
+    it "returns the response on valid response" do
+      expect(described_class.check_response!(valid_response)).to eq(valid_response)
+    end
+  end
+
+  describe ".wrap_and_check" do
+    it "raises exception on bad response" do
+      expect do
+        described_class.wrap_and_check do
+          invalid_response
+        end
+      end.to raise_error(Http::Exceptions::HttpException)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,91 @@
+require 'http/exceptions'
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause this
+# file to always be loaded, without a need to explicitly require it in any files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    # be_bigger_than(2).and_smaller_than(4).description
+    #   # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #   # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Limits the available syntax to the non-monkey patched syntax that is recommended.
+  # For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: http-exceptions
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Simon Mathieu
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-14 00:00:00.000000000 Z
+date: 2014-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -46,7 +46,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rvmrc"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -55,6 +57,8 @@ files:
 - lib/http/exceptions.rb
 - lib/http/exceptions/http_exception.rb
 - lib/http/exceptions/version.rb
+- spec/http_exception_spec.rb
+- spec/spec_helper.rb
 homepage: ''
 licenses:
 - MIT
@@ -79,4 +83,6 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: An easy way to rescue exceptions that might be thrown by your Http library
-test_files: []
+test_files:
+- spec/http_exception_spec.rb
+- spec/spec_helper.rb