http-cookie 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e01904534ca62610f72b5aba64d20f403ef41334
-  data.tar.gz: b7194473dbb2106fc6fea76fc8077135721518a3
+  metadata.gz: 633adcbc5625bcf9d8c1509b9480d955f3107a06
+  data.tar.gz: 17c8fefbe45bb8429d3c533a1338bf4cec02345e
 SHA512:
-  metadata.gz: 11de16cdf76a561e3dfcf5af1fcc78d6231a352cba9460fed867b4a6a4548dd71b6615c75eb70507599f23906877c05e878b1ed1b5abb33ddcf3410cf5d2794e
-  data.tar.gz: 9cd258c417a7f5f80a5b718a6f4c3b1a59086c871ae62500b3809fce95bbd57a75e45dd9d11deced0052996fa12e32769aae9f7547f82efbab4d1f1a4a2c68a7
+  metadata.gz: 190e3fc5a0a658b73a9fc6c0e43937b6fd9fdebb9b6d92e09edd51c24209fbd2fb61e9ea49eb29621f2fefeb1ec5095779deded65c343f2f0c52c4f53c1e0b76
+  data.tar.gz: 96627fd5e6617b71c0b5dadf08e918169aabeda0c9ebf0f3a3d1d3d4c920b3999637f61009f4d531ddb588178bd6f0e26529b9ee49bf1808374971b7337a69f3

data/.travis.yml

@@ -2,7 +2,6 @@ language: ruby
 rvm:
   - 1.8.7
   - ree
-  - 1.9.2
   - 1.9.3
   - 2.0.0
   - ruby-head
@@ -13,5 +12,6 @@ rvm:
   - rbx-19mode
 matrix:
   allow_failures:
+    - rvm: ruby-head
     - rvm: rbx-18mode
     - rvm: rbx-19mode

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.0.2 (2013-09-10)
+
+  - Fix HTTP::Cookie.parse so that it does not raise ArgumentError
+    when it finds a bad name or value that is parsable but considered
+    invalid.
+
 ## 1.0.1 (2013-04-21)
 
   - Minor error handling improvements and documentation updates.

data/http-cookie.gemspec

@@ -16,6 +16,7 @@ Gem::Specification.new do |gem|
   gem.description   = %q{HTTP::Cookie is a Ruby library to handle HTTP Cookies based on RFC 6265.  It has with security, standards compliance and compatibility in mind, to behave just the same as today's major web browsers.  It has builtin support for the legacy cookies.txt and the latest cookies.sqlite formats of Mozilla Firefox, and its modular API makes it easy to add support for a new backend store.}
   gem.summary       = %q{A Ruby library to handle HTTP Cookies based on RFC 6265}
   gem.homepage      = "https://github.com/sparklemotion/http-cookie"
+  gem.license       = "MIT"
 
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

data/lib/http/cookie.rb

@@ -281,7 +281,12 @@ class HTTP::Cookie
         Scanner.new(set_cookie, logger).scan_set_cookie { |name, value, attrs|
           break if name.nil? || name.empty?
 
-          cookie = new(name, value)
+          begin
+            cookie = new(name, value)
+          rescue => e
+            logger.warn("Invalid name or value: #{e}") if logger
+            next
+          end
           cookie.created_at = created_at if created_at
           attrs.each { |aname, avalue|
             begin

data/lib/http/cookie/version.rb

@@ -1,5 +1,5 @@
 module HTTP
   class Cookie
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

data/lib/http/cookie_jar.rb

@@ -16,7 +16,7 @@ class HTTP::CookieJar
       end
       begin
         require file
-      rescue LoadError => e
+      rescue LoadError
         raise NameError, 'can\'t resolve constant %s; failed to load %s' % [name, file]
       end
       if const_defined?(name)

data/test/test_http_cookie.rb

@@ -126,6 +126,22 @@ class TestHTTPCookie < Test::Unit::TestCase
     assert_equal 0, HTTP::Cookie.parse(cookie, url).size
   end
 
+  def test_parse_bad_name
+    cookie = "a\001b=c"
+    url = URI.parse('http://www.example.com/')
+    assert_nothing_raised {
+      assert_equal 0, HTTP::Cookie.parse(cookie, url).size
+    }
+  end
+
+  def test_parse_bad_value
+    cookie = "a=b\001c"
+    url = URI.parse('http://www.example.com/')
+    assert_nothing_raised {
+      assert_equal 0, HTTP::Cookie.parse(cookie, url).size
+    }
+  end
+
   def test_parse_weird_cookie
     cookie = 'n/a, ASPSESSIONIDCSRRQDQR=FBLDGHPBNDJCPCGNCPAENELB; path=/'
     url = URI.parse('http://www.searchinnovation.com/')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http-cookie
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Akinori MUSHA
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-21 00:00:00.000000000 Z
+date: 2013-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: domain_name
@@ -153,7 +153,8 @@ files:
 - test/test_http_cookie.rb
 - test/test_http_cookie_jar.rb
 homepage: https://github.com/sparklemotion/http-cookie
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []