http-2 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f37bf7f07706136db469b5c188cf13b2995d0c16
-  data.tar.gz: e51aeb9218b11e3cada90485ba60b5342e89322f
+  metadata.gz: 60d5e715ae277807ca53b015a14a0e8c7f6676b7
+  data.tar.gz: 17c562bfb62b6db7209962ace7bd698a59fa2c91
 SHA512:
-  metadata.gz: 45ca021e60dfe824fcc7bc6bf61d054ce37096a7f0f41ba7c1a5e45f89ad7848f37f4d6638f28d6a93bf6b41f28e8af66abfac28b4fe60d16556d82c1ec78ae3
-  data.tar.gz: c5bddd633904cd5ff9aef237debbdbcc78a6b901dad857cd5aa770e8d13ea28e26c158c902f9b840185b4a8d7dfe7c8e2acd9b380991426f0b5abdbfa4bc2f2f
+  metadata.gz: c8d072f9ac4302506d4770fd48fa153567812b2beaa2e0bc4e1f3d04b0cc7560ebf7bd6bc22335e0465814a08a70cdca9f52546b62ffbc362edea5ecfaf41103
+  data.tar.gz: 950e2e78ff84257d62ddaf9d246b31e68689fd8125ee5fb180d239dbeaabe72d373c5a166353000a27d46f3f41c3924de19fa2287c195f7b75215204ae05e78f

data/.rspec

@@ -2,3 +2,4 @@ autotest
 --color
 --format documentation
 --order rand
+--warnings

data/lib/http/2/connection.rb

@@ -49,9 +49,6 @@ module HTTP2
     # Connection state (:new, :closed).
     attr_reader :state
 
-    # Last connection error if connection is aborted.
-    attr_reader :error
-
     # Size of current connection flow control window (by default, set to
     # infinity, but is automatically updated on receipt of peer settings).
     attr_reader :local_window
@@ -95,6 +92,8 @@ module HTTP2
       @send_buffer = []
       @continuation = []
       @error = nil
+
+      @h2c_upgrade = nil
     end
 
     # Allocates new stream for current connection.
@@ -656,15 +655,18 @@ module HTTP2
       # permitted to open.
       stream.once(:active) { @active_stream_count += 1 }
       stream.once(:close) do
-        @streams.delete id
         @active_stream_count -= 1
 
         # Store a reference to the closed stream, such that we can respond
         # to any in-flight frames while close is registered on both sides.
         # References to such streams will be purged whenever another stream
         # is closed, with a minimum of 15s RTT time window.
-        @streams_recently_closed.delete_if { |_, v| (Time.now - v) > 15 }
         @streams_recently_closed[id] = Time.now
+        to_delete = @streams_recently_closed.select { |_, v| (Time.now - v) > 15 }
+        to_delete.each do |stream_id|
+          @streams.delete stream_id
+          @streams_recently_closed.delete stream_id
+        end
       end
 
       stream.on(:promise, &method(:promise)) if self.is_a? Server

data/lib/http/2/version.rb

@@ -1,3 +1,3 @@
 module HTTP2
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

data/spec/connection_spec.rb

@@ -543,6 +543,20 @@ RSpec.describe HTTP2::Connection do
       end.to raise_error(ProtocolError)
     end
 
+    it 'should not raise an error on frame for a closed stream ID' do
+      srv = Server.new
+      srv << CONNECTION_PREFACE_MAGIC
+
+      stream = srv.new_stream
+      stream.send HEADERS.dup
+      stream.send DATA.dup
+      stream.close
+
+      expect do
+        srv << f.generate(RST_STREAM.dup.merge(stream: stream.id))
+      end.to_not raise_error
+    end
+
     it 'should send GOAWAY frame on connection error' do
       stream = @conn.new_stream
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http-2
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Ilya Grigorik
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-08 00:00:00.000000000 Z
+date: 2018-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler