html2rss 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 803f570ac19ab526a065ab4514725b15e692f9fc3ead0516f337841afce35f20
-  data.tar.gz: 887228a092ec286b5796b98ba92b32cb1391eab9abceee1d05dae042a8b607ac
+  metadata.gz: 97c8c553722b6f97745e1b9676a2325ecae229bc8871e6fc41681d030cb93a7e
+  data.tar.gz: 6aada0c4686051d8c77e1e7ea12d6bbcc7c3ae290221b04823fa96e475554de6
 SHA512:
-  metadata.gz: 6526864907dd58f6a9add414e9db804a47c23c0d74907d8b055eeba020754c42d20bb97e5bd344925dbf87129fe4c73e97c6b79adb5eed687ad4f243d6bf7e74
-  data.tar.gz: 392c4e2f690c7f7e5a3ed511780bc44bd36dde70e237cb524f5f6cb7515d044bd7cc052456763c09e789999063cf513b8bff4c0c99bfdc857a3769f6bd9fc2ad
+  metadata.gz: 3af18a4949147f9ff209cd4a668f4184e3f203873a6a28029a53839340cda2eceb614504cf1bf1a3a8a8b398578c1528b33d001c6190f3dbffaace0a8571aea8
+  data.tar.gz: 3973df6dfc80a5899b14407338faff71633874fe62c6c9b77ddeb4243a94917b1e9c249708f287afc7e17f884ebb3d0ce912661d34cb95c3e61ade81e5bfd630

data/CHANGELOG.md

@@ -1,4 +1,13 @@
-# [](https://github.com/gildesmarais/html2rss/compare/v0.5.0...v) (2019-09-18)
+# [](https://github.com/gildesmarais/html2rss/compare/v0.5.1...v) (2019-09-19)
+
+
+
+## [0.5.1](https://github.com/gildesmarais/html2rss/compare/v0.5.0...v0.5.1) (2019-09-19)
+
+
+### Bug Fixes
+
+* rss contains additional categories ([#39](https://github.com/gildesmarais/html2rss/issues/39)) ([ed164ef](https://github.com/gildesmarais/html2rss/commit/ed164ef))
 
 
 

data/README.md

@@ -83,14 +83,12 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/gildes
 
 ## Releasing a new version
 
-0. `git pull`
-1. increase version in `lib/version.rb`
-2. `bundle`
-3. commit the changes
-4. `git tag v....`
-5. `git push; git push --tags`
-6. update the changelog, commit and push
-
-### Changelog generation
-
-The `CHANGELOG.md` can be generated automatically with [`standard-changelog`](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/standard-changelog).
+1. `git pull`
+2. increase version in `lib/html2rss/version.rb`
+3. `bundle`
+4. commit the changes
+5. `git tag v....`
+6. [`standard-changelog -f`](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/standard-changelog)
+7. `git add CHANGELOG.md && git commit --amend`
+8. `git tag v.... -f`
+9. `git push && git push --tags`

data/lib/html2rss/config.rb

@@ -43,12 +43,16 @@ module Html2rss
       global_config.fetch('headers', {})
     end
 
-    def options(name)
+    def attribute_options(name)
       feed_config.dig('selectors').fetch(name, {}).merge('channel' => channel_config)
     end
 
+    def attribute?(name)
+      attribute_names.include?(name.to_s)
+    end
+
     def categories
-      feed_config.dig('selectors').fetch('categories', [])
+      feed_config.dig('selectors').fetch('categories', []).map(&:to_sym)
     end
 
     def selector(name)
@@ -56,9 +60,9 @@ module Html2rss
     end
 
     def attribute_names
-      attribute_names = feed_config.fetch('selectors', {}).keys.map(&:to_s)
-      attribute_names.delete('items')
-      attribute_names
+      @attribute_names ||= feed_config.fetch('selectors', {}).keys.map(&:to_s).tap do |attrs|
+        attrs.delete('items')
+      end
     end
 
     private

data/lib/html2rss/item.rb

@@ -15,17 +15,18 @@ module Html2rss
     private_class_method :new
 
     def respond_to_missing?(method_name, _include_private = false)
-      config.attribute_names.include?(method_name) || super
+      config.attribute?(method_name) || super
     end
 
     def method_missing(method_name, *_args)
-      attribute_config = config.options(method_name.to_s)
-      return super unless attribute_config
+      return super unless respond_to_missing?(method_name)
 
-      extractor = ItemExtractors.get_extractor(attribute_config['extractor'])
-      value = extractor.new(xml, attribute_config).get
+      attribute_options = config.attribute_options(method_name)
 
-      post_process(value, attribute_config.fetch('post_process', false))
+      extractor = ItemExtractors.get_extractor(attribute_options['extractor'])
+      value = extractor.new(xml, attribute_options).get
+
+      post_process(value, attribute_options.fetch('post_process', false))
     end
 
     def available_attributes
@@ -33,8 +34,12 @@ module Html2rss
         @config.attribute_names) - ['categories']
     end
 
+    ##
+    # At least a title or a description is required to be a valid RSS 2.0 item.
     def valid?
-      [title.to_s, description.to_s].join('') != ''
+      title = self.title if config.attribute?(:title)
+      description = self.description if config.attribute?(:description)
+      [title, description].join != ''
     end
 
     ##

data/lib/html2rss/version.rb

@@ -1,3 +1,3 @@
 module Html2rss
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.5.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html2rss
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Gil Desmarais
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-18 00:00:00.000000000 Z
+date: 2019-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport