html2md_mcp_client 0.2.2 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46468e0870a51991423deb96277081f233006f39f3a265d33d35567c38bd64e9
-  data.tar.gz: 98c2d87ded5ff1d8b9641ac38f845f5912e622ee045a09930fc9169591f84bb7
+  metadata.gz: 76fea9b5c32f480a0ed9372cd6c46b39a56b19de8f88f5932f3459f7a84a141c
+  data.tar.gz: '08ec1fefabe058777da56e362b79ca38128b98eb999c571c4e0f4d312cd17cf0'
 SHA512:
-  metadata.gz: 040de8322dd8523f6adad126d63c10170e09b242401baf5388b1d2243c6d2ec8895ee9874a959d305445d179243de9fd77f3b98060e20080538c9b01ea473aec
-  data.tar.gz: 4cf6be14b86eda38382b75f35e17434d628d30dcf1b81425d211002da1e27b03cd08b01e15afa97bdad5e00e368bec6559bad2ef071ef8cdb0eea9d49180d98e
+  metadata.gz: 0a58981905888666eacf9ed7c45b33c9144281c60cadb959cdaedbb09f950d548f4b7fbd79cfb759d675f1be65a0fa477387f19bfc7b4f3ff4ffaf230471a698
+  data.tar.gz: ca53fb8fbaa31dc818f0fd357cbbe5eae1ecb9f43a2a855314be83ed7465d38afff80e9748da5d7c50d7cc05f75b18be3f2466239ade59d1dea4938f17ab31f0

data/lib/html2md_mcp_client/client.rb

@@ -61,13 +61,15 @@ module Html2mdMcpClient
     end
 
     # Call a tool. Returns the content array.
-    # Raises ToolError if the server signals an error.
+    # Raises ToolError if the server signals an error or if text content
+    # begins with "Error" (some servers omit the isError flag).
     def call_tool(name, arguments = {})
       ensure_connected!
       result = request('tools/call', { name: name, arguments: arguments })
 
-      if result['isError']
-        texts = Array(result['content']).select { |c| c['type'] == 'text' }.map { |c| c['text'] }
+      texts = Array(result['content']).select { |c| c['type'] == 'text' }.map { |c| c['text'] }
+
+      if result['isError'] || texts.any? { |t| t.start_with?('Error') }
         raise ToolError, "Tool '#{name}' error: #{texts.join('; ')}"
       end
 
@@ -75,11 +77,15 @@ module Html2mdMcpClient
     end
 
     # Convenience: call a tool and return joined text content.
+    # Raises ToolError if no text content is returned.
     def tool_text(name, arguments = {})
-      call_tool(name, arguments)
+      texts = call_tool(name, arguments)
         .select { |c| c['type'] == 'text' }
         .map { |c| c['text'] }
-        .join("\n")
+
+      raise ToolError, "Tool '#{name}' returned no text content" if texts.empty?
+
+      texts.join("\n")
     end
 
     # Find a tool definition by name. Returns nil if not found.

data/lib/html2md_mcp_client/version.rb

@@ -1,3 +1,3 @@
 module Html2mdMcpClient
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.3.1'.freeze
 end

data/spec/html2md_mcp_client/client_spec.rb

@@ -171,6 +171,17 @@ RSpec.describe Html2mdMcpClient::Client do
 
       expect(client.call_tool('empty_tool')).to eq([])
     end
+
+    it 'raises ToolError when text content starts with Error even without isError flag' do
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, {
+          'content' => [{ 'type' => 'text', 'text' => 'Error fetching URL: Connection error while fetching URL: https://bad.invalid' }]
+        }))
+
+      expect { client.call_tool('html_to_markdown', { url: 'https://bad.invalid' }) }
+        .to raise_error(Html2mdMcpClient::ToolError, /Error fetching URL/)
+    end
   end
 
   describe '#tool_text' do
@@ -189,6 +200,24 @@ RSpec.describe Html2mdMcpClient::Client do
 
       expect(client.tool_text('my_tool')).to eq("Line 1\nLine 2")
     end
+
+    it 'raises ToolError when no text content is returned' do
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, {}))
+
+      expect { client.tool_text('bad_tool') }.to raise_error(Html2mdMcpClient::ToolError, /returned no text content/)
+    end
+
+    it 'raises ToolError when content has no text entries' do
+      content = [{ 'type' => 'image', 'data' => 'base64...' }]
+
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, { 'content' => content }))
+
+      expect { client.tool_text('img_tool') }.to raise_error(Html2mdMcpClient::ToolError, /returned no text content/)
+    end
   end
 
   describe '#find_tool' do

data/spec/html2md_mcp_client/transport/http_spec.rb

@@ -116,6 +116,16 @@ RSpec.describe Html2mdMcpClient::Transport::Http do
         .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
     end
 
+    it 'raises ConnectionError on unresolvable host' do
+      t = described_class.new('http://this-host-does-not-exist.invalid/mcp')
+
+      stub_request(:post, 'http://this-host-does-not-exist.invalid/mcp')
+        .to_raise(SocketError.new('getaddrinfo: Name or service not known'))
+
+      expect { t.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
     it 'raises ProtocolError on invalid JSON' do
       stub_request(:post, url).to_return(status: 200, body: 'not json')
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html2md_mcp_client
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.1
 platform: ruby
 authors:
 - Roscommon