html2md_mcp_client 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 77778d9f03e8ebdf5d815b1b3effe0016ba73f22f3128e38b1b5b282a9a5f344
-  data.tar.gz: a34209ff17d9f23d649c01aabda40453f93465f439aafd17699363689cd9ca2e
+  metadata.gz: d360caadc9ac04f0a3218ea55a175274ddf0f43d257b60527b9eaeea83aa09a8
+  data.tar.gz: 5f69cf8d255175bb17f8a56071b792a8f90edd1ef18b0d3daa9270f8c9b2afaa
 SHA512:
-  metadata.gz: 4335781e4e0a9a6f35a9014d6ad266f2759e8ddde8584757ad46f34c5dedf808aee2236fad96643715a14ca75ff805415cc33b1320395e4f4a104809afc83d95
-  data.tar.gz: 4cb614d6ccc1354ef07e9f370385eb094fd02b0940c7f30f270ce4c3a1c7a94ee513a339a4b7ceec5c2a58cbefd6ade32dbd0906fcb69a62a8f0a76e6b22782e
+  metadata.gz: 499b6cfabd2f51ebeb7461aec041b7624325a2c5a187ddd624372f0f54124a65c664d13ea376303c7938cbf15c4d29c0033cfbfdf0a15a9b0bf6280e1765c76c
+  data.tar.gz: fd418de434d52c2b8475ded376e8f21db91ceaf49d269817c24ec4cae559ba1942b83fa9afb12e431c4d052dda52fae6abe50ba44fd9749d846c17db797950be

data/lib/html2md_mcp_client/client.rb

@@ -61,13 +61,15 @@ module Html2mdMcpClient
     end
 
     # Call a tool. Returns the content array.
-    # Raises ToolError if the server signals an error.
+    # Raises ToolError if the server signals an error or if text content
+    # begins with "Error" (some servers omit the isError flag).
     def call_tool(name, arguments = {})
       ensure_connected!
       result = request('tools/call', { name: name, arguments: arguments })
 
-      if result['isError']
-        texts = Array(result['content']).select { |c| c['type'] == 'text' }.map { |c| c['text'] }
+      texts = Array(result['content']).select { |c| c['type'] == 'text' }.map { |c| c['text'] }
+
+      if result['isError'] || texts.any? { |t| t.start_with?('Error') }
         raise ToolError, "Tool '#{name}' error: #{texts.join('; ')}"
       end
 
@@ -75,11 +77,15 @@ module Html2mdMcpClient
     end
 
     # Convenience: call a tool and return joined text content.
+    # Raises ToolError if no text content is returned.
     def tool_text(name, arguments = {})
-      call_tool(name, arguments)
+      texts = call_tool(name, arguments)
         .select { |c| c['type'] == 'text' }
         .map { |c| c['text'] }
-        .join("\n")
+
+      raise ToolError, "Tool '#{name}' returned no text content" if texts.empty?
+
+      texts.join("\n")
     end
 
     # Find a tool definition by name. Returns nil if not found.

data/lib/html2md_mcp_client/transport/http.rb

@@ -34,7 +34,9 @@ module Html2mdMcpClient
         end
 
         JSON.parse(body)
-      rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH, SocketError => e
+      rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH, Errno::ENETUNREACH,
+             Errno::ECONNRESET, Errno::ETIMEDOUT, Errno::EPIPE,
+             SocketError, Net::OpenTimeout, Net::ReadTimeout => e
         raise ConnectionError, "Cannot connect to #{@uri}: #{e.message}"
       rescue JSON::ParserError => e
         raise ProtocolError, "Invalid JSON response: #{e.message}"

data/lib/html2md_mcp_client/version.rb

@@ -1,3 +1,3 @@
 module Html2mdMcpClient
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/spec/html2md_mcp_client/client_spec.rb

@@ -171,6 +171,17 @@ RSpec.describe Html2mdMcpClient::Client do
 
       expect(client.call_tool('empty_tool')).to eq([])
     end
+
+    it 'raises ToolError when text content starts with Error even without isError flag' do
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, {
+          'content' => [{ 'type' => 'text', 'text' => 'Error fetching URL: Connection error while fetching URL: https://bad.invalid' }]
+        }))
+
+      expect { client.call_tool('html_to_markdown', { url: 'https://bad.invalid' }) }
+        .to raise_error(Html2mdMcpClient::ToolError, /Error fetching URL/)
+    end
   end
 
   describe '#tool_text' do
@@ -189,6 +200,24 @@ RSpec.describe Html2mdMcpClient::Client do
 
       expect(client.tool_text('my_tool')).to eq("Line 1\nLine 2")
     end
+
+    it 'raises ToolError when no text content is returned' do
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, {}))
+
+      expect { client.tool_text('bad_tool') }.to raise_error(Html2mdMcpClient::ToolError, /returned no text content/)
+    end
+
+    it 'raises ToolError when content has no text entries' do
+      content = [{ 'type' => 'image', 'data' => 'base64...' }]
+
+      allow(transport).to receive(:send_request)
+        .with(hash_including(method: 'tools/call'))
+        .and_return(jsonrpc_response(2, { 'content' => content }))
+
+      expect { client.tool_text('img_tool') }.to raise_error(Html2mdMcpClient::ToolError, /returned no text content/)
+    end
   end
 
   describe '#find_tool' do

data/spec/html2md_mcp_client/transport/http_spec.rb

@@ -81,6 +81,51 @@ RSpec.describe Html2mdMcpClient::Transport::Http do
         .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
     end
 
+    it 'raises ConnectionError on open timeout' do
+      stub_request(:post, url).to_raise(Net::OpenTimeout)
+
+      expect { transport.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
+    it 'raises ConnectionError on read timeout' do
+      stub_request(:post, url).to_raise(Net::ReadTimeout)
+
+      expect { transport.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
+    it 'raises ConnectionError on network unreachable' do
+      stub_request(:post, url).to_raise(Errno::ENETUNREACH)
+
+      expect { transport.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
+    it 'raises ConnectionError on connection reset' do
+      stub_request(:post, url).to_raise(Errno::ECONNRESET)
+
+      expect { transport.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
+    it 'raises ConnectionError on connection timed out' do
+      stub_request(:post, url).to_raise(Errno::ETIMEDOUT)
+
+      expect { transport.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
+    it 'raises ConnectionError on unresolvable host' do
+      t = described_class.new('http://this-host-does-not-exist.invalid/mcp')
+
+      stub_request(:post, 'http://this-host-does-not-exist.invalid/mcp')
+        .to_raise(SocketError.new('getaddrinfo: Name or service not known'))
+
+      expect { t.send_request({ jsonrpc: '2.0', id: 1, method: 'test', params: {} }) }
+        .to raise_error(Html2mdMcpClient::ConnectionError, /Cannot connect/)
+    end
+
     it 'raises ProtocolError on invalid JSON' do
       stub_request(:post, url).to_return(status: 200, body: 'not json')
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html2md_mcp_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Roscommon