html-to-markdown 2.29.0 → 3.0.0

data/vendor/html-to-markdown-rs/tests/test_spa_bisect.rs

@@ -1,9 +1,16 @@
 #![allow(missing_docs)]
 
+fn convert(
+    html: &str,
+    opts: Option<html_to_markdown_rs::ConversionOptions>,
+) -> html_to_markdown_rs::error::Result<String> {
+    html_to_markdown_rs::convert(html, opts).map(|r| r.content.unwrap_or_default())
+}
+
 use std::fs;
 use std::path::PathBuf;
 
-use html_to_markdown_rs::{ConversionOptions, convert};
+use html_to_markdown_rs::ConversionOptions;
 
 fn fixture_path(name: &str) -> PathBuf {
     [env!("CARGO_MANIFEST_DIR"), "../../test_documents/html/issues", name]

data/vendor/html-to-markdown-rs/tests/visitor_integration_test.rs

@@ -690,11 +690,13 @@ fn test_convert_accepts_visitor_parameter() {
 }
 
 /// Test visitor + `inline_images` feature combination
+///
+/// In v3, `convert()` handles inline-image extraction via `ConversionResult.images`,
+/// and `convert_with_visitor()` handles visitor callbacks. We verify both paths
+/// work on the same HTML.
 #[cfg(feature = "inline-images")]
 #[test]
 fn test_convert_with_inline_images_accepts_visitor() {
-    use html_to_markdown_rs::convert_with_inline_images;
-
     #[derive(Debug, Default)]
     struct ImageTrackingVisitor {
         images_seen: usize,
@@ -715,15 +717,10 @@ fn test_convert_with_inline_images_accepts_visitor() {
         <p>Some content</p>
     "#;
 
+    // Verify visitor callbacks fire via convert_with_visitor
     let visitor = Rc::new(RefCell::new(ImageTrackingVisitor::default()));
+    let markdown = convert_with_visitor(html, None, Some(visitor.clone())).expect("convert_with_visitor should work");
 
-    // Test convert_with_inline_images with visitor
-    let image_cfg =
-        html_to_markdown_rs::InlineImageConfig::from_update(html_to_markdown_rs::InlineImageConfigUpdate::default());
-    let result = convert_with_inline_images(html, None, image_cfg, Some(visitor.clone()))
-        .expect("convert_with_inline_images with visitor should work");
-
-    // Verify that both visitor and inline image collection worked
     assert_eq!(
         visitor.borrow().images_seen,
         1,
@@ -731,15 +728,17 @@ fn test_convert_with_inline_images_accepts_visitor() {
     );
 
     // Markdown should still be generated
-    assert!(!result.markdown.is_empty(), "Should produce markdown output");
+    assert!(!markdown.is_empty(), "Should produce markdown output");
 }
 
-/// Test visitor + metadata feature combination
+/// Test visitor + metadata: visitor callbacks fire and metadata is collected.
+///
+/// In v3, `convert()` always extracts metadata into `ConversionResult.metadata`,
+/// and `convert_with_visitor()` handles visitor callbacks. We verify both paths
+/// work on the same HTML.
 #[cfg(feature = "metadata")]
 #[test]
-fn test_convert_with_metadata_accepts_visitor() {
-    use html_to_markdown_rs::convert_with_metadata;
-
+fn test_visitor_and_metadata_both_work() {
     #[derive(Debug, Default)]
     struct MetadataAwareVisitor {
         heading_count: usize,
@@ -770,14 +769,10 @@ fn test_convert_with_metadata_accepts_visitor() {
         </html>
     "#;
 
+    // Verify visitor callbacks fire via convert_with_visitor
     let visitor = Rc::new(RefCell::new(MetadataAwareVisitor::default()));
+    let markdown = convert_with_visitor(html, None, Some(visitor.clone())).expect("convert_with_visitor should work");
 
-    // Test convert_with_metadata with visitor
-    let metadata_cfg = html_to_markdown_rs::MetadataConfig::default();
-    let (markdown, metadata) = convert_with_metadata(html, None, metadata_cfg, Some(visitor.clone()))
-        .expect("convert_with_metadata with visitor should work");
-
-    // Verify visitor was invoked
     let borrowed = visitor.borrow();
     assert!(
         borrowed.heading_count >= 2,
@@ -789,8 +784,13 @@ fn test_convert_with_metadata_accepts_visitor() {
         "Visitor should see 2 links, got {}",
         borrowed.link_count
     );
+    assert!(!markdown.is_empty(), "Should produce markdown output");
+    drop(borrowed);
+
+    // Verify metadata extraction via convert()
+    let result = html_to_markdown_rs::convert(html, None).expect("convert should work");
+    let metadata = result.metadata;
 
-    // Verify metadata was also collected
     assert_eq!(
         metadata.document.title,
         Some("Test Page".to_string()),
@@ -807,17 +807,16 @@ fn test_convert_with_metadata_accepts_visitor() {
         "Metadata should extract 2 links, got {}",
         metadata.links.len()
     );
-
-    // Verify markdown was produced
-    assert!(!markdown.is_empty(), "Should produce markdown output");
 }
 
 /// Test visitor + both `inline_images` and `metadata` features together
+///
+/// In v3, `convert()` handles metadata and inline-image extraction via `ConversionResult`,
+/// and `convert_with_visitor()` handles visitor callbacks. We verify both paths
+/// work on the same HTML.
 #[cfg(all(feature = "inline-images", feature = "metadata"))]
 #[test]
 fn test_convert_with_all_features_and_visitor() {
-    use html_to_markdown_rs::convert_with_inline_images;
-
     #[derive(Debug, Default)]
     struct ComprehensiveVisitor {
         headings: usize,
@@ -855,13 +854,9 @@ fn test_convert_with_all_features_and_visitor() {
         </html>
     "#;
 
+    // Verify visitor callbacks fire via convert_with_visitor
     let visitor = Rc::new(RefCell::new(ComprehensiveVisitor::default()));
-
-    // Test with inline images feature (metadata feature doesn't affect inline-images function)
-    let image_cfg =
-        html_to_markdown_rs::InlineImageConfig::from_update(html_to_markdown_rs::InlineImageConfigUpdate::default());
-    let result = convert_with_inline_images(html, None, image_cfg, Some(visitor.clone()))
-        .expect("convert_with_inline_images with visitor should work");
+    let markdown = convert_with_visitor(html, None, Some(visitor.clone())).expect("convert_with_visitor should work");
 
     // Verify all visitor callbacks were invoked
     let borrowed = visitor.borrow();
@@ -876,9 +871,10 @@ fn test_convert_with_all_features_and_visitor() {
         borrowed.images
     );
     assert_eq!(borrowed.links, 2, "Visitor should see 2 links, got {}", borrowed.links);
+    drop(borrowed);
 
     // Verify markdown was produced
-    assert!(!result.markdown.is_empty(), "Should produce markdown output");
+    assert!(!markdown.is_empty(), "Should produce markdown output");
 }
 
 /// Regression test: image visitor returning Custom with metadata extraction used to panic

data/vendor/html-to-markdown-rs/tests/xml_tables_test.rs

@@ -1,6 +1,13 @@
 #![allow(missing_docs)]
 
-use html_to_markdown_rs::{ConversionOptions, convert};
+fn convert(
+    html: &str,
+    opts: Option<html_to_markdown_rs::ConversionOptions>,
+) -> html_to_markdown_rs::error::Result<String> {
+    html_to_markdown_rs::convert(html, opts).map(|r| r.content.unwrap_or_default())
+}
+
+use html_to_markdown_rs::ConversionOptions;
 
 #[test]
 fn test_basic_row_and_cell_conversion() {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-to-markdown
 version: !ruby/object:Gem::Version
-  version: 2.29.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Na'aman Hirschfeld
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-22 00:00:00.000000000 Z
+date: 2026-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rb_sys
@@ -50,7 +50,6 @@ files:
 - README.md
 - Rakefile
 - Steepfile
-- bin/benchmark.rb
 - exe/html-to-markdown
 - ext/html-to-markdown-rb/extconf.rb
 - ext/html-to-markdown-rb/native/Cargo.lock
@@ -60,14 +59,9 @@ files:
 - ext/html-to-markdown-rb/native/src/conversion/inline_images.rs
 - ext/html-to-markdown-rb/native/src/conversion/metadata.rs
 - ext/html-to-markdown-rb/native/src/conversion/mod.rs
-- ext/html-to-markdown-rb/native/src/conversion/tables.rs
 - ext/html-to-markdown-rb/native/src/lib.rs
 - ext/html-to-markdown-rb/native/src/options.rs
-- ext/html-to-markdown-rb/native/src/profiling.rs
 - ext/html-to-markdown-rb/native/src/types.rs
-- ext/html-to-markdown-rb/native/src/visitor/bridge.rs
-- ext/html-to-markdown-rb/native/src/visitor/callbacks.rs
-- ext/html-to-markdown-rb/native/src/visitor/mod.rs
 - html-to-markdown-rb.gemspec
 - lib/html_to_markdown.rb
 - lib/html_to_markdown/cli.rb
@@ -78,12 +72,7 @@ files:
 - sig/html_to_markdown/cli_proxy.rbs
 - sig/open3.rbs
 - spec/cli_proxy_spec.rb
-- spec/convert_spec.rb
-- spec/convert_with_tables_spec.rb
-- spec/metadata_extraction_spec.rb
 - spec/spec_helper.rb
-- spec/visitor_issue_187_spec.rb
-- spec/visitor_spec.rb
 - vendor/Cargo.toml
 - vendor/html-to-markdown-rs/Cargo.toml
 - vendor/html-to-markdown-rs/README.md
@@ -174,23 +163,6 @@ files:
 - vendor/html-to-markdown-rs/src/converter/visitor_hooks.rs
 - vendor/html-to-markdown-rs/src/error.rs
 - vendor/html-to-markdown-rs/src/exports.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/code_analysis.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/core.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/elements.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/hierarchy.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/keywords.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/layout.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/mod.rs
-- vendor/html-to-markdown-rs/src/hocr/converter/output.rs
-- vendor/html-to-markdown-rs/src/hocr/extractor.rs
-- vendor/html-to-markdown-rs/src/hocr/mod.rs
-- vendor/html-to-markdown-rs/src/hocr/parser.rs
-- vendor/html-to-markdown-rs/src/hocr/spatial/coords.rs
-- vendor/html-to-markdown-rs/src/hocr/spatial/grouping.rs
-- vendor/html-to-markdown-rs/src/hocr/spatial/layout.rs
-- vendor/html-to-markdown-rs/src/hocr/spatial/mod.rs
-- vendor/html-to-markdown-rs/src/hocr/spatial/output.rs
-- vendor/html-to-markdown-rs/src/hocr/types.rs
 - vendor/html-to-markdown-rs/src/inline_images.rs
 - vendor/html-to-markdown-rs/src/lib.rs
 - vendor/html-to-markdown-rs/src/metadata/collector.rs
@@ -207,16 +179,19 @@ files:
 - vendor/html-to-markdown-rs/src/rcdom.rs
 - vendor/html-to-markdown-rs/src/safety.rs
 - vendor/html-to-markdown-rs/src/text.rs
+- vendor/html-to-markdown-rs/src/types/document.rs
+- vendor/html-to-markdown-rs/src/types/mod.rs
+- vendor/html-to-markdown-rs/src/types/result.rs
+- vendor/html-to-markdown-rs/src/types/structure_builder.rs
+- vendor/html-to-markdown-rs/src/types/structure_collector.rs
+- vendor/html-to-markdown-rs/src/types/tables.rs
+- vendor/html-to-markdown-rs/src/types/warnings.rs
 - vendor/html-to-markdown-rs/src/validation.rs
-- vendor/html-to-markdown-rs/src/visitor/async_traits.rs
 - vendor/html-to-markdown-rs/src/visitor/default_impl.rs
 - vendor/html-to-markdown-rs/src/visitor/mod.rs
 - vendor/html-to-markdown-rs/src/visitor/traits.rs
 - vendor/html-to-markdown-rs/src/visitor/types.rs
 - vendor/html-to-markdown-rs/src/visitor_helpers.rs
-- vendor/html-to-markdown-rs/src/visitor_helpers/helpers/callbacks/bridge.rs
-- vendor/html-to-markdown-rs/src/visitor_helpers/helpers/callbacks/bridge_visitor.rs
-- vendor/html-to-markdown-rs/src/visitor_helpers/helpers/callbacks/macros.rs
 - vendor/html-to-markdown-rs/src/visitor_helpers/helpers/callbacks/mod.rs
 - vendor/html-to-markdown-rs/src/visitor_helpers/helpers/content.rs
 - vendor/html-to-markdown-rs/src/visitor_helpers/helpers/mod.rs
@@ -225,12 +200,9 @@ files:
 - vendor/html-to-markdown-rs/src/wrapper.rs
 - vendor/html-to-markdown-rs/src/wrapper/sync.rs
 - vendor/html-to-markdown-rs/src/wrapper/utils.rs
-- vendor/html-to-markdown-rs/tests/async_visitor_test.rs
 - vendor/html-to-markdown-rs/tests/br_in_inline_test.rs
 - vendor/html-to-markdown-rs/tests/commonmark_compliance_test.rs
-- vendor/html-to-markdown-rs/tests/convert_with_metadata_no_frontmatter.rs
 - vendor/html-to-markdown-rs/tests/djot_output_test.rs
-- vendor/html-to-markdown-rs/tests/hocr_compliance_test.rs
 - vendor/html-to-markdown-rs/tests/integration_test.rs
 - vendor/html-to-markdown-rs/tests/issue_121_regressions.rs
 - vendor/html-to-markdown-rs/tests/issue_127_regressions.rs

data/bin/benchmark.rb

@@ -1,232 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require 'optparse'
-require 'time'
-
-$LOAD_PATH.unshift(File.expand_path('../lib', __dir__))
-require 'html_to_markdown'
-
-def json_escape(value)
-  value.to_s.gsub(/["\\\n\r]/) do |char|
-    case char
-    when '"', '\\'
-      "\\#{char}"
-    when "\n"
-      '\\n'
-    when "\r"
-      '\\r'
-    end
-  end
-end
-
-options = {
-  iterations: 50,
-  format: 'html',
-  scenario: 'convert-default',
-  visitor: nil
-}
-
-OptionParser.new do |parser|
-  parser.banner = 'ruby benchmark.rb --file path/to/fixture.html [--iterations 200]'
-
-  parser.on('--file FILE', 'HTML fixture to convert repeatedly') do |file|
-    options[:file] = file
-  end
-
-  parser.on('--iterations N', Integer, 'Number of conversion iterations (default: 50)') do |n|
-    options[:iterations] = n.positive? ? n : 1
-  end
-
-  parser.on('--scenario SCENARIO', 'Scenario to benchmark') do |scenario|
-    options[:scenario] = scenario
-  end
-
-  parser.on('--format FORMAT', 'Fixture format (html or hocr)') do |format|
-    options[:format] = format.downcase
-  end
-
-  parser.on('--visitor VISITOR', 'Visitor type (noop, simple, custom, complex)') do |visitor|
-    options[:visitor] = visitor if %w[noop simple custom complex].include?(visitor)
-  end
-end.parse!
-
-fixture = options.fetch(:file) do
-  warn 'Missing --file parameter'
-  exit 1
-end
-
-unless File.exist?(fixture)
-  warn "Fixture not found: #{fixture}"
-  exit 1
-end
-
-unless %w[html hocr].include?(options[:format])
-  warn "Unsupported format: #{options[:format]}"
-  exit 1
-end
-
-supported_scenarios = %w[
-  convert-default
-  convert-options
-  inline-images-default
-  inline-images-options
-  metadata-default
-  metadata-options
-]
-unless supported_scenarios.include?(options[:scenario])
-  warn "Unsupported scenario: #{options[:scenario]}"
-  exit 1
-end
-
-# Visitor factory functions
-def create_noop_visitor
-  {
-    visit_text: proc { |_ctx, _text| 'continue' },
-    visit_heading: proc { |_ctx, _level, _text, _id| 'continue' },
-    visit_paragraph: proc { |_ctx, _text| 'continue' },
-    visit_link: proc { |_ctx, _href, _text, _title| 'continue' },
-    visit_image: proc { |_ctx, _src, _alt, _title| 'continue' },
-    visit_strong: proc { |_ctx, _text| 'continue' },
-    visit_em: proc { |_ctx, _text| 'continue' },
-    visit_code: proc { |_ctx, _text| 'continue' },
-    visit_br: proc { |_ctx| 'continue' }
-  }
-end
-
-def create_simple_visitor
-  {
-    text_count: 0,
-    link_count: 0,
-    image_count: 0,
-    visit_text: proc { |_ctx, _text| 'continue' },
-    visit_heading: proc { |_ctx, _level, _text, _id| 'continue' },
-    visit_paragraph: proc { |_ctx, _text| 'continue' },
-    visit_link: proc { |_ctx, _href, _text, _title| 'continue' },
-    visit_image: proc { |_ctx, _src, _alt, _title| 'continue' },
-    visit_strong: proc { |_ctx, _text| 'continue' },
-    visit_em: proc { |_ctx, _text| 'continue' },
-    visit_code: proc { |_ctx, _text| 'continue' },
-    visit_br: proc { |_ctx| 'continue' }
-  }
-end
-
-def create_custom_visitor
-  {
-    visit_text: proc { |_ctx, _text| 'continue' },
-    visit_heading: proc { |_ctx, _level, _text, _id| 'continue' },
-    visit_paragraph: proc { |_ctx, _text| 'continue' },
-    visit_link: proc { |_ctx, href, text, _title| ['custom', "LINK[#{text}](#{href})"] },
-    visit_image: proc { |_ctx, src, alt, _title| ['custom', "![#{alt}](#{src})"] },
-    visit_strong: proc { |_ctx, _text| 'continue' },
-    visit_em: proc { |_ctx, _text| 'continue' },
-    visit_code: proc { |_ctx, _text| 'continue' },
-    visit_br: proc { |_ctx| 'continue' }
-  }
-end
-
-def create_complex_visitor
-  {
-    texts: 0,
-    links: 0,
-    images: 0,
-    headings: 0,
-    visit_text: proc { |_ctx, _text| 'continue' },
-    visit_heading: proc { |_ctx, _level, _text, _id| 'continue' },
-    visit_paragraph: proc { |_ctx, _text| 'continue' },
-    visit_link: proc { |_ctx, href, text, _title| ['custom', "[#{text}](#{href})"] },
-    visit_image: proc { |_ctx, _src, _alt, _title| 'skip' },
-    visit_strong: proc { |_ctx, _text| 'continue' },
-    visit_em: proc { |_ctx, _text| 'continue' },
-    visit_code: proc { |_ctx, _text| 'continue' },
-    visit_br: proc { |_ctx| 'continue' }
-  }
-end
-
-html = File.binread(fixture)
-html.force_encoding(Encoding::UTF_8)
-html.freeze
-iterations = options[:iterations]
-conversion_options = options[:format] == 'hocr' ? { hocr_spatial_tables: false } : {}
-options_handle = if %w[convert-options inline-images-options metadata-options].include?(options[:scenario])
-                   HtmlToMarkdown.options(conversion_options)
-                 end
-
-# Create visitor if specified
-visitor = nil
-if options[:visitor]
-  visitor_creators = {
-    'noop' => method(:create_noop_visitor),
-    'simple' => method(:create_simple_visitor),
-    'custom' => method(:create_custom_visitor),
-    'complex' => method(:create_complex_visitor)
-  }
-  creator = visitor_creators[options[:visitor]]
-  visitor = creator.call if creator
-end
-
-SCENARIO_RUNNERS = {
-  'convert-default' => ->(html, _options, _handle, _visitor) { HtmlToMarkdown.convert(html) },
-  'convert-options' => lambda do |html, _options, handle, _visitor|
-    raise ArgumentError, 'options handle required' unless handle
-
-    HtmlToMarkdown.convert_with_options(html, handle)
-  end,
-  'inline-images-default' => lambda { |html, _options, _handle, _visitor|
-    HtmlToMarkdown.convert_with_inline_images(html, nil, nil)
-  },
-  'inline-images-options' => lambda do |html, _options, handle, _visitor|
-    raise ArgumentError, 'options handle required' unless handle
-
-    HtmlToMarkdown.convert_with_inline_images_handle(html, handle, nil)
-  end,
-  'metadata-default' => ->(html, _options, _handle, _visitor) { HtmlToMarkdown.convert_with_metadata(html, nil, nil) },
-  'metadata-options' => lambda do |html, _options, handle, _visitor|
-    raise ArgumentError, 'options handle required' unless handle
-
-    HtmlToMarkdown.convert_with_metadata_handle(html, handle, nil)
-  end
-}.freeze
-
-def run_scenario(html, scenario, options, handle, visitor = nil)
-  if visitor
-    HtmlToMarkdown.convert_with_visitor(html, nil, visitor)
-  else
-    runner = SCENARIO_RUNNERS.fetch(scenario) { raise ArgumentError, "Unsupported scenario: #{scenario}" }
-    runner.call(html, options, handle, visitor)
-  end
-end
-
-run_scenario(html, options[:scenario], conversion_options, options_handle, visitor)
-
-profile_output = ENV.fetch('HTML_TO_MARKDOWN_PROFILE_OUTPUT', nil)
-if profile_output && HtmlToMarkdown.respond_to?(:start_profiling)
-  freq = Integer(ENV.fetch('HTML_TO_MARKDOWN_PROFILE_FREQUENCY', '1000'), 10)
-  HtmlToMarkdown.start_profiling(profile_output, freq)
-end
-
-start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-iterations.times { run_scenario(html, options[:scenario], conversion_options, options_handle, visitor) }
-elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
-
-HtmlToMarkdown.stop_profiling if profile_output && HtmlToMarkdown.respond_to?(:stop_profiling)
-
-payload_size_bytes = html.bytesize
-bytes_processed = payload_size_bytes * iterations
-ops_per_sec = iterations / elapsed
-mb_per_sec = (bytes_processed.to_f / (1024 * 1024)) / elapsed
-
-payload = %({
-  "language":"ruby",
-  "fixture":"#{json_escape(File.basename(fixture))}",
-  "fixture_path":"#{json_escape(fixture)}",
-  "scenario":"#{json_escape(options[:scenario])}",
-  "iterations":#{iterations},
-  "elapsed_seconds":#{format('%.8f', elapsed)},
-  "ops_per_sec":#{format('%.4f', ops_per_sec)},
-  "mb_per_sec":#{format('%.4f', mb_per_sec)},
-  "bytes_processed":#{bytes_processed},
-  "payload_size_bytes":#{payload_size_bytes}
-})
-
-puts payload.strip

data/ext/html-to-markdown-rb/native/src/conversion/tables.rs

@@ -1,71 +0,0 @@
-//! Table extraction conversion functions for Ruby bindings.
-
-use html_to_markdown_rs::{ConversionWithTables, TableData};
-use magnus::prelude::*;
-use magnus::{Error, Ruby, Value};
-
-#[cfg(feature = "metadata")]
-use super::metadata::extended_metadata_to_ruby;
-
-fn table_data_to_ruby(ruby: &Ruby, table: TableData) -> Result<Value, Error> {
-    let hash = ruby.hash_new();
-
-    // cells: Array[Array[String]]
-    let cells_array = ruby.ary_new();
-    for row in table.cells {
-        let row_array = ruby.ary_new();
-        for cell in row {
-            row_array.push(cell)?;
-        }
-        cells_array.push(row_array)?;
-    }
-    hash.aset(ruby.intern("cells"), cells_array)?;
-
-    // markdown: String
-    hash.aset(ruby.intern("markdown"), table.markdown)?;
-
-    // is_header_row: Array[bool]
-    let header_array = ruby.ary_new();
-    for is_header in table.is_header_row {
-        header_array.push(is_header)?;
-    }
-    hash.aset(ruby.intern("is_header_row"), header_array)?;
-
-    Ok(hash.as_value())
-}
-
-/// Convert a `ConversionWithTables` result to a Ruby Hash.
-///
-/// Returns a Hash with keys `:content`, `:metadata`, `:tables`.
-pub fn tables_result_to_ruby(ruby: &Ruby, result: ConversionWithTables) -> Result<Value, Error> {
-    let hash = ruby.hash_new();
-
-    // content: String
-    hash.aset(ruby.intern("content"), result.content)?;
-
-    // metadata: Hash or nil
-    #[cfg(feature = "metadata")]
-    {
-        match result.metadata {
-            Some(metadata) => {
-                hash.aset(ruby.intern("metadata"), extended_metadata_to_ruby(ruby, metadata)?)?;
-            }
-            None => {
-                hash.aset(ruby.intern("metadata"), ruby.qnil())?;
-            }
-        }
-    }
-    #[cfg(not(feature = "metadata"))]
-    {
-        hash.aset(ruby.intern("metadata"), ruby.qnil())?;
-    }
-
-    // tables: Array[Hash]
-    let tables_array = ruby.ary_new();
-    for table in result.tables {
-        tables_array.push(table_data_to_ruby(ruby, table)?)?;
-    }
-    hash.aset(ruby.intern("tables"), tables_array)?;
-
-    Ok(hash.as_value())
-}