html-table 1.7.0 → 1.7.1

data/spec/caption_spec.rb

@@ -9,66 +9,75 @@ require 'html/table'
 RSpec.describe HTML::Table::Caption do
   before do
     @table = HTML::Table.new
-    @tcaption = HTML::Table::Caption.new
+    @tcaption = described_class.new
   end
 
-  example "constructor" do
-    expect{ HTML::Table::Caption.new }.not_to raise_error
-    expect{ HTML::Table::Caption.new("foo") }.not_to raise_error
-    expect{ HTML::Table::Caption.new(1) }.not_to raise_error
-    expect{ HTML::Table::Caption.new(%w/foo bar baz/) }.not_to raise_error
-    expect{ HTML::Table::Caption.new([1,2,3]) }.not_to raise_error
-    expect{ HTML::Table::Caption.new([[1,2,3],["foo","bar"]]) }.not_to raise_error
+  example 'constructor' do
+    expect{ described_class.new }.not_to raise_error
   end
 
-  example "basic" do
-    html = "<caption></caption>"
+  example 'constructor with string' do
+    expect{ described_class.new('foo') }.not_to raise_error
+  end
+
+  example 'constructor with number' do
+    expect{ described_class.new(1) }.not_to raise_error
+  end
+
+  example 'constructor with arrays' do
+    expect{ described_class.new(%w[foo bar baz]) }.not_to raise_error
+    expect{ described_class.new([1, 2, 3]) }.not_to raise_error
+    expect{ described_class.new([[1, 2, 3], %w[foo bar]]) }.not_to raise_error
+  end
+
+  example 'basic' do
+    html = '<caption></caption>'
     expect(@tcaption.html.gsub(/\s+/, '')).to eq(html)
   end
 
-  example "with_attributes" do
+  example 'with_attributes' do
     html = "<caption align='left' valign='top'></caption>"
-    @tcaption.align = "left"
-    @tcaption.valign = "top"
+    @tcaption.align = 'left'
+    @tcaption.valign = 'top'
     expect(@tcaption.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "configure_not_allowed" do
+  example 'configure_not_allowed' do
     expect{ @tcaption.configure }.to raise_error(NoMethodError)
   end
 
-  example "add_content" do
-    html = "<caption>hello world</caption>"
-    @tcaption.content = "hello world"
+  example 'add_content' do
+    html = '<caption>hello world</caption>'
+    @tcaption.content = 'hello world'
     expect(@tcaption.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "add_multiple_content_items" do
-    html = "<caption>hello world</caption>"
-    @tcaption.content = "hello"," world"
+  example 'add_multiple_content_items' do
+    html = '<caption>hello world</caption>'
+    @tcaption.content = 'hello', ' world'
     expect(@tcaption.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "add_content_in_constructor" do
-    html = "<caption>hello world</caption>"
-    @tcaption = HTML::Table::Caption.new("hello world")
+  example 'add_content_in_constructor' do
+    html = '<caption>hello world</caption>'
+    @tcaption = described_class.new('hello world')
     expect(@tcaption.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "indent_level" do
-    expect(HTML::Table::Caption).to respond_to(:indent_level)
-    expect(HTML::Table::Caption).to respond_to(:indent_level=)
-    expect{ HTML::Table::Caption.indent_level = "foo" }.to raise_error(ArgumentTypeError)
-    expect{ HTML::Table::Caption.indent_level = 3 }.not_to raise_error
+  example 'indent_level' do
+    expect(described_class).to respond_to(:indent_level)
+    expect(described_class).to respond_to(:indent_level=)
+    expect{ described_class.indent_level = 'foo' }.to raise_error(ArgumentTypeError)
+    expect{ described_class.indent_level = 3 }.not_to raise_error
   end
 
-  example "only_row_zero_allowed" do
+  example 'only_row_zero_allowed' do
     expect{ @table[1] = @tcaption }.to raise_error(ArgumentError)
   end
 
-  example "automatically_set_to_row_zero" do
-    @table.content = "hello","world"
+  example 'automatically_set_to_row_zero' do
+    @table.content = 'hello', 'world'
     @table.push(@tcaption)
-    expect(@table[0]).to be_kind_of(HTML::Table::Caption)
+    expect(@table[0]).to be_a(described_class)
   end
 end

data/spec/colgroup_col_spec.rb

@@ -11,24 +11,24 @@ RSpec.describe HTML::Table::ColGroup::Col do
     @col = described_class.new
   end
 
-  example "basic" do
-    html = "<col>"
+  example 'basic' do
+    html = '<col>'
     expect(@col.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "no_configure" do
+  example 'no_configure' do
     expect{ @col.configure }.to raise_error(NoMethodError)
   end
 
-  example "no_content_allowed" do
+  example 'no_content_allowed' do
     expect{ @col.content }.to raise_error(NoMethodError)
-    expect{ @col.content = "foo" }.to raise_error(NoMethodError)
+    expect{ @col.content = 'foo' }.to raise_error(NoMethodError)
   end
 
-  example "indent_level" do
+  example 'indent_level' do
     expect(described_class).to respond_to(:indent_level)
     expect(described_class).to respond_to(:indent_level=)
-    expect{ described_class.indent_level = "foo" }.to raise_error(ArgumentTypeError)
+    expect{ described_class.indent_level = 'foo' }.to raise_error(ArgumentTypeError)
     expect{ described_class.indent_level = 6 }.not_to raise_error
   end
 end

data/spec/colgroup_spec.rb

@@ -8,76 +8,90 @@ require 'html/table'
 
 RSpec.describe HTML::Table::ColGroup do
   before do
-    @cgroup = HTML::Table::ColGroup.new
+    @cgroup = described_class.new
     @col = HTML::Table::ColGroup::Col.new
   end
 
-  example "constructor" do
-    expect{ HTML::Table::ColGroup.new }.not_to raise_error
-    expect{ HTML::Table::ColGroup.new(@col) }.not_to raise_error
-    expect{ HTML::Table::ColGroup.new("foo") }.to raise_error(TypeError)
+  example 'constructor' do
+    expect{ described_class.new }.not_to raise_error
+    expect{ described_class.new(@col) }.not_to raise_error
+    expect{ described_class.new('foo') }.to raise_error(ArgumentTypeError)
   end
 
-  example "basic" do
-    html = "<colgroup></colgroup>"
+  example 'basic' do
+    html = '<colgroup></colgroup>'
     expect(@cgroup.html.gsub(/\s+/, '')).to eq(html)
   end
 
-  example "with_attributes" do
+  example 'with attributes' do
     html = "<colgroup align='center' width='20%'></colgroup>"
-    @cgroup.align = "center"
-    @cgroup.width = "20%"
+    @cgroup.align = 'center'
+    @cgroup.width = '20%'
     expect(@cgroup.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "push_single_col_element" do
-    html = "<colgroup><col></colgroup>"
+  example 'push single col element' do
+    html = '<colgroup><col></colgroup>'
     @cgroup.push(@col)
     expect(@cgroup.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "index_assignment_constraints" do
-    expect{ @cgroup[0] = "foo" }.to raise_error(ArgumentTypeError)
+  example 'index assignment constraints' do
+    expect{ @cgroup[0] = 'foo' }.to raise_error(ArgumentTypeError)
     expect{ @cgroup[0] = 1 }.to raise_error(ArgumentTypeError)
     expect{ @cgroup[1] = HTML::Table::Row.new }.to raise_error(ArgumentTypeError)
     expect{ @cgroup[0] = HTML::Table::ColGroup::Col.new }.not_to raise_error
   end
 
-  example "push_constraints" do
-    expect{ @cgroup.push(7) }.to raise_error(TypeError)
-    expect{ @cgroup.push("hello") }.to raise_error(TypeError)
-    expect{ @cgroup.push(HTML::Table::Row.new) }.to raise_error(TypeError)
+  example 'push constraints' do
+    expect{ @cgroup.push(7) }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup.push('hello') }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup.push(HTML::Table::Row.new) }.to raise_error(ArgumentTypeError)
     expect{ @cgroup.push(HTML::Table::ColGroup::Col.new) }.not_to raise_error
   end
 
-  example "double_arrow_constraints" do
-    expect{ @cgroup << 7 }.to raise_error(TypeError)
-    expect{ @cgroup << "hello" }.to raise_error(TypeError)
-    expect{ @cgroup << HTML::Table::Row.new }.to raise_error(TypeError)
+  example 'double arrow constraints' do
+    expect{ @cgroup << 7 }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup << 'hello' }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup << HTML::Table::Row.new }.to raise_error(ArgumentTypeError)
     expect{ @cgroup << HTML::Table::ColGroup::Col.new }.not_to raise_error
   end
 
-  example "configure_error" do
-    expect{ @cgroup.configure(0,0){ }.to raise_error(ArgumentError) }
+  example 'unshift constraints' do
+    expect{ @cgroup.unshift(7) }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup.unshift('hello') }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup.unshift(HTML::Table::Row.new) }.to raise_error(ArgumentTypeError)
+    expect{ @cgroup.unshift(HTML::Table::ColGroup::Col.new) }.not_to raise_error
   end
 
-  example "content_error" do
+  example 'configure error' do
+    expect{ @cgroup.configure(0, 0){} }.to raise_error(ArgumentError)
+  end
+
+  example 'content error' do
     expect{ @cgroup.content }.to raise_error(NoMethodError)
     expect{ @cgroup.content = 'blah' }.to raise_error(NoMethodError)
   end
 
-  example "indent_level" do
-    expect(HTML::Table::ColGroup).to respond_to(:indent_level)
-    expect(HTML::Table::ColGroup).to respond_to(:indent_level=)
-    expect{ HTML::Table::ColGroup.indent_level = "foo" }.to raise_error(ArgumentTypeError)
-    expect{ HTML::Table::ColGroup.indent_level = 6 }.not_to raise_error
+  example 'indent_level' do
+    expect(described_class).to respond_to(:indent_level)
+    expect(described_class).to respond_to(:indent_level=)
+    expect{ described_class.indent_level = 'foo' }.to raise_error(ArgumentTypeError)
+    expect{ described_class.indent_level = 6 }.not_to raise_error
+  end
+
+  example 'end_tags? basic functionality' do
+    expect(described_class).to respond_to(:end_tags?)
+    expect(described_class.end_tags?).to be(true)
+  end
+
+  example 'end_tags= basic functionality' do
+    expect(described_class).to respond_to(:end_tags=)
+    expect{ described_class.end_tags = true }.not_to raise_error
   end
 
-  example "end_tags" do
-    expect(HTML::Table::ColGroup).to respond_to(:end_tags?)
-    expect(HTML::Table::ColGroup).to respond_to(:end_tags=)
-    expect{ HTML::Table::ColGroup.end_tags = "foo" }.to raise_error(ArgumentTypeError)
-    expect{ HTML::Table::ColGroup.end_tags = 1 }.to raise_error(ArgumentTypeError)
-    expect{ HTML::Table::ColGroup.end_tags = true }.not_to raise_error
+  example 'end_tags= raises an error if an invalid type is assigned' do
+    expect{ described_class.end_tags = 'foo' }.to raise_error(ArgumentTypeError)
+    expect{ described_class.end_tags = 1 }.to raise_error(ArgumentTypeError)
   end
 end

data/spec/data_spec.rb

@@ -11,21 +11,30 @@ RSpec.describe HTML::Table::Row::Data do
     @tdata = described_class.new
   end
 
-  example "constructor" do
+  example 'constructor' do
     expect{ described_class.new }.not_to raise_error
-    expect{ described_class.new("foo") }.not_to raise_error
+  end
+
+  example 'constructor with string' do
+    expect{ described_class.new('foo') }.not_to raise_error
+  end
+
+  example 'constructor with numeric' do
     expect{ described_class.new(1) }.not_to raise_error
-    expect{ described_class.new(%w/foo bar baz/) }.not_to raise_error
-    expect{ described_class.new([1,2,3]) }.not_to raise_error
-    expect{ described_class.new([[1,2,3],["foo","bar"]]) }.not_to raise_error
   end
 
-  example "basic" do
-    html = "<td></td>"
+  example 'constructor with arrays' do
+    expect{ described_class.new(%w[foo bar baz]) }.not_to raise_error
+    expect{ described_class.new([1, 2, 3]) }.not_to raise_error
+    expect{ described_class.new([[1, 2, 3], %w[foo bar]]) }.not_to raise_error
+  end
+
+  example 'basic' do
+    html = '<td></td>'
     expect(@tdata.html.gsub(/\s+/, '')).to eq(html)
   end
 
-  example "with_attributes" do
+  example 'with_attributes' do
     html = "<td align='left' width=3 nowrap></td>"
     @tdata.align = 'left'
     @tdata.width = 3
@@ -33,40 +42,47 @@ RSpec.describe HTML::Table::Row::Data do
     expect(@tdata.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "configure_not_allowed" do
+  example 'configure_not_allowed' do
     expect{ @tdata.configure }.to raise_error(NoMethodError)
   end
 
-  example "add_content" do
-    html = "<td>hello world</td>"
-    @tdata.content = "hello world"
+  example 'add_content' do
+    html = '<td>hello world</td>'
+    @tdata.content = 'hello world'
     expect(@tdata.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "add_content_in_constructor" do
-    html = "<td>hello world</td>"
-    td = described_class.new("hello world")
+  example 'add_content_in_constructor' do
+    html = '<td>hello world</td>'
+    td = described_class.new('hello world')
     expect(td.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "add_multiple_content_items" do
-    html = "<td>hello world</td>"
-    @tdata.content = "hello"," world"
+  example 'add_multiple_content_items' do
+    html = '<td>hello world</td>'
+    @tdata.content = 'hello', ' world'
     expect(@tdata.html.gsub(/\s{2,}/, '')).to eq(html)
   end
 
-  example "indent_level" do
+  example 'indent_level' do
     expect(described_class).to respond_to(:indent_level)
     expect(described_class).to respond_to(:indent_level=)
-    expect{ described_class.indent_level = "foo" }.to raise_error(ArgumentTypeError)
+    expect{ described_class.indent_level = 'foo' }.to raise_error(ArgumentTypeError)
     expect{ described_class.indent_level = 6 }.not_to raise_error
   end
 
-  example "end_tags" do
+  example 'end_tags? basic functionality' do
     expect(described_class).to respond_to(:end_tags?)
+    expect(described_class.end_tags?).to be(true)
+  end
+
+  example 'end_tags= basic functionality' do
     expect(described_class).to respond_to(:end_tags=)
-    expect{ described_class.end_tags = "foo" }.to raise_error(ArgumentTypeError)
-    expect{ described_class.end_tags = 1 }.to raise_error(ArgumentTypeError)
     expect{ described_class.end_tags = true }.not_to raise_error
   end
+
+  example 'end_tags= raises an error on an invalid value' do
+    expect{ described_class.end_tags = 'foo' }.to raise_error(ArgumentTypeError)
+    expect{ described_class.end_tags = 1 }.to raise_error(ArgumentTypeError)
+  end
 end

data/spec/foot_spec.rb

@@ -8,97 +8,109 @@
 require 'rspec'
 require 'html/table'
 
-class HTML::Table::Foot
-  private
-  def refresh
-    @@foot = nil
-  end
-end
-
 RSpec.describe HTML::Table::Foot do
   before do
-    @table = HTML::Table.new
     @tfoot = described_class.create
   end
 
-  example "new_not_allowed" do
-    expect{ described_class.new }.to raise_error(NoMethodError)
+  after do
+    described_class.instance_variable_set(:@instance, nil)
   end
 
-  example "constructor" do
+  example 'constructor' do
     expect{ described_class.create }.not_to raise_error
-    expect{ described_class.create("foo") }.not_to raise_error
+  end
+
+  example 'constructor with string' do
+    expect{ described_class.create('foo') }.not_to raise_error
+  end
+
+  example 'constructor with numeric' do
     expect{ described_class.create(1) }.not_to raise_error
-    expect{ described_class.create(%w/foo bar baz/) }.not_to raise_error
-    expect{ described_class.create([1,2,3]) }.not_to raise_error
-    expect{ described_class.create([[1,2,3], ["foo","bar"]]) }.not_to raise_error
   end
 
-  example "basic" do
-    html = "<tfoot></tfoot>"
+  example 'constructor with arrays' do
+    expect{ described_class.create(%w[foo bar baz]) }.not_to raise_error
+    expect{ described_class.create([1, 2, 3]) }.not_to raise_error
+    expect{ described_class.create([[1, 2, 3], %w[foo bar]]) }.not_to raise_error
+  end
+
+  example 'basic' do
+    html = '<tfoot></tfoot>'
     expect(@tfoot.html.gsub(/\s{2,}|\n/, '')).to eq(html)
   end
 
-  example "end_tags" do
+  example 'end_tags? basic functionality' do
     expect(described_class).to respond_to(:end_tags?)
-    expect(described_class).to respond_to(:end_tags=)
+    expect(described_class.end_tags?).to be(true)
     expect{ described_class.end_tags? }.not_to raise_error
+  end
+
+  example 'end_tags= basic functionality' do
+    expect(described_class).to respond_to(:end_tags=)
     expect{ described_class.end_tags = true }.not_to raise_error
   end
 
-  example "end_tags_expected_errors" do
-    expect{ described_class.end_tags = "foo" }.to raise_error(HTML::Mixin::StrongTyping::ArgumentTypeError)
+  example 'end_tags raises an error on an invalid type' do
+    expect{ described_class.end_tags = 'foo' }.to raise_error(ArgumentTypeError)
   end
 
-  example "with_attributes" do
+  example 'with attributes' do
     html = "<tfoot align='left' char='x'></tfoot>"
-    @tfoot.align = "left"
+    @tfoot.align = 'left'
     @tfoot.char = 'x'
     expect(@tfoot.html.gsub(/\s{2,}|\n/, '')).to eq(html)
   end
 
-  example "push_single_row" do
-    html = "<tfoot><tr><td>test</td></tr></tfoot>"
-    @tfoot.push Table::Row.new{|r| r.content = "test"}
+  example 'push single row' do
+    html = '<tfoot><tr><td>test</td></tr></tfoot>'
+    @tfoot.push(HTML::Table::Row.new{ |r| r.content = 'test' })
     expect(@tfoot.html.gsub(/\s{2,}|\n/, '')).to eq(html)
   end
 
-  example "push_multiple_rows" do
-    html = "<tfoot><tr><td>test</td></tr><tr><td>foo</td></tr></tfoot>"
-    r1 = Table::Row.new{|r| r.content = "test"}
-    r2 = Table::Row.new{|r| r.content = "foo"}
+  example 'push multiple rows' do
+    html = '<tfoot><tr><td>test</td></tr><tr><td>foo</td></tr></tfoot>'
+    r1 = HTML::Table::Row.new{ |r| r.content = 'test' }
+    r2 = HTML::Table::Row.new{ |r| r.content = 'foo' }
     @tfoot.push r1, r2
     expect(@tfoot.html.gsub(/\s{2,}|\n/, '')).to eq(html)
   end
 
-  example "add_content_directly" do
-    html = "<tfoot><tr><td>hello</td><td>world</td></tr></tfoot>"
-    @tfoot.content = "hello","world"
+  example 'add content directly' do
+    html = '<tfoot><tr><td>hello</td><td>world</td></tr></tfoot>'
+    @tfoot.content = 'hello', 'world'
     expect(@tfoot.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "add_content_in_constructor" do
-    html = "<tfoot><tr><td>hello</td><td>world</td></tr></tfoot>"
-    @tfoot.send(:refresh)
-    @tfoot = described_class.create(["hello","world"])
+  example 'add content in constructor' do
+    html = '<tfoot><tr><td>hello</td><td>world</td></tr></tfoot>'
+    described_class.instance_variable_set(:@instance, nil)
+    @tfoot = described_class.create(%w[hello world])
     expect(@tfoot.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  example "configure_column" do
+  example 'configure column' do
     html = "<tfoot><tr><td>hello</td><td abbr='test' width=3 nowrap>world"
-    html += "</td></tr></tfoot>"
-    @tfoot.content = "hello","world"
-    @tfoot.configure(0,1){ |data|
+    html += '</td></tr></tfoot>'
+    @tfoot.content = 'hello', 'world'
+    @tfoot.configure(0, 1) do |data|
       data.abbr   = 'test'
       data.width  = 3
       data.nowrap = true
-    }
+    end
     expect(@tfoot.html.gsub(/\s{2,}|\n+/, '')).to eq(html)
   end
 
-  after do
-    @table = nil
-    @tfoot.send(:refresh)
-    @tfoot = nil
+  # rubocop:disable RSpec/IdenticalEqualityAssertion
+  example 'new not allowed' do
+    expect{ described_class.new }.to raise_error(NoMethodError)
+  end
+
+  example 'additional calls to constructor do nothing since class is a singleton' do
+    expect(described_class.create).to eq(described_class.create)
+    expect(described_class.instance).to eq(described_class.instance)
+    expect(described_class.instance.object_id).to eq(described_class.instance.object_id)
+    expect(described_class.create.object_id).to eq(described_class.create.object_id)
   end
+  # rubocop:enable RSpec/IdenticalEqualityAssertion
 end