html-proofer 5.2.0 → 5.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03f01340b8aebd3ccad6d82ab5aef056991f91bae04498df5091b3c7e9e6641f
-  data.tar.gz: 3dda407dc70dc4d6d65ac88f6b3474e091832c3b37bc70d3bc74e8fdc4d136db
+  metadata.gz: 1081048f56ee5d0b41f5ba9278d0757d1a1eef6fdb8c50148eb2b47a183b5572
+  data.tar.gz: 9a60b977a473c77c12085062b0438eb175751a0a013206ec4dbd1baf03deffb6
 SHA512:
-  metadata.gz: f652269525122a2199b373be5f19a3a93541f14e14539621f207605f5e346cf2cd34fe68cea4ed6e86236f37e69e5f1db709c68fab71816847b20248acb487a3
-  data.tar.gz: 487828db630f2916ab417d8d9d3cecbd8aa96a5140ee3695d2c49b589f3d8f286bcb9fef964bf517f08286e35500dfc6c0a1119f2f83d22d9f0a6653ad3a3c8d
+  metadata.gz: 0402cc78e35cd4440bf95e9a9d0372f68677d28ad0e901867457c4583caebb4cbd4eefdc50e27e270d85e756ee402c0e2ba6898c3bf1b074fef6f69f8b30ae7a
+  data.tar.gz: f5754b9c79336f792cb2064baab958b7c27e62d13a6ae225a9fe5cde286d773e9427251ccd7b44afa7d258e517a5838af5ad6fdff3c63a0b6bf21b8cba08c75f

data/lib/html_proofer/attribute/url.rb

@@ -172,7 +172,9 @@ module HTMLProofer
       def unslashed_directory?(file)
         return false unless File.directory?(file)
 
-        !file.end_with?(File::SEPARATOR) && !follow_location?
+        # the trailing slash must be read off the URL, not off `file`: the latter
+        # is produced by File.expand_path, which strips trailing separators
+        !path.to_s.end_with?("/") && !follow_location?
       end
 
       def follow_location?
@@ -239,7 +241,7 @@ module HTMLProofer
         else
           url
         end
-      rescue Addressable::URI::InvalidURIError # rubocop:disable Lint/SuppressedException -- error will be reported at check time
+      rescue Addressable::URI::InvalidURIError # -- error will be reported at check time
       end
 
       private def swap_urls!

data/lib/html_proofer/runner.rb

@@ -200,7 +200,7 @@ module HTMLProofer
     end
 
     def failed_checks
-      @reporter.failures.flatten.select { |f| f.is_a?(Failure) }
+      @reporter.failures.flatten.grep(Failure)
     end
 
     def report_failed_checks

data/lib/html_proofer/url_validator/external.rb

@@ -121,7 +121,10 @@ module HTMLProofer
         return false unless url.hash?
 
         hash = url.hash
-        headers = response.options.fetch(:headers, {})
+        # `response.headers` covers both live responses (which expose the headers
+        # via :response_headers) and stubbed ones (which set :headers directly);
+        # reading options[:headers] saw nothing but stubs.
+        headers = response.headers || {}
         content_type = headers.find { |k, _| k.casecmp("content-type").zero? }
 
         # attempt to verify PDF hash ref; see #787 for more details

data/lib/html_proofer/url_validator/internal.rb

@@ -116,10 +116,13 @@ module HTMLProofer
         return true if blank?(href_hash)
         return true unless @runner.options[:check_internal_hash]
 
-        # prevents searching files we didn't ask about
-        return false unless url.known_extension?
+        # For hash links, we need to defer to file-based checking
+        # (even if URL doesn't have extension, it may resolve to index.html)
         return false unless url.has_hash?
 
+        # If URL has no known extension, defer to file-based checking
+        return false unless url.known_extension?
+
         decoded_href_hash = Addressable::URI.unescape(href_hash)
         fragment_ids = [href_hash, decoded_href_hash]
         # https://www.w3.org/TR/html5/single-page.html#scroll-to-fragid
@@ -134,10 +137,18 @@ module HTMLProofer
 
       private def find_fragments(fragment_ids, html)
         xpaths = fragment_ids.uniq.flat_map do |frag_id|
-          escaped_frag_id = "'#{frag_id.split("'").join("', \"'\", '")}', ''"
+          # Build XPath string argument, handling single quotes
+          if frag_id.include?("'")
+            # Use concat() to handle single quotes: concat('part1', "'", 'part2')
+            escaped_frag_id = frag_id.split("'").map { |part| "'#{part}'" }.join(", \"'\", ")
+            xpath_arg = "concat(#{escaped_frag_id})"
+          else
+            # No single quotes, just use quoted string
+            xpath_arg = "'#{frag_id}'"
+          end
           [
-            "//*[case_sensitive_equals(@id, concat(#{escaped_frag_id}))]",
-            "//*[case_sensitive_equals(@name, concat(#{escaped_frag_id}))]",
+            "//*[case_sensitive_equals(@id, #{xpath_arg})]",
+            "//*[case_sensitive_equals(@name, #{xpath_arg})]",
           ]
         end
         xpaths << XpathFunctions.new

data/lib/html_proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = "5.2.0"
+  VERSION = "5.2.2"
 end

data/lib/html_proofer.rb

@@ -18,7 +18,7 @@ if ENV.fetch("DEBUG", false)
   require "debug"
   begin
     require "amazing_print"
-  rescue LoadError # rubocop:disable Lint/SuppressedException
+  rescue LoadError
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.2.2
 platform: ruby
 authors:
 - Garen Torikian
@@ -135,48 +135,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.5'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: timecop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.4'
 description: Test your rendered HTML files to make sure they're accurate.
 email:
 - gjtorikian@gmail.com
@@ -234,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.10
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image
   references are legitimate, if they have alt tags, if your internal links are working,