html-proofer 5.0.8 → 5.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2c4f6e223ea64d009b2dc422066610376bfff66fa8b6da09b485ce72e5538c7
-  data.tar.gz: e9f2d8f81a4f21e5bb76bbaaedd7e8a95b95cf6439938e62c364ad92392af518
+  metadata.gz: 6ecfce010632739b71710eb8b6c91b8ca6ca4828e2b6e7df254c2cc6b00462a4
+  data.tar.gz: 50d19f3c6145d6184dc5d463cfde6684d609f797277b437103bf8114387d8570
 SHA512:
-  metadata.gz: 70fa1c406f6bf212176f2e2f257c98e88615635463d584e01e31a8be2647b096e8ebfb75549058a9626185f8f45989e446e28d9977a4d14189d074a4d6c75b9c
-  data.tar.gz: 31ea3bb4397972ade2731a442ad4cae5a435ad13f598777b2890c179f54a2f54f7d2102fb46ac805fc39bb0b8e7efe8805c61cf1fc63d8f897158caa732a6bde
+  metadata.gz: 92253a2948b3492043b548c1ae3ccf23dc66e9da5dd14bdf6724e9c6f377ce53960fa4b689390d4242e1cd3090773b3de0caba8550a61cebde932564a2811a4d
+  data.tar.gz: 8c9ad6f1cdd747241d46e06ff444f84d7de7a73f6ae71b8b9e73406e11ad8748bf29ff3db3d837e7535ddb4c235e87f5b52b8999992811ae87e2dc00bbd96a76

data/lib/html_proofer/attribute/url.rb

@@ -52,7 +52,8 @@ module HTMLProofer
 
       def ignore?
         return true if /^javascript:/.match?(@url)
-        return true if ignores_pattern?(@runner.options[:ignore_urls])
+
+        true if ignores_pattern?(@runner.options[:ignore_urls])
       end
 
       def valid?
@@ -220,11 +221,24 @@ module HTMLProofer
         @url.to_s.sub(/##{hash}/, "")
       end
 
-      # catch any obvious issues, like strings in port numbers
+      # catch any obvious issues
       private def clean_url!
-        return if @url =~ /^([!#{Regexp.last_match(0)}-;=?-\[\]_a-z~]|%[0-9a-fA-F]{2})+$/
-
-        @url = Addressable::URI.parse(@url).normalize.to_s
+        parsed_url = Addressable::URI.parse(@url)
+        url = if parsed_url.scheme.nil?
+          parsed_url
+        else
+          parsed_url.normalize
+        end.to_s
+
+        # normalize strips this off, which causes issues with cache
+        @url = if @url.end_with?("/") && !url.end_with?("/")
+          "#{url}/"
+        elsif !@url.end_with?("/") && url.end_with?("/")
+          url.chop
+        else
+          url
+        end
+      rescue Addressable::URI::InvalidURIError # rubocop:disable Lint/SuppressedException -- error will be reported at check time
       end
 
       private def swap_urls!

data/lib/html_proofer/cache.rb

@@ -41,7 +41,7 @@ module HTMLProofer
     end
 
     def parsed_timeframe(timeframe)
-      return nil if timeframe.nil?
+      return if timeframe.nil?
 
       time, date = timeframe.match(/(\d+)(\D)/).captures
       time = time.to_i
@@ -252,7 +252,7 @@ module HTMLProofer
     SECONDS_PER_HOUR   = 3600
     SECONDS_PER_DAY    = 86400
     SECONDS_PER_WEEK   = 604800
-    SECONDS_PER_MONTH  = 2629746  # 1/12 of a gregorian year
+    SECONDS_PER_MONTH  = 2629746 # 1/12 of a gregorian year
 
     private def time_ago(measurement, unit)
       case unit
@@ -269,7 +269,8 @@ module HTMLProofer
 
     private def url_matches_type?(url, type)
       return true if type == :internal && url !~ URI_REGEXP
-      return true if type == :external && url =~ URI_REGEXP
+
+      true if type == :external && url =~ URI_REGEXP
     end
 
     private def cleaned_url(url)

data/lib/html_proofer/check/images.rb

@@ -20,18 +20,6 @@ module HTMLProofer
           # does the image exist?
           if missing_src?
             add_failure("image has no src or srcset attribute", element: @img)
-          elsif @img.url.protocol_relative?
-            add_failure(
-              "image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
-              element: @img,
-            )
-          elsif @img.url.remote?
-            add_to_external_urls(@img.url, @img.line)
-          elsif !@img.url.exists? && !@img.multiple_srcsets? && !@img.multiple_sizes?
-            add_failure(
-              "internal image #{@img.url.raw_attribute} does not exist",
-              element: @img,
-            )
           elsif @img.multiple_srcsets? || @img.multiple_sizes?
             @img.srcsets_wo_sizes.each do |srcset|
               srcset_url = HTMLProofer::Attribute::Url.new(@runner, srcset, base_url: @img.base_url, source: @img.url.source, filename: @img.url.filename, extract_size: true)
@@ -47,6 +35,18 @@ module HTMLProofer
                 add_failure("internal image #{srcset} does not exist", element: @img)
               end
             end
+          elsif @img.url.protocol_relative?
+            add_failure(
+              "image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
+              element: @img,
+            )
+          elsif @img.url.remote?
+            add_to_external_urls(@img.url, @img.line)
+          elsif !@img.url.exists? && !@img.multiple_srcsets? && !@img.multiple_sizes?
+            add_failure(
+              "internal image #{@img.url.raw_attribute} does not exist",
+              element: @img,
+            )
           end
 
           # if this is an img element, check that the alt attribute is present

data/lib/html_proofer/configuration.rb

@@ -233,8 +233,8 @@ module HTMLProofer
       arg.split(",").each_with_object({}) do |s, hsh|
         split = s.split(/(?<!\\):/, 2)
 
-        re = split[0].gsub(/\\:/, ":")
-        string = split[1].gsub(/\\:/, ":")
+        re = split[0].gsub("\\:", ":")
+        string = split[1].gsub("\\:", ":")
         hsh[Regexp.new(re)] = string
       end
     end

data/lib/html_proofer/element.rb

@@ -27,7 +27,7 @@ module HTMLProofer
     end
 
     def meta_content
-      return nil unless meta_tag?
+      return unless meta_tag?
 
       @node["content"]
     end
@@ -37,7 +37,7 @@ module HTMLProofer
     end
 
     def src
-      return nil if !img_tag? && !script_tag? && !source_tag?
+      return if !img_tag? && !script_tag? && !source_tag?
 
       @node["src"]
     end
@@ -51,7 +51,7 @@ module HTMLProofer
     end
 
     def srcset
-      return nil if !img_tag? && !source_tag?
+      return if !img_tag? && !source_tag?
 
       @node["srcset"]
     end
@@ -61,7 +61,7 @@ module HTMLProofer
     end
 
     def href
-      return nil if !a_tag? && !link_tag?
+      return if !a_tag? && !link_tag?
 
       @node["href"]
     end
@@ -96,7 +96,7 @@ module HTMLProofer
     IMAGE_CANDIDATE_REGEX = /\s*([^,]\S*[^,](?:\s+[^,]+)?)\s*(?:,|$)/
 
     def srcsets
-      return nil if blank?(srcset)
+      return if blank?(srcset)
 
       srcset.split(IMAGE_CANDIDATE_REGEX).select.with_index do |_part, idx|
         idx.odd?
@@ -112,7 +112,7 @@ module HTMLProofer
     end
 
     def srcsets_wo_sizes
-      return nil if blank?(srcsets)
+      return if blank?(srcsets)
 
       srcsets.map do |srcset|
         srcset.split(" ").first
@@ -133,7 +133,7 @@ module HTMLProofer
 
       attrs = @runner.options[:swap_attributes][@node.name]
 
-      return true unless blank?(attrs)
+      true unless blank?(attrs)
     end
 
     private def swap_attributes!

data/lib/html_proofer/log.rb

@@ -13,7 +13,7 @@ module HTMLProofer
     def initialize(log_level)
       @logger = Yell.new(
         format: false,
-        name: "HTMLProofer", \
+        name: "HTMLProofer",
         level: "gte.#{log_level}",
       ) do |l|
         l.adapter(:stdout, level: "lte.warn")
@@ -41,8 +41,8 @@ module HTMLProofer
         :red
       end
 
-      if (STDOUT_LEVELS.include?(level) && $stdout.isatty) ||
-          (STDERR_LEVELS.include?(level) && $stderr.isatty)
+      if STDOUT_LEVELS.include?(level) ||
+          STDERR_LEVELS.include?(level)
         Rainbow(message).send(color)
       else
         message

data/lib/html_proofer/runner.rb

@@ -236,7 +236,7 @@ module HTMLProofer
     end
 
     private def load_cache(type)
-      ivar = instance_variable_get("@#{type}_urls")
+      ivar = instance_variable_get(:"@#{type}_urls")
 
       existing_urls_count = @cache.size(type)
       cache_text = pluralize(existing_urls_count, "#{type} link", "#{type} links")
@@ -249,7 +249,7 @@ module HTMLProofer
 
     private def format_checks_list(checks)
       checks.map do |check|
-        check.sub(/HTMLProofer::Check::/, "")
+        check.sub("HTMLProofer::Check::", "")
       end.sort.join(", ")
     end
   end

data/lib/html_proofer/url_validator/internal.rb

@@ -120,9 +120,7 @@ module HTMLProofer
         decoded_href_hash = Addressable::URI.unescape(href_hash)
         fragment_ids = [href_hash, decoded_href_hash]
         # https://www.w3.org/TR/html5/single-page.html#scroll-to-fragid
-        return true if fragment_ids.include?("top")
-
-        nil
+        true if fragment_ids.include?("top")
       end
 
       private def hash_exists_in_html?(href_hash, html)

data/lib/html_proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = "5.0.8"
+  VERSION = "5.0.10"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 5.0.8
+  version: 5.0.10
 platform: ruby
 authors:
 - Garen Torikian
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-06 00:00:00.000000000 Z
+date: 2025-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -212,7 +212,7 @@ licenses:
 metadata:
   funding_uri: https://github.com/sponsors/gjtorikian/
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -230,8 +230,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.18
-signing_key: 
+rubygems_version: 3.5.3
+signing_key:
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image
   references are legitimate, if they have alt tags, if your internal links are working,