html-proofer 5.0.2 → 5.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ee4cb46fd2691b7c8ed80a1e11069fa8d9f4b0058e69ce00bd15da9fcf3b3b4
-  data.tar.gz: cfc205c660310bde3b5329079ee1de8aa4eb3083b95c691386ccc491ddca628c
+  metadata.gz: faaebfa9ea13bfed7e8e4814ca266066f29b04d8bde57675db9e84d560a68064
+  data.tar.gz: e0db29fac2c3bb8f974986bb34f2a6b32b529e4921b84f513d17bcc1d9a8ede8
 SHA512:
-  metadata.gz: 567f404dec415cd1c21f04f6fe951cc217a3d918f8434ca1b6ec2b63d58efad89513408808626d82f7fc56f898c55a80d10560e8e36b1185c044e0b067833f4a
-  data.tar.gz: 21103cf7d04e277d886226a8e89f1720b346b353e6b8c838247a70d4360c6e1c596ea99bddb243e7dd3026febad085c5b7f163ee0a7617c127d8ad5d7237a325
+  metadata.gz: ff8490d4416a9336818563c08311b1a0f227225969d00dd99f33e3db99b7c06d184e1658fad45a41684f65bb2c7e669aa13c6de616b2e3189d84c43e95402061
+  data.tar.gz: 2edb3c5fdbd02a279e934f9ed238b5fc50e7ceabd4858492d3e0f052209716f012fa6f8efa43576a803d68b709e65b4bb53c9d0cba3ff4ce19702a97a7fa1e0c

data/lib/html_proofer/attribute/url.rb

@@ -141,12 +141,16 @@ module HTMLProofer
           # either overwrite with root_dir; or, if source is directory, use that; or, just get the current file's dirname
           @runner.options[:root_dir] || (File.directory?(@runner.current_source) ? @runner.current_source : File.dirname(@runner.current_source))
         # relative links, path is a file
-        elsif File.exist?(File.expand_path(path,
-          @runner.current_source)) || File.exist?(File.expand_path(path_dot_ext, @runner.current_source))
+        elsif File.exist?(File.expand_path(
+          path,
+          @runner.current_source,
+        )) || File.exist?(File.expand_path(path_dot_ext, @runner.current_source))
           File.dirname(@runner.current_filename)
         # relative links in nested dir, path is a file
-        elsif File.exist?(File.join(File.dirname(@runner.current_filename),
-          path)) || File.exist?(File.join(File.dirname(@runner.current_filename), path_dot_ext))
+        elsif File.exist?(File.join(
+          File.dirname(@runner.current_filename),
+          path,
+        )) || File.exist?(File.join(File.dirname(@runner.current_filename), path_dot_ext))
           File.dirname(@runner.current_filename)
         # relative link, path is a directory
         else

data/lib/html_proofer/check/favicon.rb

@@ -17,13 +17,19 @@ module HTMLProofer
 
         if found
           if @favicon.url.protocol_relative?
-            add_failure("favicon link #{@favicon.url} is a protocol-relative URL, use explicit https:// instead",
-              line: @favicon.line, content: @favicon.content)
+            add_failure(
+              "favicon link #{@favicon.url} is a protocol-relative URL, use explicit https:// instead",
+              line: @favicon.line,
+              content: @favicon.content,
+            )
           elsif @favicon.url.remote?
             add_to_external_urls(@favicon.url, @favicon.line)
           elsif !@favicon.url.exists?
-            add_failure("internal favicon #{@favicon.url.raw_attribute} does not exist", line: @favicon.line,
-              content: @favicon.content)
+            add_failure(
+              "internal favicon #{@favicon.url.raw_attribute} does not exist",
+              line: @favicon.line,
+              content: @favicon.content,
+            )
           end
         else
           add_failure("no favicon provided")

data/lib/html_proofer/check/images.rb

@@ -12,27 +12,39 @@ module HTMLProofer
           next if @img.ignore?
 
           # screenshot filenames should return because of terrible names
-          add_failure("image has a terrible filename (#{@img.url.raw_attribute})", line: @img.line,
-            content: @img.content) if terrible_filename?
+          add_failure(
+            "image has a terrible filename (#{@img.url.raw_attribute})",
+            line: @img.line,
+            content: @img.content,
+          ) if terrible_filename?
 
           # does the image exist?
           if missing_src?
             add_failure("image has no src or srcset attribute", line: @img.line, content: @img.content)
           elsif @img.url.protocol_relative?
-            add_failure("image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
-              line: @img.line, content: @img.content)
+            add_failure(
+              "image link #{@img.url} is a protocol-relative URL, use explicit https:// instead",
+              line: @img.line,
+              content: @img.content,
+            )
           elsif @img.url.remote?
             add_to_external_urls(@img.url, @img.line)
           elsif !@img.url.exists? && !@img.multiple_srcsets? && !@img.multiple_sizes?
-            add_failure("internal image #{@img.url.raw_attribute} does not exist", line: @img.line,
-              content: @img.content)
+            add_failure(
+              "internal image #{@img.url.raw_attribute} does not exist",
+              line: @img.line,
+              content: @img.content,
+            )
           elsif @img.multiple_srcsets? || @img.multiple_sizes?
             @img.srcsets_wo_sizes.each do |srcset|
               srcset_url = HTMLProofer::Attribute::Url.new(@runner, srcset, base_url: @img.base_url, extract_size: true)
 
               if srcset_url.protocol_relative?
-                add_failure("image link #{srcset_url.url} is a protocol-relative URL, use explicit https:// instead",
-                  line: @img.line, content: @img.content)
+                add_failure(
+                  "image link #{srcset_url.url} is a protocol-relative URL, use explicit https:// instead",
+                  line: @img.line,
+                  content: @img.content,
+                )
               elsif srcset_url.remote?
                 add_to_external_urls(srcset_url.url, @img.line)
               elsif !srcset_url.exists?
@@ -44,16 +56,25 @@ module HTMLProofer
           # if this is an img element, check that the alt attribute is present
           if @img.img_tag? && !ignore_element?
             if missing_alt_tag? && !ignore_missing_alt?
-              add_failure("image #{@img.url.raw_attribute} does not have an alt attribute", line: @img.line,
-                content: @img.content)
+              add_failure(
+                "image #{@img.url.raw_attribute} does not have an alt attribute",
+                line: @img.line,
+                content: @img.content,
+              )
             elsif (empty_alt_tag? || alt_all_spaces?) && !ignore_empty_alt?
-              add_failure("image #{@img.url.raw_attribute} has an alt attribute, but no content", line: @img.line,
-                content: @img.content)
+              add_failure(
+                "image #{@img.url.raw_attribute} has an alt attribute, but no content",
+                line: @img.line,
+                content: @img.content,
+              )
             end
           end
 
-          add_failure("image #{@img.url.raw_attribute} uses the http scheme", line: @img.line,
-            content: @img.content) if @runner.enforce_https? && @img.url.http?
+          add_failure(
+            "image #{@img.url.raw_attribute} uses the http scheme",
+            line: @img.line,
+            content: @img.content,
+          ) if @runner.enforce_https? && @img.url.http?
         end
 
         external_urls

data/lib/html_proofer/check/links.rb

@@ -29,8 +29,11 @@ module HTMLProofer
           end
 
           if @link.url.protocol_relative?
-            add_failure("#{@link.url} is a protocol-relative URL, use explicit https:// instead",
-              line: @link.line, content: @link.content)
+            add_failure(
+              "#{@link.url} is a protocol-relative URL, use explicit https:// instead",
+              line: @link.line,
+              content: @link.content,
+            )
             next
           end
 
@@ -55,8 +58,11 @@ module HTMLProofer
           elsif @link.url.internal?
             # does the local directory have a trailing slash?
             if @link.url.unslashed_directory?(@link.url.absolute_path)
-              add_failure("internally linking to a directory #{@link.url.raw_attribute} without trailing slash",
-                line: @link.line, content: @link.content)
+              add_failure(
+                "internally linking to a directory #{@link.url.raw_attribute} without trailing slash",
+                line: @link.line,
+                content: @link.content,
+              )
               next
             end
 
@@ -88,17 +94,26 @@ module HTMLProofer
 
       def handle_mailto
         if @link.url.path.empty?
-          add_failure("#{@link.url.raw_attribute} contains no email address", line: @link.line,
-            content: @link.content) unless ignore_empty_mailto?
+          add_failure(
+            "#{@link.url.raw_attribute} contains no email address",
+            line: @link.line,
+            content: @link.content,
+          ) unless ignore_empty_mailto?
         elsif !/#{URI::MailTo::EMAIL_REGEXP}/o.match?(@link.url.path)
-          add_failure("#{@link.url.raw_attribute} contains an invalid email address", line: @link.line,
-            content: @link.content)
+          add_failure(
+            "#{@link.url.raw_attribute} contains an invalid email address",
+            line: @link.line,
+            content: @link.content,
+          )
         end
       end
 
       def handle_tel
-        add_failure("#{@link.url.raw_attribute} contains no phone number", line: @link.line,
-          content: @link.content) if @link.url.path.empty?
+        add_failure(
+          "#{@link.url.raw_attribute} contains no phone number",
+          line: @link.line,
+          content: @link.content,
+        ) if @link.url.path.empty?
       end
 
       def ignore_empty_mailto?
@@ -113,13 +128,19 @@ module HTMLProofer
         return unless SRI_REL_TYPES.include?(@link.node["rel"])
 
         if blank?(@link.node["integrity"]) && blank?(@link.node["crossorigin"])
-          add_failure("SRI and CORS not provided in: #{@link.url.raw_attribute}", line: @link.line,
-            content: @link.content)
+          add_failure(
+            "SRI and CORS not provided in: #{@link.url.raw_attribute}",
+            line: @link.line,
+            content: @link.content,
+          )
         elsif blank?(@link.node["integrity"])
           add_failure("Integrity is missing in: #{@link.url.raw_attribute}", line: @link.line, content: @link.content)
         elsif blank?(@link.node["crossorigin"])
-          add_failure("CORS not provided for external resource in: #{@link.link.url.raw_attribute}", line: @link.line,
-            content: @link.content)
+          add_failure(
+            "CORS not provided for external resource in: #{@link.link.url.raw_attribute}",
+            line: @link.line,
+            content: @link.content,
+          )
         end
       end
 

data/lib/html_proofer/check/open_graph.rb

@@ -17,13 +17,19 @@ module HTMLProofer
           elsif !@open_graph.url.valid?
             add_failure("#{@open_graph.src} is an invalid URL", line: @open_graph.line)
           elsif @open_graph.url.protocol_relative?
-            add_failure("open graph link #{@open_graph.url} is a protocol-relative URL, use explicit https:// instead",
-              line: @open_graph.line, content: @open_graph.content)
+            add_failure(
+              "open graph link #{@open_graph.url} is a protocol-relative URL, use explicit https:// instead",
+              line: @open_graph.line,
+              content: @open_graph.content,
+            )
           elsif @open_graph.url.remote?
             add_to_external_urls(@open_graph.url, @open_graph.line)
           else
-            add_failure("internal open graph #{@open_graph.url.raw_attribute} does not exist", line: @open_graph.line,
-              content: @open_graph.content) unless @open_graph.url.exists?
+            add_failure(
+              "internal open graph #{@open_graph.url.raw_attribute} does not exist",
+              line: @open_graph.line,
+              content: @open_graph.content,
+            ) unless @open_graph.url.exists?
           end
         end
 

data/lib/html_proofer/check/scripts.rb

@@ -14,14 +14,20 @@ module HTMLProofer
           if missing_src?
             add_failure("script is empty and has no src attribute", line: @script.line, content: @script.content)
           elsif @script.url.protocol_relative?
-            add_failure("script link #{@script.url} is a protocol-relative URL, use explicit https:// instead",
-              line: @script.line, content: @script.content)
+            add_failure(
+              "script link #{@script.url} is a protocol-relative URL, use explicit https:// instead",
+              line: @script.line,
+              content: @script.content,
+            )
           elsif @script.url.remote?
             add_to_external_urls(@script.url, @script.line)
             check_sri if @runner.check_sri?
           elsif !@script.url.exists?
-            add_failure("internal script reference #{@script.src} does not exist", line: @script.line,
-              content: @script.content)
+            add_failure(
+              "internal script reference #{@script.src} does not exist",
+              line: @script.line,
+              content: @script.content,
+            )
           end
         end
 
@@ -34,14 +40,23 @@ module HTMLProofer
 
       def check_sri
         if blank?(@script.node["integrity"]) && blank?(@script.node["crossorigin"])
-          add_failure("SRI and CORS not provided in: #{@script.url.raw_attribute}", line: @script.line,
-            content: @script.content)
+          add_failure(
+            "SRI and CORS not provided in: #{@script.url.raw_attribute}",
+            line: @script.line,
+            content: @script.content,
+          )
         elsif blank?(@script.node["integrity"])
-          add_failure("Integrity is missing in: #{@script.url.raw_attribute}", line: @script.line,
-            content: @script.content)
+          add_failure(
+            "Integrity is missing in: #{@script.url.raw_attribute}",
+            line: @script.line,
+            content: @script.content,
+          )
         elsif blank?(@script.node["crossorigin"])
-          add_failure("CORS not provided for external resource in: #{@script.url.raw_attribute}", line: @script.line,
-            content: @script.content)
+          add_failure(
+            "CORS not provided for external resource in: #{@script.url.raw_attribute}",
+            line: @script.line,
+            content: @script.content,
+          )
         end
       end
     end

data/lib/html_proofer/check.rb

@@ -25,8 +25,14 @@ module HTMLProofer
     end
 
     def add_failure(description, line: nil, status: nil, content: nil)
-      @failures << Failure.new(@runner.current_filename, short_name, description, line: line, status: status,
-        content: content)
+      @failures << Failure.new(
+        @runner.current_filename,
+        short_name,
+        description,
+        line: line,
+        status: status,
+        content: content,
+      )
     end
 
     def short_name

data/lib/html_proofer/configuration.rb

@@ -280,17 +280,25 @@ module HTMLProofer
     module ConfigurationHelp
       TEXT = {
         as_links: ["Assumes that `PATH` is a comma-separated array of links to check."],
-        assume_extension: ["Automatically add specified extension to files for internal links, ",
-                           "to allow extensionless URLs (as supported by most servers) (default: `.html`).",],
+        assume_extension: [
+          "Automatically add specified extension to files for internal links, ",
+          "to allow extensionless URLs (as supported by most servers) (default: `.html`).",
+        ],
         directory_index_file: ["Sets the file to look for when a link refers to a directory. (default: `index.html`)."],
-        extensions: ["A comma-separated list of Strings indicating the file extensions you",
-                     "would like to check (default: `.html`)",],
+        extensions: [
+          "A comma-separated list of Strings indicating the file extensions you",
+          "would like to check (default: `.html`)",
+        ],
 
         allow_hash_href: ['"If `true`, assumes `href="#"` anchors are valid (default: `true`)"'],
-        allow_missing_href: ["If `true`, does not flag `a` tags missing `href`. In HTML5, this is technically ",
-                             "allowed, but could also be human error. (default: `false`)",],
-        checks: ["A comma-separated list of Strings indicating which checks you",
-                 "want to run (default: `[\"Links\", \"Images\", \"Scripts\"]",],
+        allow_missing_href: [
+          "If `true`, does not flag `a` tags missing `href`. In HTML5, this is technically ",
+          "allowed, but could also be human error. (default: `false`)",
+        ],
+        checks: [
+          "A comma-separated list of Strings indicating which checks you",
+          "want to run (default: `[\"Links\", \"Images\", \"Scripts\"]",
+        ],
         check_external_hash: ["Checks whether external hashes exist (even if the webpage exists) (default: `true`)."],
         check_internal_hash: ["Checks whether internal hashes exist (even if the webpage exists) (default: `true`)."],
         check_sri: ["Check that `<link>` and `<script>` external resources use SRI (default: `false`)."],
@@ -298,31 +306,43 @@ module HTMLProofer
         enforce_https: ["Fails a link if it's not marked as `https` (default: `true`)."],
         root_dir: ["The absolute path to the directory serving your html-files."],
 
-        ignore_empty_alt: ["If `true`, ignores images with empty/missing ",
-                           "alt tags (in other words, `<img alt>` and `<img alt=\"\">`",
-                           "are valid; set this to `false` to flag those) (default: `true`).",],
-        ignore_empty_mailto: ["If `true`, allows `mailto:` `href`s which don't",
-                              "contain an email address (default: `false`)'.",],
+        ignore_empty_alt: [
+          "If `true`, ignores images with empty/missing ",
+          "alt tags (in other words, `<img alt>` and `<img alt=\"\">`",
+          "are valid; set this to `false` to flag those) (default: `true`).",
+        ],
+        ignore_empty_mailto: [
+          "If `true`, allows `mailto:` `href`s which don't",
+          "contain an email address (default: `false`)'.",
+        ],
         ignore_missing_alt: ["If `true`, ignores images with missing alt tags (default: `false`)."],
         ignore_status_codes: ["A comma-separated list of numbers representing status codes to ignore."],
         ignore_files: ["A comma-separated list of Strings or RegExps containing file paths that are safe to ignore"],
-        ignore_urls: ["A comma-separated list of Strings or RegExps containing URLs that are",
-                      "safe to ignore. This affects all HTML attributes, such as `alt` tags on images.",],
+        ignore_urls: [
+          "A comma-separated list of Strings or RegExps containing URLs that are",
+          "safe to ignore. This affects all HTML attributes, such as `alt` tags on images.",
+        ],
         only_status_codes: ["A comma-separated list of numbers representing the only status codes to report on."],
         only_4xx: ["Only reports errors for links that fall within the 4xx status code range."],
 
-        swap_attributes: ["JSON-formatted config that maps element names to the",
-                          "preferred attribute to check (default: `{}`).",],
-        swap_urls: ["A comma-separated list containing key-value pairs of `RegExp => String`.",
-                    "It transforms URLs that match `RegExp` into `String` via `gsub`.",
-                    "The escape sequences `\\:` should be used to produce literal `:`s.",],
+        swap_attributes: [
+          "JSON-formatted config that maps element names to the",
+          "preferred attribute to check (default: `{}`).",
+        ],
+        swap_urls: [
+          "A comma-separated list containing key-value pairs of `RegExp => String`.",
+          "It transforms URLs that match `RegExp` into `String` via `gsub`.",
+          "The escape sequences `\\:` should be used to produce literal `:`s.",
+        ],
 
         typhoeus: ["JSON-formatted string of Typhoeus config; if set, overrides the html-proofer defaults."],
         hydra: ["JSON-formatted string of Hydra config; if set, overrides the html-proofer defaults."],
         cache: ["JSON-formatted string of cache config; if set, overrides the html-proofer defaults."],
 
-        log_level: ["Sets the logging level. One of `:debug`, `:info`, ",
-                    "`:warn`, `:error`, or `:fatal`. (default: `:info`)",],
+        log_level: [
+          "Sets the logging level. One of `:debug`, `:info`, ",
+          "`:warn`, `:error`, or `:fatal`. (default: `:info`)",
+        ],
 
         version: ["Prints the version of html-proofer."],
       }.freeze

data/lib/html_proofer/element.rb

@@ -82,10 +82,25 @@ module HTMLProofer
       !blank?(srcset) && srcset.split(",").size > 1
     end
 
+    # From https://github.com/sindresorhus/srcset/blob/f7c48acd7facf18e94dec47e6b96e84e0f0e69dc/index.js#LL1-L16C71
+    # This regex represents a loose rule of an “image candidate string”; see https://html.spec.whatwg.org/multipage/images.html#srcset-attribute
+    # An “image candidate string” roughly consists of the following:
+    # 1. Zero or more whitespace characters.
+    # 2. A non-empty URL that does not start or end with `,`.
+    # 3. Zero or more whitespace characters.
+    # 4. An optional “descriptor” that starts with a whitespace character.
+    # 5. Zero or more whitespace characters.
+    # 6. Each image candidate string is separated by a `,`.
+    # We intentionally implement a loose rule here so that we can perform more aggressive error handling and reporting in the below code.
+
+    IMAGE_CANDIDATE_REGEX = /\s*([^,]\S*[^,](?:\s+[^,]+)?)\s*(?:,|$)/
+
     def srcsets
       return nil if blank?(srcset)
 
-      srcset.split(",").map(&:strip)
+      srcset.split(IMAGE_CANDIDATE_REGEX).select.with_index do |_part, idx|
+        idx.odd?
+      end.map(&:strip)
     end
 
     def multiple_sizes?

data/lib/html_proofer/log.rb

@@ -11,9 +11,11 @@ module HTMLProofer
     STDERR_LEVELS = [:error, :fatal].freeze
 
     def initialize(log_level)
-      @logger = Yell.new(format: false, \
+      @logger = Yell.new(
+        format: false, \
         name: "HTMLProofer", \
-        level: "gte.#{log_level}") do |l|
+        level: "gte.#{log_level}",
+      ) do |l|
         l.adapter(:stdout, level: "lte.warn")
         l.adapter(:stderr, level: "gte.error")
       end

data/lib/html_proofer/runner.rb

@@ -42,8 +42,10 @@ module HTMLProofer
         @logger.log(:info, "Running #{check_text} (#{format_checks_list(checks)}) on #{@source} ...\n\n")
         check_list_of_links unless @options[:disable_external]
       else
-        @logger.log(:info,
-          "Running #{check_text} (#{format_checks_list(checks)}) in #{@source} on *#{@options[:extensions].join(", ")} files ...\n\n")
+        @logger.log(
+          :info,
+          "Running #{check_text} (#{format_checks_list(checks)}) in #{@source} on *#{@options[:extensions].join(", ")} files ...\n\n",
+        )
 
         check_files
         @logger.log(:info, "Ran on #{pluralize(files.length, "file", "files")}!\n\n")

data/lib/html_proofer/url_validator/external.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 require "typhoeus"
-require "uri"
+require "open-uri"
+# require "uri"
+require "pdf-reader"
 
 module HTMLProofer
   class UrlValidator
@@ -88,8 +90,12 @@ module HTMLProofer
         return if @runner.options[:ignore_status_codes].include?(response_code)
 
         if response_code.between?(200, 299)
-          @cache.add_external(href, filenames, response_code, "OK", true) unless check_hash_in_2xx_response(href, url,
-            response, filenames)
+          @cache.add_external(href, filenames, response_code, "OK", true) unless check_hash_in_2xx_response(
+            href,
+            url,
+            response,
+            filenames,
+          )
         elsif response.timed_out?
           handle_timeout(href, filenames, response_code)
         elsif response_code.zero?
@@ -115,6 +121,28 @@ module HTMLProofer
         return false unless url.hash?
 
         hash = url.hash
+        headers = response.options.fetch(:headers, {})
+        content_type = headers.find { |k, _| k.casecmp("content-type").zero? }
+
+        # attempt to verify PDF hash ref; see #787 for more details
+        # FIXME: this is re-reading the PDF response
+        if content_type && /pdf/.match?(content_type[1])
+          io = URI.parse(url.to_s).open
+          reader = PDF::Reader.new(io)
+
+          pages = reader.pages
+          if hash =~ /\Apage=(\d+)\z/
+            page = Regexp.last_match[1].to_i
+
+            unless pages[page - 1]
+              msg = "External link #{href} failed: #{url.sans_hash} exists, but the hash '#{hash}' does not"
+              add_failure(filenames, msg, response.code)
+              @cache.add_external(href, filenames, response.code, msg, false)
+            end
+
+            return true
+          end
+        end
 
         body_doc = create_nokogiri(response.body)
 

data/lib/html_proofer/url_validator/internal.rb

@@ -36,8 +36,14 @@ module HTMLProofer
 
             target_file_path = url.absolute_path
             unless file_exists?(target_file_path)
-              @failed_checks << Failure.new(@runner.current_filename, "Links > Internal",
-                "internally linking to #{url}, which does not exist", line: metadata[:line], status: nil, content: nil)
+              @failed_checks << Failure.new(
+                @runner.current_filename,
+                "Links > Internal",
+                "internally linking to #{url}, which does not exist",
+                line: metadata[:line],
+                status: nil,
+                content: nil,
+              )
               to_add << [url, metadata, false]
               next
             end
@@ -55,8 +61,14 @@ module HTMLProofer
               next
             end
             unless hash_exists
-              @failed_checks << Failure.new(@runner.current_filename, "Links > Internal",
-                "internally linking to #{url}; the file exists, but the hash '#{url.hash}' does not", line: metadata[:line], status: nil, content: nil)
+              @failed_checks << Failure.new(
+                @runner.current_filename,
+                "Links > Internal",
+                "internally linking to #{url}; the file exists, but the hash '#{url.hash}' does not",
+                line: metadata[:line],
+                status: nil,
+                content: nil,
+              )
               to_add << [url, metadata, false]
               next
             end
@@ -75,8 +87,14 @@ module HTMLProofer
             exists = hash_exists_in_html?(href_hash, html)
             url_metadata.each do |(url, metadata)|
               unless exists
-                @failed_checks << Failure.new(metadata[:filename], "Links > Internal",
-                  "internally linking to #{url}; the file exists, but the hash '#{href_hash}' does not", line: metadata[:line], status: nil, content: nil)
+                @failed_checks << Failure.new(
+                  metadata[:filename],
+                  "Links > Internal",
+                  "internally linking to #{url}; the file exists, but the hash '#{href_hash}' does not",
+                  line: metadata[:line],
+                  status: nil,
+                  content: nil,
+                )
               end
               to_add << [url, metadata, exists]
             end

data/lib/html_proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = "5.0.2"
+  VERSION = "5.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 5.0.4
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-15 00:00:00.000000000 Z
+date: 2023-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: pdf-reader
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.11'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.11'
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -306,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image