html-proofer 3.9.2 → 3.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bb78c07ea46c99e7e763ee0a6e283ce82c5623eb
-  data.tar.gz: b978e20e49c1da740faf32af61ee45364f343e90
+SHA256:
+  metadata.gz: 246e851f166c3330542ef13670c9b86ea6acef06b142de26692ae16ec421dd15
+  data.tar.gz: 6e63ce9f51b36817a9420ef07dd7a40c5668227f94ffc01df4cf3d8ac21fdb1e
 SHA512:
-  metadata.gz: 57c2748da2642f8dcb604d86f112cdb5119b1553ec491bcf5f996853f5d27a6ddcdd12bf6744c092225d8e7910548f3531e70b5464529dc6efd4146ec9d56d90
-  data.tar.gz: a7929074fa4fe9172df82a51c7430b12da95461a75c6c323883bc1166b768e81fec6c6f18a3db5730a5f39c941c5d43e390e37630bacae33a7c4d6274703bec0
+  metadata.gz: 19a3a97c74d2c9fddbbb4b12cbc38e9ab08309232c876ccaab922643de9535f0ebf9d56a90a3ce0c4821cd070d5b629ef4368629e2e5b2c6a02c36acb5019e3a
+  data.tar.gz: e2201edf4fee55ed6b80b00e7bbdb5eb272a8fc5748d1bcd41148e3afa7757e24487c5698e12083288aeefc2a5e7db317d8fd29b5340d5678d9c14fe2b327381

data/bin/htmlproofer

@@ -15,7 +15,7 @@ Mercenary.program(:htmlproofer) do |p|
 
   p.option 'allow_missing_href', '--allow-missing-href', 'If `true`, does not flag `a` tags missing `href` (this is the default for HTML5).'
   p.option 'allow_hash_href', '--allow-hash-href', 'If `true`, ignores the `href="#"`'
-  p.option 'as_links', '--as-links', 'Assumes that `PATH` is a comma-separated array of links to check.'
+  p.option 'as_links', '--as-links link1,[link2,...]', Array, 'Assumes that `PATH` is a comma-separated array of links to check.'
   p.option 'alt_ignore', '--alt-ignore image1,[image2,...]', Array, 'A comma-separated list of Strings or RegExps containing `img`s whose missing `alt` tags are safe to ignore'
   p.option 'assume_extension', '--assume-extension', 'Automatically add extension (e.g. `.html`) to file paths, to allow extensionless URLs (as supported by Jekyll 3 and GitHub Pages) (default: `false`).'
   p.option 'checks_to_ignore', '--checks-to-ignore check1,[check2,...]', Array, ' An array of Strings indicating which checks you\'d like to not perform.'
@@ -25,12 +25,12 @@ Mercenary.program(:htmlproofer) do |p|
   p.option 'check_img_http', '--check-img-http', 'Fails an image if it\'s marked as `http` (default: `false`).'
   p.option 'check_opengraph', '--check-opengraph', 'Enables the Open Graph checker (default: `false`).'
   p.option 'check_sri', '--check-sri', 'Check that `<link>` and `<script>` external resources do use SRI (default: `false`).'
-  p.option 'directory_index_file', '--directory-index-file', String, 'Sets the file to look for when a link refers to a directory. (default: `index.html`)'
+  p.option 'directory_index_file', '--directory-index-file <filename>', String, 'Sets the file to look for when a link refers to a directory. (default: `index.html`)'
   p.option 'disable_external', '--disable-external', 'If `true`, does not run the external link checker, which can take a lot of time (default: `false`)'
   p.option 'empty_alt_ignore', '--empty-alt-ignore', 'If `true`, ignores images with empty alt tags'
-  p.option 'error_sort', '--error-sort SORT', 'Defines the sort order for error output. Can be `:path`, `:desc`, or `:status` (default: `:path`).'
+  p.option 'error_sort', '--error-sort <sort>', String, 'Defines the sort order for error output. Can be `:path`, `:desc`, or `:status` (default: `:path`).'
   p.option 'enforce_https', '--enforce-https', 'Fails a link if it\'s not marked as `https` (default: `false`).'
-  p.option 'extension', '--extension EXT', String, 'The extension of your HTML files including the dot. (default: `.html`)'
+  p.option 'extension', '--extension <ext>', String, 'The extension of your HTML files including the dot. (default: `.html`)'
   p.option 'external_only', '--external_only', 'Only checks problems with external references'
   p.option 'file_ignore', '--file-ignore file1,[file2,...]', Array, 'A comma-separated list of Strings or RegExps containing file paths that are safe to ignore'
   p.option 'http_status_ignore', '--http-status-ignore 123,[xxx, ...]', Array, 'A comma-separated list of numbers representing status codes to ignore.'

data/lib/html-proofer.rb

@@ -19,6 +19,7 @@ rescue LoadError; end
 module HTMLProofer
   def check_file(file, options = {})
     raise ArgumentError unless file.is_a?(String)
+    raise ArgumentError, "#{file} does not exist" unless File.exist?(file)
     options[:type] = :file
     HTMLProofer::Runner.new(file, options)
   end
@@ -26,6 +27,7 @@ module HTMLProofer
 
   def check_directory(directory, options = {})
     raise ArgumentError unless directory.is_a?(String)
+    raise ArgumentError, "#{directory} does not exist" unless Dir.exist?(directory)
     options[:type] = :directory
     HTMLProofer::Runner.new([directory], options)
   end
@@ -34,6 +36,9 @@ module HTMLProofer
   def check_directories(directories, options = {})
     raise ArgumentError unless directories.is_a?(Array)
     options[:type] = :directory
+    directories.each do |directory|
+      raise ArgumentError, "#{directory} does not exist" unless Dir.exist?(directory)
+    end
     HTMLProofer::Runner.new(directories, options)
   end
   module_function :check_directories

data/lib/html-proofer/check/links.rb

@@ -110,6 +110,7 @@ class LinkCheck < ::HTMLProofer::Check
   def hash_check(html, href_hash)
     decoded_href_hash = Addressable::URI.unescape(href_hash)
     fragment_ids = [href_hash, decoded_href_hash]
+    # https://www.w3.org/TR/html5/single-page.html#scroll-to-fragid
     fragment_ids.include?('top') || !find_fragments(html, fragment_ids).empty?
   end
 
@@ -117,8 +118,8 @@ class LinkCheck < ::HTMLProofer::Check
     xpaths = fragment_ids.flat_map do |frag_id|
       escaped_frag_id = "'#{frag_id.split("'").join("', \"'\", '")}', ''"
       [
-        "//*[case_insensitive_equals(@id, concat(#{escaped_frag_id}))]",
-        "//*[case_insensitive_equals(@name, concat(#{escaped_frag_id}))]"
+        "//*[case_sensitive_equals(@id, concat(#{escaped_frag_id}))]",
+        "//*[case_sensitive_equals(@name, concat(#{escaped_frag_id}))]"
       ]
     end
     xpaths << XpathFunctions.new
@@ -140,8 +141,8 @@ class LinkCheck < ::HTMLProofer::Check
   end
 
   class XpathFunctions
-    def case_insensitive_equals(node_set, str_to_match)
-      node_set.find_all { |node| node.to_s.casecmp(str_to_match.to_s.downcase).zero? }
+    def case_sensitive_equals(node_set, str_to_match)
+      node_set.find_all { |node| node.to_s. == str_to_match.to_s }
     end
   end
 end

data/lib/html-proofer/url_validator.rb

@@ -178,8 +178,9 @@ module HTMLProofer
 
       body_doc = create_nokogiri(response.body)
 
+      unencoded_hash = Addressable::URI.unescape(hash)
+      xpath = %(//*[@name="#{hash}"]|/*[@name="#{unencoded_hash}"]|//*[@id="#{hash}"]|//*[@id="#{unencoded_hash}"])
       # user-content is a special addition by GitHub.
-      xpath = %(//*[@name="#{hash}"]|//*[@id="#{hash}"])
       if URI.parse(href).host =~ /github\.com/i
         xpath << %(|//*[@name="user-content-#{hash}"]|//*[@id="user-content-#{hash}"])
       end

data/lib/html-proofer/version.rb

@@ -1,3 +1,3 @@
 module HTMLProofer
-  VERSION = '3.9.2'.freeze
+  VERSION = '3.9.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.9.2
+  version: 3.9.3
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mercenary
@@ -314,7 +314,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image