html-proofer 3.7.2 → 3.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: deb1da1ed4ae6e0e0641fae514b0cbd2da643487
-  data.tar.gz: 24d179721b6ceb6e913a39228edc4e751c225d2b
+  metadata.gz: 301f92856184797608bb768aad054c717bb349ff
+  data.tar.gz: f4e2a2c8c4e8267dc2f287bd411e53f95d9454ba
 SHA512:
-  metadata.gz: 28017e3ec9e9a91ed0aa56821a6ecfc940fa1ee36dc3323a06f559b2b38c65b9670e4484b4decdc8f7bcf0c38c6574524f40a17a3290a923565c21d93c4a65b5
-  data.tar.gz: f505b3e0e951f6b407f9f77567e89f78533885a3d2ce0defd839c02690e24b1b26cea2a5424753675d8439c3e5144aed477d508d9b075f53c546fd5f91e3119b
+  metadata.gz: 4a11c32e6aba302074bef75174ac36921273c6e69173fe66a419035b2fc37610b8a8351dfabfc0e7830a3081b1e004529c5cffaefb9e8cde5d574b74f8481ef6
+  data.tar.gz: 4cc636be64d8a4646c6305cfd9885a4d0d249bf062bbd739efa9af6fe230c4d57a994c071e9f17120416957bebc3453d7d566ddec001305e5d457ff535546402

data/lib/html-proofer/check/favicon.rb

@@ -10,6 +10,16 @@ class FaviconCheck < ::HTMLProofer::Check
 
     return if found
 
+    return if is_immediate_redirect?
+
     add_issue('no favicon specified')
   end
+
+  private
+
+  def is_immediate_redirect?
+    # allow any instant-redirect meta tag
+    @html.xpath("//meta[@http-equiv='refresh']").attribute('content').value.starts_with? '0;' rescue false
+  end
+
 end

data/lib/html-proofer/check/images.rb

@@ -2,7 +2,7 @@ class ImageCheck < ::HTMLProofer::Check
   SCREEN_SHOT_REGEX = /Screen(?: |%20)Shot(?: |%20)\d+-\d+-\d+(?: |%20)at(?: |%20)\d+.\d+.\d+/
 
   def empty_alt_tag?
-    @img.alt.strip.empty?
+    @img.alt.nil? || @img.alt.strip.empty?
   end
 
   def terrible_filename?
@@ -36,7 +36,7 @@ class ImageCheck < ::HTMLProofer::Check
         add_issue("internal image #{@img.url} does not exist", line: line, content: content)
       end
 
-      if !@img.ignore_alt? && (@img.alt.nil? || (empty_alt_tag? && !@img.ignore_empty_alt?))
+      if empty_alt_tag? && !@img.ignore_empty_alt? && !@img.ignore_alt?
         add_issue("image #{@img.url} does not have an alt attribute", line: line, content: content)
       end
 

data/lib/html-proofer/check/links.rb

@@ -40,7 +40,7 @@ class LinkCheck < ::HTMLProofer::Check
       next if @link.non_http_remote?
 
       if !@link.internal? && @link.remote?
-        check_sri(line, content) if @link.check_sri?
+        check_sri(line, content) if @link.check_sri? && node.name == 'link'
         # we need to skip these for now; although the domain main be valid,
         # curl/Typheous inaccurately return 404s for some links. cc https://git.io/vyCFx
         next if @link.try(:rel) == 'dns-prefetch'

data/lib/html-proofer/configuration.rb

@@ -32,7 +32,8 @@ module HTMLProofer
     TYPHOEUS_DEFAULTS = {
       followlocation: true,
       headers: {
-        'User-Agent' => "Mozilla/5.0 (compatible; HTML Proofer/#{HTMLProofer::VERSION}; +https://github.com/gjtorikian/html-proofer)"
+        'User-Agent' => "Mozilla/5.0 (compatible; HTML Proofer/#{HTMLProofer::VERSION}; +https://github.com/gjtorikian/html-proofer)",
+        'Accept' => 'application/xml,application/xhtml+xml,text/html;q=0.9, text/plain;q=0.8,image/png,*/*;q=0.5'
       },
       connecttimeout: 10,
       timeout: 30

data/lib/html-proofer/log.rb

@@ -1,5 +1,5 @@
 require 'yell'
-require 'colored'
+require 'colorized_string'
 
 module HTMLProofer
   class Log
@@ -35,7 +35,7 @@ module HTMLProofer
 
     def colorize(color, message)
       if $stdout.isatty && $stderr.isatty
-        Colored.colorize(message, foreground: color)
+        ColorizedString.new(message).colorize(color)
       else
         message
       end

data/lib/html-proofer/url_validator.rb

@@ -36,7 +36,7 @@ module HTMLProofer
       return nil if @external_urls.nil?
       paths_with_queries = {}
       iterable_external_urls = @external_urls.dup
-      @external_urls.keys.each do |url|
+      @external_urls.each_key do |url|
         uri = begin
                 Addressable::URI.parse(url)
               rescue URI::Error, Addressable::URI::InvalidURIError

data/lib/html-proofer/version.rb

@@ -1,3 +1,3 @@
 module HTMLProofer
-  VERSION = '3.7.2'.freeze
+  VERSION = '3.7.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.7.2
+  version: 3.7.3
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-21 00:00:00.000000000 Z
+date: 2017-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mercenary
@@ -39,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
-  name: colored
+  name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -170,6 +170,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement