html-proofer 3.3.1 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1362c6dbcda2e6b32a8794d8059a2faed3d53220
-  data.tar.gz: 367c4016f9c5f916f296a1aa0db2ddf7b4504212
+  metadata.gz: dbcb9a266ebfc0ded83c471ce4c39b316707cdc8
+  data.tar.gz: 95eaa7fb30840606d11dc234eb9b6e5917971100
 SHA512:
-  metadata.gz: 40257c5bfc71ebcdb65215d1a4e1c18009453c8d16115b8555d262e985e57ff7801e6425c0af087247ab7efa7dbd65391476e3cf7375b570d4989da981085966
-  data.tar.gz: 0f673f255d4641a3e8c61943729b9fcd76c36e2b0f03201abbff81fdf961ceb9ead4ea618149e4d8e72db24c5bb991bc34cc3b7b04ffdfe0b7537607e65dc6fa
+  metadata.gz: 91e54490b69b026d0e2ddefbdc6a89858c6943b3193a2f80b389835f45d10708f5b9abb919c3eece6a6827b0630afc67f2d1d49b0c60c5a669fcdf6ecfdac444
+  data.tar.gz: a97d14e881323aa66e7a7c31bd1db5f007890d3715ba0950a9bf51f44117f076e982cc7c85a0b1e9433f5c4dfd5d5ecb12212b5d92108d4c21c7e4e3bbdc885e

data/lib/html-proofer/check/links.rb

@@ -39,7 +39,7 @@ class LinkCheck < ::HTMLProofer::Check
       # intentionally here because we still want valid? & missing_href? to execute
       next if @link.non_http_remote?
       # does the file even exist?
-      if @link.remote?
+      if !@link.internal? && @link.remote?
         add_to_external_urls(@link.href)
         next
       elsif !@link.internal? && !@link.exists?
@@ -84,10 +84,8 @@ class LinkCheck < ::HTMLProofer::Check
   end
 
   def handle_hash(link, line, content)
-    if link.internal?
-      unless hash_check @html, link.hash
-        add_issue("linking to internal hash ##{link.hash} that does not exist", line: line, content: content)
-      end
+    if link.internal? && !hash_check(link.html, link.hash)
+      add_issue("linking to internal hash ##{link.hash} that does not exist", line: line, content: content)
     elsif link.external?
       external_link_check(link, line, content)
     end

data/lib/html-proofer/element.rb

@@ -16,6 +16,8 @@ module HTMLProofer
         instance_variable_set("@#{name}", value.value)
       end
 
+      @aria_hidden = @aria_hidden == "true" ? true : false
+
       @text = obj.content
       @check = check
       @checked_paths = {}
@@ -86,7 +88,7 @@ module HTMLProofer
     end
 
     def ignore_alt?
-      return true if ignores_pattern_check(@check.options[:alt_ignore])
+      return true if ignores_pattern_check(@check.options[:alt_ignore]) || @aria_hidden
     end
 
     def ignore_empty_alt?
@@ -108,7 +110,19 @@ module HTMLProofer
 
     # path is an anchor or a query
     def internal?
-      url.start_with? '#', '?'
+      hash_link || param_link || slash_link
+    end
+
+    def hash_link
+      url.start_with?('#')
+    end
+
+    def param_link
+      url.start_with?('?')
+    end
+
+    def slash_link
+      url.start_with?('|')
     end
 
     def file_path
@@ -176,5 +190,17 @@ module HTMLProofer
     def base
       @base ||= @html.at_css('base')
     end
+
+    def html
+      if internal?
+        # If link is on the same page, then URL is on the current page so can use the same HTML as for current page
+        if hash_link || param_link
+          @html
+        elsif slash_link
+          # link on another page, e.g. /about#Team - need to get HTML from the other page
+          create_nokogiri(absolute_path)
+        end
+      end
+    end
   end
 end

data/lib/html-proofer/url_validator.rb

@@ -150,7 +150,7 @@ module HTMLProofer
       elsif response.timed_out?
         handle_timeout(href, filenames, response_code)
       elsif response_code == 0
-        handle_failure(href, filenames, response_code, response.return_message)
+        handle_failure(effective_url, filenames, response_code, response.return_message)
       elsif method == :head
         queue_request(:get, href, filenames)
       else

data/lib/html-proofer/version.rb

@@ -1,3 +1,3 @@
 module HTMLProofer
-  VERSION = '3.3.1'.freeze
+  VERSION = '3.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.4.0
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-20 00:00:00.000000000 Z
+date: 2016-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mercenary