html-proofer 3.18.5 → 3.18.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e90edda0dcb30f00baa440ec7b231bf73e086e0414fe9a1a56870940e2c15aeb
-  data.tar.gz: 2505df1fb597aaadfa68bf0f7c8b3d9380e27a236c31582d4c91840bf5e65623
+  metadata.gz: e2d6deb85601ff3f5e5df02999f1b55f29231e5658f1d4fa9986c002b3cc0263
+  data.tar.gz: e20a007144a866b41b97eb36a964ca1372d693ade77acc69a9c9e706b353c8ef
 SHA512:
-  metadata.gz: c5b864da4544723801ade7b906c387f893aed338ca36f9f3ae4a4660fa69f2f60883071cb2030cf526911abe954cf81932691a96c7c8f93e5e6970a18120449a
-  data.tar.gz: b141806119a645c1b974028f4e4ec3ecf60d74d51d1f5575d8b2fab4a3c7e90ddd8a6f8511474bd64825d49f591630ed8e9be83c1d5676b22b0f73b42ce93e3e
+  metadata.gz: c51154450eb20c04c0b7038effb12ab8d258457ea5560421b5a2a0739342504afebb8fd092fe4378838a076636ff2665eb691f513b8b34b49af2e89ffba988c2
+  data.tar.gz: fcb7bf492588fabc991caf1f779fca14a7b553d3ce00dbf55ba24aebf3c39f7613af6a408d94c3a3faaeb21dceb8265ece91ca9bf4320aee7d4f3dca133ba4de

data/lib/html-proofer/cache.rb

@@ -109,8 +109,13 @@ module HTMLProofer
       additions
     end
 
+    # TODO: Garbage performance--both the external and internal
+    # caches need access to this file. Write a proper versioned
+    # schema in the future
     def write
-      File.write(cache_file, @cache_log.to_json)
+      file = {}
+      file = JSON.parse(File.read(cache_file)) if File.exist?(cache_file)
+      File.write(cache_file, file.merge(@cache_log).to_json)
     end
 
     def load?

data/lib/html-proofer/check/links.rb

@@ -59,11 +59,8 @@ class LinkCheck < ::HTMLProofer::Check
         add_to_external_urls(@link.href || @link.src)
         next
       elsif @link.internal?
-        if @link.exists? || @link.hash
-          add_to_internal_urls(@link.href, InternalLink.new(@link, @path, line, content))
-        else
-          add_issue("internally linking to #{@link.href}, which does not exist", line: line, content: content)
-        end
+        add_to_internal_urls(@link.href, InternalLink.new(@link, @path, line, content))
+        add_issue("internally linking to #{@link.href}, which does not exist", line: line, content: content) if !@link.exists? && !@link.hash
       end
     end
 

data/lib/html-proofer/element.rb

@@ -24,7 +24,7 @@ module HTMLProofer
         raise e
       end
 
-      @aria_hidden = defined?(@aria_hidden) && @aria_hidden == 'true' ? true : false
+      @aria_hidden = defined?(@aria_hidden) && @aria_hidden == 'true'
 
       @data_proofer_ignore = defined?(@data_proofer_ignore)
 
@@ -220,6 +220,8 @@ module HTMLProofer
     end
 
     def ignores_pattern_check(links)
+      return false unless links.is_a?(Array)
+
       links.each do |ignore|
         case ignore
         when String

data/lib/html-proofer/middleware.rb

@@ -22,7 +22,7 @@ module HTMLProofer
         allow_hash_href: true,
         check_external_hash: true,
         check_html: true,
-        url_ignore: [/.*/], # Don't try to check if local files exist
+        url_ignore: [%r{^/}], # Don't try to check if local files exist
         validation: { report_eof_tags: true }
       }
     end

data/lib/html-proofer/runner.rb

@@ -63,7 +63,9 @@ module HTMLProofer
           swap(url, @options[:url_swap])
         end
       end
-      @external_urls = Hash[*@src.map { |s| [s, nil] }.flatten]
+      @external_urls = @src.each_with_object({}) do |url, hash|
+        hash[url] = nil
+      end
       validate_external_urls
     end
 
@@ -123,7 +125,7 @@ module HTMLProofer
           end
 
           external_urls = check.external_urls
-          external_urls = Hash[check.external_urls.map { |url, file| [swap(url, @options[:url_swap]), file] }] if @options[:url_swap]
+          external_urls = check.external_urls.map { |url, file| [swap(url, @options[:url_swap]), file] }.to_h if @options[:url_swap]
           result[:external_urls].merge!(external_urls)
           result[:failures].concat(check.issues)
         end

data/lib/html-proofer/url_validator.rb

@@ -85,7 +85,7 @@ module HTMLProofer
     # for HEAD. If we've decided to check for hashes, we must do a GET--HEAD is
     # not available as an option.
     def external_link_checker(external_urls)
-      external_urls = Hash[external_urls.sort]
+      external_urls = external_urls.sort.to_h
 
       count = external_urls.length
       check_text = pluralize(count, 'external link', 'external links')

data/lib/html-proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = '3.18.5'
+  VERSION = '3.18.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.18.5
+  version: 3.18.6
 platform: ruby
 authors:
 - Garen Torikian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-02 00:00:00.000000000 Z
+date: 2021-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable