html-proofer 3.18.0 → 3.18.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 010dde5e6758227f807cb7b17095b68df2d987ff4911c7c1e5f8876cff2f5bf2
-  data.tar.gz: 7925b79c6e1431c175aab35c1181ffa8127b1051427a5810411bacfe61c1ae27
+  metadata.gz: e90edda0dcb30f00baa440ec7b231bf73e086e0414fe9a1a56870940e2c15aeb
+  data.tar.gz: 2505df1fb597aaadfa68bf0f7c8b3d9380e27a236c31582d4c91840bf5e65623
 SHA512:
-  metadata.gz: 794d63f91e2fd22e5e5dba8a1b1032ec0c85b5fbe4e4db991f02cef6c205ac777f0dc9ea611378fe1702ee57c2fb917d4a1d95f02e10dda402df6d451d6cbd54
-  data.tar.gz: 3bf224c6ed71160031e95d3258401a314d8a480b069a5c6c9d555a163f288d1128eac3f76decd3033b2d32d98ed89f65b37bfeef696fd475a2d2b8749aa097da
+  metadata.gz: c5b864da4544723801ade7b906c387f893aed338ca36f9f3ae4a4660fa69f2f60883071cb2030cf526911abe954cf81932691a96c7c8f93e5e6970a18120449a
+  data.tar.gz: b141806119a645c1b974028f4e4ec3ecf60d74d51d1f5575d8b2fab4a3c7e90ddd8a6f8511474bd64825d49f591630ed8e9be83c1d5676b22b0f73b42ce93e3e

data/lib/html-proofer/check/links.rb

@@ -45,16 +45,21 @@ class LinkCheck < ::HTMLProofer::Check
       # intentionally here because we still want valid? & missing_href? to execute
       next if @link.non_http_remote?
 
-      if !@link.internal? && @link.remote?
+      if !@link.href&.start_with?('#') && !@link.internal? && @link.remote?
         check_sri(line, content) if @link.check_sri? && node.name == 'link'
         # we need to skip these for now; although the domain main be valid,
         # curl/Typheous inaccurately return 404s for some links. cc https://git.io/vyCFx
         next if @link.respond_to?(:rel) && @link.rel == 'dns-prefetch'
 
+        unless @link.path?
+          add_issue("#{@link.href} is an invalid URL", line: line, content: content)
+          next
+        end
+
         add_to_external_urls(@link.href || @link.src)
         next
       elsif @link.internal?
-        if @link.exists?
+        if @link.exists? || @link.hash
           add_to_internal_urls(@link.href, InternalLink.new(@link, @path, line, content))
         else
           add_issue("internally linking to #{@link.href}, which does not exist", line: line, content: content)
@@ -72,10 +77,10 @@ class LinkCheck < ::HTMLProofer::Check
       return false
     end
 
-    # verify the target hash
-    return handle_hash(link, path, line, content) if link.hash
+    return true unless link.hash
 
-    true
+    # verify the target hash
+    handle_hash(link, path, line, content)
   end
 
   def check_schemes(link, line, content)

data/lib/html-proofer/element.rb

@@ -74,6 +74,10 @@ module HTMLProofer
       !parts.nil?
     end
 
+    def path?
+      !parts.host.nil? && !parts.path.nil?
+    end
+
     def parts
       @parts ||= Addressable::URI.parse url
     rescue URI::Error, Addressable::URI::InvalidURIError

data/lib/html-proofer/runner.rb

@@ -157,11 +157,12 @@ module HTMLProofer
         @cache.write
       else
         @internal_urls.values.flatten.each do |internal_url|
-          @internal_link_checks.check_internal_link(internal_url.link, internal_url.path, internal_url.line, internal_url.content)
+          result = @internal_link_checks.check_internal_link(internal_url.link, internal_url.path, internal_url.line, internal_url.content)
+          next if result
+
+          @failures.concat(@internal_link_checks.issues) unless @internal_link_checks.issues.length.zero?
         end
       end
-
-      @failures.concat(@internal_link_checks.issues) unless @internal_urls.length.zero?
     end
 
     def files

data/lib/html-proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = '3.18.0'
+  VERSION = '3.18.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.18.0
+  version: 3.18.5
 platform: ruby
 authors:
 - Garen Torikian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-11 00:00:00.000000000 Z
+date: 2021-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -285,9 +285,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.4.10
+  - - "<"
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '4.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="