html-proofer 3.17.2 → 3.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee53fc4edb91d7319f27f79abf9c31a10761b19fdbabf25904048fd4a1f3f2b5
-  data.tar.gz: a779feb72397f9f7b3498702ba6097437ca4162fe95e9c618df2c32df317196f
+  metadata.gz: 852efb42767ef8589aa2f469f06c807ab287d78da04043e5a57e4d4a7f8bf6dd
+  data.tar.gz: 065406c8f1a7978d025224dc4ef53137e698eaeec8f097c1375620c8d6e0c5ba
 SHA512:
-  metadata.gz: 1caec4616e73928e36e32cedc4529b0ad4628d5ff22b0b060f14d967f9e778fbad9cfdc1b3cc22aa302ea9e7509eb3d7bbaffeacc7f95541cede0bb1c875a3fa
-  data.tar.gz: e33a43f7e5fcbe892acf02c89950715d5b34e2d11430507ab83574126e9568a32a57a238727fa047153d7f4824baba9d62dbf2839655fd49c28ac50bb1469eea
+  metadata.gz: c5aabdd3e5087dd1282b4428b7105e62216b22510c1a73a9f80f1e6b2ba18906217c7aaa974b245644de2b325bef8fd3e05c61c528302fb59ce5a353da0c1d04
+  data.tar.gz: 7155e2eed2e31173ad7e8efe4d7ce31b2cf18fa403b560f03428e3ef8ff8f9c60654f9e1ee6a4470ff65f609fdaeeb107e0236c85610212e90b7a9535a650522

data/lib/html-proofer.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Naming/FileName
 # frozen_string_literal: true
 
 def require_all(path)
@@ -52,3 +53,4 @@ module HTMLProofer
     HTMLProofer::Runner.new(links, options)
   end
 end
+# rubocop:enable Naming/FileName

data/lib/html-proofer/check.rb

@@ -26,8 +26,8 @@ module HTMLProofer
       raise NotImplementedError, 'HTMLProofer::Check subclasses must implement #run'
     end
 
-    def add_issue(desc, line: nil, status: -1, content: nil)
-      @issues << Issue.new(@path, desc, line: line, status: status, content: content)
+    def add_issue(desc, line: nil, path: nil, status: -1, content: nil)
+      @issues << Issue.new(path || @path, desc, line: line, status: status, content: content)
       false
     end
 

data/lib/html-proofer/check/favicon.rb

@@ -7,7 +7,7 @@ class FaviconCheck < ::HTMLProofer::Check
       favicon = create_element(node)
       next if favicon.ignore?
 
-      found = true if favicon.rel.split(' ').last.eql? 'icon'
+      found = true if favicon.rel.split.last.eql? 'icon'
       break if found
     end
 

data/lib/html-proofer/check/links.rb

@@ -45,7 +45,7 @@ class LinkCheck < ::HTMLProofer::Check
       # intentionally here because we still want valid? & missing_href? to execute
       next if @link.non_http_remote?
 
-      if !@link.internal? && @link.remote?
+      if !@link.href&.start_with?('#') && !@link.internal? && @link.remote?
         check_sri(line, content) if @link.check_sri? && node.name == 'link'
         # we need to skip these for now; although the domain main be valid,
         # curl/Typheous inaccurately return 404s for some links. cc https://git.io/vyCFx
@@ -54,7 +54,7 @@ class LinkCheck < ::HTMLProofer::Check
         add_to_external_urls(@link.href || @link.src)
         next
       elsif @link.internal?
-        if @link.exists?
+        if @link.exists? || @link.hash
           add_to_internal_urls(@link.href, InternalLink.new(@link, @path, line, content))
         else
           add_issue("internally linking to #{@link.href}, which does not exist", line: line, content: content)
@@ -65,17 +65,17 @@ class LinkCheck < ::HTMLProofer::Check
     external_urls
   end
 
-  def check_internal_link(link, line, content)
+  def check_internal_link(link, path, line, content)
     # does the local directory have a trailing slash?
     if link.unslashed_directory?(link.absolute_path)
-      add_issue("internally linking to a directory #{link.absolute_path} without trailing slash", line: line, content: content)
+      add_issue("internally linking to a directory #{link.absolute_path} without trailing slash", path: path, line: line, content: content)
       return false
     end
 
-    # verify the target hash
-    return handle_hash(link, line, content) if link.hash
+    return true unless link.hash
 
-    true
+    # verify the target hash
+    handle_hash(link, path, line, content)
   end
 
   def check_schemes(link, line, content)
@@ -103,9 +103,9 @@ class LinkCheck < ::HTMLProofer::Check
     add_issue("#{link.href} contains no phone number", line: line, content: content) if link.path.empty?
   end
 
-  def handle_hash(link, line, content)
+  def handle_hash(link, path, line, content)
     if link.internal? && !hash_exists?(link.html, link.hash) # rubocop:disable Style/GuardClause
-      return add_issue("linking to internal hash ##{link.hash} that does not exist", line: line, content: content)
+      return add_issue("linking to internal hash ##{link.hash} that does not exist", path: path, line: line, content: content)
     elsif link.external?
       return external_link_check(link, line, content)
     end

data/lib/html-proofer/middleware.rb

@@ -60,7 +60,7 @@ module HTMLProofer
       body = []
       result.last.each { |e| body << e }
 
-      body = body.join('')
+      body = body.join
       begin
         html = body.lstrip
       rescue StandardError

data/lib/html-proofer/runner.rb

@@ -147,18 +147,22 @@ module HTMLProofer
         urls_to_check = load_internal_cache
 
         urls_to_check.each_pair do |url, internal_urls|
-          result = @internal_link_checks.check_internal_link(internal_urls.first.link, internal_urls.first.line, internal_urls.first.content)
+          # pulled from cache
+          internal_urls = @internal_urls[url] unless internal_urls.first.is_a?(LinkCheck::InternalLink)
+
+          result = @internal_link_checks.check_internal_link(internal_urls.first.link, internal_urls.first.path, internal_urls.first.line, internal_urls.first.content)
           code = result ? 200 : 404
           @cache.add(url, @internal_urls_to_paths[url].sort, code, '') # TODO: blank msg for now
         end
         @cache.write
       else
         @internal_urls.values.flatten.each do |internal_url|
-          @internal_link_checks.check_internal_link(internal_url.link, internal_url.line, internal_url.content)
+          result = @internal_link_checks.check_internal_link(internal_url.link, internal_url.path, internal_url.line, internal_url.content)
+          next if result
+
+          @failures.concat(@internal_link_checks.issues) unless @internal_link_checks.issues.length.zero?
         end
       end
-
-      @failures.concat(@internal_link_checks.issues) unless @internal_urls.length.zero?
     end
 
     def files
@@ -211,7 +215,8 @@ module HTMLProofer
       sorted_failures.sort_and_report
       count = @failures.length
       failure_text = pluralize(count, 'failure', 'failures')
-      raise @logger.colorize :fatal, "HTML-Proofer found #{failure_text}!"
+      @logger.log :fatal, "\nHTML-Proofer found #{failure_text}!"
+      exit 1
     end
 
     # Set before_request callback.

data/lib/html-proofer/url_validator.rb

@@ -120,7 +120,7 @@ module HTMLProofer
     def clean_url(href)
       # catch any obvious issues, like strings in port numbers
       parsed = Addressable::URI.parse(href)
-      if href =~ /^([!#{$&}-;=?-\[\]_a-z~]|%[0-9a-fA-F]{2})+$/
+      if href =~ /^([!#{Regexp.last_match(0)}-;=?-\[\]_a-z~]|%[0-9a-fA-F]{2})+$/
         href
       else
         parsed.normalize

data/lib/html-proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = '3.17.2'
+  VERSION = '3.18.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.17.2
+  version: 3.18.2
 platform: ruby
 authors:
 - Garen Torikian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-23 00:00:00.000000000 Z
+date: 2020-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -122,20 +122,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: codecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -308,7 +294,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image